Commit Graph
1013 Commits
Author SHA1 Message Date
Willie 5e02ef7ef0 refactor(sync): select a target's skills through SelectTargetSkills
Status, doctor, diff, the dashboard's target and diff handlers and analyze each
repeated FilterSkills followed by FilterSkillsByTarget, and only some dropped
disabled skills first. Routing them through SelectTargetSkills keeps their
answers identical to sync and mcp serve when a selection rule changes.

The callers that did not drop disabled skills get discoveries without them, so
their output does not change.
2026-10-06 14:18:20 +08:00
Willie cc7d802411 feat(mcp): serve skills over MCP with the SEP-2640 Skills extension
Agents on a disposable VM, in a hosted assistant or behind an MCP gateway can
reach an MCP endpoint but not the folder skills sync to, so they got tools and
none of the user's skills (#428).

`skillshare mcp serve` is a read-only server for the skills skillshare already
manages. It declares io.modelcontextprotocol/skills and implements skills/list,
skills/get and resources/read: one entry per skill, its URI from the source
path, the full frontmatter, and every file with a sha256 digest and size.
--target applies that target's selection, and the source is reread at most
every 5 seconds so install, update, enable and disable show up without a
restart; unchanged files keep their digest. stdio is the default; --http
serves Streamable HTTP and needs SKILLSHARE_MCP_TOKEN off loopback.

Skills the extension cannot carry are skipped with a warning instead of being
published incomplete: a name that breaks the Agent Skills rules or differs from
its directory, more than 512 files or 16 MiB, or a nested skill that is not
served. --check lists them without serving. The naming rules moved to
internal/skillpkg so sync and the server share them.

Few clients support the extension yet, so the server also offers list_skills
and read_skill tools. A client that declares the extension does not see them,
so it never gets each skill twice.

sync.SelectTargetSkills is the one place that turns discovered skills into a
target's selection (enabled, include/exclude, frontmatter targets).

Refs: #428
2026-10-06 14:18:16 +08:00
Willie bfbce09a12 test(windows): compare against resolved paths for 8.3 temp dirs
The windows-latest runner's TEMP is an 8.3 short path
(C:\Users\RUNNER~1\...), while the product reports the resolved long
path. Four tests compared the short form and failed only on the runner;
the local guest has no short names. Resolve the expected path first.

Refs #344
2026-10-06 10:58:15 +08:00
Willie 8b01e9f5a4 Merge branch 'main' into runkids/sync-windows-tests 2026-10-06 10:51:56 +08:00
Willie 92183d5a09 test(windows): run audit, config, install, mcp and cmd tests on Windows CI
These packages were left out of the windows-test job because of failures
that came from test assumptions (POSIX paths, permission bits, HOME,
bash shims posing as git), not product behavior. Fix them and add the
packages to the list so they stay green.

Two failures were real product bugs:
- swapStagedIntoSource named its backup like the temp that
  sourcefs.MoveIn creates beside it. On a coarse clock (Windows) both
  names matched, the failed move removed the temp and with it the
  backup, and the old skill was lost.
- MetadataStore.GetByPath looked up OS-native paths in slash-form keys,
  so `update --group` missed nested skills on Windows.

The test sandbox now also sets USERPROFILE, which os.UserHomeDir reads
on Windows; tests were reading the real profile.

Refs #344
2026-10-06 10:46:37 +08:00
Willie c0f200f7d6 Merge branch 'main' into runkids/pi-cimd-validation 2026-10-06 10:36:04 +08:00
Willie 8f79733b4f fix(mcp): validate Pi CIMD OAuth settings
Reject unsupported client registration values and CIMD client or callback conflicts before syncing invalid settings to Pi. Keep dcr and custom Pi options supported, identify the legacy codemode alias, and document current Pi launch behavior.
2026-10-06 09:52:16 +08:00
Willie 8e9ef1c806 test(sync): make the tests pass on Windows and run them in CI
Ten tests assumed POSIX behaviour:

- Five asserted os.ModeSymlink, but Windows links with a junction;
  check utils.IsLinkMode instead.
- Two used `/abs/...` as an absolute path, which has no volume on
  Windows; give the fixtures one.
- Windows has no permission bits to preserve, so the 0600 check is
  skipped there.
- Reading a file as a directory reports not-exist on Windows, which
  prune ignores, so that prune-error test is skipped there.
- A single-file extension relies on the shebang and the executable bit,
  so ListExtensions finds only directory extensions on Windows, as the
  extras docs describe.

Add ./internal/sync and ./internal/trash to the windows-test package
list so they stay green.

Refs #344
2026-10-06 09:40:50 +08:00
Willie 8f47b5962a test(trash): make the link tests pass on Windows
Three link tests assumed POSIX behaviour:

- alias/../checkout is resolved lexically on Windows, before the alias
  is followed, so the traversal case cannot hold and is skipped there.
- Windows drops `..` when it creates a relative symlink, so the expected
  link text is cleaned first.
- Windows stores `assets/note.txt` as `assets\note.txt`, so the nested
  link target is compared in slash form.

Refs #344
2026-10-06 09:40:49 +08:00
Willie e031274207 fix(utils): refuse a network path as a junction target
A junction cannot point at a UNC path; mklink /J exits 1 for one. The
reparse-point API would instead write an unusable mount point, so return
an error up front and leave nothing behind, as mklink did.

Refs #420
2026-10-06 01:28:55 +08:00
Willie 05b2f12023 fix(utils): detect junctions under GODEBUG=winsymlink=0
With winsymlink=0 Go reports a junction as ModeSymlink instead of
ModeIrregular, so IsJunction returned false and the trash fallback
recreated the junction with os.Symlink again. Read the reparse tag for
both modes.

Refs #420
2026-10-06 01:16:37 +08:00
Willie 4b2da26f9a fix(utils): accept extended-length paths as junction targets
The junction substitute name is an NT path (\??\C:\x). A target given as
a Win32 extended path (\\?\C:\x or \\?\Volume{GUID}\x) kept its prefix,
so prepending \??\ produced an invalid name and the junction could not
be read through. Swap the prefix instead of stacking it.

Refs #420
2026-10-06 01:02:09 +08:00
Willie 3375419c63 test(sourcefs): allow the raw writes in CreateJunction
The previous commit moved junction creation onto os.Mkdir and os.Remove
inside CreateJunction. The raw-write ratchet lists every such call, so
record them with the same reason as the neighbouring link helpers.

Refs #420
2026-10-06 00:54:38 +08:00
Willie eb359a7626 fix(utils): create junctions through the reparse-point API
Quoting the paths for `cmd /c mklink` stops `&` from splitting the
command, but cmd.exe still expands `%VAR%` inside quotes, so a path with
a token such as `%TEMP%` pointed the junction somewhere else or failed.

Create the directory and set its mount-point reparse data with
FSCTL_SET_REPARSE_POINT instead. No shell parses the paths, which also
removes the need for quoting. Like mklink /J it refuses an existing
link path, and it removes the directory it made if setting the reparse
data fails.

Refs #420
2026-10-06 00:52:54 +08:00
Willie 377eae3d89 fix(utils): quote junction paths passed to cmd.exe
CreateJunction passed both paths to `cmd /c mklink` as plain exec
arguments. Go quotes an argument only when it has whitespace, so a path
with a cmd metacharacter such as `&` was split into a second command:
the junction was not created, and a crafted name could run a command.

Build the command line ourselves and quote both paths. A Windows path
cannot contain a double quote, so the quoting cannot be broken out of.
The regression test uses unspaced paths with `&`, which fail without
this change.

Refs #420
2026-10-06 00:44:26 +08:00
Willie d97f6d88b7 fix(trash): keep junctions as junctions when moving across volumes
When the skills source and the trash live on different volumes, the
cross-device fallback in moveLink and copyDir recreated a Windows
junction with os.Symlink. That needs Developer Mode or elevation, which
the junction was chosen to avoid, so `unlink` and `trash restore` could
fail after `link` had succeeded.

Recreate a junction as a junction through a shared helper, and keep the
original link in place when creation fails. CreateJunction moves from
internal/sync to internal/utils so trash can reuse it.

Refs #420
2026-10-06 00:32:38 +08:00
Willie 06f6362f3b Merge remote-tracking branch 'origin/main' into runkids/419-link-unlink 2026-10-05 23:45:45 +08:00
Willie 6c9c3f5fce fix(server): roll back the dashboard link when enabling fails
POST /api/source-links with enable: true left the new link in the source
when the config could not be saved, so the dialog reported a failure the
filesystem did not match and a retry failed with "already exists". Share
one sourcelink.Discard rollback between the CLI and the handler.
2026-10-05 23:16:58 +08:00
Willie 147b509e5f fix(plugins): show the commit when a source changes without a new version
Update checks compare the source digest, not the version, so a repo that
pushes commits without bumping its manifest (ponytail ships dozens a day)
showed "4.12.0" with an Update button and looked like a stuck update.

Check now returns the source commit, and the version tag adds
"old → new" commits when the version itself did not move.
2026-10-05 23:03:03 +08:00
Willie d6a533d1b6 fix(server): reflect traversal failures on standalone source links
sourceLinks were built before discovery ran, so a target readable at its
root whose subtree failed during traversal stayed available: true with
no warning while sourceLinkWarnings already reported it as incomplete.
Build the items after discovery and treat a recorded skip as unavailable.
2026-10-05 23:01:50 +08:00
Willie 9db36b472a Merge remote-tracking branch 'origin/main' into runkids/419-link-unlink
# Conflicts:
#	internal/server/handler_skills.go
#	skills/skillshare/references/TROUBLESHOOTING.md
#	website/docs/reference/commands/ui.md
#	website/docs/reference/targets/configuration.md
#	website/i18n/ja/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/ja/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/i18n/ko/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/ko/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/i18n/zh-Hant/docusaurus-plugin-content-docs/current/reference/commands/ui.md
#	website/i18n/zh-Hant/docusaurus-plugin-content-docs/current/reference/targets/configuration.md
#	website/src/data/featureMap.ts
2026-10-05 22:49:25 +08:00
Willie 891c687a47 fix(server): anchor target frontmatter writes to the source
Rewrite frontmatter as bytes and read and write target assignments through sourcefs with the discovery follow policy. Refuse nested SKILL.md links with per-skill batch errors or HTTP 400 while regular followed skills remain editable and outside files stay unchanged.
2026-10-05 22:35:00 +08:00
Willie 50b6515a16 fix(sourcefs): retain the staged-copy traversal allowance
Keep the existing non-source traversal allowance attached to the recursive staged-copy helper. The walk still reads only incoming content outside the skills source and all destination writes remain anchored by sourcefs.
2026-10-05 22:32:59 +08:00
Willie 51f2beadd1 fix(install): retain existing skills until replacement succeeds
Copy staged directory links as concrete content through the source root, skip dangling links, and reject directory cycles. Preserve the existing skill under a sibling name and restore it if moving or copying the replacement fails so followed checkout updates cannot discard the old content.
2026-10-05 22:28:43 +08:00
Willie f20b7f7f1f fix(trash): record link copying in the write ratchet
Register link recreation alongside the existing trash and agent recovery copy operations. Keep translated trash guidance separate from the existing group paragraph.
2026-10-05 22:27:55 +08:00
Willie 38c223bd74 fix(trash): preserve nested links in cross-device copies
Recreate nested links with their stored target text instead of dropping them before removing the original skill. Reuse the junction target resolution and symlink fallback used by moveLink without traversing link contents.
2026-10-05 22:24:39 +08:00
Willie 113d410da7 fix(hub): apply the source follow policy to local discovery
Hub index, built-in search, and draft candidates discovered only the source path, dropping the follow policy used by the inventory. Add optional walk options to the shared Hub functions and pass the operation policy from dashboard handlers and CLI indexing.

Explicit CLI sources use the active config policy while retaining configuration-free indexing. Cover global/project modes, enabled/disabled following, all three handlers, and CLI source overrides; document the behavior in all website locales and built-in guidance.
2026-10-05 22:03:47 +08:00
Willie 98300a2eec fix(install): recognize gitdir files as checkouts
Followed worktrees and submodules were discovered as tracked repos but bypassed guards that required a .git directory. Widen IsGitRepo to accept a directory or regular gitdir file and reuse it in discovery and reconciliation. All existing callers classify checkouts or run Git commands; none requires the directory layout, so a separate predicate would retain inconsistent decisions.

Exercise actual followed worktrees in CLI and dashboard update fixtures, including project mode and force retries, and document that they receive the same checkout guards.
2026-10-05 21:53:12 +08:00
Willie e7eecffeab Merge remote-tracking branch 'origin/main' into runkids/274-follow-source-links 2026-10-05 21:32:38 +08:00
Willie 064048da89 fix(server): list files from followed skill roots
A symlink passed as a filepath.Walk root is listed as a single file, so root-of-link skills returned files containing only a dot. Reuse the discovery follow policy to resolve the walk root and compute relative file names from it while retaining logical resource paths.

Cover global/project responses and disabled following, update the existing traversal inventory, and document root-of-link file browsing in all website locales and troubleshooting guidance.
2026-10-05 21:31:29 +08:00
Willie e8242affc3 fix(update): exclude followed checkouts from missing repo recovery
Missing-repo discovery ignored the operation follow policy, so tracked metadata added a skipped checkout back to update --all and allowed --force to reset it. Thread the policy through missing-repo detection and its CLI/server callers, including rehydration, so existing followed checkouts remain excluded.

Cover global and project updates with dirty tracked checkouts and force, as well as shared and dashboard rehydration. Document that --force does not override the batch skip.
2026-10-05 21:22:47 +08:00
Willie a280a20f8c Merge remote-tracking branch 'origin/runkids/274-follow-source-links' into runkids/419-link-unlink
# Conflicts:
#	internal/sourcewalk/follow_test.go
#	skills/skillshare/references/TROUBLESHOOTING.md
2026-10-05 21:19:53 +08:00
Willie 1e7e23f587 fix(ui): keep empty source links available to unlink
Source links disappeared from the dashboard when discovery found no skills, leaving empty or unavailable folders without an Unlink action. Return first-level links independently with their follow-policy availability and preserve their groups in every skills view, including empty unlink confirmations.

Cover empty and dangling inventory, disabled following, and empty-link removal in list, cards, and tree views; document the API field and rendering.
2026-10-05 21:17:30 +08:00
Willie df7a6ad73d fix(sourcewalk): preserve inventory on followed traversal failures
Discovery callbacks may ignore filesystem errors after a followed target passes its availability probe. Record these failures in the shared Follow policy before dispatching callbacks so sync and reconciliation preserve entries missing from an incomplete inventory.

Keep ordinary vanished-child races tolerated, while treating loss of the target itself as unavailable. Cover both walkers and merge/copy pruning, and document read failures in the English and translated configuration guidance.
2026-10-05 20:46:45 +08:00
Willie 97446744ff feat(omp): add native Oh My Pi support (#423)
* feat(omp): add native Oh My Pi support

Support OMP skills, instructions, MCP, code hooks and guarded extension selection using its verified native contracts rather than Pi aliases.

Add reviewed marketplace plugin installation, cache-preserving scoped removal and fresh-cache reinstall. Align Pi/OMP extension cards and localize inventory guidance while keeping native ownership and read-only constraints.

Include regression coverage, isolated E2E runbooks, documentation and verification policies. Native plugin updates and unverified runtime platforms remain guarded.

Refs #409

* fix(omp): guard runtime ownership and localize inventory guidance

Native install recursively replaces its runtime destination, and a missing cache manifest could leave the real runtime link installed after removal. Bind and recheck an absent reviewed destination, and recover removal names only from verified scope-local links.

Localize fixed backend reasons and warnings across dashboard locales while preserving paths and external diagnostics. Restore the reviewed source in the existing reinstall fixture and record real native verification.

* fix(omp): allow forgetting natively removed plugins

A different plugin can retain node_modules after native uninstall deletes this installation. When its cache, registration and known runtime state are absent, forget only the stale Skillshare binding instead of demanding runtime-name proof for unrelated files.

Extend the existing removal recovery test with a failing-before-fix case that verifies the binding is dropped and unrelated native lock bytes and plugin files are preserved. make check passes.
2026-10-05 20:36:39 +08:00
Willie cd6e0165dd fix(uninstall): refuse skills at followed link roots
A root skill discovered through a followed source link occupies the link entry itself. Moving that entry to trash silently unlinks every nested skill instead of removing one skill.

Share the root-skill guard across single and batch API handlers and CLI uninstall, report the unlink action clearly, and preserve explicit unlink and nested skill removal.
2026-10-05 20:02:58 +08:00
Willie 98ab6eb832 test(source-links): accept Windows junctions in link assertions
Use the existing link detection and target resolution helpers so correct directory junctions pass the source-link core, API, and CLI tests. Accept the Windows junction kind while retaining symlink coverage and target identity checks without platform skips.
2026-10-05 18:27:12 +08:00
Willie 680506b4ff fix(ui): uninstall linked skills individually from detail pages
Share policy-based link identity enrichment between skill list and detail responses. Use that identity in the detail action menu and shared uninstall dialog so followed checkout members keep single-skill confirmation and submit their own flat name.
2026-10-05 18:27:12 +08:00
Willie 3ad3af713f fix(server): resolve uninstall names without basename collisions
Prefer exact skill flat names and reject ambiguous basename fallbacks in both uninstall handlers. Route explicit managed repositories before basename lookup so a followed checkout cannot hijack removal of a root skill or repository.
2026-10-05 18:27:12 +08:00
Willie 6e641dca14 fix(server): restore skills through followed source links
Pass the current global or project follow policy to skill trash restore so the dashboard matches CLI behavior and can restore into followed link targets. Keep disabled-link refusals and agent restores unchanged, and cover both scopes and link naming styles with handler regression tests.
2026-10-05 18:27:12 +08:00
Willie db45b0db06 fix(server): uninstall individual skills from followed links
Resolve followed skills with the discovery policy before applying tracked-repo restrictions or prefix-based batch routing. This lets dashboard uninstall move only the selected skill from a followed checkout while retaining managed-repo protection and logical trash restore paths.

Add single and batch handler regressions for global and project modes, skipped links, and tracked-repo members; document the API behavior.
2026-10-05 18:27:12 +08:00
Willie 370b612f33 fix(ui): simplify followed-folder actions
Keep followed checkout updates in the Updates tab and expose unlink as a single quiet icon in group headers. Remove unused checkout metadata and linked-group menus while preserving the confirmation and single-skill uninstall flows.
2026-10-05 18:27:12 +08:00
Willie 6a358b73a7 fix(ui): move source-link unlink into group menus
Match tracked repository affordances without offering whole-repo uninstall for followed user checkouts. Resolve checkout identity for Update repo, keep linked skill uninstall scoped to the selected skill, and explain target preservation, sync impact, and trash recovery before destructive requests.
2026-10-05 18:27:12 +08:00
Willie 46fd8ef355 feat(ui): unlink followed source folders from the dashboard
Expose policy-resolved first-level link identity on listed skills so linked groups can be distinguished from ordinary folders without another request. Add a confirmation that preserves the target folder and explains trash recovery, then refresh the dashboard after unlinking.
2026-10-05 18:27:12 +08:00
Willie c1ea7e3445 feat(ui): link folders from the skills dashboard
Let dashboard users add local skill folders through the shared source-link guards without creating links by hand. Keep follow_source_links opt-in in the current mode and expose link removal through the API with recoverable trash semantics.

Cover handler behavior, request shapes, dialog errors, and all dashboard locales, and document the endpoints in the API audit topic.
2026-10-05 18:27:12 +08:00
Willie 4ae67cbe52 feat(source-links): add link and unlink commands
follow_source_links only follows a link the user made by hand, so the
guards (source or parent, sync target overlap, link chain) surfaced in
doctor only after the link existed, and Windows users had to pick
between a junction and mklink /D themselves.

link checks the prospective target with Follow.Allow, which shares the
guard rules and reason strings with the walk, before creating a junction
on Windows or an absolute symlink elsewhere. It warns when the target is
not a git checkout and leaves follow_source_links alone unless --enable
is given. unlink moves only the link entry to trash, the same way
uninstall removes a first-level link, so the target is never touched and
trash restore undoes it. internal/sourcelink holds both operations so the
dashboard can call them too.

Refs #419
2026-10-05 18:27:12 +08:00
Willie aafb7e7e96 fix(ui): keep followed checkouts out of dashboard updates
Separate user-owned followed Git checkouts into linked_repos in check and resources responses so the Updates tab renders information instead of tracked errors or retry actions. Refuse dashboard updates before Git runs, including force retries and descendant skills, while leaving managed repositories unchanged.
2026-10-05 18:26:12 +08:00
Willie c5c9289781 fix(discovery): surface skipped source link warnings
Keep one follow policy per list and status operation and report its skipped links without hiding healthy inventory. Send JSON diagnostics to stderr and expose sourceLinkWarnings in the dashboard resources response, reusing the sync warning formatter.
2026-10-05 18:26:12 +08:00
Willie 3b898f3730 Merge branch 'main' into runkids/274-follow-source-links 2026-10-05 16:11:45 +08:00
Willie 8879d445ab fix(status): require a source fingerprint for extension outputs (#416)
Extension outputs were matched to an agent by stem alone. A plain copy
that sync tracked before the target enabled an extension (reviewer.md)
passed for the converted output, so status, doctor, diff and the Sync tab
reported the target in sync while the next sync would write reviewer.toml
and prune the copy.

Only a transform records a source fingerprint, so an output without one
is no longer counted as converted. Outputs written before fingerprints
existed (before 0.24.5) show as pending until the next sync, which is
what they were already reported as before #392.

Refs #415
2026-10-05 15:51:40 +08:00