mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
The Sync page predicted which orphan links sync would remove with its own copy of prune's rule. The copy had already drifted once (#914), and it still disagreed in two cases: prune treats a link it cannot follow, such as a loop, as broken, while the page only counted a missing destination; and prune keeps a link whose target it cannot read. The decision now lives in sync.OrphanLink. Prune and the dashboard diff both call it, so a later change to the rule reaches both. Prune's results, warnings and dry-run text are unchanged. LinksIntoSource, added for the dashboard's copy, is no longer needed and is removed.
249 lines
8.6 KiB
Go
249 lines
8.6 KiB
Go
package server
|
|
|
|
import (
|
|
"encoding/json"
|
|
"maps"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"skillshare/internal/config"
|
|
"skillshare/internal/resource"
|
|
"skillshare/internal/sync"
|
|
)
|
|
|
|
func TestHandleDiff_Empty(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Diffs []any `json:"diffs"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Diffs) != 0 {
|
|
t.Errorf("expected 0 diffs, got %d", len(resp.Diffs))
|
|
}
|
|
}
|
|
|
|
func TestHandleDiff_WithTarget(t *testing.T) {
|
|
tgtPath := filepath.Join(t.TempDir(), "claude-skills")
|
|
s, src := newTestServerWithTargets(t, map[string]string{"claude": tgtPath})
|
|
addSkill(t, src, "alpha")
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Diffs []map[string]any `json:"diffs"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Diffs) != 1 {
|
|
t.Fatalf("expected 1 diff target, got %d", len(resp.Diffs))
|
|
}
|
|
}
|
|
|
|
func TestHandleDiff_AgentPruneWhenSourceEmpty(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
|
|
agentSource := filepath.Join(t.TempDir(), "agents")
|
|
agentTarget := filepath.Join(t.TempDir(), "claude-agents")
|
|
if err := os.MkdirAll(agentSource, 0o755); err != nil {
|
|
t.Fatalf("mkdir agent source: %v", err)
|
|
}
|
|
if err := os.MkdirAll(agentTarget, 0o755); err != nil {
|
|
t.Fatalf("mkdir agent target: %v", err)
|
|
}
|
|
if err := os.Symlink(filepath.Join(agentSource, "tutor.md"), filepath.Join(agentTarget, "tutor.md")); err != nil {
|
|
t.Fatalf("seed orphan agent symlink: %v", err)
|
|
}
|
|
|
|
s.cfg.AgentsSource = agentSource
|
|
s.cfg.Targets["claude"] = config.TargetConfig{
|
|
Skills: &config.ResourceTargetConfig{Path: filepath.Join(t.TempDir(), "claude-skills")},
|
|
Agents: &config.ResourceTargetConfig{Path: agentTarget},
|
|
}
|
|
if err := s.cfg.Save(); err != nil {
|
|
t.Fatalf("save config: %v", err)
|
|
}
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Diffs []struct {
|
|
Target string `json:"target"`
|
|
Items []struct {
|
|
Skill string `json:"skill"`
|
|
Action string `json:"action"`
|
|
Kind string `json:"kind"`
|
|
} `json:"items"`
|
|
} `json:"diffs"`
|
|
}
|
|
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("unmarshal diff response: %v", err)
|
|
}
|
|
|
|
if len(resp.Diffs) != 1 {
|
|
t.Fatalf("expected 1 diff target, got %d", len(resp.Diffs))
|
|
}
|
|
if resp.Diffs[0].Target != "claude" {
|
|
t.Fatalf("expected claude target, got %q", resp.Diffs[0].Target)
|
|
}
|
|
if len(resp.Diffs[0].Items) != 1 {
|
|
t.Fatalf("expected 1 diff item, got %d", len(resp.Diffs[0].Items))
|
|
}
|
|
item := resp.Diffs[0].Items[0]
|
|
if item.Skill != "tutor.md" || item.Action != "prune" || item.Kind != "agent" {
|
|
t.Fatalf("unexpected diff item: %+v", item)
|
|
}
|
|
}
|
|
|
|
// Refs #391: the Sync tab listed every converted extension agent as pending.
|
|
func TestHandleDiff_AgentExtensionOutputsAreNotPending(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
|
|
agentSource := filepath.Join(t.TempDir(), "agents")
|
|
agentTarget := filepath.Join(t.TempDir(), "codex-agents")
|
|
if err := os.MkdirAll(agentSource, 0o755); err != nil {
|
|
t.Fatalf("mkdir agent source: %v", err)
|
|
}
|
|
srcFile := filepath.Join(agentSource, "reviewer.md")
|
|
if err := os.WriteFile(srcFile, []byte("# Reviewer"), 0o644); err != nil {
|
|
t.Fatalf("write agent: %v", err)
|
|
}
|
|
agents := []resource.DiscoveredResource{{FlatName: "reviewer.md", AbsPath: srcFile, RelPath: "reviewer.md"}}
|
|
spec := &sync.ExtensionSpec{Run: []string{"cat"}, Dir: agentSource, Name: "id", OutputExt: "toml"}
|
|
if _, err := sync.SyncAgentsTransform(agents, agentSource, agentTarget, "copy", spec, false, false); err != nil {
|
|
t.Fatalf("seed converted output: %v", err)
|
|
}
|
|
|
|
s.cfg.AgentsSource = agentSource
|
|
s.cfg.Targets["codex"] = config.TargetConfig{
|
|
Skills: &config.ResourceTargetConfig{Path: filepath.Join(t.TempDir(), "codex-skills")},
|
|
Agents: &config.ResourceTargetConfig{Path: agentTarget, Extension: "id"},
|
|
}
|
|
if err := s.cfg.Save(); err != nil {
|
|
t.Fatalf("save config: %v", err)
|
|
}
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
if strings.Contains(rr.Body.String(), "reviewer") {
|
|
t.Fatalf("converted agent should not be pending: %s", rr.Body.String())
|
|
}
|
|
}
|
|
|
|
// Sync keeps a same-name link from another tool, broken or not, and a folder
|
|
// that is only named like skillshare's, so the diff must not predict an update,
|
|
// a new copy or a prune.
|
|
func TestComputeTargetDiff_KeepsEntriesSkillshareDidNotCreate(t *testing.T) {
|
|
for _, mode := range []string{"merge", "copy"} {
|
|
t.Run(mode, func(t *testing.T) {
|
|
source, target, other := t.TempDir(), t.TempDir(), t.TempDir()
|
|
for _, dir := range []string{filepath.Join(source, "alpha"), filepath.Join(source, "beta"), filepath.Join(other, "alpha"), filepath.Join(target, "team__shared")} {
|
|
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(dir, "SKILL.md"), []byte("---\nname: "+filepath.Base(dir)+"\n---\n"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
if err := os.Symlink(filepath.Join(other, "alpha"), filepath.Join(target, "alpha")); err != nil {
|
|
t.Skipf("symlinks unavailable: %v", err)
|
|
}
|
|
if err := os.Symlink(filepath.Join(other, "gone"), filepath.Join(target, "beta")); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
discovered, err := sync.DiscoverSourceSkills(source)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
dt := (&Server{}).computeTargetDiff("claude", config.TargetConfig{Skills: &config.ResourceTargetConfig{Path: target, Mode: mode}}, discovered, "merge", source, nil)
|
|
|
|
got := map[string]string{}
|
|
for _, item := range dt.Items {
|
|
got[item.Skill] = item.Action + ": " + item.Reason
|
|
}
|
|
want := map[string]string{"alpha": "skip: " + sync.ForeignLinkReason, "beta": "skip: " + sync.ForeignLinkReason}
|
|
if mode == "merge" { // the copy-mode diff lists only what sync changes or keeps
|
|
want["team__shared"] = "local: local only"
|
|
}
|
|
if !maps.Equal(got, want) {
|
|
t.Fatalf("items = %v, want %v", got, want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// After the source moves and the old checkout stays, a link sync made earlier
|
|
// is recorded but still resolves outside the source. Prune keeps a live
|
|
// external link, so the diff must not count it as a removal.
|
|
func TestComputeTargetDiff_KeepsRecordedLinkThatStillResolvesElsewhere(t *testing.T) {
|
|
source, target, oldSource := t.TempDir(), t.TempDir(), t.TempDir()
|
|
for _, name := range []string{"live", "gone"} {
|
|
if err := os.MkdirAll(filepath.Join(oldSource, name), 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.Symlink(filepath.Join(oldSource, name), filepath.Join(target, name)); err != nil {
|
|
t.Skipf("symlinks unavailable: %v", err)
|
|
}
|
|
}
|
|
if err := os.RemoveAll(filepath.Join(oldSource, "gone")); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := sync.WriteManifest(target, &sync.Manifest{Managed: map[string]string{"live": "symlink", "gone": "symlink"}}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
dt := (&Server{}).computeTargetDiff("claude", config.TargetConfig{Skills: &config.ResourceTargetConfig{Path: target, Mode: "merge"}}, nil, "merge", source, nil)
|
|
|
|
if len(dt.Items) != 1 || dt.Items[0].Skill != "gone" || dt.Items[0].Action != "prune" {
|
|
t.Fatalf("items = %+v, want only the broken link pruned", dt.Items)
|
|
}
|
|
}
|
|
|
|
// Prune treats a link it cannot follow as broken, not only one whose
|
|
// destination is missing. A recorded link that loops is removed by sync, so the
|
|
// diff must list it.
|
|
func TestComputeTargetDiff_ListsRecordedLinkThatCannotBeFollowed(t *testing.T) {
|
|
source, target := t.TempDir(), t.TempDir()
|
|
loop := filepath.Join(target, "loop")
|
|
if err := os.Symlink(loop, loop); err != nil {
|
|
t.Skipf("symlinks unavailable: %v", err)
|
|
}
|
|
if err := sync.WriteManifest(target, &sync.Manifest{Managed: map[string]string{"loop": "symlink"}}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
dt := (&Server{}).computeTargetDiff("claude", config.TargetConfig{Skills: &config.ResourceTargetConfig{Path: target, Mode: "merge"}}, nil, "merge", source, nil)
|
|
|
|
if len(dt.Items) != 1 || dt.Items[0].Skill != "loop" || dt.Items[0].Action != "prune" {
|
|
t.Fatalf("items = %+v, want the looping link pruned", dt.Items)
|
|
}
|
|
}
|