Files
skillshare/internal/server/handler_diff_test.go
T
Willie 72ed5ba0fb fix(diff): compare extension agent outputs and apply target filters (#414)
* fix(diff): compare extension agent outputs and apply target filters

#392 taught status and doctor to recognise converted extension outputs,
but diff (CLI) and the Sync tab (/api/diff) still compared the target
directory's *.md files against the source name. A target whose extension
renames the output (codex -> .toml) therefore listed every agent as
pending after a sync.

Both diff paths now use the same manifest-based check as status, and
report tracked outputs whose source is gone as prune items. They also
apply the target's include/exclude and the agents' frontmatter targets,
so an agent that sync would skip is no longer shown as pending.

Refs #391

* chore(release): request 0.24.6

The pending feat commits would make Release Please propose 0.25.0. This
batch is meant to ship as the 0.24.6 patch, so ask for that version.

Release-As: 0.24.6
2026-10-05 15:40:19 +08:00

158 lines
4.7 KiB
Go

package server
import (
"encoding/json"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"strings"
"testing"
"skillshare/internal/config"
"skillshare/internal/resource"
"skillshare/internal/sync"
)
func TestHandleDiff_Empty(t *testing.T) {
s, _ := newTestServer(t)
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
rr := httptest.NewRecorder()
s.handler.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
var resp struct {
Diffs []any `json:"diffs"`
}
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Diffs) != 0 {
t.Errorf("expected 0 diffs, got %d", len(resp.Diffs))
}
}
func TestHandleDiff_WithTarget(t *testing.T) {
tgtPath := filepath.Join(t.TempDir(), "claude-skills")
s, src := newTestServerWithTargets(t, map[string]string{"claude": tgtPath})
addSkill(t, src, "alpha")
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
rr := httptest.NewRecorder()
s.handler.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
var resp struct {
Diffs []map[string]any `json:"diffs"`
}
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Diffs) != 1 {
t.Fatalf("expected 1 diff target, got %d", len(resp.Diffs))
}
}
func TestHandleDiff_AgentPruneWhenSourceEmpty(t *testing.T) {
s, _ := newTestServer(t)
agentSource := filepath.Join(t.TempDir(), "agents")
agentTarget := filepath.Join(t.TempDir(), "claude-agents")
if err := os.MkdirAll(agentSource, 0o755); err != nil {
t.Fatalf("mkdir agent source: %v", err)
}
if err := os.MkdirAll(agentTarget, 0o755); err != nil {
t.Fatalf("mkdir agent target: %v", err)
}
if err := os.Symlink(filepath.Join(agentSource, "tutor.md"), filepath.Join(agentTarget, "tutor.md")); err != nil {
t.Fatalf("seed orphan agent symlink: %v", err)
}
s.cfg.AgentsSource = agentSource
s.cfg.Targets["claude"] = config.TargetConfig{
Skills: &config.ResourceTargetConfig{Path: filepath.Join(t.TempDir(), "claude-skills")},
Agents: &config.ResourceTargetConfig{Path: agentTarget},
}
if err := s.cfg.Save(); err != nil {
t.Fatalf("save config: %v", err)
}
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
rr := httptest.NewRecorder()
s.handler.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
var resp struct {
Diffs []struct {
Target string `json:"target"`
Items []struct {
Skill string `json:"skill"`
Action string `json:"action"`
Kind string `json:"kind"`
} `json:"items"`
} `json:"diffs"`
}
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
t.Fatalf("unmarshal diff response: %v", err)
}
if len(resp.Diffs) != 1 {
t.Fatalf("expected 1 diff target, got %d", len(resp.Diffs))
}
if resp.Diffs[0].Target != "claude" {
t.Fatalf("expected claude target, got %q", resp.Diffs[0].Target)
}
if len(resp.Diffs[0].Items) != 1 {
t.Fatalf("expected 1 diff item, got %d", len(resp.Diffs[0].Items))
}
item := resp.Diffs[0].Items[0]
if item.Skill != "tutor.md" || item.Action != "prune" || item.Kind != "agent" {
t.Fatalf("unexpected diff item: %+v", item)
}
}
// Refs #391: the Sync tab listed every converted extension agent as pending.
func TestHandleDiff_AgentExtensionOutputsAreNotPending(t *testing.T) {
s, _ := newTestServer(t)
agentSource := filepath.Join(t.TempDir(), "agents")
agentTarget := filepath.Join(t.TempDir(), "codex-agents")
if err := os.MkdirAll(agentSource, 0o755); err != nil {
t.Fatalf("mkdir agent source: %v", err)
}
srcFile := filepath.Join(agentSource, "reviewer.md")
if err := os.WriteFile(srcFile, []byte("# Reviewer"), 0o644); err != nil {
t.Fatalf("write agent: %v", err)
}
agents := []resource.DiscoveredResource{{FlatName: "reviewer.md", AbsPath: srcFile, RelPath: "reviewer.md"}}
spec := &sync.ExtensionSpec{Run: []string{"cat"}, Dir: agentSource, Name: "id", OutputExt: "toml"}
if _, err := sync.SyncAgentsTransform(agents, agentSource, agentTarget, "copy", spec, false, false); err != nil {
t.Fatalf("seed converted output: %v", err)
}
s.cfg.AgentsSource = agentSource
s.cfg.Targets["codex"] = config.TargetConfig{
Skills: &config.ResourceTargetConfig{Path: filepath.Join(t.TempDir(), "codex-skills")},
Agents: &config.ResourceTargetConfig{Path: agentTarget, Extension: "id"},
}
if err := s.cfg.Save(); err != nil {
t.Fatalf("save config: %v", err)
}
req := httptest.NewRequest(http.MethodGet, "/api/diff", nil)
rr := httptest.NewRecorder()
s.handler.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
if strings.Contains(rr.Body.String(), "reviewer") {
t.Fatalf("converted agent should not be pending: %s", rr.Body.String())
}
}