mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-18 18:04:17 +00:00
Adopting the portable root plugin.json replaced the whole Codex target info, dropping the interface.logo read from .codex-plugin/plugin.json. Codex still overlays that native manifest, and the portable one rarely names a logo, so the add/list UI fell back to a generic icon. Refs Codex review on #396.
185 lines
6.5 KiB
Go
185 lines
6.5 KiB
Go
package plugin
|
|
|
|
import (
|
|
"context"
|
|
"slices"
|
|
"testing"
|
|
)
|
|
|
|
func TestManifestFailureIsTargetLocal(t *testing.T) {
|
|
root := fixture(t)
|
|
writeFile(t, root, ".cursor-plugin/plugin.json", "{")
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
c := d.Candidates[0]
|
|
if !slices.Contains(c.Targets, "claude") || slices.Contains(c.Targets, "cursor") {
|
|
t.Fatalf("wrong targets: %+v", c)
|
|
}
|
|
}
|
|
|
|
func TestOpenCodeConventionalEntryWithoutSDK(t *testing.T) {
|
|
root := fixture(t)
|
|
writeFile(t, root, "package.json", `{"name":"demo","main":".opencode/plugins/demo.js"}`)
|
|
writeFile(t, root, ".opencode/plugins/demo.js", "export const Demo = async () => ({})")
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !slices.Contains(d.Candidates[0].Targets, "opencode") {
|
|
t.Fatal("OpenCode convention was not detected")
|
|
}
|
|
}
|
|
|
|
func TestOrdinaryNPMPackageIsNotPlugin(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeFile(t, root, "package.json", `{"name":"ordinary","main":"index.js"}`)
|
|
writeFile(t, root, "index.js", "export default {}")
|
|
if _, err := Discover(context.Background(), root); err == nil {
|
|
t.Fatal("ordinary package accepted")
|
|
}
|
|
}
|
|
|
|
func TestPiConventionalPackage(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeFile(t, root, "package.json", `{"name":"demo","keywords":["pi-package"]}`)
|
|
writeFile(t, root, "extensions/demo.ts", "export default () => {}")
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !slices.Contains(d.Candidates[0].Targets, "pi") {
|
|
t.Fatal("Pi convention was not detected")
|
|
}
|
|
}
|
|
|
|
func TestMissingOpenCodeEntryNamesTheSentenceAndTheFile(t *testing.T) {
|
|
root := fixture(t)
|
|
writeFile(t, root, "package.json", `{"name":"demo","dependencies":{"@opencode-ai/plugin":"1"}}`)
|
|
d, err := DiscoverOptions(context.Background(), root, "", "dist/main.js")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
info := d.Candidates[0].TargetInfo["opencode"]
|
|
if info.ProblemKey != "plugins.problem.opencodeEntryMissing" || info.ProblemArgs["entry"] != "dist/main.js" || info.Problem == "" {
|
|
t.Fatalf("problem is not translatable: %+v", info)
|
|
}
|
|
}
|
|
|
|
func TestExplicitOpenCodeEntry(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeFile(t, root, "package.json", `{"name":"custom","main":"index.js"}`)
|
|
writeFile(t, root, "entry.js", "export const plugin = async () => ({})")
|
|
d, err := DiscoverOptions(context.Background(), root, "", "entry.js")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if d.Candidates[0].TargetInfo["opencode"].Entry != "entry.js" {
|
|
t.Fatalf("entry ignored: %+v", d)
|
|
}
|
|
if _, err := DiscoverOptions(context.Background(), root, "", "../outside.js"); err == nil {
|
|
t.Fatal("escaped explicit entry")
|
|
}
|
|
if _, err := DiscoverRef(context.Background(), root, "main"); err == nil {
|
|
t.Fatal("local source accepted Git ref")
|
|
}
|
|
}
|
|
|
|
func TestBrokenCatalogDoesNotHideValidManifest(t *testing.T) {
|
|
root := fixture(t)
|
|
writeFile(t, root, ".cursor-plugin/marketplace.json", "{")
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(d.Candidates) != 1 || len(d.Warnings) != 1 {
|
|
t.Fatalf("unexpected discovery: %+v", d)
|
|
}
|
|
}
|
|
|
|
func TestDroidPluginTargetNotSupported(t *testing.T) {
|
|
if slices.Contains(Targets, "droid") {
|
|
t.Fatal("Droid must not be offered")
|
|
}
|
|
root := fixture(t)
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if slices.Contains(d.Candidates[0].Targets, "droid") {
|
|
t.Fatal("Droid compatibility must not be advertised")
|
|
}
|
|
}
|
|
|
|
// Codex 0.159 installs from a portable root plugin.json ahead of .codex-plugin/plugin.json, so
|
|
// its version is what Codex reports after an update.
|
|
func TestCodexPortableManifestPrecedesNative(t *testing.T) {
|
|
root := fixture(t)
|
|
writeFile(t, root, "plugin.json", `{"$schema":"https://agent-plugins.org/schemas/1.0.0/plugin.schema.json","name":"demo","version":"portable"}`)
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if info := d.Candidates[0].TargetInfo["codex"]; info.Manifest != "plugin.json" || info.Version != "portable" {
|
|
t.Fatalf("Codex manifest: %+v", info)
|
|
}
|
|
writeFile(t, root, "plugin.json", "{")
|
|
d, err = Discover(context.Background(), root)
|
|
if err != nil || !slices.Contains(d.Candidates[0].Targets, "codex") {
|
|
t.Fatalf("broken fallback hid native manifest: %+v %v", d, err)
|
|
}
|
|
}
|
|
|
|
// Codex reports 1.0.0 for a portable manifest without a version; expecting it keeps the
|
|
// post-update version check instead of skipping it.
|
|
func TestCodexExpectsDefaultVersionOfVersionlessPortableManifest(t *testing.T) {
|
|
root := t.TempDir()
|
|
writeFile(t, root, "plugin.json", `{"$schema":"https://agent-plugins.org/schemas/1.0.0/plugin.schema.json","name":"demo"}`)
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got := d.Candidates[0].TargetInfo["codex"].Version; got != "1.0.0" {
|
|
t.Fatalf("Codex version = %q, want 1.0.0", got)
|
|
}
|
|
if got := d.Candidates[0].TargetInfo["cursor"].Version; got != "" {
|
|
t.Fatalf("cursor version = %q, want none", got)
|
|
}
|
|
}
|
|
|
|
// Codex overlays .codex-plugin/plugin.json on a portable manifest, so its logo still applies.
|
|
func TestCodexKeepsNativeLogoUnderPortableManifest(t *testing.T) {
|
|
root := fixture(t)
|
|
writeFile(t, root, ".codex-plugin/plugin.json", `{"name":"demo","version":"1.0.0","skills":"./skills","interface":{"logo":"./logo.png"}}`)
|
|
writeFile(t, root, "logo.png", "png-bytes")
|
|
writeFile(t, root, "plugin.json", `{"$schema":"https://agent-plugins.org/schemas/1.0.0/plugin.schema.json","name":"demo"}`)
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got := d.Candidates[0].TargetInfo["codex"].Logo; got != "data:image/png;base64,cG5nLWJ5dGVz" {
|
|
t.Fatalf("native logo lost: %q", got)
|
|
}
|
|
}
|
|
|
|
func TestCodexLogoComesFromTheManifestInsideThePlugin(t *testing.T) {
|
|
root := fixture(t)
|
|
writeFile(t, root, ".codex-plugin/plugin.json", `{"name":"demo","version":"1.0.0","skills":"./skills","interface":{"logo":"./logo.png"}}`)
|
|
writeFile(t, root, "logo.png", "png-bytes")
|
|
d, err := Discover(context.Background(), root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got := d.Candidates[0].TargetInfo["codex"].Logo; got != "data:image/png;base64,cG5nLWJ5dGVz" {
|
|
t.Fatalf("logo not read: %q", got)
|
|
}
|
|
writeFile(t, root, ".codex-plugin/plugin.json", `{"name":"demo","version":"1.0.0","skills":"./skills","interface":{"logo":"../outside.png"}}`)
|
|
if d, err = Discover(context.Background(), root); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got := d.Candidates[0].TargetInfo["codex"].Logo; got != "" {
|
|
t.Fatalf("logo outside the plugin was read: %q", got)
|
|
}
|
|
}
|