Files
skillshare/internal/plugin/codex_cli.go
T
Willie f0e3ee22b3 test(plugin): keep Codex finder tests off the machine's own installs
The macOS finder tests stub PATH, but the candidate list still checked
/opt/homebrew/bin/codex, /usr/local/bin/codex and /Applications on the
real filesystem. In the devcontainer /usr/local/bin/codex exists, so it
won over the app bundle each test set up and make check failed there.

The finder now joins those absolute paths onto a root field, "" on a
real machine, and the tests point it at an empty temp dir.
2026-10-04 22:56:12 +08:00

98 lines
3.3 KiB
Go

package plugin
import (
"os"
"os/exec"
"path/filepath"
"runtime"
"strings"
)
// codexCLIEnv points plugin commands at a Codex CLI on this machine only, for when the
// config is shared with another OS or a background job starts with a minimal PATH.
const codexCLIEnv = "SKILLSHARE_CODEX_CLI"
// codexFinder looks for the Codex CLI. Its fields are the machine, so tests can stand in.
type codexFinder struct {
goos string
root string // prefixes the absolute install paths; "" on a real machine
home string
localAppData string
getenv func(string) string
lookPath func(string) (string, error)
}
func newCodexFinder() codexFinder {
home, _ := os.UserHomeDir()
return codexFinder{goos: runtime.GOOS, home: home, localAppData: os.Getenv("LOCALAPPDATA"), getenv: os.Getenv, lookPath: exec.LookPath}
}
// candidates are the places a Codex CLI is installed outside PATH: Homebrew or the
// Windows installer, which a background job's PATH may lack, and the copy the Codex
// desktop app ships. A pattern may
// hold one *, for the Windows app's per-version folder.
func (f codexFinder) candidates() []string {
switch f.goos {
case "darwin":
paths := []string{filepath.Join(f.root, "/opt/homebrew/bin/codex"), filepath.Join(f.root, "/usr/local/bin/codex")}
dirs := []string{filepath.Join(f.root, "/Applications")}
if f.home != "" {
dirs = append(dirs, filepath.Join(f.home, "Applications"))
}
// The app is ChatGPT.app since it merged with ChatGPT, Codex.app before. Since 26.924
// its CLI is the packaged entrypoint codex-cli/bin/codex; older builds have codex.
for _, dir := range dirs {
for _, app := range []string{"ChatGPT.app", "Codex.app"} {
resources := filepath.Join(dir, app, "Contents", "Resources")
paths = append(paths, filepath.Join(resources, "codex-cli", "bin", "codex"), filepath.Join(resources, "codex"))
}
}
return paths
case "windows":
// The official PowerShell installer's default, then the copy the app keeps.
if f.localAppData != "" {
return []string{
filepath.Join(f.localAppData, "Programs", "OpenAI", "Codex", "bin", "codex.exe"),
filepath.Join(f.localAppData, "OpenAI", "Codex", "bin", "*", "codex.exe"),
}
}
}
return nil
}
// find returns the Codex CLI to run and the places it looked. It returns "codex" when
// nothing is found, so the run still fails as missing, and looked then names the places.
func (f codexFinder) find() (string, []string) {
if cli := strings.TrimSpace(f.getenv(codexCLIEnv)); cli != "" {
return cli, []string{codexCLIEnv + "=" + cli}
}
looked := []string{"PATH"}
if _, err := f.lookPath("codex"); err == nil {
return "codex", looked
}
for _, pattern := range f.candidates() {
looked = append(looked, pattern)
if path := newest(pattern); path != "" {
return path, looked
}
}
return "codex", looked
}
// newest is the most recently modified file matching pattern: the Codex app leaves one
// folder per version it has installed.
func newest(pattern string) string {
matches, _ := filepath.Glob(pattern)
best, bestTime := "", int64(0)
for _, path := range matches {
info, err := os.Stat(path)
if err != nil || info.IsDir() {
continue
}
if t := info.ModTime().UnixNano(); best == "" || t > bestTime {
best, bestTime = path, t
}
}
return best
}