Files
skillshare/internal/server/handler_toggle_batch_test.go
Willie d4c2f6e9a0 fix(server): report toggles that .local ignore rules override
Disabling a skill only checked that its path was written to .skillignore.
A "!" rule in .skillignore.local is applied after that file, and an
unanchored one such as "!feature-radar" re-includes every path segment with
that name, so the skill stayed enabled while the dashboard reported success.
The dashboard also never showed the .local file, so nothing explained why.

Single and batch toggles now re-discover after writing and report an item
that did not reach the requested state as failed, naming the overriding
file; the batch toast shows the first failure's reason. GET /api/skillignore
and /api/agentignore return the .local file, and Settings > Files shows its
rules above the editor.
2026-10-04 19:34:24 +08:00

190 lines
5.9 KiB
Go

package server
import (
"bytes"
"encoding/json"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"strings"
"testing"
)
func postBatchToggle(t *testing.T, s *Server, body string) (*httptest.ResponseRecorder, batchToggleResponse) {
t.Helper()
req := httptest.NewRequest(http.MethodPost, "/api/resources/batch/toggle", bytes.NewBufferString(body))
rr := httptest.NewRecorder()
s.handler.ServeHTTP(rr, req)
var resp batchToggleResponse
if rr.Code == http.StatusOK {
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
t.Fatalf("failed to decode response: %v (body=%s)", err, rr.Body.String())
}
}
return rr, resp
}
func readIgnoreLines(t *testing.T, path string) []string {
t.Helper()
data, err := os.ReadFile(path)
if err != nil {
if os.IsNotExist(err) {
return nil
}
t.Fatalf("read ignore file: %v", err)
}
var lines []string
for _, l := range strings.Split(string(data), "\n") {
if s := strings.TrimSpace(l); s != "" {
lines = append(lines, s)
}
}
return lines
}
func TestHandleBatchToggle_DisableSkills(t *testing.T) {
s, src := newTestServer(t)
addSkill(t, src, "skill-a")
addSkill(t, src, "skill-b")
addSkill(t, src, "skill-c")
rr, resp := postBatchToggle(t, s, `{"names":["skill-a","skill-b"],"kind":"skill","enable":false}`)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
if resp.Summary.Updated != 2 || resp.Summary.Unchanged != 0 || resp.Summary.Failed != 0 {
t.Fatalf("unexpected summary: %+v", resp.Summary)
}
lines := readIgnoreLines(t, filepath.Join(src, ".skillignore"))
got := map[string]bool{}
for _, l := range lines {
got[l] = true
}
if !got["skill-a"] || !got["skill-b"] {
t.Errorf("expected skill-a and skill-b disabled, got %v", lines)
}
if got["skill-c"] {
t.Errorf("skill-c should not be disabled, got %v", lines)
}
}
func TestHandleBatchToggle_EnableSubset(t *testing.T) {
s, src := newTestServer(t)
addSkill(t, src, "skill-a")
addSkill(t, src, "skill-b")
if err := os.WriteFile(filepath.Join(src, ".skillignore"), []byte("skill-a\nskill-b\n"), 0644); err != nil {
t.Fatalf("seed .skillignore: %v", err)
}
rr, resp := postBatchToggle(t, s, `{"names":["skill-a"],"kind":"skill","enable":true}`)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
if resp.Summary.Updated != 1 {
t.Fatalf("expected updated=1, got %+v", resp.Summary)
}
lines := readIgnoreLines(t, filepath.Join(src, ".skillignore"))
if len(lines) != 1 || lines[0] != "skill-b" {
t.Errorf("expected only skill-b remaining disabled, got %v", lines)
}
}
func TestHandleBatchToggle_AlreadyDisabled_Unchanged(t *testing.T) {
s, src := newTestServer(t)
addSkill(t, src, "skill-a")
if err := os.WriteFile(filepath.Join(src, ".skillignore"), []byte("skill-a\n"), 0644); err != nil {
t.Fatalf("seed .skillignore: %v", err)
}
_, resp := postBatchToggle(t, s, `{"names":["skill-a"],"kind":"skill","enable":false}`)
if resp.Summary.Unchanged != 1 || resp.Summary.Updated != 0 {
t.Fatalf("expected unchanged=1, got %+v", resp.Summary)
}
}
func TestHandleBatchToggle_UnknownName_Failed(t *testing.T) {
s, src := newTestServer(t)
addSkill(t, src, "skill-a")
_, resp := postBatchToggle(t, s, `{"names":["skill-a","ghost"],"kind":"skill","enable":false}`)
if resp.Summary.Updated != 1 || resp.Summary.Failed != 1 {
t.Fatalf("expected updated=1 failed=1, got %+v", resp.Summary)
}
var ghost *batchToggleItemResult
for i := range resp.Results {
if resp.Results[i].Name == "ghost" {
ghost = &resp.Results[i]
}
}
if ghost == nil || ghost.Success || ghost.Error == "" {
t.Fatalf("expected ghost to fail with error, got %+v", ghost)
}
}
func TestHandleBatchToggle_Agents(t *testing.T) {
s, _ := newTestServer(t)
agentsDir := s.agentsSource()
if err := os.MkdirAll(agentsDir, 0o755); err != nil {
t.Fatalf("create agents dir: %v", err)
}
addAgent(t, agentsDir, "demo/reviewer.md")
addAgent(t, agentsDir, "demo/planner.md")
rr, resp := postBatchToggle(t, s, `{"names":["demo/reviewer.md","demo/planner.md"],"kind":"agent","enable":false}`)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
if resp.Summary.Updated != 2 {
t.Fatalf("expected updated=2, got %+v", resp.Summary)
}
lines := readIgnoreLines(t, filepath.Join(agentsDir, ".agentignore"))
got := map[string]bool{}
for _, l := range lines {
got[l] = true
}
if !got["demo/reviewer.md"] || !got["demo/planner.md"] {
t.Errorf("expected both agents disabled, got %v", lines)
}
}
func TestHandleBatchToggle_InvalidKind(t *testing.T) {
s, _ := newTestServer(t)
rr, _ := postBatchToggle(t, s, `{"names":["x"],"kind":"bogus","enable":false}`)
if rr.Code != http.StatusBadRequest {
t.Errorf("expected 400 for invalid kind, got %d", rr.Code)
}
}
// A "!name" rule in .skillignore.local re-includes every path segment called
// name, so writing the skill's path to .skillignore does not disable it.
func seedLocalNegation(t *testing.T, src string) {
t.Helper()
addSkill(t, src, "feature-radar/feature-radar")
addSkill(t, src, "feature-radar/feature-radar-scan")
if err := os.WriteFile(filepath.Join(src, ".skillignore.local"), []byte("!feature-radar\n"), 0644); err != nil {
t.Fatalf("seed .skillignore.local: %v", err)
}
}
func TestHandleBatchToggle_DisableOverriddenByLocalNegation_Fails(t *testing.T) {
s, src := newTestServer(t)
seedLocalNegation(t, src)
rr, resp := postBatchToggle(t, s, `{"names":["feature-radar__feature-radar","feature-radar__feature-radar-scan"],"kind":"skill","enable":false}`)
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
}
if resp.Summary.Updated != 1 || resp.Summary.Failed != 1 {
t.Fatalf("expected updated=1 failed=1, got %+v", resp.Summary)
}
r := resp.Results[0]
if r.Success || r.Disabled || !strings.Contains(r.Error, ".skillignore.local") {
t.Errorf("expected overridden skill to fail naming .skillignore.local, got %+v", r)
}
}