* chore(main): release 0.25.9
* chore(release): synchronize release metadata
* docs(release): write user-facing notes for 0.25.9
Replace the generated commit list with notes that describe each change
from the user's side, with examples, matching the recent entries.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
The MCP page's Open in editor button (#552) was documented only in the
English command reference, so ja, ko, zh-Hans and zh-Hant readers did not
learn about it or that it shows only when the browser runs on the
dashboard's machine.
* fix(config): keep YAML anchors and aliases when a command writes the config
Every writer re-encodes the in-memory struct, which has no anchors, so a
command such as `target a --add-exclude` expanded `&shared` / `*shared`
under targets and projects and the lists stopped following each other.
The comment pass added for #525 already pairs each old node with the one
that replaced it; relinkAliases uses the same pairs to put anchors back and
turn unedited alias values into aliases again.
An anchored node keeps its anchor and the aliases that still hold its old
value follow its new value, as the file declares. An alias that was edited
keeps its own list and leaves the anchored one alone. Output is sorted by
name, so the anchor moves to the first place the group appears: an alias
may not precede its anchor.
Fixes#546
* fix(config): keep YAML merge keys when a command writes the config
A command rewrites config.yaml from the Go struct, which holds the merged
keys of `<<: *base` and not the merge itself, so every merge key was written
out expanded and later edits of the anchored mapping no longer reached the
mappings that merged it. relinkAliases already restored anchors and aliases
from the old/new node pairing; relinkMerge now does the same for merge keys,
including `<<: [*a, *b]`, merges in nested mappings and in project-config
target items.
A key stays written out when the old mapping set it itself, or when its value
is no longer the one its merge source gives it. yaml.v3 merges are shallow, so
such a key replaces the merged value as a whole and what is written always
decodes to the config the command meant to save. A source that was removed, or
that holds a key the mapping no longer has, is not merged back.
Output order is not the old file's order, so an anchor that would follow its
first merge key moves onto it (`<<: &base`). The next write pairs that mapping
with the alias that still shows its value, so the file stays stable.
The runbook steps for anchors now write their own config: mdproof re-runs the
setup before each step, so step 7 and 8 never saw the config of step 6
(Codex review on #551). Steps for merge keys are added the same way.
* fix(config): let edits of an anchored mapping that add or remove a key reach its mergers
A command that added a key to an anchored mapping (the first `agents:`
block via `target base --agent-mode copy`) made relinkMerge refuse the
merge source: the merging mapping's pre-edit data lacked the key, which
was read as "the command removed it". The merge key was dropped and the
merger written out expanded, so later edits of the anchor no longer
reached it.
A source is now refused only when the merging mapping had a key before
the write and the command removed it. A key the source gained does not
count.
The symmetric case is fixed with it: a key removed from the anchored
mapping stayed written out under a merger that still held the old merged
value. An unedited key that the merger did not set itself now follows
the source that gave it, whatever that source now says (a changed value,
a removed key, or the next source of `<<: [*a, *b]`). A key the merger
set itself, or that the command edited, stays written out.
Tests cover add, remove and change of a key on the anchored mapping and
on the merging mapping, a key from either source of a merge list, nested
merges, projects, project-config target items and chained merges. Runbook
step 11 covers the real binary.
* fix(config): keep every comment when a write relinks merge keys and aliases
Rewriting a merge key replaced the original merge items and covered keys with
new nodes and carried over only the comments of the key and the list itself, so
a comment on an item of `<<:` followed by `- *a # note` was lost on any write,
and so was the trailing comment of a removed key when the mapping was left with
keys the merge supplies.
Comments now follow the entry they were on: a merge item's to the alias that
replaces it, those of an item that is no longer merged to the next item, and
those of a key the merge supplies to the next key still written, or in front of
the merge key when none is. The merge list keeps its flow or block style so item
comments stay on their lines.
Sweeping the rest of the relink paths for the same loss found more places where
yaml.v3 drops or moves a comment: the comment after an anchor on a block mapping
collided with its first key's comment, a line comment on a block collection or
on a key with an empty value is not written, and an anchored collection's head
comment moved on the next write. These are settled once on the written tree, and
the body of an inline merge source gets its comments paired too.
Open in editor split $VISUAL and $EDITOR on whitespace, so a Windows
path such as "C:\Program Files\Notepad++\notepad++.exe" broke at the
space and no editor was found. A user asked to open files in Notepad++,
which is not on PATH by default (#538).
Double or single quotes now keep a field together. Backslashes stay
literal, since Windows paths use them.
* feat(mcp): open an Agent's MCP config file from the dashboard
Users asked to jump from the MCP page straight into a client's config
file, such as opencode.json or .cursor/mcp.json, instead of copying the
path and opening it by hand (#538).
The open uses the same editor chain as a skill's Open in editor, so the
dashboard opens files one way. The endpoint takes a target, not a path,
and only opens a file the MCP page already lists. It answers only
requests from the machine running the dashboard, because the editor
starts on that machine. The list now reports which files exist, so the
button is hidden for a client detected before it has a file.
* fix(mcp): hide Open in editor where the server would refuse it
Codex review: the dashboard can be opened through a LAN IP, but the
open endpoint answers only loopback requests, so the button showed and
every click returned 403, while the docs promised it would open.
The list now reports `openable` instead of `existing`: the files that
exist, and only when the request comes from the dashboard's machine. A
viewer elsewhere does not see the button, and the docs say where it
appears.
* fix(mcp): don't treat a reverse proxy's viewers as local for Open in editor
Codex review: the documented Nginx and Caddy setups connect from
127.0.0.1, so the loopback socket check let any browser behind the proxy
see the button and launch editors on the server.
The browser now counts as local only when the socket and the Host it
used are both loopback and no proxy forwarding header is present. Both
documented proxies keep the browser's Host and add X-Real-IP or
X-Forwarded-For, so their viewers no longer qualify.
* fix(sync): limit project adoption writes to moved skills
A stale install record could trigger a full project reconcile during sync, adding unrelated remote installs to the manifest, ignore rules and lockfile. Skip project writes when nothing was re-keyed, and update only moved declarations, ignore rules and existing pins while preserving full explicit reconcile behavior.
Cover the visible project directory sharing its global source with byte-identical no-move checks and a real move that preserves unrelated entries and audit acceptances.
* fix(sync): preserve existing move destination declarations
The adoption-only config rewrite could duplicate a destination already declared in the project manifest. Keep that destination declaration and remove the moved old entry, matching full reconcile behavior while preserving the destination fields.
Add a regression that fails with duplicate entries and passes with the existing destination branch retained. Re-run make check after the fix.
Pi 1.2.0 (earendil-works/pi#10765) runs normalizePath on resource-filter
patterns before matching, so `~`, `~/`, `file://` and, on Windows, `~\`
and Git Bash/MSYS/Cygwin/WSL drive paths now match files that older Pi
never matched. Skillshare supports Pi 0.99.2 and later without knowing
which one evaluates the rules, so it reported a definite selection that
could be wrong and let the write guard reason from it. Such rules now
evaluate as unknown, and the dashboard names the rule instead of a
generic message.
Exact rules also missed Pi's normalizeExactPattern in every version: a
leading ".\" is dropped on all platforms and backslashes become slashes
on Windows. Skillshare only dropped "./", so `-.\extensions\a.ts`
looked unmatched and produced a duplicate missing row.
* chore(main): release 0.25.8
* chore(release): synchronize release metadata
* docs(changelog): rewrite 0.25.8 notes for users
The generated entry listed the raw commit subject. Describe the macOS OMP install fix with the message users saw and the command that now works.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
Adding a plugin from a Git URL to Oh My Pi on macOS was always blocked
with "linked or non-directory OMP path component", which the dashboard
shows as "The reviewed OMP runtime destination must be verified empty".
The source is cloned into os.MkdirTemp, which lives under /var/folders,
and /var links to /private/var. The OMP install check reads the source's
package.json through ompSafePath, which rejects any linked component, so
Skillshare's own temp clone failed it. A local source under a linked
parent failed the same way.
acquireRef now hands callers the resolved root of the temp clone and of
a local directory, while the recorded source stays as given. Links inside
the source are still handled as before; cleanup still removes the
original temp directory.
* chore(main): release 0.25.7
* chore(release): synchronize release metadata
* docs(changelog): rewrite 0.25.7 notes for users
The generated entry listed raw commit subjects. Describe the OMP version fix and the plugin update dialog fix in the changelog's usual style, with the error users saw and what changed.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
* fix(plugin): accept OMP 18.6.1 and later instead of exactly 18.6.1
The OMP adapter pinned the native version to exactly 18.6.1, so every
newer release was refused: the dashboard reported "Installation requires
OMP 18.6.1" for a user on 18.8.7, and removal and standalone extension
selection were blocked the same way.
The sources the adapter depends on (marketplace cache/manager/types,
plugin-cli output, the project anchor in discovery/helpers.ts, extension
loading and the pi-natives file lock) are unchanged from v18.6.1 through
v18.10.2, so the pin is now a minimum. The install, removal and selection
gates share one check built on the existing plainVersion helper;
unparsable, prerelease and older versions stay blocked.
Messages, all dashboard locales, the plugin reference docs and the
built-in skill now state 18.6.1+. A test keeps the English guidance text
in en.json equal to the Go strings the dashboard matches on.
* fix(docs): record the OMP 18.6.1+ boundary in the cache safety report
The safety report still said installation is allowed only for OMP 18.6.1
and that an unknown version blocks it, which no longer matches the gate.
It now states the minimum, which versions stay blocked, and the source
comparison and native 18.8.7 run that justify replacing the pin. The two
OMP runbooks no longer require exactly 18.6.1.
Keep plugin names on their own line and let agent labels and version changes wrap. Reserve space for update status so batches with many agents remain readable.
Shared memory lives under ~/.config/skillshare/extras/memory on the host.
Inside the devcontainer the CLI resolves a different path, so the blanket
"never run skillshare on the host" rule blocked memory reviews from
saving approved notes. Carve out an exception limited to
`skillshare extras memory ... -g` on explicit user request.
The 0.25.6 callout covers the batch plugin update, the dashboard memory
section and memory tools, and OpenCode 2 MCP and plugin support. The
dashboard memory paragraph from #537 was only in English; the four
translated guides now carry it. johnkattenhorn reported #535.
* fix(mcp): turn off a global server in OpenCode 2 projects
OpenCode 2 replaces a global server with the project entry of the same
name, and silently drops an entry without its type and command or url.
The project switch Skillshare wrote, {"enabled": false}, therefore left
the server on in OpenCode 2, while OpenCode 1 merged it by field.
Checked against OpenCode 2.0.27 and 1.19.0: OpenCode 2 still reads the
flat mcp.<name> shape and turns enabled: false into disabled: true, and
both read an entry with type and command or url. So no version detection
is needed. When the global config under mcp.projects defines the server,
the OpenCode switch now carries its type and executable, or its url
without the query, next to enabled: false. Args, env, headers and the
query stay out of a project file that may be committed, as the Pi switch
once did. A switch that already carries the endpoint keeps it when the
global server later leaves the config, unless it was edited since sync.
In project mode, or when the global config lacks the server, only the
bare switch can be written; the plan now says OpenCode 2 ignores it, in
the CLI and the dashboard.
Import also reads OpenCode 2's mcp.servers section, which its own
`mcp add` writes, instead of reporting it as one broken server.
Refs #538
* fix(mcp): keep secrets in a URL path out of the OpenCode switch
The OpenCode switch dropped only the query of the global server's URL.
Some MCP services put the key in the path instead, and an absolute
executable path names the user's home directory; both then reached a
project file that may be committed. A disabled server never starts, and
OpenCode 2 accepts any type with a command or url, so the switch now
carries only the executable's name or the URL's scheme and host.
Refs #538
* fix(mcp): skip OpenCode 2's timeout defaults when importing
OpenCode 2 keeps server defaults in mcp.timeout next to mcp.servers, so
import listed timeout as a broken server. It is dropped only together
with a recognized servers section, where it cannot be a v1 server.
Refs #538
* fix(mcp): read an empty OpenCode 2 servers section
An empty mcp.servers object was not recognized as OpenCode 2's section,
so import listed servers and timeout as broken servers instead of
finding no entries. The dashboard help for disabled also still said only
the switch is written, which is no longer true for opencode.
Refs #538
* fix(mcp): keep an OpenCode endpoint switch next to its own fields
The kept switch was matched by the whole native entry, so a field only
OpenCode reads, such as a per-server timeout, made the next sync drop the
type and command or url once the global server left the config, and
OpenCode 2 then ignored the switch. Match the fields Skillshare manages.
Refs #538
* fix(mcp): show the OpenCode endpoint switch in the dashboard preview
The dashboard renders a project's server alone, so the preview never saw
the same-named global server and showed the bare switch that OpenCode 2
ignores, while sync wrote the switch with the endpoint. Resolve the
global server the way sync does.
Refs #538
* fix(plugin): read OpenCode 2's version output
OpenCode 2 prints "opencode v2.0.27" for --version, while OpenCode 1
prints only "1.19.0". The adapter trimmed a leading "v" only, so plugin
sync to OpenCode 2 failed as an unrecognized version and imported
updates were skipped as if OpenCode 1 had no update command. Read the
last field, and decide the update check with the same parser.
Refs #538
* feat(memory): add host-owned review and verification workflows
Share scoped memory tools between Dashboard and Memory, and route retrospective and Dreaming requests through the built-in skill. Keep agent execution in the host, require approval for reviewed edits, and preserve versioned CLI write safeguards.
Confirm scope before exposing prompts and include the resolved root in recent memory responses. Update provenance guidance and localized documentation, with regressions for unavailable scope and protected review prompts.
* fix(memory): distinguish trial copy controls for screen readers
Include the localized step title in each trial copy control accessible name while keeping the short visible label. Update the existing clipboard test selector for the distinct names; no new test or local test rerun was requested for this label-only fix.
* fix(memory): point connection hints to the trial tools
Replace stale verification-prompt directions in all eleven locales with the current Memory tools and Try across sessions labels. Interpolate the existing localized labels so future naming changes remain aligned.
No new tests or local test reruns for this copy-only correction, as requested by the maintainer.
* feat(ui): surface existing shared memory on the dashboard
Make shared notes visible through recent updates and direct links, with file timestamps and an introductory state for untouched starters. Keep the dashboard quiet until memory is configured, and preserve access to existing notes when starter files are missing.
* fix(memory): bound dashboard reads and remember preview expansion
Count vault entries from metadata and read at most the two starters and four recent candidates instead of hashing the full vault on dashboard load. Keep incomplete starter states accessible and refresh the overview after source and instruction changes. Remember preview expansion in browser storage and raise the collapsed height to 360px.
An imported plugin's native marketplace decides the version an update installs, so the update check now applies only to bindings with a reviewed source and an import records the version installed. Importing an imported plugin again also records the installed version; a source binding keeps the version Skillshare reviewed.
Refs #535
Updating several plugins from the dashboard was slow: each plugin took a
preview and an apply round trip, apply previewed again, every plugin cloned
its source on its own, and config reloaded after each one.
The dashboard now sends the picks to POST /api/plugins/update/stream. The
server holds the plugin lock once, previews each plugin once and applies that
plan, lets plugins from one source share a single read of it, and reloads
config once at the end. POST /api/plugins/update/stop lets the plugin under
way finish and starts no other; a closed page does not cut an install short.
The check-to-update safety moves to the server: an Agent whose source moved
since the check, or that no check showed, installs nothing. npm packages in
Pi are exempt, since Pi installs whatever npm names latest; the old
client-side comparison flagged them as moved on every update.
The update dialog follows the Skills update page, shows per-Agent old -> new
versions, fails rows a broken stream never finished, and lists every plugin
with its Agent and version when all are current.
Release-As: 0.25.6
A successful source update does not always require a target sync: existing symlinks already expose the updated content. Recheck the per-kind diff before offering Sync Now, refresh it when resources change, and report check failures without claiming targets are current.
Cover stale previews and post-sync dismissal with regression tests, and align the dashboard, workflow, source/target, and built-in skill documentation across locales.
Prefixed naming rewrites name: in every copy to the entry name, so the
target folder and name: always agree. Requiring name: to equal the source
folder only skipped skills it could sync: a tracked repo that is itself a
skill lives in _<repo>, so its root SKILL.md could never pass.
Only standard naming now requires the match; name format rules still
apply to both. Sync lists the skills named this way, so a user looking
for _ooux in the target finds ooux.
The dashboard's skipped-skills hint always blamed folders that end in the
same name, even when skills were skipped for their name. The diff API now
reports naming skips apart from collisions and the hint names the cause.
Refs #530
* feat(ui): check plugin updates on load and update them in one batch
Updating plugins took four steps each: press Check updates, press Update
on one row, review a second preview, apply, then check again because the
list did not know the update had happened. Six plugins meant six rounds.
The page now checks once in the background when it opens, so rows show
their new version without a click. The header's Check updates button
becomes "Update N" when something is behind and opens one dialog: every
plugin with an update is ticked, a plugin on several Agents is one row
whose Agents can be left out, and imported installs Skillshare cannot
update sit apart. One button runs them in turn through the existing
preview and apply, so no new API is needed. Progress, results, errors
and per-Agent retry stay in the same dialog, and the applied results
update the page state, so nothing has to be checked again.
The count and the dialog both come from what is still behind after the
last check, limited to Agents that can be updated from here, so a
partial batch is not offered again and Agents with check but no update
(OMP, Antigravity CLI, Grok) do not inflate the count.
* fix(ui): keep batch plugin updates to what the user reviewed
Codex review of #527 found four ways the batch update could act on
something other than what the dialog showed:
- A source that moved between the background check and the click was
installed straight from the fresh preview, so a newer version or new
components went in unreviewed. The batch now compares each fresh plan
with the version and commit the check showed, applies nothing when
they differ, says so on the row, and runs a quiet check so the next
dialog shows the new version for review.
- A retry of the failed Agents that failed again lost that subset, so a
third try re-sent Agents that had already updated. A failed row now
always keeps the Agents it failed on.
- An update the server skipped (its marketplace gone, say) counted as
done: the row said updated and the plugin left the update count.
Skipped outcomes now keep the Agent pending and show as skipped.
- A plugin removed after the check stayed in the update count and
failed with "not found" when picked. Pending updates now drop any
plugin or Agent binding the inventory no longer has.
* fix(ui): show a manual check's result and each Agent's own version move
Codex's second review of #527 found two gaps:
- A check the user pressed that found nothing to update from here (only
imported installs, or everything current) opened nothing, so the
"update inside the Agent" guidance and the up-to-date result never
showed. The check now reports whether it came back, and a check the
user asked for opens the dialog; the background check on load stays
quiet.
- A plugin on several Agents showed one version move built from the
first Agent's installed version and the first new version found, which
can mix Agents that come from different sources. The row now shows one
move only when every Agent makes the same one, and each Agent's own
move otherwise.
* fix(plugin): carry the source digest on a check so a batch update can tell it moved
Codex's third review of #527: a local-directory plugin has no commit,
so when its files changed again after the check while the manifest
version stayed the same, the batch's version and commit comparison
passed and the fresh preview was applied without the user seeing it.
The check copied the installed binding, so its digest was the one
already installed, not the source's. It now sets the discovered digest
alongside the version and commit, as the update preview already does.
The dashboard keeps that digest with each update it found and refuses
to apply when the fresh preview's digest differs, marking the row as
changed since the check. An npm package has no digest and is unaffected.
* fix(ui): list blocked check results and drop unticked Agents from the batch
Codex's fourth review of #527:
- A check can mark an Agent blocked when the updated source no longer
offers a compatible plugin for it. The update dialog listed only
updatable, native-check and up-to-date results, so it hid the block
and could say everything was current. Blocked results now get their
own section with the reason, and the empty state says nothing can be
updated from here rather than that everything is up to date.
- An Agent unticked after the check stayed in the pending updates;
picking it produced a no-op that the batch reported as updated.
Pending updates now skip bindings with sync off, as the row's own
behind count already does.
* fix(ui): count partly skipped plugins as updated and surface a failed re-check
Codex's fifth review of #527:
- When one Agent of a plugin updated and another came back skipped, the
row was marked skipped, the summary counted no update, and the Agent
that did update was not shown. A row now names which Agents updated
and which were skipped, and the summary counts any plugin with an
updated Agent.
- After a source moved since the check, the follow-up check ran quietly,
so if it failed the stale update stayed offered and every retry hit
the same skip. The moved plugin now leaves the found updates, and the
follow-up check reports its failure like any check the user started.
A comment on a key the command removed was lost. It now sits in front of the next surviving key, or on the last entry of its section, in source order. Adds the config_keeps_comments runbook.
Refs #525
Every writer re-encoded the in-memory struct, so a command such as target --mode copy dropped every comment. marshalConfig now takes the file being replaced and copies its comments onto the keys that are still present; list items are matched by name, and a read error fails the save. registry.yaml goes the same way.
Fixes#525
Cleanup after #523: install.MoveLockPins shared by skillmove and the project reconcile; one server store reload and reconcile dispatcher; adoption skips the source walk when no plain record's directory is missing.
After a plain mv, only install or Install missing moved an installed skill's record; sync now adopts it too (CLI global, CLI project, dashboard), never prunes, and skips on --dry-run. A hand-moved project skill keeps its lock pin; a same-name nested skill never takes a live record; metadata load failures are sync warnings.
Since 0.25.4 reconcile adopts a skill moved by hand at the next
install, so the warning no longer claims the source link is lost;
it names what still does not follow.
Three follow-ups from the review of #520: a name refused for a
collision no longer makes an unrelated name in the same batch fail
for a path that will not exist, a .skillignore that cannot be read
after the rename is reported instead of silently skipped, and the
batch install --dry-run path runs the same --into preflight as the
real install.
Closes#521
The move command page broke the locale builds because its relative
links and anchors only resolve against translated siblings; the
verification list now names the rule that avoids it.
The locale builds have no translated move page, so its relative
.md links did not resolve and the website build failed; the
migration anchor it points at did not exist in the translated
headings. Use absolute doc links and give the heading an explicit
id in every locale, as the other cross-linked headings do.
Add a Move dialog with entry points in the selection bar, the skill and
folder menus, the tree pane and the detail page. It previews the move
with a dry run, blocks a whole-folder move when any item is refused,
offers Move anyway only for a name collision and Sync now on the
result, and animates the new-folder step and dialog transitions.
Refs #510
Add skillshare move and POST /api/resources/batch/move so skills and
whole folders can change folder inside the source while keeping their
.metadata.json entry, accepted audit findings, lockfile pin, config
group, .gitignore and literal .skillignore lines. Moving by hand lost
the record and made the next install start over. install --into now
refuses a folder inside a skill or a tracked checkout.
Refs #510
* feat(ui): pick an existing folder when installing into a folder
The "Into folder" field in the install dialog was free text, so users
mistyped paths or could not see which folders already exist. Replace it
with a picker listing the source root, every existing folder, and a
"New folder..." entry that reveals an input validated like
validate.IntoPath. The `into` value sent to the API is unchanged, so no
backend change is needed.
Existing folders are derived client-side from the resource list and
exclude tracked repos, followed source links, folders that are skills
and names the server would reject. FolderPicker takes a disabledFolder
prop so a later move dialog can reuse it.
Refs #510
* fix(ui): block install while the picked folder is not a usable path
Two paths let an unusable `into` through:
- Choosing "New folder..." cleared the value but still counted as
valid, so install silently went to the source root. The picker now
reports validity with each change and an empty new folder is invalid.
- Validity was ignored once Advanced was collapsed, and the server does
not run IntoPath on install, so a bad path could still be installed.
The dialog now keeps the picker's validity regardless of the panel.
* feat(ui): make new folder a step in the folder picker
Typing a new folder path inline gave no sense of where it would land or
what the skill's link would be called. Align the picker with the
approved design:
- Picker rows show a folder icon, the path in monospace, and how many
skills are under it; "New folder..." sits below a separator.
- "New folder..." opens a step in the dialog with a parent folder,
a name, and a result box with the folder path and the link name
(path with / as __ in front of the skill name). Using it returns
to the picker with the new path selected and tagged as new.
- A caption under the picker says where the skill installs and what
its link is called, using the skill name from the source when known.
- Escape and the back arrow in the step return to the picker instead
of closing the install dialog.
The `into` sent to the API is still a plain path. FolderPicker takes
disabledPaths (a folder and everything below it) for the move dialog.
Refs #510
* docs(wiki): cap Codex review rounds and require a state matrix before review
PR #513 reached 7+ Codex rounds because each round surfaced one more
state dimension (project mode, tracked installs, followed links, legacy
keys, lock pins) that the change had never listed. Every round costs the
maintainer a review cycle.
Require a state matrix and a consumer sweep before the first review,
separate findings worth code from unrealistic combinations, and stop at
three rounds unless a finding shows data loss or a broken supported
workflow.
* docs(proposals): add move installed skill proposal for #510
Moving an installed skill with mv strands its install record, and the
documented workaround (uninstall + install --into) re-downloads and
drops audit acceptances and lock pins. Propose one explicit move
operation shared by the CLI, the Web API and the dashboard.
Records the maintainer decisions: no auto-sync, followed links refused,
target filters warn only, whole-folder move in v1, --force limited to
name collisions.
* fix(proposals): cover nested skills, bare tracked checkouts and duplicate destinations
Codex review of the move proposal found three gaps in the folder-move
design:
- A skill directory that contains nested skills was planned as one
skill, so descendants would move on disk but keep their old records,
pins and audit acceptances. Plan now expands descendants too.
- Refusals were derived from discovered skills only, so a tracked
checkout with no discoverable skill would move along with its folder.
Preflight now walks the whole tree for checkouts and links.
- Two inputs converging on one destination path were treated as a
forceable flat-name collision and left the batch half-moved. They are
now a separate, non-forceable duplicate_dest refusal.
* fix(proposals): keep nested records through reconcile, warn both filter directions, refuse overlapping roots
Second Codex round on the move proposal found three more gaps:
- The reconcile walk stops at an installed parent and then prunes every
record it did not see, so a moved nested skill would lose its record
and audit acceptances. Reconcile must keep records below a live
installed record.
- Target filter warnings only covered rules that stop matching. A move
into a folder that an exclude pattern covers (or an include newly
adds) changes sync output too, so compare the effective filter result
before and after.
- Batches such as `move foo foo/sub archive` planned the same subtree
twice. Overlapping source roots are now refused before any rename.
* chore(main): release 0.25.4
* chore(release): synchronize release metadata
* docs(changelog): restore the curated 0.25.4 entry and add #511, #513, #515
Release Please regenerated the entry when #513 landed on main. Restore
the user-facing version and describe the three fixes merged since: the
skills source named like a tool folder (#511, via #514), the hidden
agents source folder (#515) and moved installed skills (#513).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
* fix(install): keep a moved skill's record instead of reinstalling it
Install records are keyed by path, so a skill moved with mv shows up as
missing. "Install missing" (and bare `skillshare install`) then cloned it
again at the old path, leaving two copies that both sync to targets, and
reconcile could hand the new copy's record to the moved one.
A gone record now follows an unrecorded directory of the same name whose
files match the recorded hashes, when exactly one such directory exists.
Install-from-config skips such entries and reconcile re-keys the record,
so the moved copy keeps its source. Same-name skills with other files are
left alone, so an update can never overwrite them from that source.
Refs: #510
* fix(install): keep audit acceptances and unreadable links out of moves
Re-keying a moved skill went through Remove, which also drops the audit
findings accepted for the old path, so an unchanged skill could block or
prompt again on its next update. MoveEntry now carries them to the new key.
A record below a first-level source link that cannot be read looks gone
to Lstat, so an identical copy elsewhere could take its record while the
link was down. Such records are no longer matched as moved.
* fix(install): drop legacy-path acceptances and respect lock pins on move
A legacy basename key such as `demo` with group `old` keeps its accepted
audit findings under `old/demo`. MoveEntry removed only the key's own
acceptances, so the old path kept them and a later skill placed there
would inherit them without a new --force. It now deletes the old path.
When the lockfile pins another commit than the moved copy holds, treating
the copy as the moved skill re-keyed its stale record and let the project
lock be rewritten with the older commit. Such copies no longer count as a
move, so the pinned commit is installed as before.
* fix(install): search for moved skills only where reconcile looks
The search for a moved copy walked into installed skills and tracked
checkouts, which reconcile skips. A copy found there made install skip the
skill, then reconcile never saw the copy and pruned the record, and in
project mode the config entry with it. The search now stops at the same
boundaries.
* fix(install): never take a recorded skill as another's moved copy
Two identical skills can be recorded at different paths. When one of them
went missing, the other matched its hashes and was taken as its moved
copy, so install skipped the missing skill and reconcile pruned its record.
A directory with a record of its own is now never a move destination.
* fix(install): derive moved-copy paths from the resolved source root
sourcewalk.WalkDir reports paths under the resolved source root, but the
moved-copy search took them relative to the unresolved one. With a linked
source (or Windows short temp paths) every path came out as ../..., so the
installed-skill boundary never matched and a copy inside an installed
parent could be taken as the move, after which reconcile pruned the record.
The search now resolves the root first, as reconcile does.
* fix(install): move a record only to one copy of what the config declares
Three cases still let a move drop or misplace a record:
- In project mode the manifest can point a skill at a new source while a
copy of the old one exists elsewhere; that copy was taken as the skill,
so the new source was never installed. The record's source and branch
must now match the config entry.
- A git checkout reconcile treats as tracked could be accepted before the
tracked boundary was checked; the boundaries now run first.
- With two identical copies, reconcile re-keyed the record to whichever
it walked first. Both reconcile and the install-from-config search now
require exactly one destination, and reconcile decides after the walk.
* fix(install): clear accepted findings left at a move destination
A removed legacy grouped entry can leave findings accepted for its path
behind. MoveEntry only wrote the destination when the moved skill had its
own acceptances, so a skill moved into that path inherited findings it
never accepted. The destination is now cleared before the transfer.
* fix(install): follow a moved skill only while its declaration still matches
The install-from-config search compared source and branch but not the
tracking mode, so a skill switched to tracked was satisfied by an old
plain copy and never cloned.
Project reconciliation, which other installs also run, inferred moves
without looking at the manifest at all. A record whose declaration now
names another source could follow a copy of the old source, after which
the manifest entry was rewritten to that old source. Moves in project
mode now require the declaration to still match the record, through the
same MatchesDeclaration check the install path uses.
* fix(install): infer no move while a source link is unreadable
An unreadable followed source link can hide a second identical copy, so
a copy that looked unique could take the record arbitrarily. Reconcile
and the install-from-config search now infer a move only from a complete
inventory; reconcile already keeps the gone record in that case.
* fix(install): infer no move when the source walk hit an error
Both walks dropped traversal errors, so an unreadable directory that hid
a second identical copy left the visible one looking unique and it could
take the record. Any walk error now counts as an incomplete inventory,
like an unreadable source link, and no move is inferred from it.
* fix(install): keep a record whose move waits on a failed walk
When a walk error deferred a move, the walk still counted as complete, so
pruning dropped the gone record along with its accepted audit findings
and it could never follow the copy. A failed walk that deferred a move
now marks the inventory incomplete, as an unreadable source link does;
a failed walk with no move candidate keeps the old behavior.
Also correct InstallFromConfig's comments, which still said reconcile
runs only after an install.
* fix(install): move a moved skill's gitignore rule in project mode
Project reconcile added the managed ignore rule for a moved skill's new
path but left the old one, and the gitignore update only ever adds. If
the old path later held source-controlled files, Git kept ignoring them
without a word. Reconcile now reports the paths records moved away from,
and project reconcile removes their managed rules before adding the new.
* test(config): skip the unreadable-directory reconcile test on Windows
Windows does not stop reading a directory created with mode 0, and
os.Geteuid reports -1 there, so the root-only skip let the test run and
fail on the Windows runner.
* fix(install): count a candidate that cannot be hashed as an incomplete search
MovedEntryKey dropped a same-name candidate whose files could not be
hashed, so a readable identical copy beside it looked unique and could
take the record. It now returns the hash error, and reconcile and the
install-from-config search treat it like a walk error: no move is
inferred from that scan, and reconcile keeps the record waiting.
AgentKind.Discover and the skill detail file listing skipped every
hidden directory, including the walk root itself. The `!= "."` guard in
agent.go never fires because walkRoot is an absolute resolved path, so a
sources.agents directory such as ~/.agents discovered zero agents.
Exempt the walk root (`path != walkRoot`), matching the other walks in
the repo. Nested hidden directories are still skipped.
Related to #511 (same class as #514).
SkipTargetDotDir only exempted dotdirs directly under the walk root, never
the root itself. ProjectTargetDotDirs() always contains ".skillshare", so a
source whose basename is a target dotdir (".skillshare", ".claude", ...) had
its first Walk callback return SkipDir. Discovery then saw an empty source:
`skillshare list` returned [] and sync pruned previously managed links.
Exempt path == walkRoot in the shared helper so both callers
(sync discovery and resource skill discovery) are fixed. Nested target
dotdirs are still skipped and first-level ones stay visible.
Fixes#511
Install records live in one .metadata.json keyed by skill path, so moving
an installed skill with mv leaves its record at the old path and the moved
copy loses its source link. Keep mv for self-created skills and document
uninstall + install --into for installed ones.
Refs: #510
Invalidate instruction queries when targets change or config.yaml is saved so AGENTS.md target lists and instruction paths do not remain cached until reload or expiry.
#508 made --track --force clone first and replace the existing tracked repo
only after the clone succeeds, and refuse a local source (path or file://
URL) that is, or lies inside, that tracked repo. Users relying on --force to
recover a broken repo need to know the old one is kept on failure, and why a
source under the destination is rejected.