912 Commits
Author SHA1 Message Date
Willie 6a94c69e47 docs: update docs and changelog for v0.17.1
Add documentation for new features (UI theme system, init --subdir),
bug fixes (collect .git skip, actionable git errors), and release notes.
Update CHANGELOG.md, website changelog, and 6 doc pages.
v0.17.1
2026-03-13 14:09:40 +08:00
Willie 894b1b3793 fix(init): improve subdir prompt with TTY check, --subdir flag, and ui helpers
Follow-up to #78. Adding:
- TTY guard so the prompt is skipped in non-interactive/CI environments
- --subdir CLI flag for scriptable usage
- Consistent use of bufio.Reader (no mixed fmt.Scanln)
- ui.Info / ui.Success for prompt output aligned with other init steps
2026-03-13 14:02:26 +08:00
Willie 767ad31ec3 fix(collect): skip .git directories when pulling nested skills to source
copyDirectoryWithState did not skip .git/ dirs, causing collect to fail
on git-cloned repos (e.g. obra/superpowers) — filepath.Walk would abort
on .git pack files, leaving only empty directories in source.

Add copyDirectorySkipGit() variant and use it in PullSkill. Existing
copyDirectory (used by copy-mode sync) is unchanged.
2026-03-13 13:37:12 +08:00
Willie 9d837e943f fix(devcontainer): fix project mode UI and port cleanup
Two issues fixed:

1. Air's full_bin does not run through sh -c, so the previous
   "cd ... && /workspace/..." in SKILLSHARE_UI_EXEC_PREFIX was
   silently failing (cd exits 0, binary never runs). Replace with
   a wrapper script that does cd + exec.

2. Port cleanup relied on fuser which is missing in containers.
   Add pids_on_port() that reads /proc/net/tcp6 to find socket
   inodes and maps them back to PIDs. Three-layer cleanup:
   PID file → pkill pattern → port-level kill.

Also improve error messages: show the stuck PIDs and fix command
instead of the unhelpful "slow start" message.
2026-03-13 11:48:04 +08:00
Willie 0a3305f617 fix(update): capture git stderr and show actionable error messages
The update handler used internal/git which ran git commands without
capturing stderr, so failures like divergent branches only showed
"exit status 128". Now runGitWithProgress captures stderr and pipes
it through install.WrapGitError for meaningful messages.

Also adds:
- extractGitFatal() strips verbose hint: lines from git output
- Force checkbox and per-item Force retry button in Update UI
- "(try force update)" / "(try --force)" hint on pull failures
2026-03-13 09:45:56 +08:00
Willie c16dc22af6 fix(install): show actionable error messages when git stderr is empty
When git commands fail with an empty stderr (common in --progress mode),
wrapGitError() was returning the raw exec.ExitError which only produces
"exit status 128" — giving users no clue about the actual problem.

Now extracts the exit code and maps it to actionable messages:
- exit 128: "repository not found or authentication required"
- exit 128 + token: "authentication token was rejected"
- exit 1: "check network connectivity and repository URL"
2026-03-13 09:45:56 +08:00
Willie 7c4aa7bc5a feat(init): add subdirectory prompt for source path (#78)
Implemented Subdirectory Specification for Source
2026-03-13 09:44:47 +08:00
Daylam Tayari 4a8814ffcf Switched dir name reading to bufio for space sup 2026-03-12 13:15:15 -05:00
Daylam Tayari 06dae1c34f Added new line for spacing in prompts 2026-03-12 12:53:17 -05:00
Daylam Tayari 4fc7b4b885 Implemented source subdir specification 2026-03-12 12:46:37 -05:00
Willie 6fb99035af feat(ui): add multi-theme system with Playful (hand-drawn) style
Add a two-dimensional theme system: Style (Clean/Playful) × Mode (Light/Dark/System).

Theme infrastructure:
- ThemeContext with style + mode state, matchMedia listener, localStorage persistence
- ThemePopover in sidebar for switching style and mode
- FOUC prevention via inline script in index.html
- CSS custom properties for radius, shadows, fonts (resolved per theme)
- design.ts migrated to CSS variable refs

Playful theme features:
- Wobbly border-radius on cards, buttons, badges, inputs, dialogs
- Hard offset shadows (no blur) for sketch aesthetic
- Caveat handwritten font for headings, DM Sans for body text
- Dotted paper texture background
- Skill cards as pastel sticky notes with masking tape strips
- Wavy underlines on links
- Dashed sidebar border with Caveat section headers
- Per-card wobble variety (6 unique border-radius patterns)

Component enhancements:
- ss-* CSS class hooks on all themed components for CSS-only overrides
- SegmentedControl: aria-pressed for theme targeting, clean defaults
- SkillDetailSkeleton: custom loading skeleton matching detail page layout
- Dashboard Quick Action cards: hover animations (pulse/bounce)
- AuditPage: fix tour step targeting

Clean theme unchanged — all Playful styles scoped under [data-theme="playful"].
2026-03-12 23:23:28 +08:00
Daylam Tayari e23bea133f Switched existing usage of cmd.Output to cmd.Run 2026-03-12 23:22:35 +08:00
Daylam Tayari c08ed7f96c Switched git repo check to git rev-parse 2026-03-12 23:22:35 +08:00
Daylam Tayari 156e428baf Updated git initialization check in doctor cmd 2026-03-12 23:22:35 +08:00
Daylam Tayari f8ce3387d3 Integrated checkGitRepo in pull cmd 2026-03-12 23:22:35 +08:00
Daylam Tayari 57419a51b8 Updated checkGitRepo to use git status
Using git status as it will handle nested directories and git commands
are ultimately what is used throughout the code
2026-03-12 23:22:35 +08:00
Willie 43a64872ab fix(test): enable per-runbook isolation in mdproof config
Use mdproof v0.0.5 per-runbook isolation to give each runbook its own
HOME and TMPDIR, eliminating inter-runbook state leakage that caused
4 of 22 runbooks to fail when run sequentially.

Key changes:
- Add ensure-skillshare-linux-binary.sh to build step (creates ss symlink)
- Use direct binary path in setup/teardown (bypass wrapper overhead)
- Create target dirs (~/.claude, ~/.codex) so --all-targets detects them
- Clean shared /tmp/ paths between runbooks
v0.17.0
2026-03-12 16:45:02 +08:00
Willie 405a2f907a feat(extras): add mode command for CLI, TUI, and Web UI
Add ability to change sync mode of an extra's target across all three
interfaces: CLI (`extras mode`/shorthand `extras <name> --mode`),
TUI (`M` key with mode picker overlay), and Web UI (inline Select
dropdown per target with PATCH /api/extras/{name}/mode endpoint).

Fix sync behavior so symlinks from a previous mode are auto-replaced
without --force, while regular files still require explicit --force.

Consolidate sync mode list into config.ExtraSyncModes single source
of truth. Fix Select component missing disabled prop and add viewport
collision detection with useLayoutEffect.

Includes 8 integration tests covering mode command happy path, error
cases, shorthand syntax, and mode-switch sync behavior.
2026-03-12 16:45:02 +08:00
Willie 5b224a1f87 fix(extras): remove unused width params, load fresh config in doRemove
Address code review findings:
- Remove unused width parameter from renderExtrasDetail and
  renderExtrasContentPanelStr to eliminate dead code
- Load fresh config in doRemove to avoid mutating the TUI model's
  config copy in a background goroutine (prevents potential data race)
2026-03-12 16:45:02 +08:00
Willie a8e2f9c57c docs(extras): document interactive TUI and --no-tui flag for extras list 2026-03-12 16:45:02 +08:00
Willie 9b0146ab77 fix(extras): resolve lint warnings in extras list TUI
Replace WriteString(fmt.Sprintf(...)) with fmt.Fprintf for QF1012,
and use min/max builtins for tree scroll clamping.
2026-03-12 16:45:02 +08:00
Willie 947a5d33b3 feat(extras): add interactive TUI for extras list with browse, remove, sync, collect, and content viewer 2026-03-12 16:45:02 +08:00
Willie 2a9ddb0cf6 feat(extras): add TUI list item and delegate for extras list 2026-03-12 16:45:02 +08:00
Willie 4526b5a493 refactor(extras): extract buildExtrasListEntries for TUI reuse 2026-03-12 16:45:02 +08:00
Willie 9738e5238e refactor(extras): extract remove helpers for TUI reuse 2026-03-12 16:45:02 +08:00
Willie ee38d34513 refactor(diff): show extras by default, remove --extras/--all flags
Extras diff is now automatically included when extras are configured.
No need for explicit --extras or --all flags — simpler UX.

- Remove showExtras/showAll from diffRenderOpts
- Replace flag check with len(cfg.Extras) > 0
- Update integration test, built-in skill refs, website docs, changelog
2026-03-12 16:45:02 +08:00
Willie d756004e56 feat(extras): add extras reference docs, fix diff project mode, improve TUI
- Add references/extras.md covering all 4 subcommands (init, list,
  remove, collect) plus sync extras and diff --extras
- Update SKILL.md with dedicated Extras recipes section and reference link
- Update status.md with diff --extras/--all flags
- Fix sync.md: extras supports project mode (not global only), correct
  source path to include extras/ subdirectory
- Fix diff --extras not working in project mode (diff_project.go was
  missing collectExtrasDiff integration)
- Replace DefaultDelegate with custom diffItemDelegate so Extras
  separator renders as non-selectable group header (matching list TUI)
- Add skipDiffSeparator to prevent cursor landing on separator items
- Add Next Steps hints to extras detail panel in diff TUI
- Group Backup/Trash under "Storage" header in doctor output
- Remove extra leading spaces from doctor extras status lines
2026-03-12 16:45:02 +08:00
Willie cc93c4f0a4 fix(extras): add y/N confirm prompt to remove, clean up empty dirs
- extras remove: replace silent-exit warning with interactive [y/N]
  prompt; --force skips the prompt as before
- extras remove: after removing config entry, delete the source
  directory if empty and the parent extras/ directory if empty
- sync extras: clean up empty extras/ directory when no extras are
  configured (both global and project mode)
- Add removeEmptyDir helper and ExtrasParentDirProject path function
2026-03-12 16:45:02 +08:00
Willie 7a6e78783b fix(build): separate host and devcontainer binary output paths
Devcontainer `make build` previously wrote a Linux binary to
`bin/skillshare` via the shared volume mount, overwriting the host's
macOS binary and causing `exec format error`.

Introduce a `BINARY` variable (Makefile) / `SKILLSHARE_BINARY` env var
(mise) so devcontainer builds to `/usr/local/bin/skillshare` while the
host keeps `bin/skillshare`. Also update `scripts/test.sh` to respect
a pre-set `SKILLSHARE_TEST_BINARY` instead of unconditionally
overwriting it.
2026-03-12 16:45:02 +08:00
Willie 48f1d3767f fix(test): improve extras runbooks with jq assertions, idempotency, and init cleanup
- Replace python3 JSON parsing with native mdproof jq: assertions across
  extras_refactor_json_runbook (7 steps simplified)
- Add cat>> idempotency guards (sed -i cleanup) before YAML appends
- Add ssenv --init default extras cleanup in Step 1 of extras_commands
  and sync_extras runbooks to prevent false failures
- Rename runbook.json → mdproof.json (mdproof only reads mdproof.json)
- Move /tmp cleanup from step_setup to setup (per-runbook, not per-step)
  to avoid breaking cross-step dependencies
- Fix ensure-mdproof.sh to upgrade dev binary to latest release
- Add .mdproof/lessons-learned.md with 5 documented gotchas
- Update cli-e2e-test SKILL.md with assertion types, jq best practices,
  --init extras checklist item, and /mdproof skill collaboration
2026-03-12 16:45:02 +08:00
Willie 09ccd14266 fix(extras): resolve tilde expansion, unify headers, add doctor target warnings
Extras commands had multiple issues with tilde (~) path handling — Go
doesn't expand ~ (that's shell behavior), so paths like ~/.claude/rules
were treated as literal relative paths, creating bogus ~/  directories.

Key fixes:
- Export config.ExpandPath() and call it before os.Stat / sync operations
  in extras_list, sync_extras, extras_collect, and doctor
- Unify extras output headers to match target list style (single "Extras"
  header instead of per-extra headers, fix double-icon bug in list)
- Add per-target reachability warning in doctor for unreachable extras
  targets with expanded path display

Update all 3 E2E runbooks to use extras/<name>/ path layout, add /tmp
cleanup for idempotent re-runs, add migration test step, and create new
comprehensive extras_commands_runbook (18 steps covering init/list/remove/
collect/doctor/tilde/project-mode).

Improve cli-e2e-test skill with 4 new checklist items and 2 rules learned
from test friction (/tmp isolation, symlink write-through, cat>>
idempotency, extras path layout).
2026-03-12 16:45:02 +08:00
Willie 28d35e8a77 fix(ui): align CopyButton to design system, fix sidebar scroll, update lockfile
- CopyButton: add focus ring, active:scale-95, remove unused style prop
- FileViewerModal: use IconButton for close, Spinner for loading state
- SkillDetailPage: fix sticky sidebar not scrollable when content overflows viewport
- Update pnpm-lock.yaml for test dependencies added by PR #76
- Add salmonumbrella and daylamtayari to README contributors
2026-03-12 16:45:02 +08:00
Willie 990b4dc160 feat(extras): add TUI wizard for extras init, improve status display
Wire up the existing extras init TUI wizard so `extras init` without
arguments launches the interactive 5-phase flow. Add --no-tui flag for
scripting. Guard against silently swallowing --mode when launching TUI.

Redesign extras status output to match Targets section style using
ui.Status with per-target rows showing [mode] path (N files). Extract
shared printExtrasStatus helper to eliminate duplication between global
and project status. Add (project) label to project-mode header.

Clean up: delete duplicate extrasEffectiveMode in favor of
sync.EffectiveMode, remove redundant os.Stat TOCTOU in doctor.go
checkExtras, handle zero-targets edge case with a warning.
2026-03-12 16:45:02 +08:00
Willie 4e3b55a303 docs: update README latest version note to v0.17.0 2026-03-12 16:45:02 +08:00
Willie 04c669e0ba feat(website): clean design system for docs pages and add mdproof blog post
Redesign docs/non-homepage pages to match the ui/ dashboard's clean
aesthetic (solid borders, subtle blur shadows, clean border-radius)
while preserving the homepage's hand-drawn style via CSS modules.
Add blog post announcing skillshare's full migration to mdproof for
E2E testing.
2026-03-12 16:45:02 +08:00
Willie 9501b59874 docs: update v0.17.0 changelog with UI redesign and additional bug fixes
Add Web UI redesign section (clean design, table view, keyboard shortcuts,
onboarding tour) and two missing bug fixes (dotdir skipping during install
discovery, sync collision message). Sync website changelog from v0.16.15
to v0.17.0 entry. Update release notes with matching content.
2026-03-12 16:45:02 +08:00
Willie 91d22fbaf5 docs: fix extras source paths and remove incorrect global-only claims
Extras source dir is under extras/ subdirectory (~/.config/skillshare/extras/<name>/),
not directly under the config root. Also, sync extras and the extras config field
both support project mode — removed incorrect "global only" admonitions.

- extras.md: fix source path references and example output
- sync.md: replace global-only admonition, fix directory structure diagram
- configuration.md: fix source path, add extras/ to overview tree
- index.md: add Extras Management category with extras command
2026-03-12 16:45:02 +08:00
Willie be4c693df5 feat(ui): add step-by-step onboarding tour with spotlight overlay
Self-built tour engine: TourProvider (context + state machine),
TourOverlay (spotlight cutout via box-shadow), TourTooltip (positioned
bubble with arrow, progress dots, mobile bottom sheet).

14 steps covering all sidebar sections. Auto-adjusts for project mode
(skips Git Sync) and empty state (no skills). Keyboard accessible
(Escape/Arrow/Enter). Triggered via sidebar Quick Tour button.
2026-03-12 16:45:02 +08:00
Willie 3981bda6d1 feat(ui): add table view to SearchPage, fix Audit loading and alignment
- SearchPage: add card/table view toggle with pagination, sticky toolbar,
  and localStorage persistence for view preference
- AuditPage: replace generic PageSkeleton with StreamProgressBar for
  seamless loading-to-progress transition
- AuditPage: fix triage panel help text alignment with selector input
  by matching py-1.5 padding
- SkillsPage: add sticky thead and scrollable table body
- Change tag badges from accent to info variant
2026-03-12 16:45:02 +08:00
Willie bac2bc292f fix(ui): align GitSync, Search, Backup, Trash, AuditRules to design system
- GitSyncPage: space-y-5, animate-fade-in, PageHeader in loading/error states,
  Button loading prop replacing manual Spinner, remove Spinner import
- SearchPage: Card overflow prop, remove redundant disabled on loading buttons,
  hide icons during loading state
- BackupPage: space-y-5, actions into PageHeader, summary as inline text,
  remove unused isNewest/index props, add Refresh button, fix hook ordering
- TrashPage: space-y-5, actions into PageHeader, summary as inline text,
  remove unused index prop, add Refresh button
- AuditRulesPage: border-2 → border on accordion, fix sticky header shadow
  thickness, restructure sticky group to include controls bar
2026-03-12 16:45:02 +08:00
Willie d3b9890028 fix(ui): align pages to design system — loading props, spacing, borders, click-to-toggle
- SyncPage/CollectPage/UpdatePage: root container space-y-5, remove manual margins
- Replace manual Spinner with Button loading prop across Sync, Collect, Update pages
- Fix double-toggle bug: wrap Checkbox in stopPropagation span for row click-to-toggle
- CollectPage: native checkbox → Checkbox component, border-2 → border on skill rows
- SyncPage: separator border-muted-dark → border-pencil-light/30, DiffItemRow index key → composite key
- UpdatePage: Card rotation → tilt prop, border-pencil/10 → border-muted, EmptyState for up-to-date
- UpdatePage: remove dead UpdatePageHeader component, Spinner import, outlined Card summary
- InstallForm: restructure layout with grouped sections and dashed separators
- HubManagerModal/SkillPickerModal/SearchPage/InstallPage/AuditRulesPage: minor design token alignment
2026-03-12 16:45:02 +08:00
Willie 095d076bc1 fix(ui): remove all left-border stripes, fix modifier HUD bug, refine components
Replace left-border colored stripes with severity dots across all pages
(AuditPage, AuditRulesPage, InstallForm, GitSyncPage, SkillsPage) and
components (Card accent variant, ConfirmDialog, Select). Card accent now
uses a thicker border instead of a left stripe.

Fix Cmd+S modifier HUD staying visible by resetting state immediately
after shortcut fires and adding a 2-second auto-dismiss safety timer.

Additional refinements: extract Checkbox/Select/Spinner/Tooltip into
standalone components, update Button link variant to pencil colors,
replace SkillsPage FilterChips with SegmentedControl connected, and
update style guide to mark left-border stripes as an anti-pattern.
2026-03-12 16:45:02 +08:00
Willie bb6b3f56d2 fix(ui): replace useEffect with render-time state adjustment in SkillsTable
Removes the anti-pattern of calling setState synchronously inside
useEffect to reset pagination when skills list changes. Uses React's
recommended "adjusting state during rendering" pattern instead, which
avoids cascading re-renders.
2026-03-12 16:45:02 +08:00
Willie 7ade470557 refactor(ui): rename oMLX references to skillshare-inspired
Remove external brand references from code comments, design tokens,
and style guide. The design philosophy is our own.
2026-03-12 16:45:02 +08:00
Willie acfbabd1b2 feat(skills): add ui-website-style skill with design system reference
Consolidate the UI dashboard and website design system guidance into a
dedicated skill. Moves STYLE_GUIDE.md from ui/ into the skill's
references/ directory so it lives alongside the actionable SKILL.md
that Claude uses for component selection, token usage, and page
structure decisions.
2026-03-12 16:45:02 +08:00
Willie cb8b5b530a feat(ui): add modifier keyboard shortcuts, HUD overlay, and sync progress animation
- Add Cmd/Ctrl+S shortcut to navigate to Sync page (cross-platform)
- Show floating HUD bar when holding Cmd/Ctrl to reveal modifier shortcuts
- Add indeterminate shimmer progress bar during sync operations
- Animate SVG pipeline dashed lines with flow effect while syncing
- Update KeyboardShortcutsModal to render modifier key combos (⌘/Ctrl)
- Add ScrollToTop button for long-scrolling pages
- Migrate page styles to use shared design tokens (radius, shadows)
2026-03-12 16:45:02 +08:00
Willie b4288ac7b1 fix(ui): redesign sidebar bottom bar with nav-consistent style
Replace horizontal icon+text buttons with vertical layout matching
the nav item style (icon + label, same padding/gap). Add keyboard
shortcuts toggle button and global shortcut hook integration.
2026-03-12 16:45:02 +08:00
Willie 99335ccf56 feat(ui): add sticky group headers in SkillsPage grouped view
Replace Virtuoso with GroupedVirtuoso for the grouped view so that
directory sub-headers stick below the toolbar while scrolling.
GroupedVirtuoso's TopItemList component is customized with the
measured toolbar height offset to position headers correctly.
2026-03-12 16:45:02 +08:00
Willie 314d6a3dff fix(sync): show duplicate skill names in collision message, fix vertical spacing
Display the actual duplicate skill name(s) in the "isolated by target
filters" info message so users can identify which skills collide.

Remove the extra fmt.Println() before backup section — ui.Header()
already includes a leading newline, so the previous blank line created
a double gap.

Also replace VirtualizedGroupedView with native DOM GroupedView using
sticky sub-headers that respect the toolbar height offset.
2026-03-12 16:45:02 +08:00
Willie 5369595bc1 fix(install): skip target dotdirs during skill discovery
Repos like pbakaus/impeccable commit .claude/skills/ alongside their
source skills, causing discoverSkills to find every skill twice (36
instead of 18). Fix by deriving known target dotdir names (.claude,
.cursor, .skillshare, etc.) from targets.yaml project_path values and
skipping them during filepath.Walk.

Non-target hidden dirs (.curated, .system — used by openai/skills) are
still discovered as before. Injection pattern avoids circular import
between config and install packages.
2026-03-12 16:45:02 +08:00