Follow-up to #78. Adding:
- TTY guard so the prompt is skipped in non-interactive/CI environments
- --subdir CLI flag for scriptable usage
- Consistent use of bufio.Reader (no mixed fmt.Scanln)
- ui.Info / ui.Success for prompt output aligned with other init steps
copyDirectoryWithState did not skip .git/ dirs, causing collect to fail
on git-cloned repos (e.g. obra/superpowers) — filepath.Walk would abort
on .git pack files, leaving only empty directories in source.
Add copyDirectorySkipGit() variant and use it in PullSkill. Existing
copyDirectory (used by copy-mode sync) is unchanged.
Two issues fixed:
1. Air's full_bin does not run through sh -c, so the previous
"cd ... && /workspace/..." in SKILLSHARE_UI_EXEC_PREFIX was
silently failing (cd exits 0, binary never runs). Replace with
a wrapper script that does cd + exec.
2. Port cleanup relied on fuser which is missing in containers.
Add pids_on_port() that reads /proc/net/tcp6 to find socket
inodes and maps them back to PIDs. Three-layer cleanup:
PID file → pkill pattern → port-level kill.
Also improve error messages: show the stuck PIDs and fix command
instead of the unhelpful "slow start" message.
The update handler used internal/git which ran git commands without
capturing stderr, so failures like divergent branches only showed
"exit status 128". Now runGitWithProgress captures stderr and pipes
it through install.WrapGitError for meaningful messages.
Also adds:
- extractGitFatal() strips verbose hint: lines from git output
- Force checkbox and per-item Force retry button in Update UI
- "(try force update)" / "(try --force)" hint on pull failures
When git commands fail with an empty stderr (common in --progress mode),
wrapGitError() was returning the raw exec.ExitError which only produces
"exit status 128" — giving users no clue about the actual problem.
Now extracts the exit code and maps it to actionable messages:
- exit 128: "repository not found or authentication required"
- exit 128 + token: "authentication token was rejected"
- exit 1: "check network connectivity and repository URL"
Use mdproof v0.0.5 per-runbook isolation to give each runbook its own
HOME and TMPDIR, eliminating inter-runbook state leakage that caused
4 of 22 runbooks to fail when run sequentially.
Key changes:
- Add ensure-skillshare-linux-binary.sh to build step (creates ss symlink)
- Use direct binary path in setup/teardown (bypass wrapper overhead)
- Create target dirs (~/.claude, ~/.codex) so --all-targets detects them
- Clean shared /tmp/ paths between runbooks
Add ability to change sync mode of an extra's target across all three
interfaces: CLI (`extras mode`/shorthand `extras <name> --mode`),
TUI (`M` key with mode picker overlay), and Web UI (inline Select
dropdown per target with PATCH /api/extras/{name}/mode endpoint).
Fix sync behavior so symlinks from a previous mode are auto-replaced
without --force, while regular files still require explicit --force.
Consolidate sync mode list into config.ExtraSyncModes single source
of truth. Fix Select component missing disabled prop and add viewport
collision detection with useLayoutEffect.
Includes 8 integration tests covering mode command happy path, error
cases, shorthand syntax, and mode-switch sync behavior.
Address code review findings:
- Remove unused width parameter from renderExtrasDetail and
renderExtrasContentPanelStr to eliminate dead code
- Load fresh config in doRemove to avoid mutating the TUI model's
config copy in a background goroutine (prevents potential data race)
Extras diff is now automatically included when extras are configured.
No need for explicit --extras or --all flags — simpler UX.
- Remove showExtras/showAll from diffRenderOpts
- Replace flag check with len(cfg.Extras) > 0
- Update integration test, built-in skill refs, website docs, changelog
- Add references/extras.md covering all 4 subcommands (init, list,
remove, collect) plus sync extras and diff --extras
- Update SKILL.md with dedicated Extras recipes section and reference link
- Update status.md with diff --extras/--all flags
- Fix sync.md: extras supports project mode (not global only), correct
source path to include extras/ subdirectory
- Fix diff --extras not working in project mode (diff_project.go was
missing collectExtrasDiff integration)
- Replace DefaultDelegate with custom diffItemDelegate so Extras
separator renders as non-selectable group header (matching list TUI)
- Add skipDiffSeparator to prevent cursor landing on separator items
- Add Next Steps hints to extras detail panel in diff TUI
- Group Backup/Trash under "Storage" header in doctor output
- Remove extra leading spaces from doctor extras status lines
- extras remove: replace silent-exit warning with interactive [y/N]
prompt; --force skips the prompt as before
- extras remove: after removing config entry, delete the source
directory if empty and the parent extras/ directory if empty
- sync extras: clean up empty extras/ directory when no extras are
configured (both global and project mode)
- Add removeEmptyDir helper and ExtrasParentDirProject path function
Devcontainer `make build` previously wrote a Linux binary to
`bin/skillshare` via the shared volume mount, overwriting the host's
macOS binary and causing `exec format error`.
Introduce a `BINARY` variable (Makefile) / `SKILLSHARE_BINARY` env var
(mise) so devcontainer builds to `/usr/local/bin/skillshare` while the
host keeps `bin/skillshare`. Also update `scripts/test.sh` to respect
a pre-set `SKILLSHARE_TEST_BINARY` instead of unconditionally
overwriting it.
Extras commands had multiple issues with tilde (~) path handling — Go
doesn't expand ~ (that's shell behavior), so paths like ~/.claude/rules
were treated as literal relative paths, creating bogus ~/ directories.
Key fixes:
- Export config.ExpandPath() and call it before os.Stat / sync operations
in extras_list, sync_extras, extras_collect, and doctor
- Unify extras output headers to match target list style (single "Extras"
header instead of per-extra headers, fix double-icon bug in list)
- Add per-target reachability warning in doctor for unreachable extras
targets with expanded path display
Update all 3 E2E runbooks to use extras/<name>/ path layout, add /tmp
cleanup for idempotent re-runs, add migration test step, and create new
comprehensive extras_commands_runbook (18 steps covering init/list/remove/
collect/doctor/tilde/project-mode).
Improve cli-e2e-test skill with 4 new checklist items and 2 rules learned
from test friction (/tmp isolation, symlink write-through, cat>>
idempotency, extras path layout).
- CopyButton: add focus ring, active:scale-95, remove unused style prop
- FileViewerModal: use IconButton for close, Spinner for loading state
- SkillDetailPage: fix sticky sidebar not scrollable when content overflows viewport
- Update pnpm-lock.yaml for test dependencies added by PR #76
- Add salmonumbrella and daylamtayari to README contributors
Wire up the existing extras init TUI wizard so `extras init` without
arguments launches the interactive 5-phase flow. Add --no-tui flag for
scripting. Guard against silently swallowing --mode when launching TUI.
Redesign extras status output to match Targets section style using
ui.Status with per-target rows showing [mode] path (N files). Extract
shared printExtrasStatus helper to eliminate duplication between global
and project status. Add (project) label to project-mode header.
Clean up: delete duplicate extrasEffectiveMode in favor of
sync.EffectiveMode, remove redundant os.Stat TOCTOU in doctor.go
checkExtras, handle zero-targets edge case with a warning.
Redesign docs/non-homepage pages to match the ui/ dashboard's clean
aesthetic (solid borders, subtle blur shadows, clean border-radius)
while preserving the homepage's hand-drawn style via CSS modules.
Add blog post announcing skillshare's full migration to mdproof for
E2E testing.
Extras source dir is under extras/ subdirectory (~/.config/skillshare/extras/<name>/),
not directly under the config root. Also, sync extras and the extras config field
both support project mode — removed incorrect "global only" admonitions.
- extras.md: fix source path references and example output
- sync.md: replace global-only admonition, fix directory structure diagram
- configuration.md: fix source path, add extras/ to overview tree
- index.md: add Extras Management category with extras command
Self-built tour engine: TourProvider (context + state machine),
TourOverlay (spotlight cutout via box-shadow), TourTooltip (positioned
bubble with arrow, progress dots, mobile bottom sheet).
14 steps covering all sidebar sections. Auto-adjusts for project mode
(skips Git Sync) and empty state (no skills). Keyboard accessible
(Escape/Arrow/Enter). Triggered via sidebar Quick Tour button.
- SearchPage: add card/table view toggle with pagination, sticky toolbar,
and localStorage persistence for view preference
- AuditPage: replace generic PageSkeleton with StreamProgressBar for
seamless loading-to-progress transition
- AuditPage: fix triage panel help text alignment with selector input
by matching py-1.5 padding
- SkillsPage: add sticky thead and scrollable table body
- Change tag badges from accent to info variant
Replace left-border colored stripes with severity dots across all pages
(AuditPage, AuditRulesPage, InstallForm, GitSyncPage, SkillsPage) and
components (Card accent variant, ConfirmDialog, Select). Card accent now
uses a thicker border instead of a left stripe.
Fix Cmd+S modifier HUD staying visible by resetting state immediately
after shortcut fires and adding a 2-second auto-dismiss safety timer.
Additional refinements: extract Checkbox/Select/Spinner/Tooltip into
standalone components, update Button link variant to pencil colors,
replace SkillsPage FilterChips with SegmentedControl connected, and
update style guide to mark left-border stripes as an anti-pattern.
Removes the anti-pattern of calling setState synchronously inside
useEffect to reset pagination when skills list changes. Uses React's
recommended "adjusting state during rendering" pattern instead, which
avoids cascading re-renders.
Consolidate the UI dashboard and website design system guidance into a
dedicated skill. Moves STYLE_GUIDE.md from ui/ into the skill's
references/ directory so it lives alongside the actionable SKILL.md
that Claude uses for component selection, token usage, and page
structure decisions.
- Add Cmd/Ctrl+S shortcut to navigate to Sync page (cross-platform)
- Show floating HUD bar when holding Cmd/Ctrl to reveal modifier shortcuts
- Add indeterminate shimmer progress bar during sync operations
- Animate SVG pipeline dashed lines with flow effect while syncing
- Update KeyboardShortcutsModal to render modifier key combos (⌘/Ctrl)
- Add ScrollToTop button for long-scrolling pages
- Migrate page styles to use shared design tokens (radius, shadows)
Replace horizontal icon+text buttons with vertical layout matching
the nav item style (icon + label, same padding/gap). Add keyboard
shortcuts toggle button and global shortcut hook integration.
Replace Virtuoso with GroupedVirtuoso for the grouped view so that
directory sub-headers stick below the toolbar while scrolling.
GroupedVirtuoso's TopItemList component is customized with the
measured toolbar height offset to position headers correctly.
Display the actual duplicate skill name(s) in the "isolated by target
filters" info message so users can identify which skills collide.
Remove the extra fmt.Println() before backup section — ui.Header()
already includes a leading newline, so the previous blank line created
a double gap.
Also replace VirtualizedGroupedView with native DOM GroupedView using
sticky sub-headers that respect the toolbar height offset.
Repos like pbakaus/impeccable commit .claude/skills/ alongside their
source skills, causing discoverSkills to find every skill twice (36
instead of 18). Fix by deriving known target dotdir names (.claude,
.cursor, .skillshare, etc.) from targets.yaml project_path values and
skipping them during filepath.Walk.
Non-target hidden dirs (.curated, .system — used by openai/skills) are
still discovered as before. Injection pattern avoids circular import
between config and install packages.