- Add -j short flag to wants_machine_output() in devcontainer wrapper,
preventing stderr banner noise for `skillshare list -j` etc.
- Show tracked repo name badge on skill items so filtered results remain
distinguishable when group headers are absent. Two tracked skills from
different repos now render with their repo origin visible.
Support key:value tag syntax in the `/` filter input for precise
skill filtering by type, group directory, and repo name:
t:tracked g:security audit
→ type=tracked AND group contains "security" AND free text "audit"
Tags: t:/type: (tracked/remote/local/github), g:/group: (substring),
r:/repo: (substring). Multiple tags use AND logic. Unknown tags
gracefully degrade to free text. Optional `_` prefix on type values
(e.g. t:_tracked) and short alias t:track are accepted.
Filter input placeholder and help line update to show available tags
when filtering mode is active.
- Skip group separator lines when all items belong to one group
- Fix row truncation: use ANSI-aware xansi.Truncate instead of
stripping ANSI codes then counting runes (lost color + wrong width)
- Account for bodyStyle padding when calculating text truncation width
- Add MaxWidth to prevent lipgloss from wrapping long rows
- Add repo-grouped layout with separator lines (matching list TUI)
- Use custom auditDelegate with compact single-line rows and truncation
- Sort by repo key (tracked first) then severity within each group
- Widen left panel from 25%/[25,45] to 36%/[30,46] to prevent wrapping
- Dynamically calculate panel height based on actual footer line count
instead of hardcoded overhead, maximizing list space
- Auto-skip group separator items on navigation
The audit summary used 10+ distinct colors on a single screen,
making it hard to focus on actionable information.
Changes:
- Threats line: remove per-category rainbow colors (8 colors → dim/bold)
- Severity c/h/m/l/i: zero values now gray, only non-zero get color
- Policy line: dim metadata (only STRICT/LEGACY get warning yellow)
- Passed count: no longer green (normal state needs no emphasis)
- Remove unused categoryStyle() and categoryColorCLI() functions
Design principle: quiet gray baseline with color only for items
that require user attention (failed count, aggregate risk).
- Add group separators: tracked repos and standalone skills are visually
grouped with dim header lines showing repo name and count
- Compact skill paths: strip tracked repo prefix, show at most last 2
path segments in list rows (full path in detail panel)
- Auto-skip group headers on navigation (up/down/page)
- Replace split Source/Sync sections with unified Details section,
removing duplicate info already shown in header
- Narrow left panel ratio (42% → 36%) for more detail space
- Separator "/" without spaces for tighter list rows
- Rename local group to "standalone" to avoid confusion with local badge
- Adjust renderFactRow label width (9 → 12) for longer labels
- Bold skill name in header for better distinction from list items
- Add spacing between name and metadata line
- Show full source URL instead of truncating at 50 chars
- Rename "Overview" section to "Description" to match frontmatter field
The detail panel header was rendered on L00 (same row as the list title),
making the skill name invisible. Push content to L01 with a leading newline
and use colorSkillPath for consistent group/name coloring matching the left
panel. Compress status/date/targets into a single metadata line to save
vertical space. Show full source URL and synced targets in Quick Facts.
Also suppress devcontainer stderr redirect message in --json/--format modes
and fix audit summary field name (analyzerCount → activeAnalyzers).
Keep sync dry-run diagnostics on stdout by default to avoid non-JSON behavior regressions. Introduce sync.DiagOutput so JSON mode can silence diagnostics via io.Discard at command entry and restore after execution. Update search JSON integration assertion to match fully silent progress behavior.
JSON mode stdout was already pure JSON, but stderr still emitted
progress lines (e.g. "Discovering skills...", "Found N local skill(s)")
which broke `2>&1 | jq .` pipelines. Remove the else-branch stderr
writes so --json mode is fully silent except for stdout JSON output.
Extract buildTrackedRepoJSON() that runs git.IsDirty concurrently via
goroutines + WaitGroup instead of sequential subprocess spawns per repo.
Also deduplicates the tracked-repo JSON loop between global and project
status paths, and optimizes skill counting to a single pass with a map.
- Extract writeJSONResult() to replace 5 identical write+silent-error trailers
- Replace local isRepoDirty() with existing git.IsDirty() (8 call sites)
- Use defer for suppressUIToDevnull restore instead of manual calls at each
return site in install.go and update.go (prevents stdout leak on new paths)
- Fix ResolvePolicy always filling EnabledAnalyzers, which broke the
nil-means-all contract for ForPolicy; add EffectiveAnalyzers() for display
- Simplify collectOutputJSON double map allocation
- Remove unnecessary string conversion in writeJSONError
collect --json and sync --json returned the raw error after writing
JSON, causing main() to print a duplicate plain-text error. Wrap with
jsonSilentError so main() exits non-zero silently.
Also fix sync --json skipping backup output that would corrupt stdout.
updateTrackedRepo and updateRegularSkill now return (updateResult, error)
instead of just error, so callers (including project mode and JSON output)
can accurately report updated/skipped/securityFailed/pruned counts.
Adapt cmdUpdateProject, cmdUpdateProjectBatch, updateAllProjectSkills,
and list_project.go TUI action to the new signatures.
When no explicit analyzer filter was configured, status --json reported
an empty analyzers array. Now ResolvePolicy backfills the full list of
built-in analyzer IDs so the JSON output reflects what actually runs.
Add Registry.IDs() helper with deduplication (markdownLinkAnalyzer and
staticAnalyzer share the "static" ID).
suppressUIToStderr was redirecting UI to stderr, but in environments
where stdout and stderr share the same terminal (e.g. docker exec),
all the spinner/progress/header output was still visible alongside
the JSON. Replace with suppressUIToDevnull which opens os.DevNull
for both os.Stdout and ui.ProgressWriter, producing zero visible
noise in --json mode.
Also add status --json support for project mode, reusing the same
JSON schema as global mode (source, skill_count, tracked_repos,
targets, audit, version).
install --json: logo, spinners, and step output leaked to stdout,
corrupting machine-parseable JSON. Add suppressUIToStderr() around the
entire install flow, restoring stdout before writing JSON.
diff --project --json: spinner and progress display polluted stdout.
Skip spinner and progress creation in JSON mode, matching the existing
cmdDiffGlobal pattern.
uninstall --json: five error paths (discovery failure, no skills found,
glob detection, validation, preflight) returned plain-text errors instead
of JSON error envelopes. Wrap each with writeJSONError().
Add 8 integration tests (5 new failure cases + 3 confirming existing
behavior) with an assertPureJSON helper that validates stdout contains
only valid JSON with no leading/trailing noise.
The --json addition accidentally removed the guard that rejects
unexpected positional arguments in project mode. Restore it so
`skillshare status --project foo` correctly returns an error
instead of silently ignoring the extra argument.
writeJSONError now returns a jsonSilentError sentinel that main()
recognises — it exits with code 1 without printing plain-text output
to stdout. This fixes a regression where --json errors (config load
failure, missing source dir, discovery failure) returned exit 0.
All writeJSONError call sites changed from the broken pattern:
writeJSONError(err); return nil // exit 0, wrong
to:
return writeJSONError(err) // exit 1, correct
Also applied the same fix to update.go error paths which had the
older pattern of writeJSONError(err) followed by return err (which
would print both JSON and plain text).
Added regression tests for sync and install error paths verifying
both non-zero exit code and valid JSON error output on stdout.
Address code review feedback from PR #67:
- Move all dry-run diagnostic messages (internal/sync) from stdout to
stderr so they don't pollute JSON output
- Suppress UI output (spinners, headers, warnings) in uninstall --json
mode by adding jsonOutput guards across all phases
- Return nil after writeJSONError to prevent dual output (JSON + plain
text error) in install and sync commands
- Handle json.MarshalIndent error in writeJSONError with stderr fallback
- Merge duplicated discovery logic (JSON vs non-JSON branches) in sync,
sync_project, diff, and collect using nullable spinner pattern
- Remove checkRepoDirty alias in status.go, call isRepoDirty directly
- Remove extractJSON test workaround — tests now assert stdout is valid
JSON directly, enforcing the clean-stdout contract
Structured JSON output for 8 commands (sync, install, update,
uninstall, collect, target list, status, diff), bringing total
--json coverage to all 12 major CLI commands.
Runbooks can now leverage structured JSON output for verification
instead of brittle text matching. Adds --json quick reference table
(12 commands), jq assertion patterns, and updated checklist/templates.
- Replace hasFlag loop with slices.Contains (stdlib)
- Deduplicate checkRepoDirty → delegate to isRepoDirty
- Add nil-receiver guard to diffProgress.stop() for consistency
- Return explicit error for status --json in project mode
- Use consistent error message in sync --json source-not-found path
Detect inline API keys, tokens, and passwords in skill files via 10 new
hardcoded-secret-* rules (HIGH severity): Google API keys, AWS access
keys, GitHub PATs (classic + fine-grained), Slack tokens, OpenAI keys,
Anthropic keys, Stripe keys, PEM private key blocks, and generic
api_key/password assignments.
Closes a gap where GitHub Secret Scanning caught a Google API key in a
skill file but our audit engine missed it entirely.
AuditPage: use Virtuoso with useWindowScroll for skill audit cards.
SyncPage: use Virtuoso with fixed-height container for diff items
(100+ threshold), flat render for small lists.
Replace sequential POST loops and blocking useQuery calls with
Server-Sent Events for real-time progress feedback on Update, Check,
and Diff operations. Extract shared helpers to reduce duplication:
- initSSE() in middleware.go consolidates SSE preamble across 4 handlers
- createSSEStream() in client.ts unifies EventSource lifecycle management
- StreamProgressBar component replaces 3 near-identical progress bars
- handleDiff now delegates to computeTargetDiff (eliminates ~150 lines)
- Paginate audit results (20 cards + 10 findings per card) to prevent
DOM overload with large skill counts
Improve all 5 active skills with pushy descriptions for better
triggering accuracy, following devcontainer as the gold standard.
- changelog: add trigger scenarios (release notes, version prep)
- cli-e2e-test: add trigger scenarios (runbook, E2E validation)
- codebase-audit: add 3 new audit dimensions (handler split, oplog
coverage, web API consistency) and trigger scenarios
- implement-feature: add project patterns reference (handler split,
dual-mode, TUI, web API, oplog) and trigger scenarios
- update-docs: expand scope to all 7 doc categories with code-to-doc
mapping guide and trigger scenarios
Also remove empty .skillshare/skills/frontend/ directory.
Detect local drift (modified/missing/added files) in installed skills
by comparing current SHA-256 hashes against stored .skillshare-meta.json
records. Skills without metadata are flagged as unverifiable warnings.
Add metadataAnalyzer (skill scope) that cross-references SKILL.md
metadata against the actual git source from .skillshare-meta.json:
- publisher-mismatch (HIGH): description claims an org but repo owner
differs (e.g. "from Acme Corp" but sourced from evil-fork)
- authority-language (MEDIUM): uses "official"/"verified" language but
source is not a well-known organization
Both rules are disable-able via audit-rules.yaml. The analyzer reads
meta from disk (zero API signature changes) and avoids import cycles
by defining its own minimal metaJSON struct.
When git operations fail due to SSL certificate issues (self-signed certs,
internal CAs), the error message now suggests GIT_SSL_CAINFO, GIT_SSL_NO_VERIFY,
and SSH as alternatives instead of showing raw git stderr.
Env vars like GIT_SSL_CAINFO are already inherited via os.Environ() in
gitCommand() — the actual gap was error detection and user guidance.
Add server-sent events endpoint for audit scans so the web UI can
display per-skill progress instead of waiting for the full batch.
Backend:
- Extract discoverAuditSkills and processAuditResults from handler
- Add handler_audit_stream.go with SSE streaming endpoint
- Register GET /api/audit/stream route with read-lock middleware
- Add CORS headers for SSE connections in middleware
Frontend:
- Add AuditStreamPanel and AuditResultCard components
- Wire streaming audit into AuditPage with start/stop controls
- Add useAuditStream hook and streamAudit API client method
- Add per-skill audit action on SkillDetailPage
- Add check-based update detection on UpdatePage
- Configure Vite proxy for SSE endpoint
Replace bordered boxes around Source/Sync sections with simple
title + indented rows. Reserves brand yellow solely for selected
item indicator, reducing visual noise in the detail panel.
Add CHANGELOG and website changelog entries for v0.16.10 covering
sync extras and tui toggle features. Create dedicated tui command
reference page and register it in sidebar and commands index.
Bump built-in skill version to v0.16.10.
- Add contentEqual() byte comparison for copy-mode idempotency check:
re-running sync extras no longer marks identical copies as conflicts
- Restore mode default in CLI handler so display shows "(merge)"
instead of "()" for targets with no explicit mode
- Fix bug: pass `rest` (not `args`) to cmdSyncExtras in --all path
- Return error from cmdSyncExtras when totalErrors > 0
- Remove empty if-block dead code in syncOneExtraFile
- Remove redundant mode default (SyncExtra already defaults to merge)
- Consolidate capitalize/capitalizeFirst into single Unicode-safe helper
- Remove trivial copyExtraFile wrapper, call copyFile directly
- Warn when --all is used in project mode (extras are global only)
- Cache os.UserHomeDir() at package level for shortenPath
- Use source file set instead of per-file os.Stat in pruneExtraOrphans
Route `skillshare sync extras` to new cmdSyncExtras handler that
iterates config.Extras, calls sync.SyncExtra per target, and logs
to oplog. `skillshare sync --all` runs normal skill sync followed
by extras sync in one invocation.
Add ExtraTargetConfig and ExtraConfig structs to support a new
`extras:` section in config.yaml for syncing non-skill resources
(rules, commands, etc.) to target directories.
- ExtraConfig: name + list of ExtraTargetConfig (path + mode)
- Extras field added to Config struct (after Targets, before Ignore)
- Load() expands ~ in extras paths, matching existing target behavior
- Tests cover parsing, tilde expansion, mode field, and empty extras