Codex review on #400:
- Now that Pi reports an installed npm package's version, plugin import
records it in config, and nothing rewrites it after a pi update. The
Plugins page preferred that recorded version, so an imported package
kept showing its import-time version. For an npm package the page now
prefers what Pi reports installed, and falls back to the recorded one.
- When the package reached the checked version before the update ran,
the update preview had a noop change and the apply an unchanged
outcome, but only update changes took an Agent off the checked list, so
the stale old -> new tag and Update button stayed until another check.
A noop with an outcome that is not failed now clears it too.
Codex review on #400:
- The private-registry check read npm's config by hand, and each round
found another place npm reads it from: the lowercase environment, the
global npmrc, and now a globalconfig or prefix set in the user .npmrc.
Rather than chase npm's rules, the check now asks npm itself:
`npm config get registry @scope:registry` in the folder Pi runs npm in.
Any registry other than npmjs, or npm not answering, leaves the package
to Pi. The hand-written .npmrc reading is gone.
- When an apply stopped before any Agent ran, such as on a stale preview,
the result had no outcomes, and the page took every planned update off
its list, hiding the row's Update action. Only an Agent the result
reports done comes off now.
Codex review on #400:
- The Plugins page kept only one version per plugin from a check, and
only when the change had one, then hid the row's Update button when an
Agent already had that version. A source plugin whose content changed
without a version bump, or whose manifest has no version, so lost its
Update action once the check dialog closed. The page now keeps what the
check found per plugin and Agent, with or without a version, and an
applied update takes those Agents off; the version only shows what the
update brings.
- The private-registry check did not read npm's global config, so a
registry set only in $PREFIX/etc/npmrc still sent the package name to
npmjs. It now reads the file npm_config_globalconfig names, else
$PREFIX/etc/npmrc with the prefix from the environment or the npm on
PATH, and leaves the package to Pi when it can't tell where that file
is.
- Reading the package version made a package.json whose version is not a
string fail to decode as a whole, which dropped its pi manifest and the
extensions it declares. The version is decoded on its own now, so an
odd one is only skipped.
Codex review on #400:
- A package added with a range such as npm:demo@^1.2.0 was compared with
npm's unrestricted latest. With latest at 2.0.0 and the newest matching
release at 1.9.0, check kept offering 2.0.0, which Pi never installs
because it keeps the configured range. Only a package added without a
version follows latest now; one with a range or a tag is left to Pi, as
a pinned one already was.
- The private-registry check read the user .npmrc path only from
NPM_CONFIG_USERCONFIG. npm reads its environment case-insensitively, so
a lowercase npm_config_userconfig pointing at an .npmrc with a private
registry was ignored, and the package name went to npmjs. Both
spellings are read now.
The plugin reference, its translations and the built-in skill say which
packages the check leaves to Pi.
Codex review on #400:
- The update check asked the public npm registry about every unpinned Pi
package, even when the environment or an .npmrc sends the package, or
its scope, to another registry. A public package with the same name
could then hide a real update or offer an unrelated version. The check
now reads the npm registry settings for the package and its scope from
the environment, Pi's npm folder and the user .npmrc, and falls back to
checking in Pi when any of them names another registry.
- The row's Update button disappeared as soon as any Agent had the
version the check found, so with one Pi target behind and another up to
date, the one behind lost it. The row now compares each selected Agent
with that version on its own, and updates only the ones behind.
The Plugins page listed every binding a run touched, one row each, so a
single failure sat among a dozen "unchanged" rows, and the preview did
the same. Failures now come first, Agents that ended the same way share
a row, and what stayed the same folds into one Unchanged line that opens
to one row per plugin, with Pi packages apart. Logos stay only on the
rows that need a look.
An npm package in Pi recorded no version and no source, so it showed no
version and Check updates could only say to check in Pi. The installed
package.json now gives its version, on the Plugins page and in a Pi
target's Extensions tab, and check compares that version with npm's
latest. A newer version gets an Update button on the row and in the
check's result; it updates that one package with pi update <source>,
not pi update --extensions, which would also update packages the
preview never listed. update leaves a package already at npm's latest
alone, and records no version, so the dashboard keeps reading what Pi
installed. The two check messages that were English in every locale now
have keys.
Release-As: 0.24.5
Codex review on #399: switching an extension of a global package in a
project writes a project override, which the project view reads in its
project-entry loop. In project mode that loop looked only at the
project's config, so the override lost the global plugin's name.
A project entry now falls back to the global config's owners when the
project config has none.
Codex review on #399: a dashboard started in project mode gives the
plugin service the project's config, so a global Pi package that
Skillshare installed, inherited by the project, found no owner and its
card fell back to the state path again. The earlier test kept
ConfigPath on the global config and missed this.
The service now takes the global config path in project mode, and the
project view looks up inherited global entries there.
Codex review on #399: an entry with a readable source but a value
Skillshare can't edit, such as "extensions": null, returned early in
both the global and project views before ManagedBy was set. Its card
then fell back to the plugin's local state path again.
The lookup now runs for every entry whose source can be read, before
the early return.
The Import dialog listed everything an Agent reports as installed,
including what Skillshare itself installed there (a Pi plugin shows up
as its state path) and what was already imported. Importing either one
again changes nothing, and the path does not say which plugin it is.
Each Agent's list now skips entries whose ID a package already binds to
that Agent, counts only what is left, and says when everything there is
already managed.
Codex review on #399: piProjectState never set ManagedBy, unlike
piGlobalState. A project's Extensions tab (<project>@pi, or pi in
project mode) therefore titled a plugin Skillshare installed by its
state path and dropped the "Managed by Skillshare" tag, for both the
project's own entries and the global entries it inherits.
The lookup by source, then by resolved local path, moves into
piManagedBy and runs for every package of both views.
The macOS finder tests stub PATH, but the candidate list still checked
/opt/homebrew/bin/codex, /usr/local/bin/codex and /Applications on the
real filesystem. In the devcontainer /usr/local/bin/codex exists, so it
won over the app bundle each test set up and make check failed there.
The finder now joins those absolute paths onto a root field, "" on a
real machine, and the tests point it at an empty temp dir.
A plugin Skillshare installs from a Git source and binds only to Pi
landed in the "Pi packages" list, which is meant for packages Pi
installs itself (npm:/git: identifiers with no recorded source). The
list now also requires that neither the package nor any binding has a
source, so such plugins stay under "Managed by Skillshare".
The Pi target's Extensions tab titled those same plugins by their
local state path (local:.../skillshare-<hash>/content), which does not
say which plugin it is. The server already returns the plugin name as
managedBy; use it as the card title, keeping the path in the tooltip
and details.
countAgentLinksAndBroken counted every healthy .md link in the target,
so a leftover link for an agent the target no longer syncs could stand
in for a missing expected one and hide drift. status and doctor now
count a link as linked only when its name is an expected agent; broken
links are still reported regardless of name.
Refs #395, Codex review on #397.
Adopting the portable root plugin.json replaced the whole Codex target
info, dropping the interface.logo read from .codex-plugin/plugin.json.
Codex still overlays that native manifest, and the portable one rarely
names a logo, so the add/list UI fell back to a generic icon.
Refs Codex review on #396.
status counted every discovered agent against each target, while sync
agents writes only the agents left after .agentignore, the target's
include/exclude and the frontmatter targets field. A target that leaves
some agents out was reported as N/M with drift after a complete sync,
in the table and in --json, in global and project mode. doctor and the
dashboard already filtered per target.
status now applies the same three filters before counting and expecting.
The table reports an invalid include/exclude as an error, like it does
for skills; --json falls back to the active agents.
Refs #395
The polling instructions read as applying only after an `@codex review`
comment, so an agent could open a pull request and hand Codex's initial
findings back to the user instead of following them up itself.
A portable root plugin.json without a version left the Codex binding's
version empty, which skips the post-update version check, so an update
could advance the snapshot while Codex still ran an older copy. Codex
reports 1.0.0 for such a manifest, so expect that instead.
Refs Codex review on #396.
Codex 0.159 installs from a portable root plugin.json (agent-plugins.org
schema) ahead of .codex-plugin/plugin.json, and reports 1.0.0 when that
manifest has no version. Skillshare preferred .codex-plugin/plugin.json,
so updating a package that ships both (ponytail 4.10.3) failed with
"native update returned version 1.0.0; expected 4.10.3" on every sync.
Two agents that flatten to the same name matched the same manifest entry
and were both counted, so status could report 2/2 with one output on
disk. Each manifest key now satisfies one agent.
Refs Codex review on #392.
Counting an extension output as synced from its output hash alone missed
the common case: the user edits the agent in the source and runs status
to see whether a sync is due. The output still matched the manifest, so
status, doctor and the dashboard reported no drift although the next
sync would regenerate it.
Sync now records a SHA-256 of the source each output was converted from
in the manifest (sources), and status counts an output only when both
the output and that fingerprint are current. Outputs recorded by earlier
releases have no fingerprint and count as current until the next sync
records one, so upgrading does not show the 0/N the report was about.
Refs #391, Codex review on #392.
When a "!" rule in .skillignore.local overrode a single disable, the handler
returned 409 before its only ops log call, although AddPattern had already
written the pattern to .skillignore. The shared file changed with no trace in
the log. Log the attempt with status "error" and the reason before returning.
Disabling a skill only checked that its path was written to .skillignore.
A "!" rule in .skillignore.local is applied after that file, and an
unanchored one such as "!feature-radar" re-includes every path segment with
that name, so the skill stayed enabled while the dashboard reported success.
The dashboard also never showed the .local file, so nothing explained why.
Single and batch toggles now re-discover after writing and report an item
that did not reach the requested state as failed, naming the overriding
file; the batch toast shows the first failure's reason. GET /api/skillignore
and /api/agentignore return the .local file, and Settings > Files shows its
rules above the editor.
The tree pane's folder switch showed a partial state by only centering the
knob on the off-colored track. On a 34px track that looked like a stuck or
broken off switch. Give the mixed state a half-tone track and a dash in the
knob, the way an indeterminate checkbox reads.
An agent target with an extension writes each agent under output_ext
(reviewer.toml) with transformed content, and the manifest tracks that
output name. status, doctor and the dashboard's Sync tab counted synced
agents by looking for the source name and comparing with the source
content, so every converted agent was missing: status showed 0/N with
drift, doctor said the same, and the Sync tab kept them pending after a
successful sync.
For an extension target, count an agent as synced when the manifest
tracks an output with the same stem and that file still matches its
recorded hash. Matching by stem avoids loading the extension spec in
status paths. doctor keeps reporting leftover broken links for these
targets.
Refs #391
Installing a repo whose root is a skill copies the whole repo into the
source, including any .claude/skills/ the author keeps for their own
development. Install discovery already skips target dotdirs, but the
source walk used by sync, check, and the dashboard only skipped .git,
so those dev-only skills surfaced as nested skills and were synced to
every target.
Share the skip set through sourcewalk and apply it in both source
walks. Only dotdirs nested below the source root are skipped: host-style
paths directly under the root (.cursor/skills/*) stay visible because
they drive target inference.
The global block still offered "a decision with its reason" and "a
pitfall you confirmed" as things that belong in it, so a project
decision matched both blocks. The examples are now per scope: the global
ones name user preferences, decisions that apply across projects, and
pitfalls in a tool; the project ones stay project-bound. Both rules take
the examples as a parameter instead of a string replacement.
Refs Codex review on #387.
An agent that reads both a global and a project guidance block saw the
same body twice, with two "save it here", and had to guess whether a
user preference or a project decision went to the shared folder or the
project one. Each block now says what belongs in it: the global block
points project notes at a project memory when one exists, and the
project block keeps project notes and says that notes about the user,
their tools, or other projects do not belong in it. The project block's
examples follow suit, so it no longer names "a stated user preference".
The active rule's two overlapping sentences on when to save are merged
into one, and the plugins reference describes the older Codex.app path
without reference to current events.
Rewrites the generated notes as user-facing entries with examples, drops
the duplicate Performance line that the #384 merge commit produced, and
syncs the website changelog.
#385 documented the new Source link info row and its --json check in
the English doctor page only; the ja, ko, zh-Hans and zh-Hant pages now
carry the same row and paragraph.
* fix(plugin): find the Codex CLI the desktop app ships
Plugin commands ran the bare name `codex` from PATH, so a machine with only
the Codex desktop app, or a scheduled job started with a minimal PATH,
reported the CLI as missing. The account-only `cli` override did not help:
the default codex target cannot set it, and an absolute path in a config
shared between macOS and Windows is wrong on one of them.
When `codex` is not on PATH, look in Homebrew's folders and the CLI the app
installs (Codex.app on macOS, %LOCALAPPDATA%\OpenAI\Codex\bin on Windows).
SKILLSHARE_CODEX_CLI overrides the search on one machine without touching
the synced config. The missing-CLI error now lists every place searched, in
the CLI and the dashboard.
Refs #338
* docs(plugin): note where Skillshare finds the Codex CLI
The plugin reference and the sharing guide still said every native CLI must
be on PATH, and the built-in skill told agents a missing CLI has no
fallback. Codex now has one, plus a machine-local override that agents
should prefer over a path in a shared config.
Refs #338
* fix(plugin): look for the Codex CLI inside ChatGPT.app
Since the Codex desktop app merged with ChatGPT, macOS installs it as
ChatGPT.app, so an app-only Mac with a minimal PATH still reported Codex as
missing. Try ChatGPT.app before Codex.app in /Applications and
~/Applications, the order Codex's own desktop-app finder uses.
Refs #338
* fix(plugin): run the packaged CLI entrypoint of the ChatGPT app
ChatGPT Desktop 26.924 removed Contents/Resources/codex and ships the CLI
at the entrypoint its package manifest declares, codex-cli/bin/codex, so a
current app-only Mac still reported Codex as missing. Try that entrypoint
first in each app bundle and keep the old path for earlier builds.
Refs #338
* fix(plugin): find the Codex CLI from the Windows installer
The official PowerShell installer puts codex.exe in
%LOCALAPPDATA%\Programs\OpenAI\Codex\bin and adds it to the user PATH. A job
started without that PATH missed it, the same gap Homebrew's folders cover
on macOS. Try it before the desktop app's copy.
Refs #338
* fix(plugin): keep an account's cli even when it is codex
The Codex search ran whenever the executable was the bare name codex, so an
account that set cli: codex could get SKILLSHARE_CODEX_CLI or the app's CLI
instead, against the documented rule that an account's own cli is kept.
Search only when no account cli is set.
Refs #338
Implements rollout steps 1 and 2 of proposals/274-skillfollow.md. Nothing follows a link or parses .skillfollow yet.
Step 1: doctor reports first-level symlinks and junctions in the skills source as info, in text and JSON, without following them.
Step 2a: internal/sourcewalk owns traversal of the skills source. Thirteen raw walks move onto it with identical behavior, and a go/parser ratchet fails the tests on any new unclassified walk.
Step 2b: internal/sourcefs wraps an os.Root opened at the skills source and refuses any write whose path has a link component. The six write sites the proposal found in review move onto it, including the cross-device copy fallback, and a second ratchet covers raw os write calls. The only behavior change is that an explicit path crossing a link inside the source is refused instead of written through.
Refs #274
Release-As: 0.24.3