Commit Graph
616 Commits
Author SHA1 Message Date
Willie ba7752f85d feat(ui): enhance install skill picker with descriptions and into-dir field
Include skill description from SKILL.md frontmatter in the discover API
response, add the optional description field to the DiscoveredSkill
TypeScript interface, and render it inline in the SkillPickerModal.
Filter search also matches against descriptions. The --into directory
input already existed in InstallForm, so no change was needed there.
2026-02-28 20:56:34 +08:00
Willie 6def2a254a feat(ui): add security overview card to dashboard
Enhance the existing Security Audit section on the Dashboard with:
- Risk label badge (clean/low/medium/high/critical) next to the title
- Severity breakdown badges (CRITICAL/HIGH/MEDIUM/LOW/INFO) for non-zero counts
- ShieldAlert icon in red when CRITICAL findings exist
- Card variant="accent" highlight when CRITICAL findings are present
- Green "All Clear" message with ShieldCheck icon when no findings
- Renamed section title from "Security Audit" to "Security Overview"
- Renamed last stat box from "Critical" to "Failed" for accuracy
2026-02-28 20:56:34 +08:00
Willie 18cfaa984c feat(ui): add sync mode selector to targets page 2026-02-28 20:56:34 +08:00
Willie 208b34d8a0 fix(ui): add accessibility improvements — aria-labels, focus trap, ErrorBoundary, htmlFor 2026-02-28 20:56:34 +08:00
Willie b24a80f861 feat(ui): add dark theme with toggle, aligned to website color palette
- Add .dark CSS variable overrides (warm brown bg, gold primary, muted shadows)
- Add ThemeContext with localStorage persistence and prefers-color-scheme detection
- Add theme toggle button (sun/moon) fixed at top-right of main content
- Replace all bg-white with bg-surface for theme-aware backgrounds
- Rewrite CodeMirror theme to use @lezer/highlight HighlightStyle for proper
  syntax highlighting in both light and dark modes
- Convert design.ts shadows from hardcoded hex to CSS variable references
- Add dark: variants for elements that need different active states per theme
- Add postit/tracked CSS custom properties with dark mode translucent overrides
2026-02-28 19:15:57 +08:00
Willie 00f8f38dd8 fix(check): pass custom targets to unknown-target validation in project mode
Follow-up to PR #58: check_project.go now extracts custom target names
from project config and passes them to findUnknownSkillTargets, matching
the global-mode fix. Also surfaces config load errors as warnings instead
of silently ignoring them. Adds integration tests for check and doctor
(global + project mode) verifying no false "unknown target" warnings.
2026-02-28 18:48:51 +08:00
Colin Mason ae500e89ca include user-configured targets in unknown target validation
findUnknownSkillTargets only checked the built-in targets.yaml list,
causing false warnings for custom targets defined in config.yaml.

Pass configured target names from global/project config into the
validation so user-defined targets are recognized.
2026-02-28 18:35:25 +08:00
Willie a37c458740 fix(ui): support subdir URL discovery and fix modal scroll-away bug
handleDiscover and handleInstallBatch now use DiscoverFromGitSubdir
when the source URL contains a subdirectory path, enabling the skill
picker modal to appear for multi-skill subdirectories.

Fix SkillPickerModal content disappearing on checkbox click caused by
Card's overflow-hidden creating a scroll container — browser's
scrollIntoView on the sr-only input would scroll content out of view.
Use overflow-clip instead to preserve border-radius clipping without
creating a scroll context.

Issue #56 (workaround)
2026-02-28 18:26:48 +08:00
Willie 0e488698ff feat(upgrade): show version transition in Homebrew and skill upgrade output
Previously, `skillshare upgrade` via Homebrew only showed "Upgraded" with
no version info, and skill downloads had the same issue. Now all upgrade
paths display clear version transitions:

- Homebrew: "Upgraded  v0.16.3 → v0.16.5" or "Already up to date ✓"
- Direct download: "Upgraded  v0.16.3 → v0.16.5" (was "Upgraded to v0.16.5")
- Skill install: "Installed v0.16.5" (new) or "Upgraded  v0.1.0 → v0.16.5"

Also records toVersion in oplog for Homebrew upgrades.
2026-02-28 18:25:57 +08:00
Willie 1f8fbd4489 docs(website): add status/doctor perf entry to changelog v0.16.4 2026-02-28 03:44:02 +08:00
Willie a41ccacf71 docs: add status/doctor perf entry to changelog 2026-02-28 03:44:02 +08:00
Willie 5017df2336 perf(status,doctor): eliminate redundant discovery and CheckStatus calls
status: single DiscoverSourceSkills pass shared across printSourceStatus,
printTrackedReposStatus, and printTargetsStatus; extractTrackedRepos
replaces GetTrackedRepos Walk; targetStatusResult carries syncedCount
so drift check reuses getMerge/CopyStatusDetail results.

doctor: single DiscoverSourceSkills pass shared across 5 check functions
(checkSource, checkSkillsValidity, checkSkillTargetsField, checkSyncDrift,
checkDuplicateSkills); cachedTargetStatus map lets checkSyncDrift reuse
checkTargets results; checkForUpdates network request runs in goroutine
overlapping local I/O.

Both commands show a spinner during discovery to avoid appearing frozen
on large skill sets.
2026-02-28 03:44:02 +08:00
Willie d86ee8cc7f fix(ui): align spinner output and skip backup when no skills
Remove 2-space indent from spinner Success/Fail/Warn and
SuccessMsg/ErrorMsg so they align with other ui.Success output.

Move backup after discovery in sync so it is skipped when there
are 0 skills to sync — no point backing up if nothing will change.
2026-02-28 03:44:02 +08:00
Willie 9a7ee1b6f7 fix: address code review findings (3 important + 5 suggestions)
- Fix non-TTY progress bar not incrementing for grouped skills in Phase 2
- Fix Unicode truncation in UpdateTitle using runewidth instead of len()
- Fix IP address regex missing end-of-line bare IPs (add $ anchor)
- Fix gofmt alignment in updateTarget struct comments
- Extract sliceHasName[T] generic helper to deduplicate universal detection
- Add nil meta defensive warning with skipped count in grouped updates
- Replace hand-rolled contains/containsStr with strings.Contains in tests
- Add red team TC-20b for inline code fetch-with-pipe detection
2026-02-28 03:44:02 +08:00
Willie 6ca6f58cf6 fix(test): adapt online audit parity test for skip-unchanged optimisation
The skip-unchanged optimisation (ec81fc1) causes update --all to skip
skills whose metadata already matches the repo state, producing no
InstallResult and therefore no audit output.  The test now invalidates
one skill's metadata between install and update, forcing a re-install
that exercises the audit code path.
2026-02-28 03:44:02 +08:00
Willie 51d2e3a6c5 perf(update): speed up grouped updates and unstick progress bar
Optimize grouped repo updates by skipping reinstall when installed metadata already matches remote state (commit match, or subdir tree-hash match when HEAD moved).

Emit per-skill grouped progress events so the batch progress bar advances continuously instead of appearing stuck at 0%.

When skipping by tree-hash match, best-effort refresh meta.Version to latest commit to keep status/version output current.

Add unit tests covering commit/tree-hash skip behavior and metadata version refresh.
2026-02-28 03:44:02 +08:00
Willie b4a4969ff6 perf(update): skip unchanged skills in grouped repo updates
When update --all processes many skills from the same repo, avoid reinstall/copy when installed metadata already matches the fetched repo state.

For root skills, skip when meta.Version matches repo commit. For subdir skills, require both meta.Version and meta.TreeHash to match. Added unit tests for match/mismatch cases.
2026-02-28 03:44:02 +08:00
Willie 0f29dd3abd perf(update): remove per-skill delay in batch update loop
Drop the fixed 50ms sleep in the grouped batch update iteration. On very large update --all runs this sleep dominates runtime (for example ~90 minutes at ~108k skills) without improving correctness.

This keeps progress updates intact while eliminating artificial throttling in TTY mode.
2026-02-28 03:44:02 +08:00
Willie 65402b9491 feat(update): add phase headers and scanning spinner for batch mode
- Add PhaseHeader UI helper for "[1/3] Pulling N tracked repos..." labels
- Show phase headers between batch update phases when 2+ phases exist
- Skip phase headers when only 1 phase (avoids meaningless "[1/1]")
- Lazily start progress bar after first phase header to fix ordering
- Add scanning spinner during filepath.Walk for large skill sets
- Cache metadata in updateTarget to avoid redundant ReadMeta calls
2026-02-28 03:44:02 +08:00
Willie 6a5d2eaa98 perf(collect): remove eager calculateDirSize from FindLocalSkills
Size was computed by walking every file in every local skill directory
during the scan phase, before the user even confirms. CLI never displays
the size. Move to lazy on-demand calculation in the Web UI handler only.
2026-02-28 03:44:02 +08:00
Willie f49e6f0a11 docs: update v0.16.4 changelog with batch gitignore perf and new fixes
Add entries for batch gitignore operations, pull project mode leak fix,
list TUI action safety, unified batch summary, and output spacing.
Update date to 2026-02-28.
2026-02-28 03:44:02 +08:00
Willie 4c70b7d0af perf(gitignore): batch read/write for install reconcile and uninstall
UpdateGitIgnore/RemoveFromGitIgnore were called per-skill inside loops,
re-reading the entire .gitignore each time. With large files (100K+ lines
in project mode), this caused O(N×M) complexity and process hangs.

- Add UpdateGitIgnoreBatch and RemoveFromGitIgnoreBatch (single read/write)
- ReconcileProjectSkills: collect entries during walk, batch-update once
- uninstall (global + project): batch-remove after loop, not per-iteration
- Fix spinner WithRemoveWhenDone in StartSpinnerWithSteps
- Add E2E runbook for gitignore batch performance validation
2026-02-28 03:44:02 +08:00
Willie 965f06077b fix(pull): force global sync after pull to avoid project mode auto-detection
When pull calls cmdSync with empty args in a directory containing
.skillshare/config.yaml, auto-detection incorrectly switches to
project mode. Pass --global explicitly since pull always operates
on the global source.
2026-02-28 03:44:02 +08:00
Willie 13acc7533d fix(list): add in-TUI confirmation and explicit mode flags for actions
A/U/X shortcuts now show a confirmation overlay (→ skillshare <action>
<flag> <skill>, Proceed? [Y/n]) before executing. This prevents
accidental actions and lets users see the exact command.

Global mode dispatch now passes -g to audit/update/uninstall, fixing
auto-detect misidentifying as project mode when .skillshare/ exists
in cwd. Uninstall adds --force to skip double confirmation since
the TUI already confirmed.
2026-02-28 03:44:02 +08:00
Willie 429e67a88c fix(audit): downgrade data-uri severity to MEDIUM 2026-02-28 03:44:02 +08:00
Willie e14ef99641 fix(ui): add trailing blank line after command output
Add visual separation between command output and the shell prompt
for better readability.
2026-02-28 03:44:02 +08:00
Willie 1099ba4a9e feat(ui): unified batch summary and output patterns across commands
Add generic OperationSummary() with Metric struct for consistent
batch output. Refactor SyncSummary/UpdateSummary as thin wrappers.

Apply unified patterns to collect, uninstall, backup:
- Spinner for scanning phases
- StepDone/StepSkip/StepFail semantic indicators
- OperationSummary for batch results
- Header before collect scanning for context
- Spacing before backup "Recent backups" section

Fix pterm spinner RemoveWhenDone bug: Success/Fail/Warn messages
were silently eaten because Stop() clears the line after printing.
Use Stop() + lightweight symbols (✓/✗/!) instead of pterm badges.
Also replace SuccessMsg/ErrorMsg pterm.Success/Error badges.
2026-02-28 03:44:02 +08:00
Willie 5d9a77372d feat(init): label universal as shared agent directory and add coexistence docs
- Change universal description from "(recommended)" to "(shared agent directory)"
  in detect, checklist, and discover flows
- Add FAQ section on using universal alongside npx skills: merge vs copy mode
  differences, name collision caveats, lock file visibility
- Add universal info admonition to supported-targets page
- Add E2E runbook for universal target path verification
- Update CHANGELOG and release notes for v0.16.4
2026-02-28 03:44:02 +08:00
Willie 1a207e6d2c feat(audit): add fetch-with-pipe, ip-address-url, and data-uri rules
Add 5 new audit rules (31 → 36 total) to close detection gaps:

- fetch-with-pipe (HIGH ×3): curl/wget piped to sh/bash/python/node/etc.
  Previously only double-pipe (||) was caught by shell-chain; single
  pipe (|) to interpreters — the classic RCE vector — was undetected.
- ip-address-url (MEDIUM): URLs with raw IP addresses that bypass DNS
  security controls; excludes RFC 1918 and loopback ranges.
- data-uri (HIGH): data: URIs in markdown links that may embed
  executable content.

fetch-with-pipe is suppressed inside markdown code fences (tutorial
context), matching existing behavior for destructive-commands et al.

Includes unit tests (25 cases), code fence suppression test, red team
TC-18 through TC-21, and audit.md documentation updates.
2026-02-28 03:44:02 +08:00
Willie 8997196593 fix(init): correct universal target path and auto-include in init
The universal target pointed to ~/.config/agents/skills (wrong) instead
of ~/.agents/skills, causing `npx skills list` to miss synced skills.

Also auto-recommend universal as a target whenever any CLI is detected
during `init` and `init --discover`, since ~/.agents/ won't exist on
disk until skillshare creates it.

Closes #54
2026-02-28 03:44:02 +08:00
Willie 79f26f2e98 fix(docs): correct broken anchor link in docker-sandbox page
#interactive-playground → #playground to match the actual heading ID.
2026-02-28 03:44:02 +08:00
Willie 1c84866eeb docs: add install duplicate detection docs and v0.16.4 changelog
- Add Duplicate Detection section to install.md (same-repo skip,
  cross-path detection, conflict with different repo)
- Update --force flag description to mention dedup override
- Add v0.16.4 changelog entry to CHANGELOG.md and website
2026-02-28 03:44:02 +08:00
Willie 666091a453 feat(install): add cross-path duplicate detection and same-repo skip
Prevent accidental duplicate installs when the same repo is already
installed at a different path (e.g., --into vs root). Same-repo
reinstalls now show a friendly skip indicator instead of an error.

- Add CheckCrossPathDuplicate() with URL normalization (HTTPS/SSH)
- Add ErrSkipSameRepo sentinel for graceful skip flow control
- Add checkExistingConflict() with repo URL comparison
- Fix --force hint to use repo URL (not per-skill subpath) and
  include --into when applicable
- Add dedup check to Web UI install endpoints (HTTP 409)
- Group skipped skills by directory with repo label in summary
2026-02-28 03:44:02 +08:00
Willie 0f2d66e18a refactor(update): align batch summary with sync-style single-line format
Replace verbose SuccessMsg summary with UpdateSummary() matching
SyncSummary's clean single-line stats format with color coding.
2026-02-28 03:44:02 +08:00
Willie 41fe18b3be fix(update): normalize empty Subdir to "." for root-level skill repos
Root-level skills (SKILL.md at repo root) have meta.Subdir="" but
discoverSkills() returns Path=".". The mismatch caused lookup failure
in batch update, falsely reporting these skills as stale/deleted.
2026-02-28 03:44:02 +08:00
Willie 00cb3ba80e feat(targets): add Verdent AI coding agent
Add Verdent (verdent.ai) as a built-in target with standard skill paths.
Update target count from 49+ to 50+ across README, homepage, and docs.
Sync changelog and release notes with the new target entry.
v0.16.3
2026-02-27 05:39:49 +08:00
Willie 988a9b7213 docs: sync website changelog and update changelog skill to cover both files
The changelog skill previously only updated root CHANGELOG.md, leaving
website/src/pages/changelog.md out of sync. Added Step 6 to the skill
workflow for syncing the website version, and backfilled missing v0.16.2
and v0.16.3 entries into the website changelog.
2026-02-27 05:39:49 +08:00
Willie 217af0782c fix(install): respect quiet mode for tracked config dry-run 2026-02-27 05:39:49 +08:00
Willie dc62efdb40 fix(list,log): skip TUI when async load returns empty results
When list or log TUI loads zero items asynchronously, exit the TUI
immediately and print a plain-text hint instead of showing an empty
interactive screen. Uses an emptyResult flag on the TUI model to
signal the caller after tea.Quit.
2026-02-27 05:39:49 +08:00
Willie cfbcaaff9e fix(uninstall): fix stale summary, skip message, and pluralization UX
After pre-flight filters out dirty tracked repos, recalculate summary
so spinner and confirm prompt use correct noun type. Print skip count
when repos are skipped. Replace all "(s)" patterns with pluralS() for
natural English output ("2 groups" not "2 group(s)"). Add isMixed()
method to avoid magic string comparison on noun().
2026-02-27 05:39:49 +08:00
Willie 87abb6e049 feat(install): replace spinner with tree-style progress and summary output
Switch config install and search install UI from plain spinner to
TreeSpinner with StepResult summary showing installed/skipped/failed
counts and elapsed time. Add git clone progress callback to spinners
so users see real-time cloning status.

- Add Quiet field to InstallOptions for suppressing per-skill output
- Add Skipped field to ConfigInstallResult for accurate summary
- Update integration test assertion to match new summary format
2026-02-27 05:39:49 +08:00
Willie c7f8a86c62 feat(install): group config skills by repo to avoid redundant clones
When a registry has multiple skills from the same git repo,
InstallFromConfig now clones the repo once and installs each skill
from the local clone via InstallFromDiscovery. This mirrors the
optimization already present in search_batch.go for hub installs.

The install flow is restructured into 4 phases:
1. Tracked repos (unchanged, each does its own clone+discover)
2. Grouped plain skills (clone once per repo, install from discovery)
3. Singles (unchanged per-skill Install flow)
4. Reconcile config

Skills that fail to match in grouped discovery fall back to Phase 3.
2026-02-27 05:39:49 +08:00
Willie 2e976233b4 docs: fix alt text for skills screenshot in README 2026-02-27 05:39:49 +08:00
Willie 0a28fcdbdb fix(search): preserve canonical repo source in grouped installs
Use a repo-root source in grouped search installs by normalizing from CloneURL instead of carrying subdir Raw values. This prevents malformed metadata sources (for example duplicated subdir paths) and keeps provider-agnostic behavior for GitHub/GitLab/Bitbucket/Azure and SSH URLs.

Also centralize discovery source formatting for metadata so whole-repo SSH installs use //subdir syntax consistently.

Add regression coverage:
- cmd unit tests for grouped clone source normalization across providers
- install unit tests for discovery source formatting (including SSH)
- integration test in tests/integration that verifies grouped install metadata source round-trips through ParseSource.
2026-02-27 05:39:49 +08:00
Willie 5a111ce8f6 fix(search): use provider-agnostic source for repo-grouped cloning
Replace GitHub-specific GitHubOwner()/GitHubRepo() calls with a
value copy of the parsed source, clearing only Subdir. Fixes empty
Raw/Name for GitLab, Bitbucket, and Azure DevOps batch installs.
2026-02-27 05:39:49 +08:00
Willie f29b4ac1b8 fix(sync): dereference directory symlinks in copy mode and update changelog
Copy mode now resolves directory symlinks to concrete directories,
preventing broken symlinks in targets that use file copying (e.g.,
Windsurf). DirChecksum follows symlinks for consistent hash comparison.
DirMaxMtime disables mtime fast-path for symlink-containing skills to
avoid stale cache hits. Cycle detection prevents infinite recursion.

Also updates CHANGELOG v0.16.3 with previously missing entries:
hub risk badge colors, batch failure output, repo-grouped cloning.
2026-02-27 05:39:49 +08:00
Willie 76482a5c09 feat(search): colorize risk badges in hub TUI with lipgloss
Replace plain-text risk badges with lipgloss-styled colored versions
in the search TUI list and detail panel, matching the severity color
palette used elsewhere. Add CHANGELOG entry for v0.16.3.
2026-02-27 05:39:49 +08:00
Willie 48b670220d fix(search): improve batch install failure output readability
Classify failure details by type (security/ambiguous/not found) with
distinct icons and colors. Truncate long ambiguous path lists and audit
findings to 3 lines + "(+N more)" to prevent screen flooding. Add
breathing room between multi-line entries. Highlight skill names in
bright white for better scanability.

Also includes repo-grouping refactor: skills from the same git repo
are cloned once and installed from the shared clone, with extracted
helpers (groupByRepo, installFromDiscoveryResult, logSkillInstallOp).
2026-02-27 05:39:49 +08:00
Willie dec449a898 fix(search): show git progress detail and reconcile once after batch install
- Show detailed git clone status (cloning 45%, resolving 67%) instead of
  static "installing..." by wiring up install.OnProgress callback
- Only show actively installing skills in progress area (skip queued/done)
- Move per-skill reconcile to single batch-level reconcile at end, fixing
  O(n²) directory walks that caused batch installs to appear stuck
2026-02-27 05:39:49 +08:00
Willie 9ef63572f3 revert(ui): switch progress bar back to pterm ProgressbarPrinter
The custom thread-safe progress bar (progress.go) had width overflow
issues. Revert to pterm's built-in ProgressbarPrinter which handles
terminal width calculation internally. Remove StartProgressWithMaxWidth
in favor of the simpler StartProgress API.
2026-02-27 05:39:49 +08:00