Commit Graph
696 Commits
Author SHA1 Message Date
Willie b5372b1228 feat(audit): add global deduplication with composite key
DeduplicateGlobal removes duplicate findings using
pattern|file|line|normalizedSnippet as key. Higher severity wins on
conflict. Snippet normalization strips ANSI, collapses whitespace.
2026-03-03 16:08:11 +08:00
Willie 47ee1ed3da feat(audit): add Policy type and ResolvePolicy with profile presets
Introduces Profile (default/strict/permissive) and DedupeMode
(legacy/global) types. ResolvePolicy resolves layered inputs from
CLI flags, config, profile presets, and built-in defaults.
2026-03-03 16:08:11 +08:00
Willie 34ecba48ee test: stabilize make test under updated audit rules 2026-03-03 16:08:11 +08:00
Willie 474bf3e4c1 feat(devcontainer): standalone lifecycle without VS Code dependency
`make devc` now builds, initialises, and enters the devcontainer in one
step — no VS Code required. A unified `scripts/devc.sh` replaces the old
`devcontainer_shell.sh` with full lifecycle subcommands (up/shell/down/
restart/reset/status).

Key changes:
- Dockerfile Stage 2 copies node+pnpm from ui-builder (removes need for
  devcontainer feature, benefits sandbox playground too)
- profile.d scripts moved from setup.sh → start-dev.sh so they survive
  container recreation (down → up) without re-running full setup
- Volume-based sentinel (~/.devcontainer-initialized) lets devc.sh skip
  setup.sh when volumes persist, cutting restart to ~2s
- Go toolchain PATH added to profile.d (login shell was losing it)
- Makefile/mise.toml gain devc-up/-down/-restart/-reset/-status targets
- Website docs updated with terminal-first flow and CLI path in diagrams
2026-03-03 16:08:11 +08:00
Willie bcbbaaf34d refactor(audit): remove noisy rules, recalibrate credential severities
Remove rules that generated excessive false positives:
- source-repository-link (HIGH): legitimate docs links flagged too often;
  external-link (LOW) already covers the same URLs
- env-access (MEDIUM): process.env references are ubiquitous in JS skills
- obfuscation-1 (long base64): caught README badges and binary data

Recalibrate credential-access severity levels to reduce alert fatigue:
- etc-passwd/sudoers: HIGH → MEDIUM (read-only system files, not secrets)
- shell-history, openvpn: MEDIUM → LOW (low-impact reconnaissance)
- auth-log: LOW → INFO (log files, no direct credential exposure)

Update all affected unit tests, integration tests, red team assertions,
skill references, and website docs to match.
2026-03-03 16:08:11 +08:00
Willie 1caba253c6 fix(audit): prevent severity-only merge from wiping rules and enable --pattern from ignoring ID-level disables
P1: mergeYAMLRules Phase 2 used full-object replacement for overlays
without Enabled set, causing severity-only entries ({id, severity}) to
wipe regex/pattern/message from the base rule. compileRules then failed
with "empty regex". Now uses field-level merge: only entries with Regex
do full replacement; otherwise Enabled and Severity are patched
individually.

P2: TogglePattern enable only removed pattern-level disable entries,
leaving ID-level {id: "x", enabled: false} untouched — both builtin
and custom rules. Now clearDisableForPattern matches by builtin ID set
OR by r.Pattern == pattern, covering custom rules in the same group.
2026-03-03 16:08:11 +08:00
Willie a97cf9e34e refactor(audit): simplify rules code, fix N+1 I/O, and extract shared helpers
- Remove duplicate readOrCreateRulesFile (use loadUserRules)
- Consolidate severity normalization with shorthand aliases (c/h/m/l/i)
- Merge enable/disable into shared cmdAuditRulesToggle
- Cache builtinYAML() with sync.Once to avoid repeated YAML parsing
- Cache rulesPath/patterns/sevCounts on TUI model, use SetItems over list.New
- Extract execMutation helper, remove dead expandAll/collapseAll/buildTitle
- Fix TestScanContent_InsecureHTTP test pollution via resetForTest()
- Add batch ToggleRules/SetSeverityBatch to eliminate N+1 file I/O
- Extract shared severity helpers to ui/src/lib/severity.ts
- Merge 9 filter() calls into single-pass useMemo in AuditRulesPage
- Add 7 tests for batch toggle and severity operations
2026-03-03 16:08:11 +08:00
Willie dbe759ecfe feat(audit): add CLI rules subcommand, severity override, reset, and redesign Web UI
- Add `audit rules` CLI subcommand with list, enable, disable, severity,
  and reset commands for managing audit rules without editing YAML
- Add SetSeverity/SetPatternSeverity/ResetRules mutations in audit package
- Redesign TUI with severity tabs, two-level pattern→rule navigation,
  inline severity picker (1-5 keys), and reset-all support
- Add compiled rules API endpoints (GET /api/audit/compiled, PATCH toggle)
- Redesign AuditRulesPage with severity-colored stripes, stat cards,
  expand/collapse, toggle switches, and dark-mode-aware CSS variables
- Redesign LogPage with status-colored row stripes, reusable PillButton,
  improved stats cards with left border stripes, default 10 entries/page
- Remove system-writes audit pattern (noisy, low value)
- Fix dark mode contrast across both pages by replacing hardcoded
  design.ts colors with var(--color-*) CSS variable references
2026-03-03 16:08:11 +08:00
Willie 3f8d42512f feat(server): add compiled rules listing and toggle API endpoints
GET /api/audit/rules/compiled returns structured rule list with patterns.
POST /api/audit/rules/toggle enables/disables rules by id or pattern.
2026-03-03 16:08:11 +08:00
Willie 0b3fc11fba feat(audit): add two-level TUI for audit rules browsing and toggling
Implement a full bubbletea TUI with two navigation levels:
- Level 1 (patterns): shows pattern categories with rule count, disabled
  count, and max severity; press Enter to drill in, d to toggle pattern
- Level 2 (rules): shows individual rules with severity and status; detail
  panel shows full ID, regex, message, source; d toggles single rule,
  D toggles entire pattern, Esc returns to Level 1

Also adds audit.ResetGlobalCache() to clear cached rules after YAML
mutations, enabling live-reload within the TUI session.
2026-03-03 16:08:11 +08:00
Willie 9997114f6d feat(audit): add ToggleRule/TogglePattern for programmatic rule management 2026-03-03 16:08:11 +08:00
Willie 9eabb29ba2 feat(audit): add CompiledRule type with ListRules and PatternSummary
Introduce rules_list.go with exported types and functions for listing
all audit rules with their enable/disable status and source layer
(builtin/global/project). Includes PatternSummary for grouped stats
and UniquePatterns for pattern enumeration. Disabled rules appear in
listings with Enabled=false so UIs can display toggle state.
2026-03-03 16:08:11 +08:00
Willie beb4a1ef8d feat(audit): support pattern-level rules in audit-rules.yaml merge
Extend mergeYAMLRules to handle overlay entries that specify a pattern
but no id — these apply to all base rules sharing that pattern name.

Processing uses two phases:
  1. Pattern-level overlays (bulk disable / severity override)
  2. ID-level overlays (can override pattern-level, e.g. re-enable
     an individual rule after a pattern-level disable)

An explicit enabled:true in an id-level overlay clears a disabled flag
set by a pattern-level overlay.
2026-03-03 16:08:11 +08:00
Willie 885f072d16 feat(audit): add table-driven credential detection and 12 new security rules
Replace hardcoded credential-access YAML rules with a Go data table
(credentials.go) covering 30+ sensitive paths × 5 access methods, with
$HOME variant support, descriptive rule IDs, and an INFO-level heuristic
catch-all for unknown home dotdirs.

Add 12 new detection rules from security gap analysis:
- invisible-payload (CRITICAL): Unicode tag chars U+E0001–E007F
- prompt-injection-4 (CRITICAL): output suppression directives
- hidden-unicode-2 (HIGH): bidi control chars (Trojan Source)
- config-manipulation-0 (HIGH): AI config/memory file poisoning
- hidden-comment-injection-1 (HIGH): markdown reference-link injection
- data-exfiltration-3 (HIGH): DNS exfiltration via dig/nslookup
- self-propagation-0 (HIGH): repository worm instructions
- untrusted-install-0/1 (MEDIUM): npx -y, pip install from URL
- hidden-unicode-3 (MEDIUM): soft hyphens, directional marks

The invisible-payload pattern intentionally bypasses tutorial suppression
so CRITICAL findings are never silenced in educational contexts.
2026-03-03 16:08:11 +08:00
Willie 72b53ba697 docs: add v0.16.9 changelog, release notes, and audit docs update
Update CHANGELOG.md and website changelog with v0.16.9 entry covering
interpreter tier (T6), expanded prompt injection/credential access
detection, and regex bypass fixes. Sync audit.md with new rule IDs
and detection descriptions. Add contributor reneleonhardt to README.
2026-03-03 16:08:11 +08:00
Willie 5d9565098e fix(audit): close regex bypass vulnerabilities and improve code reuse
Security fixes from red-team review of audit rules:
- Prompt injection: add \s* after ^ anchor to prevent whitespace bypass,
  add (?i) for case-insensitive matching, use [^>]* for HTML attributes,
  expand to cover DEV MODE / DEVELOPER_MODE variants
- Credential access: add rules for ln/cp symlink, input redirection,
  dd if=/etc/shadow (previously mislabeled as destructive-commands)
- Data exfiltration: remove exclude pattern that allowed .png?stolen_data
- Interpreter tier: add bun, deno, npx, tsx, pwsh, powershell; add
  version-suffix stripping (python3.11 → python3); handle env prefix

Code quality (from /simplify review):
- Rename crossFinding → syntheticFinding and reuse in TierCombinationFindings
  to eliminate 5 inline Finding literals
- Extract hasFinding() test helper to reduce tier test boilerplate
- Remove unnecessary (?i) from credential-access-3/4 (Unix commands are
  always lowercase)
2026-03-03 16:08:11 +08:00
Willie 7a6ba4546d feat(audit): expand prompt injection detection, add interpreter tier and credential rules
Strengthen the audit engine with new detection capabilities inspired by
skilld's sanitization research and Snyk ToxicSkills findings:

- Expand prompt-injection-1 to detect OVERRIDE:/IGNORE:/ADMIN:/ROOT: prefixes
- Add prompt-injection-2: agent directive XML tags (<system>, <instructions>, etc.)
- Add prompt-injection-3: DEVELOPER MODE, JAILBREAK, DAN MODE directives
- Add data-exfiltration-2: external images with query params (exfil vector)
- Add credential-access-3/4: /etc/shadow, /etc/passwd and related system files
- Add TierInterpreter (T6): classify python/node/ruby/perl/lua/php as
  Turing-complete runtimes separate from build tools
- Add tier-interpreter and tier-interpreter-network combination findings
- Add cross-skill-cred-interpreter rule for credential × interpreter pairs
- Update docs to reflect 38 rules and new tier/cross-skill patterns
2026-03-03 16:08:11 +08:00
Willie 1676d7d064 fix(audit): suppress pterm cursor codes leaking into structured stdout
pterm's cursor package writes hide/show ANSI codes (\x1b[?25l/h)
directly to os.Stdout, bypassing WithWriter(). The previous fix
(SetProgressWriter to stderr) was insufficient because pterm still
created progress bar objects that triggered cursor.Hide()/Show().

Add SuppressProgressToStderr() which both redirects ProgressWriter
and forces isProgressTTY() to return false, preventing pterm
components from being instantiated at all. Extract assertNoANSI
test helper and cover all three structured formats (JSON, SARIF,
Markdown).

Also update pre-commit E2E runbook with steps 10-11 (framework
integration tests) and add pre-commit-hook recipe to sidebar.
2026-03-03 16:08:11 +08:00
Willie c298e2a1d1 docs(blog): update vercel/skills comparison with current facts
- vercel/skills now supports GitLab and any git URL (not GitHub-only)
- vercel/skills now has server-side audit via Snyk for catalog skills
- Reposition skillshare audit advantage as customizable local scanning
  (custom rules, thresholds, offline, SARIF/JSON output, pre-commit)
- Add custom audit rules, pre-commit hook, audit formats to comparison
v0.16.8
2026-03-02 23:01:30 +08:00
Willie ac20153948 docs: add pre-commit E2E runbook and update cli-e2e-test skill
- Add ai_docs/tests/precommit_audit_hook_runbook.md (9-step E2E test
  for skillshare audit -p as pre-commit hook)
- Fix cli-e2e-test SKILL.md: clarify init -p has separate flag set from
  global init; add audit rule ID vs pattern name guidance; add project
  mode init example to container templates; add two new checklist items
- Update CHANGELOG.md with pre-commit hook, audit TUI filter, O(N)
  cross-skill rewrite, and SARIF line-0 fix entries
2026-03-02 23:01:30 +08:00
Willie ca5a036e58 perf(audit): rewrite cross-skill analysis from O(N²) to O(N)
Replace nested pair-checking loop with set-based approach:
- Single pass builds capability sets (credReaders, netSenders, etc.)
- Each rule checks non-empty sets → one summary finding per rule
- 100k skills: ~15ms vs ~30s+ (benchmark included)
- Use DiscoverSourceSkillsLite for audit discovery (skip frontmatter)
- Use patternDataflowTaint constant instead of raw string
2026-03-02 23:01:30 +08:00
Willie 28dacd19b8 feat(audit): expand TUI filter to search risk, status, severity, patterns, and files
Previously the audit TUI "/" filter only matched skill names. Now it
also searches risk label, status (blocked/warning/clean), max severity,
finding pattern names, and finding file names — making it easy to narrow
down results like `/critical`, `/exec-command`, or `/blocked`.
2026-03-02 23:01:30 +08:00
Willie 2fe90526f9 fix(audit): omit SARIF region for line-0 findings and add cross-skill to API
P1: SARIF startLine=0 is invalid per spec — GitHub Code Scanning rejects
it. Use *sarifRegion pointer with omitempty so findings without line
numbers (tier, cross-skill, analyzability, content-integrity) produce
valid SARIF output without a region field.

P2: Server audit endpoint (handleAuditAll) now calls CrossSkillAnalysis
after collecting results, matching CLI behavior. Previously the API
returned only per-skill findings without cross-skill interaction checks.

Also guard fmt.Println() in auditFiltered() for structured output
consistency (same fix as auditInstalled in previous commit).
2026-03-02 23:01:30 +08:00
Willie 170c57d1de docs: add v0.16.8 changelog 2026-03-02 23:01:30 +08:00
Willie 23206306d8 fix(audit): prevent stdout pollution in structured output formats
Two issues caused red team test failures after --format flag introduction:

1. ss_capture helper merged stderr into stdout (2>&1), so the --json
   deprecation warning poisoned JSON parsing by jq. Fix: capture stderr
   to a temp file separately from stdout.

2. Two unguarded fmt.Println() calls in auditInstalled() printed blank
   lines to stdout even in JSON/SARIF/markdown mode. Fix: wrap in
   if !jsonOutput guard.

Also migrate all 39 --json invocations in red team tests to --format json
since --json is deprecated.
2026-03-02 23:01:30 +08:00
Willie 89c3586da6 feat(audit): add markdown output format and improve terminal layout
- Add --format markdown for self-contained audit reports (GitHub Issues/PRs)
- Simplify pterm box rendering: replace DefaultBox with separator-line style
- Remove unused SkillBox, SummaryBox, SkillDisplay, wrapText helpers
- Color Box titles cyan (consistent with HeaderBox)
- Add breathing room: blank lines around progress bar and after summary
- Show "skillshare audit (project)" header title in project mode
- Append elapsed time to cross-skill synthetic results to fix slice mismatch
2026-03-02 23:01:30 +08:00
Willie 87268d3098 feat(audit): add cross-skill interaction detection
Two individually harmless skills can form an attack chain when installed
together (e.g., one reads credentials, another has network access).

After per-skill scans complete, the audit engine now extracts a capability
profile from each Result and checks for dangerous cross-skill combinations:

- cross-skill-exfiltration (HIGH): credential reader + network sender
- cross-skill-privilege-network (MEDIUM): privilege commands + network
- cross-skill-stealth (HIGH): stealth skill alongside high-risk skill

Rules only fire for complementary pairs (each skill lacks the other's
capability) to avoid duplicating per-skill findings. Results appear as
synthetic "_cross-skill" entry in all output formats (text, JSON, SARIF, TUI).
2026-03-02 23:01:30 +08:00
Willie 50e5e115c0 feat(audit): add dataflow taint tracking for cross-line exfiltration
Adds forward taint propagation analysis that detects multi-line data
exfiltration patterns where sensitive data flows through variables or
temp files before reaching a network sink.

Tracks three taint sources: credential file reads (~/.ssh, .env, etc.),
sensitive env var references ($TOKEN, $API_KEY, etc.), and command
substitution outputs. Propagates taint through variable assignments,
pipe chains, and temp file redirections. Generates HIGH-severity
dataflow-taint findings when tainted data reaches network commands.

- Add ScanShellDataflow for shell scripts and ScanMarkdownDataflow
  for fenced code blocks in markdown
- Add DeduplicateDataflow to avoid duplicate findings with existing
  per-line pattern rules
- Integrate into scanSkillImpl and ScanFileWithRules scan paths
- Can be disabled via audit-rules.yaml (id: dataflow-taint)
2026-03-02 23:01:30 +08:00
Willie 85508dcea8 docs(audit): add analyzability score section and missing rule IDs
The analyzability score feature (committed in ae7bd21) was missing
dedicated documentation. Also backfills content-oversize (from 3ad814d)
which was never added to the docs.

- Add "Analyzability Score" section explaining score meaning, threshold,
  exclusions, and CLI/JSON output format
- Add content-oversize to Content Integrity table
- Add low-analyzability to LOW/INFO severity listing
- Add low-analyzability (INFO) and content-oversize (MEDIUM) to
  Built-in Rule IDs table
- Update :::note block to mention new structural/analyzability checks
2026-03-02 23:01:30 +08:00
Willie b6652f11a0 feat(audit): add command safety tiering (T0–T5) for behavioral classification
Classify every shell command in skill files into 6 behavioral tiers
(read-only, mutating, destructive, network, privilege, stealth) as an
orthogonal dimension to pattern-based severity. This lets audit report
"what kind of actions" a skill performs, not just "which known patterns
it matches."

- Add tier engine with 80+ command mappings and stealth regex patterns
- Detect tiers in scripts and Markdown fenced code blocks separately
- Generate combination findings: T2+T3→HIGH, T5→CRITICAL, T3>5→MEDIUM
- Display tier profile in CLI text, TUI detail panel, and JSON/API output
- Exclude .skillshare-meta.json from totalBytes to fix analyzability ratio
- Document tier definitions, profile output, and combination findings
2026-03-02 23:01:30 +08:00
Willie 787c46c7c3 fix(tui): improve gray text contrast on dark terminals
Bump Dim 245→247 and Faint 239→242 for better readability on
dark terminal backgrounds without losing visual hierarchy.
2026-03-02 23:01:30 +08:00
Willie 71bf0969be feat(audit): show analyzability score in TUI detail panel and summary
- Detail panel: show per-skill "Auditable: X%" with green/yellow color
- Summary footer: append "Auditable: X% avg" to the status bar
2026-03-02 23:01:30 +08:00
Willie 8e83495200 feat(audit): add analyzability score and pre-commit hook
Analyzability score measures what percentage of a skill's content is
auditable plaintext vs binary/non-scannable. Surfaces in CLI text
output, JSON, SARIF, and Web UI API responses.

- Add TotalBytes, AuditableBytes, Analyzability fields to audit.Result
- Emit INFO-level low-analyzability finding when score < 70%
- Show "Auditable: X%" in per-skill and summary text output
- Expose analyzability in server API (auditResultResponse + auditSummary)
- Add .pre-commit-hooks.yaml for pre-commit framework integration
- Add pre-commit hook recipe docs and audit.md cross-references
2026-03-02 23:01:30 +08:00
Willie afb8951359 fix(audit): show spinner/progress on stderr for structured output formats
Previously --format json/sarif completely suppressed spinner and progress
bar, making the CLI appear frozen during long scans.

Now spinner/progress output is redirected to stderr via ProgressWriter,
so progress indicators remain visible while structured data stays clean
on stdout. This follows the Unix convention: data → stdout, diagnostics
→ stderr.

Also:
- Extract fileTTY() shared helper (DRY IsTTY + isProgressTTY)
- Add format constants (formatText/JSON/SARIF) and isStructured()
- Capture/restore previous ProgressWriter in defer (defensive)
2026-03-02 23:01:30 +08:00
Willie 3bc9ad7574 feat(targets): add AstrBot, update Cline to universal .agents/skills
- Add AstrBot target (data/skills / ~/.astrbot/data/skills)
- Update Cline paths from ~/.cline/skills to ~/.agents/skills (global)
  and .cline/skills to .agents/skills (project)
- Update website docs: add AstrBot badge/row, update Cline paths,
  add Cline to universal agents info box
2026-03-02 23:01:30 +08:00
Willie 8ef6f113af docs(recipes): add SARIF GitHub Actions workflow to CI/CD recipe
- Add GitHub Actions with SARIF upload example
- Update existing examples to use --format json instead of --json
- Add SARIF variation note and verification step
2026-03-02 23:01:30 +08:00
Willie 3af76ff4b9 docs(audit): add SARIF output format and --format flag documentation
- Add --format flag to Options table, mark --json as deprecated
- Add SARIF output section with severity mapping table
- Add GitHub Actions Code Scanning example with SARIF upload
- Update usage examples and recommended workflow
2026-03-02 23:01:30 +08:00
Willie 11668b8f0a feat(audit): add --format flag with sarif/json/text + deprecate --json
- Add --format <text|json|sarif> flag to audit command
- Deprecate --json in favor of --format json (with stderr warning)
- SARIF output uses ToSARIF() from internal/audit/sarif.go
- Suppress UI (spinners, progress bars) for all structured outputs
- Update auditPath/auditSkillByName to accept format string
- Update help text with new flag and examples
- Add 3 integration tests: FormatSARIF, FormatJSON, JSONDeprecation
2026-03-02 23:01:30 +08:00
Willie 043a47e57a feat(audit): add SARIF 2.1.0 conversion (internal/audit/sarif.go)
Add ToSARIF() function that converts audit Results into SARIF 2.1.0
format for CI/CD integration (GitHub Code Scanning, etc.).

- 12 structs modeling the SARIF schema subset we need
- Severity mapping: CRITICAL/HIGH→error, MEDIUM→warning, LOW/INFO→note
- Rule deduplication by pattern (first occurrence wins)
- SARIFOptions for tool version and base URI
- 4 test cases: empty, findings, severity mapping, JSON round-trip
2026-03-02 23:01:30 +08:00
Willie 0712368668 feat(devc): add make devc shortcut to enter devcontainer from terminal
Adds scripts/devcontainer_shell.sh that detects a running devcontainer
and opens an interactive shell (or runs a one-off command). Registered
as `make devc` / `mise run devc`. Also consolidates README recent
updates to one entry per minor series and updates the devcontainer
skill with the new entry point.
2026-03-02 10:05:57 +08:00
Willie 38f8f1c796 fix(symlink): resolve symlinked source/target dirs across all Walk callsites
filepath.Walk/WalkDir silently skip symlinked root directories because
os.Lstat sees the root as a non-directory symlink and never enters it.
This affected update, uninstall, reconcile, and server handlers when
the source directory was a symlink (common with dotfiles managers).

Extract ResolveSymlink() from sync.go into internal/utils/path.go and
apply it at every filepath.Walk/WalkDir callsite on source/target dirs.

Also add containment guards to resolveGroupSkills (uninstall) and
resolveGroupUpdatable (update) to reject group directories that are
symlinks pointing outside the source tree.
v0.16.7
2026-03-02 10:05:57 +08:00
Willie 32a29c8e91 fix(upgrade): clear prompt lines to preserve tree layout
Upgrade prompts ("Install built-in skill?" and "Upgrade to vX?")
left their input lines visible after the user responded, breaking
the tree-drawing structure. Add ui.ClearLines() to erase prompt
lines via ANSI cursor-up + clear-line, so StepEnd connects cleanly
to the preceding tree node. No-op on non-TTY.
2026-03-02 10:05:57 +08:00
Willie 8a820bbe5e docs: add symlinked directory sync E2E runbook
Covers 13 test scenarios for dotfiles manager symlink support:
symlinked source/target, chained symlinks, merge/copy modes,
status/diff/list/collect through symlinks, and idempotency.
2026-03-02 10:05:57 +08:00
Willie c426a801d7 fix(sync): preserve external symlinks during sync (dotfiles manager support)
When source or target directories are symlinks managed by external tools
(e.g., dotfiles managers), sync would incorrectly delete them during
mode conversion. This change:

- Add resolveWalkRoot() so filepath.Walk follows symlinked source dirs
- Add isSymlinkToSource() with canonicalization to distinguish internal
  symlink-mode targets from external symlinks (alias-safe)
- Protect external target symlinks in both merge and copy mode
- Allow FindLocalSkills to scan through external symlinked targets
- Handle external symlinks in CheckStatusMerge as normal directories
2026-03-02 10:05:57 +08:00
Willie d1370c0f98 fix(sync): preserve external symlinks in merge/copy mode conversions
When a target directory is an external symlink (e.g., dotfiles manager
pointing ~/.claude/skills/ elsewhere), sync previously deleted it
unconditionally during symlink→merge/copy mode conversion. This also
affected DiscoverSourceSkills which failed to traverse symlinked source
directories because filepath.Walk uses Lstat on root.

Changes:
- Add resolveWalkRoot() helper; use in both Discover functions so
  filepath.Walk enters symlinked source directories
- Add isSymlinkToSource() to distinguish source-pointing symlinks
  (symlink mode residue, safe to remove) from external symlinks
- Pass explicit sourcePath to SyncTargetMergeWithSkills and
  SyncTargetCopyWithSkills for reliable symlink origin detection
- Fix FindLocalSkills to use utils.ResolveLinkTarget (handles relative
  symlinks correctly) and follow external symlinks for scanning
- Fix CheckStatusMerge to follow external symlinks instead of returning
  StatusConflict
- Add 17 unit tests and 6 integration tests covering symlinked source,
  target, both, chained symlinks, idempotency, prune, and pull
2026-03-02 10:05:57 +08:00
Willie d8fb76d33d fix(restore): handle ReadDir error to prevent accidental backup deletion
os.ReadDir failure was silently ignored, causing otherTargets to be 0
and triggering removal of the entire timestamp directory instead of
just the target subdirectory. Now returns an error early.

Also adds diff TUI expand test from previous session.
v0.16.6
2026-03-02 02:23:50 +08:00
Willie 8e5efe36f6 docs: add v0.16.6 changelog entry
Covers diff TUI, --patch/--stat flags, glob pattern matching,
trash/restore TUIs, Homebrew-aware version check, and bug fixes.
2026-03-02 02:23:50 +08:00
Willie 7a22b781f2 feat(diff): async expand with spinner and support all diff types
- Add loading spinner while computing file diffs (prevents TUI freeze)
- Compute file diffs in parallel using sync.WaitGroup
- Support expanding "local only" and "remove" items (not just modify/add)
- Populate dstDir on remove/orphan items for file listing
- Relax ensureFiles to work with dstDir-only entries
- Add stale result guard when navigating during async load
2026-03-02 02:23:50 +08:00
Willie b371050078 feat(skills): add devcontainer skill for AI-guided container execution
Teaches AI assistants when and how to run CLI commands, tests, and
debugging inside the devcontainer instead of on the host. Covers
ssenv isolation, credential-helper, web UI, and common pitfalls.
2026-03-02 02:23:50 +08:00
Willie ba894dc5a6 docs: update website docs for v0.16.* features
Cross-validate and fix docs against source code:
- diff: fix merge mode description (no manifest-based orphans)
- backup: fix "What Gets Backed Up" (symlinks now followed)
- restore: add interactive TUI section and --no-tui flag
- trash: add SKILL.md preview, ls/rm aliases
- version: fix example, add Homebrew-aware update notifications
- install: add shell glob protection tip
- update: add basename matching note for glob patterns
- uninstall: add top-level-only matching note
- README: consolidate 0.16.* highlights
2026-03-02 02:23:50 +08:00