`make devc` now builds, initialises, and enters the devcontainer in one
step — no VS Code required. A unified `scripts/devc.sh` replaces the old
`devcontainer_shell.sh` with full lifecycle subcommands (up/shell/down/
restart/reset/status).
Key changes:
- Dockerfile Stage 2 copies node+pnpm from ui-builder (removes need for
devcontainer feature, benefits sandbox playground too)
- profile.d scripts moved from setup.sh → start-dev.sh so they survive
container recreation (down → up) without re-running full setup
- Volume-based sentinel (~/.devcontainer-initialized) lets devc.sh skip
setup.sh when volumes persist, cutting restart to ~2s
- Go toolchain PATH added to profile.d (login shell was losing it)
- Makefile/mise.toml gain devc-up/-down/-restart/-reset/-status targets
- Website docs updated with terminal-first flow and CLI path in diagrams
Remove rules that generated excessive false positives:
- source-repository-link (HIGH): legitimate docs links flagged too often;
external-link (LOW) already covers the same URLs
- env-access (MEDIUM): process.env references are ubiquitous in JS skills
- obfuscation-1 (long base64): caught README badges and binary data
Recalibrate credential-access severity levels to reduce alert fatigue:
- etc-passwd/sudoers: HIGH → MEDIUM (read-only system files, not secrets)
- shell-history, openvpn: MEDIUM → LOW (low-impact reconnaissance)
- auth-log: LOW → INFO (log files, no direct credential exposure)
Update all affected unit tests, integration tests, red team assertions,
skill references, and website docs to match.
P1: mergeYAMLRules Phase 2 used full-object replacement for overlays
without Enabled set, causing severity-only entries ({id, severity}) to
wipe regex/pattern/message from the base rule. compileRules then failed
with "empty regex". Now uses field-level merge: only entries with Regex
do full replacement; otherwise Enabled and Severity are patched
individually.
P2: TogglePattern enable only removed pattern-level disable entries,
leaving ID-level {id: "x", enabled: false} untouched — both builtin
and custom rules. Now clearDisableForPattern matches by builtin ID set
OR by r.Pattern == pattern, covering custom rules in the same group.
Implement a full bubbletea TUI with two navigation levels:
- Level 1 (patterns): shows pattern categories with rule count, disabled
count, and max severity; press Enter to drill in, d to toggle pattern
- Level 2 (rules): shows individual rules with severity and status; detail
panel shows full ID, regex, message, source; d toggles single rule,
D toggles entire pattern, Esc returns to Level 1
Also adds audit.ResetGlobalCache() to clear cached rules after YAML
mutations, enabling live-reload within the TUI session.
Introduce rules_list.go with exported types and functions for listing
all audit rules with their enable/disable status and source layer
(builtin/global/project). Includes PatternSummary for grouped stats
and UniquePatterns for pattern enumeration. Disabled rules appear in
listings with Enabled=false so UIs can display toggle state.
Extend mergeYAMLRules to handle overlay entries that specify a pattern
but no id — these apply to all base rules sharing that pattern name.
Processing uses two phases:
1. Pattern-level overlays (bulk disable / severity override)
2. ID-level overlays (can override pattern-level, e.g. re-enable
an individual rule after a pattern-level disable)
An explicit enabled:true in an id-level overlay clears a disabled flag
set by a pattern-level overlay.
Update CHANGELOG.md and website changelog with v0.16.9 entry covering
interpreter tier (T6), expanded prompt injection/credential access
detection, and regex bypass fixes. Sync audit.md with new rule IDs
and detection descriptions. Add contributor reneleonhardt to README.
Strengthen the audit engine with new detection capabilities inspired by
skilld's sanitization research and Snyk ToxicSkills findings:
- Expand prompt-injection-1 to detect OVERRIDE:/IGNORE:/ADMIN:/ROOT: prefixes
- Add prompt-injection-2: agent directive XML tags (<system>, <instructions>, etc.)
- Add prompt-injection-3: DEVELOPER MODE, JAILBREAK, DAN MODE directives
- Add data-exfiltration-2: external images with query params (exfil vector)
- Add credential-access-3/4: /etc/shadow, /etc/passwd and related system files
- Add TierInterpreter (T6): classify python/node/ruby/perl/lua/php as
Turing-complete runtimes separate from build tools
- Add tier-interpreter and tier-interpreter-network combination findings
- Add cross-skill-cred-interpreter rule for credential × interpreter pairs
- Update docs to reflect 38 rules and new tier/cross-skill patterns
pterm's cursor package writes hide/show ANSI codes (\x1b[?25l/h)
directly to os.Stdout, bypassing WithWriter(). The previous fix
(SetProgressWriter to stderr) was insufficient because pterm still
created progress bar objects that triggered cursor.Hide()/Show().
Add SuppressProgressToStderr() which both redirects ProgressWriter
and forces isProgressTTY() to return false, preventing pterm
components from being instantiated at all. Extract assertNoANSI
test helper and cover all three structured formats (JSON, SARIF,
Markdown).
Also update pre-commit E2E runbook with steps 10-11 (framework
integration tests) and add pre-commit-hook recipe to sidebar.
- vercel/skills now supports GitLab and any git URL (not GitHub-only)
- vercel/skills now has server-side audit via Snyk for catalog skills
- Reposition skillshare audit advantage as customizable local scanning
(custom rules, thresholds, offline, SARIF/JSON output, pre-commit)
- Add custom audit rules, pre-commit hook, audit formats to comparison
- Add ai_docs/tests/precommit_audit_hook_runbook.md (9-step E2E test
for skillshare audit -p as pre-commit hook)
- Fix cli-e2e-test SKILL.md: clarify init -p has separate flag set from
global init; add audit rule ID vs pattern name guidance; add project
mode init example to container templates; add two new checklist items
- Update CHANGELOG.md with pre-commit hook, audit TUI filter, O(N)
cross-skill rewrite, and SARIF line-0 fix entries
Replace nested pair-checking loop with set-based approach:
- Single pass builds capability sets (credReaders, netSenders, etc.)
- Each rule checks non-empty sets → one summary finding per rule
- 100k skills: ~15ms vs ~30s+ (benchmark included)
- Use DiscoverSourceSkillsLite for audit discovery (skip frontmatter)
- Use patternDataflowTaint constant instead of raw string
Previously the audit TUI "/" filter only matched skill names. Now it
also searches risk label, status (blocked/warning/clean), max severity,
finding pattern names, and finding file names — making it easy to narrow
down results like `/critical`, `/exec-command`, or `/blocked`.
P1: SARIF startLine=0 is invalid per spec — GitHub Code Scanning rejects
it. Use *sarifRegion pointer with omitempty so findings without line
numbers (tier, cross-skill, analyzability, content-integrity) produce
valid SARIF output without a region field.
P2: Server audit endpoint (handleAuditAll) now calls CrossSkillAnalysis
after collecting results, matching CLI behavior. Previously the API
returned only per-skill findings without cross-skill interaction checks.
Also guard fmt.Println() in auditFiltered() for structured output
consistency (same fix as auditInstalled in previous commit).
Two issues caused red team test failures after --format flag introduction:
1. ss_capture helper merged stderr into stdout (2>&1), so the --json
deprecation warning poisoned JSON parsing by jq. Fix: capture stderr
to a temp file separately from stdout.
2. Two unguarded fmt.Println() calls in auditInstalled() printed blank
lines to stdout even in JSON/SARIF/markdown mode. Fix: wrap in
if !jsonOutput guard.
Also migrate all 39 --json invocations in red team tests to --format json
since --json is deprecated.
- Add --format markdown for self-contained audit reports (GitHub Issues/PRs)
- Simplify pterm box rendering: replace DefaultBox with separator-line style
- Remove unused SkillBox, SummaryBox, SkillDisplay, wrapText helpers
- Color Box titles cyan (consistent with HeaderBox)
- Add breathing room: blank lines around progress bar and after summary
- Show "skillshare audit (project)" header title in project mode
- Append elapsed time to cross-skill synthetic results to fix slice mismatch
Two individually harmless skills can form an attack chain when installed
together (e.g., one reads credentials, another has network access).
After per-skill scans complete, the audit engine now extracts a capability
profile from each Result and checks for dangerous cross-skill combinations:
- cross-skill-exfiltration (HIGH): credential reader + network sender
- cross-skill-privilege-network (MEDIUM): privilege commands + network
- cross-skill-stealth (HIGH): stealth skill alongside high-risk skill
Rules only fire for complementary pairs (each skill lacks the other's
capability) to avoid duplicating per-skill findings. Results appear as
synthetic "_cross-skill" entry in all output formats (text, JSON, SARIF, TUI).
Adds forward taint propagation analysis that detects multi-line data
exfiltration patterns where sensitive data flows through variables or
temp files before reaching a network sink.
Tracks three taint sources: credential file reads (~/.ssh, .env, etc.),
sensitive env var references ($TOKEN, $API_KEY, etc.), and command
substitution outputs. Propagates taint through variable assignments,
pipe chains, and temp file redirections. Generates HIGH-severity
dataflow-taint findings when tainted data reaches network commands.
- Add ScanShellDataflow for shell scripts and ScanMarkdownDataflow
for fenced code blocks in markdown
- Add DeduplicateDataflow to avoid duplicate findings with existing
per-line pattern rules
- Integrate into scanSkillImpl and ScanFileWithRules scan paths
- Can be disabled via audit-rules.yaml (id: dataflow-taint)
The analyzability score feature (committed in ae7bd21) was missing
dedicated documentation. Also backfills content-oversize (from 3ad814d)
which was never added to the docs.
- Add "Analyzability Score" section explaining score meaning, threshold,
exclusions, and CLI/JSON output format
- Add content-oversize to Content Integrity table
- Add low-analyzability to LOW/INFO severity listing
- Add low-analyzability (INFO) and content-oversize (MEDIUM) to
Built-in Rule IDs table
- Update :::note block to mention new structural/analyzability checks
Classify every shell command in skill files into 6 behavioral tiers
(read-only, mutating, destructive, network, privilege, stealth) as an
orthogonal dimension to pattern-based severity. This lets audit report
"what kind of actions" a skill performs, not just "which known patterns
it matches."
- Add tier engine with 80+ command mappings and stealth regex patterns
- Detect tiers in scripts and Markdown fenced code blocks separately
- Generate combination findings: T2+T3→HIGH, T5→CRITICAL, T3>5→MEDIUM
- Display tier profile in CLI text, TUI detail panel, and JSON/API output
- Exclude .skillshare-meta.json from totalBytes to fix analyzability ratio
- Document tier definitions, profile output, and combination findings
Analyzability score measures what percentage of a skill's content is
auditable plaintext vs binary/non-scannable. Surfaces in CLI text
output, JSON, SARIF, and Web UI API responses.
- Add TotalBytes, AuditableBytes, Analyzability fields to audit.Result
- Emit INFO-level low-analyzability finding when score < 70%
- Show "Auditable: X%" in per-skill and summary text output
- Expose analyzability in server API (auditResultResponse + auditSummary)
- Add .pre-commit-hooks.yaml for pre-commit framework integration
- Add pre-commit hook recipe docs and audit.md cross-references
Previously --format json/sarif completely suppressed spinner and progress
bar, making the CLI appear frozen during long scans.
Now spinner/progress output is redirected to stderr via ProgressWriter,
so progress indicators remain visible while structured data stays clean
on stdout. This follows the Unix convention: data → stdout, diagnostics
→ stderr.
Also:
- Extract fileTTY() shared helper (DRY IsTTY + isProgressTTY)
- Add format constants (formatText/JSON/SARIF) and isStructured()
- Capture/restore previous ProgressWriter in defer (defensive)
- Add GitHub Actions with SARIF upload example
- Update existing examples to use --format json instead of --json
- Add SARIF variation note and verification step
- Add --format flag to Options table, mark --json as deprecated
- Add SARIF output section with severity mapping table
- Add GitHub Actions Code Scanning example with SARIF upload
- Update usage examples and recommended workflow
- Add --format <text|json|sarif> flag to audit command
- Deprecate --json in favor of --format json (with stderr warning)
- SARIF output uses ToSARIF() from internal/audit/sarif.go
- Suppress UI (spinners, progress bars) for all structured outputs
- Update auditPath/auditSkillByName to accept format string
- Update help text with new flag and examples
- Add 3 integration tests: FormatSARIF, FormatJSON, JSONDeprecation
Add ToSARIF() function that converts audit Results into SARIF 2.1.0
format for CI/CD integration (GitHub Code Scanning, etc.).
- 12 structs modeling the SARIF schema subset we need
- Severity mapping: CRITICAL/HIGH→error, MEDIUM→warning, LOW/INFO→note
- Rule deduplication by pattern (first occurrence wins)
- SARIFOptions for tool version and base URI
- 4 test cases: empty, findings, severity mapping, JSON round-trip
Adds scripts/devcontainer_shell.sh that detects a running devcontainer
and opens an interactive shell (or runs a one-off command). Registered
as `make devc` / `mise run devc`. Also consolidates README recent
updates to one entry per minor series and updates the devcontainer
skill with the new entry point.
filepath.Walk/WalkDir silently skip symlinked root directories because
os.Lstat sees the root as a non-directory symlink and never enters it.
This affected update, uninstall, reconcile, and server handlers when
the source directory was a symlink (common with dotfiles managers).
Extract ResolveSymlink() from sync.go into internal/utils/path.go and
apply it at every filepath.Walk/WalkDir callsite on source/target dirs.
Also add containment guards to resolveGroupSkills (uninstall) and
resolveGroupUpdatable (update) to reject group directories that are
symlinks pointing outside the source tree.
Upgrade prompts ("Install built-in skill?" and "Upgrade to vX?")
left their input lines visible after the user responded, breaking
the tree-drawing structure. Add ui.ClearLines() to erase prompt
lines via ANSI cursor-up + clear-line, so StepEnd connects cleanly
to the preceding tree node. No-op on non-TTY.
Covers 13 test scenarios for dotfiles manager symlink support:
symlinked source/target, chained symlinks, merge/copy modes,
status/diff/list/collect through symlinks, and idempotency.
When source or target directories are symlinks managed by external tools
(e.g., dotfiles managers), sync would incorrectly delete them during
mode conversion. This change:
- Add resolveWalkRoot() so filepath.Walk follows symlinked source dirs
- Add isSymlinkToSource() with canonicalization to distinguish internal
symlink-mode targets from external symlinks (alias-safe)
- Protect external target symlinks in both merge and copy mode
- Allow FindLocalSkills to scan through external symlinked targets
- Handle external symlinks in CheckStatusMerge as normal directories
When a target directory is an external symlink (e.g., dotfiles manager
pointing ~/.claude/skills/ elsewhere), sync previously deleted it
unconditionally during symlink→merge/copy mode conversion. This also
affected DiscoverSourceSkills which failed to traverse symlinked source
directories because filepath.Walk uses Lstat on root.
Changes:
- Add resolveWalkRoot() helper; use in both Discover functions so
filepath.Walk enters symlinked source directories
- Add isSymlinkToSource() to distinguish source-pointing symlinks
(symlink mode residue, safe to remove) from external symlinks
- Pass explicit sourcePath to SyncTargetMergeWithSkills and
SyncTargetCopyWithSkills for reliable symlink origin detection
- Fix FindLocalSkills to use utils.ResolveLinkTarget (handles relative
symlinks correctly) and follow external symlinks for scanning
- Fix CheckStatusMerge to follow external symlinks instead of returning
StatusConflict
- Add 17 unit tests and 6 integration tests covering symlinked source,
target, both, chained symlinks, idempotency, prune, and pull
os.ReadDir failure was silently ignored, causing otherTargets to be 0
and triggering removal of the entire timestamp directory instead of
just the target subdirectory. Now returns an error early.
Also adds diff TUI expand test from previous session.
- Add loading spinner while computing file diffs (prevents TUI freeze)
- Compute file diffs in parallel using sync.WaitGroup
- Support expanding "local only" and "remove" items (not just modify/add)
- Populate dstDir on remove/orphan items for file listing
- Relax ensureFiles to work with dstDir-only entries
- Add stale result guard when navigating during async load
Teaches AI assistants when and how to run CLI commands, tests, and
debugging inside the devcontainer instead of on the host. Covers
ssenv isolation, credential-helper, web UI, and common pitfalls.