Commit Graph
780 Commits
Author SHA1 Message Date
Willie b2a9ebbaab feat(tools): scaffold runbook test runner with types 2026-03-11 04:53:08 +08:00
Willie 5aa7cb4490 chore: update readme 2026-03-09 13:52:34 +08:00
Willie 7284d38d79 fix(ui): cap progress counter and guard RenderInlineBar against zero total
Increment() now clamps p.current to p.total so concurrent callers
cannot produce a "11/10" display. RenderInlineBar() returns a safe
empty bar when total <= 0 instead of panicking on division by zero.
v0.16.14
2026-03-09 12:47:03 +08:00
Willie ad713bc669 fix(ui): render phase headers inline with progress bar to prevent visual duplication
Phase transitions during batch update (e.g. pull repos → update skills) were
printing separate PhaseHeader lines that created a second visible progress bar.
Now phases use ProgressBar.SetHeader() which overwrites the header line in place
via ANSI cursor-up, keeping a single continuous bar from start to finish.
2026-03-09 12:47:03 +08:00
Willie 404ad0afde fix(tui): replace 256-color gray gradient with SGR dim in skill path rendering
colorSkillPath() and colorSkillPathBold() used Color("241")~Color("249")
gradient for subdirectory segments — fixed palette grays that render
inconsistently across terminal themes. Replace with tc.Dim (SGR faint).
2026-03-09 12:47:03 +08:00
Willie ae80756b9a feat(ui): replace bright-black gray with SGR dim for consistent terminal rendering
\033[90m (bright black) renders too dark on many terminals and themes.
Replace with \x1b[0;2m (SGR dim attribute) which adapts to any foreground.

Changes:
- Add Dim constant and DimText() helper in internal/ui
- Replace all pterm.Gray() calls with DimText() in pterm.go
- Replace all ui.Gray references with ui.Dim across cmd/skillshare/
- Replace fixed 256-color grays (Color("247"/"242")) with lipgloss
  .Faint(true) in TUI styles (tui_colors.go, list_tui.go, log_tui.go)
- Fix progress bar layout: put count after % at fixed position,
  title last (truncated) — prevents count from being pushed off-screen
- Extract duplicate renderBar() from diff.go and search_batch.go
  into shared ui.RenderInlineBar() helper
2026-03-09 12:47:03 +08:00
Willie cca896dd91 feat(ui): replace pterm progress bar with custom fixed-width bar
Replace pterm's ProgressbarPrinter with a custom implementation using
\r overwrite for flicker-free rendering. The new bar uses block chars
(■/・), orange color with dim text for labels, and dynamic title width
based on terminal size.

Key improvements:
- Render throttling (50ms) prevents I/O overload on large skill counts
- Git progress messages auto-normalized in UpdateTitle
- Final 100% frame preserved on screen after Stop()
- Cursor hidden during progress, restored on completion
2026-03-09 12:47:03 +08:00
Willie 401f526bce chore: update readme 2026-03-07 13:10:24 +08:00
Willie 7c582cbe21 docs: update v0.16.13 changelog to match project style
Expand bug fix descriptions, add grouped layout ASCII example,
and sync website changelog.
v0.16.13
2026-03-06 23:10:48 +08:00
Willie 657b833569 fix: suppress devcontainer redirect for -j flag and show tracked badge in filter mode
- Add -j short flag to wants_machine_output() in devcontainer wrapper,
  preventing stderr banner noise for `skillshare list -j` etc.
- Show tracked repo name badge on skill items so filtered results remain
  distinguishable when group headers are absent. Two tracked skills from
  different repos now render with their repo origin visible.
2026-03-06 23:10:48 +08:00
Willie 0e7bfea8ee feat(tui): add structured filter tags to list TUI
Support key:value tag syntax in the `/` filter input for precise
skill filtering by type, group directory, and repo name:

  t:tracked g:security audit
  → type=tracked AND group contains "security" AND free text "audit"

Tags: t:/type: (tracked/remote/local/github), g:/group: (substring),
r:/repo: (substring). Multiple tags use AND logic. Unknown tags
gracefully degrade to free text. Optional `_` prefix on type values
(e.g. t:_tracked) and short alias t:track are accepted.

Filter input placeholder and help line update to show available tags
when filtering mode is active.
2026-03-06 23:10:48 +08:00
Willie 7015aaf611 refactor(tui): unify duplicated group/render logic between list and audit TUIs
- Extract renderPrefixRow shared helper (was duplicated in renderSkillRow
  and auditDelegate.Render)
- Remove auditGroupItem type, reuse groupItem from list_tui_item.go
- Remove skipAuditGroupItem, reuse skipGroupItem
- Simplify buildGroupedItems multi-group check to match audit's
  map-based approach; delete countRepoGroups
- Fix auditFooterLines hot-path: check len(ByCategory) instead of
  calling formatCategoryBreakdownTUI on every render
- Simplify baseSkillPath redundant branch
2026-03-06 23:10:48 +08:00
Willie c085f10a1f fix(tui): skip group separators when single group and fix row truncation
- Skip group separator lines when all items belong to one group
- Fix row truncation: use ANSI-aware xansi.Truncate instead of
  stripping ANSI codes then counting runes (lost color + wrong width)
- Account for bodyStyle padding when calculating text truncation width
- Add MaxWidth to prevent lipgloss from wrapping long rows
2026-03-06 23:10:48 +08:00
Willie 8ddf886921 feat(tui): add grouped layout and dynamic panel height to audit TUI
- Add repo-grouped layout with separator lines (matching list TUI)
- Use custom auditDelegate with compact single-line rows and truncation
- Sort by repo key (tracked first) then severity within each group
- Widen left panel from 25%/[25,45] to 36%/[30,46] to prevent wrapping
- Dynamically calculate panel height based on actual footer line count
  instead of hardcoded overhead, maximizing list space
- Auto-skip group separator items on navigation
2026-03-06 23:10:48 +08:00
Willie a217e40e2b fix(audit): reduce color noise in CLI and TUI output
The audit summary used 10+ distinct colors on a single screen,
making it hard to focus on actionable information.

Changes:
- Threats line: remove per-category rainbow colors (8 colors → dim/bold)
- Severity c/h/m/l/i: zero values now gray, only non-zero get color
- Policy line: dim metadata (only STRICT/LEGACY get warning yellow)
- Passed count: no longer green (normal state needs no emphasis)
- Remove unused categoryStyle() and categoryColorCLI() functions

Design principle: quiet gray baseline with color only for items
that require user attention (failed count, aggregate risk).
2026-03-06 23:10:48 +08:00
Willie 0a0ac2ee57 feat(tui): redesign list panel with grouped layout and compact paths
- Add group separators: tracked repos and standalone skills are visually
  grouped with dim header lines showing repo name and count
- Compact skill paths: strip tracked repo prefix, show at most last 2
  path segments in list rows (full path in detail panel)
- Auto-skip group headers on navigation (up/down/page)
- Replace split Source/Sync sections with unified Details section,
  removing duplicate info already shown in header
- Narrow left panel ratio (42% → 36%) for more detail space
- Separator "/" without spaces for tighter list rows
- Rename local group to "standalone" to avoid confusion with local badge
- Adjust renderFactRow label width (9 → 12) for longer labels
2026-03-06 23:10:48 +08:00
Willie 9b5429a3fd feat(targets): add Warp, Purecode AI, Witsy targets
Add 3 new AI agent targets discovered from vercel-labs/skills PRs:
- warp: universal path (~/.agents/skills)
- purecode (alias: purecode-ai): ~/.purecode/skills (global), .agents/skills (project)
- witsy: universal path (~/.agents/skills)

Update website docs: badge grid, path table, alias table, universal
info box, and target counts (50+ → 55+).
2026-03-06 23:10:48 +08:00
Willie 5ae4c7ab93 fix(tui): improve detail panel readability
- Bold skill name in header for better distinction from list items
- Add spacing between name and metadata line
- Show full source URL instead of truncating at 50 chars
- Rename "Overview" section to "Description" to match frontmatter field
2026-03-06 23:10:48 +08:00
Willie f115ab5e0e fix(tui): show skill name and group in list detail panel
The detail panel header was rendered on L00 (same row as the list title),
making the skill name invisible. Push content to L01 with a leading newline
and use colorSkillPath for consistent group/name coloring matching the left
panel. Compress status/date/targets into a single metadata line to save
vertical space. Show full source URL and synced targets in Quick Facts.

Also suppress devcontainer stderr redirect message in --json/--format modes
and fix audit summary field name (analyzerCount → activeAnalyzers).
2026-03-06 23:10:48 +08:00
Willie 7223ac52f4 fix(sync): preserve non-json dry-run output stream
Keep sync dry-run diagnostics on stdout by default to avoid non-JSON behavior regressions. Introduce sync.DiagOutput so JSON mode can silence diagnostics via io.Discard at command entry and restore after execution. Update search JSON integration assertion to match fully silent progress behavior.
v0.16.12
2026-03-06 02:15:36 +08:00
Willie d707fc619b fix(cli): suppress stderr progress messages in --json mode
JSON mode stdout was already pure JSON, but stderr still emitted
progress lines (e.g. "Discovering skills...", "Found N local skill(s)")
which broke `2>&1 | jq .` pipelines. Remove the else-branch stderr
writes so --json mode is fully silent except for stdout JSON output.
2026-03-06 02:15:36 +08:00
Willie 6ad930f71d perf(cli): parallelize git dirty checks in status --json
Extract buildTrackedRepoJSON() that runs git.IsDirty concurrently via
goroutines + WaitGroup instead of sequential subprocess spawns per repo.
Also deduplicates the tracked-repo JSON loop between global and project
status paths, and optimizes skill counting to a single pass with a map.
2026-03-06 02:15:36 +08:00
Willie 0d59f15db4 refactor(cli): deduplicate JSON output helpers and fix ResolvePolicy semantics
- Extract writeJSONResult() to replace 5 identical write+silent-error trailers
- Replace local isRepoDirty() with existing git.IsDirty() (8 call sites)
- Use defer for suppressUIToDevnull restore instead of manual calls at each
  return site in install.go and update.go (prevents stdout leak on new paths)
- Fix ResolvePolicy always filling EnabledAnalyzers, which broke the
  nil-means-all contract for ForPolicy; add EffectiveAnalyzers() for display
- Simplify collectOutputJSON double map allocation
- Remove unnecessary string conversion in writeJSONError
2026-03-06 02:15:36 +08:00
Willie b366f619cb chore: formatting alignment and changelog jq example fix
- diff.go: align JSON struct field tags
- CHANGELOG: fix jq example (.errors → .details)
- analyzer_metadata: align map literal and test struct formatting
2026-03-06 02:15:36 +08:00
Willie 8ddf685aae fix(cli): wrap collect/sync JSON errors with jsonSilentError
collect --json and sync --json returned the raw error after writing
JSON, causing main() to print a duplicate plain-text error. Wrap with
jsonSilentError so main() exits non-zero silently.

Also fix sync --json skipping backup output that would corrupt stdout.
2026-03-06 02:15:36 +08:00
Willie 4535da1d01 refactor(cli): return updateResult from single-target update handlers
updateTrackedRepo and updateRegularSkill now return (updateResult, error)
instead of just error, so callers (including project mode and JSON output)
can accurately report updated/skipped/securityFailed/pruned counts.

Adapt cmdUpdateProject, cmdUpdateProjectBatch, updateAllProjectSkills,
and list_project.go TUI action to the new signatures.
2026-03-06 02:15:36 +08:00
Willie bcf31d851a fix(audit): show actual active analyzers in status --json output
When no explicit analyzer filter was configured, status --json reported
an empty analyzers array. Now ResolvePolicy backfills the full list of
built-in analyzer IDs so the JSON output reflects what actually runs.

Add Registry.IDs() helper with deduplication (markdownLinkAnalyzer and
staticAnalyzer share the "static" ID).
2026-03-06 02:15:36 +08:00
Willie 4b09d2ee3d fix(cli): redirect JSON-mode UI to /dev/null and add status --project --json
suppressUIToStderr was redirecting UI to stderr, but in environments
where stdout and stderr share the same terminal (e.g. docker exec),
all the spinner/progress/header output was still visible alongside
the JSON. Replace with suppressUIToDevnull which opens os.DevNull
for both os.Stdout and ui.ProgressWriter, producing zero visible
noise in --json mode.

Also add status --json support for project mode, reusing the same
JSON schema as global mode (source, skill_count, tracked_repos,
targets, audit, version).
2026-03-06 02:15:36 +08:00
Willie b5430e094b fix(cli): suppress UI output in --json mode for install, diff, uninstall
install --json: logo, spinners, and step output leaked to stdout,
corrupting machine-parseable JSON. Add suppressUIToStderr() around the
entire install flow, restoring stdout before writing JSON.

diff --project --json: spinner and progress display polluted stdout.
Skip spinner and progress creation in JSON mode, matching the existing
cmdDiffGlobal pattern.

uninstall --json: five error paths (discovery failure, no skills found,
glob detection, validation, preflight) returned plain-text errors instead
of JSON error envelopes. Wrap each with writeJSONError().

Add 8 integration tests (5 new failure cases + 3 confirming existing
behavior) with an assertPureJSON helper that validates stdout contains
only valid JSON with no leading/trailing noise.
2026-03-06 02:15:36 +08:00
Willie 9a12df02b4 fix(cli): restore argument validation for status --project mode
The --json addition accidentally removed the guard that rejects
unexpected positional arguments in project mode. Restore it so
`skillshare status --project foo` correctly returns an error
instead of silently ignoring the extra argument.
2026-03-06 02:15:36 +08:00
Willie 1a4de5ddd1 fix(cli): use errors.As for jsonSilentError check in main
Type assertion would break if the error gets wrapped via fmt.Errorf
with %w. errors.As handles wrapped errors correctly.
2026-03-06 02:15:36 +08:00
Willie 18cd0ecc94 fix(cli): preserve non-zero exit code for --json error paths
writeJSONError now returns a jsonSilentError sentinel that main()
recognises — it exits with code 1 without printing plain-text output
to stdout. This fixes a regression where --json errors (config load
failure, missing source dir, discovery failure) returned exit 0.

All writeJSONError call sites changed from the broken pattern:
  writeJSONError(err); return nil   // exit 0, wrong
to:
  return writeJSONError(err)        // exit 1, correct

Also applied the same fix to update.go error paths which had the
older pattern of writeJSONError(err) followed by return err (which
would print both JSON and plain text).

Added regression tests for sync and install error paths verifying
both non-zero exit code and valid JSON error output on stdout.
2026-03-06 02:15:36 +08:00
Willie 6b4a8782bd fix(cli): ensure --json mode outputs pure JSON to stdout
Address code review feedback from PR #67:

- Move all dry-run diagnostic messages (internal/sync) from stdout to
  stderr so they don't pollute JSON output
- Suppress UI output (spinners, headers, warnings) in uninstall --json
  mode by adding jsonOutput guards across all phases
- Return nil after writeJSONError to prevent dual output (JSON + plain
  text error) in install and sync commands
- Handle json.MarshalIndent error in writeJSONError with stderr fallback
- Merge duplicated discovery logic (JSON vs non-JSON branches) in sync,
  sync_project, diff, and collect using nullable spinner pattern
- Remove checkRepoDirty alias in status.go, call isRepoDirty directly
- Remove extractJSON test workaround — tests now assert stdout is valid
  JSON directly, enforcing the clean-stdout contract
2026-03-06 02:15:36 +08:00
Willie 71f560331b docs: add v0.16.12 changelog
Structured JSON output for 8 commands (sync, install, update,
uninstall, collect, target list, status, diff), bringing total
--json coverage to all 12 major CLI commands.
2026-03-06 02:15:36 +08:00
Willie 5c31332efb feat(skill): add --json assertion guidance to cli-e2e-test skill
Runbooks can now leverage structured JSON output for verification
instead of brittle text matching. Adds --json quick reference table
(12 commands), jq assertion patterns, and updated checklist/templates.
2026-03-06 02:15:36 +08:00
Willie 18bfe5ff96 feat(skill): improve built-in skill for v0.16.12
- Expand description from 160 to 708 chars with broader trigger keywords
  (targets, backup/restore, trash, hub, symlink/copy, include/exclude filters)
- Add Skill Hubs recipe section (hub add/list/remove/default/index)
- Add Scripting & CI/CD recipe section (12 --json commands)
- Add --json column to Quick Lookup table
- Fix backup row: correctly show ✗ for project mode (global-only)
- Split tui/ui rows: tui/upgrade are ✗, ui supports -p
- Add hub to command list
- Update AI Caller Rules: hardcoded secret detection, --no-tui commands,
  12 --json commands
- Add --json flag docs to reference files (install, update, uninstall,
  status, diff, sync, collect)

Eval results: 100% pass rate across 5 test cases (up from 80% in iteration 1).
Key fix: Quick Lookup backup ✗ resolved false project-mode claims.
2026-03-06 02:15:36 +08:00
Willie f03ba456c0 chore: update docs 2026-03-06 02:15:36 +08:00
Willie 9982c2ebb9 fix(cli): clean up --json output code after review
- Replace hasFlag loop with slices.Contains (stdlib)
- Deduplicate checkRepoDirty → delegate to isRepoDirty
- Add nil-receiver guard to diffProgress.stop() for consistency
- Return explicit error for status --json in project mode
- Use consistent error message in sync --json source-not-found path
2026-03-06 02:15:36 +08:00
Willie 02aa2b2a45 feat(cli): add --json output to 8 commands (Phase 1+2)
Add structured JSON output support for agent and CI/CD consumption:

Phase 1 (mutating): sync, install, update, uninstall, collect
Phase 2 (read-only): target list, status, diff

Key design decisions:
- Per-command JSON schema (no universal envelope)
- Shared helper: writeJSON() with recursive nil slice→[] conversion
- --json implies --force for mutating commands (skip prompts)
- TUI/spinners suppressed; progress goes to stderr, JSON to stdout
- 10 integration tests covering valid JSON, dry-run, nil slices

Also includes post-review cleanup:
- ensureEmptySlices now recurses into nested structs/slices
- Unified mode resolution via getTargetMode() (removed 4 duplicates)
- sync --json now creates backups (behavioral parity with non-JSON)
- targetList no longer double-parses --json flag
2026-03-06 02:15:36 +08:00
Willie 6730760215 feat(audit): add hardcoded secret detection (10 rules)
Detect inline API keys, tokens, and passwords in skill files via 10 new
hardcoded-secret-* rules (HIGH severity): Google API keys, AWS access
keys, GitHub PATs (classic + fine-grained), Slack tokens, OpenAI keys,
Anthropic keys, Stripe keys, PEM private key blocks, and generic
api_key/password assignments.

Closes a gap where GitHub Secret Scanning caught a Google API key in a
skill file but our audit engine missed it entirely.
v0.16.11
2026-03-05 02:34:24 +08:00
Willie 7e072c33c9 feat(ui): replace "Show more" pagination with virtualized scrolling
AuditPage: use Virtuoso with useWindowScroll for skill audit cards.
SyncPage: use Virtuoso with fixed-height container for diff items
(100+ threshold), flat render for small lists.
2026-03-05 02:13:21 +08:00
Willie 344b067806 feat(ui): add SSE streaming for update, check, and diff pages
Replace sequential POST loops and blocking useQuery calls with
Server-Sent Events for real-time progress feedback on Update, Check,
and Diff operations. Extract shared helpers to reduce duplication:

- initSSE() in middleware.go consolidates SSE preamble across 4 handlers
- createSSEStream() in client.ts unifies EventSource lifecycle management
- StreamProgressBar component replaces 3 near-identical progress bars
- handleDiff now delegates to computeTargetDiff (eliminates ~150 lines)
- Paginate audit results (20 cards + 10 findings per card) to prevent
  DOM overload with large skill counts
2026-03-05 02:13:21 +08:00
Willie 2af44f1d3f chore(skills): strengthen built-in skill descriptions and content
Improve all 5 active skills with pushy descriptions for better
triggering accuracy, following devcontainer as the gold standard.

- changelog: add trigger scenarios (release notes, version prep)
- cli-e2e-test: add trigger scenarios (runbook, E2E validation)
- codebase-audit: add 3 new audit dimensions (handler split, oplog
  coverage, web API consistency) and trigger scenarios
- implement-feature: add project patterns reference (handler split,
  dual-mode, TUI, web API, oplog) and trigger scenarios
- update-docs: expand scope to all 7 doc categories with code-to-doc
  mapping guide and trigger scenarios

Also remove empty .skillshare/skills/frontend/ directory.
2026-03-05 02:13:21 +08:00
Willie ae5708e48d feat(doctor): add skill integrity verification via file hash comparison
Detect local drift (modified/missing/added files) in installed skills
by comparing current SHA-256 hashes against stored .skillshare-meta.json
records. Skills without metadata are flagged as unverifiable warnings.
2026-03-05 02:13:21 +08:00
Willie ebf2aaf822 feat(audit): add metadata analyzer for supply-chain trust verification
Add metadataAnalyzer (skill scope) that cross-references SKILL.md
metadata against the actual git source from .skillshare-meta.json:

- publisher-mismatch (HIGH): description claims an org but repo owner
  differs (e.g. "from Acme Corp" but sourced from evil-fork)
- authority-language (MEDIUM): uses "official"/"verified" language but
  source is not a well-known organization

Both rules are disable-able via audit-rules.yaml. The analyzer reads
meta from disk (zero API signature changes) and avoids import cycles
by defining its own minimal metaJSON struct.
2026-03-05 02:13:21 +08:00
Willie 272735c607 feat(install): detect SSL certificate errors and show actionable guidance
When git operations fail due to SSL certificate issues (self-signed certs,
internal CAs), the error message now suggests GIT_SSL_CAINFO, GIT_SSL_NO_VERIFY,
and SSH as alternatives instead of showing raw git stderr.

Env vars like GIT_SSL_CAINFO are already inherited via os.Environ() in
gitCommand() — the actual gap was error detection and user guidance.
2026-03-05 02:13:21 +08:00
Willie 76c1904afb feat(ui): add SSE-based audit streaming and real-time progress
Add server-sent events endpoint for audit scans so the web UI can
display per-skill progress instead of waiting for the full batch.

Backend:
- Extract discoverAuditSkills and processAuditResults from handler
- Add handler_audit_stream.go with SSE streaming endpoint
- Register GET /api/audit/stream route with read-lock middleware
- Add CORS headers for SSE connections in middleware

Frontend:
- Add AuditStreamPanel and AuditResultCard components
- Wire streaming audit into AuditPage with start/stop controls
- Add useAuditStream hook and streamAudit API client method
- Add per-skill audit action on SkillDetailPage
- Add check-based update detection on UpdatePage
- Configure Vite proxy for SSE endpoint
2026-03-05 02:13:21 +08:00
Willie 0daafd20ee style(tui): remove detail panel box borders for cleaner layout
Replace bordered boxes around Source/Sync sections with simple
title + indented rows. Reserves brand yellow solely for selected
item indicator, reducing visual noise in the detail panel.
2026-03-05 02:13:21 +08:00
Willie 1aa8b5623c chore: update readme 2026-03-04 13:40:42 +08:00
Willie 5bfca0e12d docs: add v0.16.10 changelog, tui command page, and release notes
Add CHANGELOG and website changelog entries for v0.16.10 covering
sync extras and tui toggle features. Create dedicated tui command
reference page and register it in sidebar and commands index.
Bump built-in skill version to v0.16.10.
v0.16.10
2026-03-04 12:16:32 +08:00