Commit Graph
892 Commits
Author SHA1 Message Date
Willie 9b0146ab77 fix(extras): resolve lint warnings in extras list TUI
Replace WriteString(fmt.Sprintf(...)) with fmt.Fprintf for QF1012,
and use min/max builtins for tree scroll clamping.
2026-03-12 16:45:02 +08:00
Willie 947a5d33b3 feat(extras): add interactive TUI for extras list with browse, remove, sync, collect, and content viewer 2026-03-12 16:45:02 +08:00
Willie 2a9ddb0cf6 feat(extras): add TUI list item and delegate for extras list 2026-03-12 16:45:02 +08:00
Willie 4526b5a493 refactor(extras): extract buildExtrasListEntries for TUI reuse 2026-03-12 16:45:02 +08:00
Willie 9738e5238e refactor(extras): extract remove helpers for TUI reuse 2026-03-12 16:45:02 +08:00
Willie ee38d34513 refactor(diff): show extras by default, remove --extras/--all flags
Extras diff is now automatically included when extras are configured.
No need for explicit --extras or --all flags — simpler UX.

- Remove showExtras/showAll from diffRenderOpts
- Replace flag check with len(cfg.Extras) > 0
- Update integration test, built-in skill refs, website docs, changelog
2026-03-12 16:45:02 +08:00
Willie d756004e56 feat(extras): add extras reference docs, fix diff project mode, improve TUI
- Add references/extras.md covering all 4 subcommands (init, list,
  remove, collect) plus sync extras and diff --extras
- Update SKILL.md with dedicated Extras recipes section and reference link
- Update status.md with diff --extras/--all flags
- Fix sync.md: extras supports project mode (not global only), correct
  source path to include extras/ subdirectory
- Fix diff --extras not working in project mode (diff_project.go was
  missing collectExtrasDiff integration)
- Replace DefaultDelegate with custom diffItemDelegate so Extras
  separator renders as non-selectable group header (matching list TUI)
- Add skipDiffSeparator to prevent cursor landing on separator items
- Add Next Steps hints to extras detail panel in diff TUI
- Group Backup/Trash under "Storage" header in doctor output
- Remove extra leading spaces from doctor extras status lines
2026-03-12 16:45:02 +08:00
Willie cc93c4f0a4 fix(extras): add y/N confirm prompt to remove, clean up empty dirs
- extras remove: replace silent-exit warning with interactive [y/N]
  prompt; --force skips the prompt as before
- extras remove: after removing config entry, delete the source
  directory if empty and the parent extras/ directory if empty
- sync extras: clean up empty extras/ directory when no extras are
  configured (both global and project mode)
- Add removeEmptyDir helper and ExtrasParentDirProject path function
2026-03-12 16:45:02 +08:00
Willie 7a6e78783b fix(build): separate host and devcontainer binary output paths
Devcontainer `make build` previously wrote a Linux binary to
`bin/skillshare` via the shared volume mount, overwriting the host's
macOS binary and causing `exec format error`.

Introduce a `BINARY` variable (Makefile) / `SKILLSHARE_BINARY` env var
(mise) so devcontainer builds to `/usr/local/bin/skillshare` while the
host keeps `bin/skillshare`. Also update `scripts/test.sh` to respect
a pre-set `SKILLSHARE_TEST_BINARY` instead of unconditionally
overwriting it.
2026-03-12 16:45:02 +08:00
Willie 48f1d3767f fix(test): improve extras runbooks with jq assertions, idempotency, and init cleanup
- Replace python3 JSON parsing with native mdproof jq: assertions across
  extras_refactor_json_runbook (7 steps simplified)
- Add cat>> idempotency guards (sed -i cleanup) before YAML appends
- Add ssenv --init default extras cleanup in Step 1 of extras_commands
  and sync_extras runbooks to prevent false failures
- Rename runbook.json → mdproof.json (mdproof only reads mdproof.json)
- Move /tmp cleanup from step_setup to setup (per-runbook, not per-step)
  to avoid breaking cross-step dependencies
- Fix ensure-mdproof.sh to upgrade dev binary to latest release
- Add .mdproof/lessons-learned.md with 5 documented gotchas
- Update cli-e2e-test SKILL.md with assertion types, jq best practices,
  --init extras checklist item, and /mdproof skill collaboration
2026-03-12 16:45:02 +08:00
Willie 09ccd14266 fix(extras): resolve tilde expansion, unify headers, add doctor target warnings
Extras commands had multiple issues with tilde (~) path handling — Go
doesn't expand ~ (that's shell behavior), so paths like ~/.claude/rules
were treated as literal relative paths, creating bogus ~/  directories.

Key fixes:
- Export config.ExpandPath() and call it before os.Stat / sync operations
  in extras_list, sync_extras, extras_collect, and doctor
- Unify extras output headers to match target list style (single "Extras"
  header instead of per-extra headers, fix double-icon bug in list)
- Add per-target reachability warning in doctor for unreachable extras
  targets with expanded path display

Update all 3 E2E runbooks to use extras/<name>/ path layout, add /tmp
cleanup for idempotent re-runs, add migration test step, and create new
comprehensive extras_commands_runbook (18 steps covering init/list/remove/
collect/doctor/tilde/project-mode).

Improve cli-e2e-test skill with 4 new checklist items and 2 rules learned
from test friction (/tmp isolation, symlink write-through, cat>>
idempotency, extras path layout).
2026-03-12 16:45:02 +08:00
Willie 28d35e8a77 fix(ui): align CopyButton to design system, fix sidebar scroll, update lockfile
- CopyButton: add focus ring, active:scale-95, remove unused style prop
- FileViewerModal: use IconButton for close, Spinner for loading state
- SkillDetailPage: fix sticky sidebar not scrollable when content overflows viewport
- Update pnpm-lock.yaml for test dependencies added by PR #76
- Add salmonumbrella and daylamtayari to README contributors
2026-03-12 16:45:02 +08:00
Willie 990b4dc160 feat(extras): add TUI wizard for extras init, improve status display
Wire up the existing extras init TUI wizard so `extras init` without
arguments launches the interactive 5-phase flow. Add --no-tui flag for
scripting. Guard against silently swallowing --mode when launching TUI.

Redesign extras status output to match Targets section style using
ui.Status with per-target rows showing [mode] path (N files). Extract
shared printExtrasStatus helper to eliminate duplication between global
and project status. Add (project) label to project-mode header.

Clean up: delete duplicate extrasEffectiveMode in favor of
sync.EffectiveMode, remove redundant os.Stat TOCTOU in doctor.go
checkExtras, handle zero-targets edge case with a warning.
2026-03-12 16:45:02 +08:00
Willie 4e3b55a303 docs: update README latest version note to v0.17.0 2026-03-12 16:45:02 +08:00
Willie 04c669e0ba feat(website): clean design system for docs pages and add mdproof blog post
Redesign docs/non-homepage pages to match the ui/ dashboard's clean
aesthetic (solid borders, subtle blur shadows, clean border-radius)
while preserving the homepage's hand-drawn style via CSS modules.
Add blog post announcing skillshare's full migration to mdproof for
E2E testing.
2026-03-12 16:45:02 +08:00
Willie 9501b59874 docs: update v0.17.0 changelog with UI redesign and additional bug fixes
Add Web UI redesign section (clean design, table view, keyboard shortcuts,
onboarding tour) and two missing bug fixes (dotdir skipping during install
discovery, sync collision message). Sync website changelog from v0.16.15
to v0.17.0 entry. Update release notes with matching content.
2026-03-12 16:45:02 +08:00
Willie 91d22fbaf5 docs: fix extras source paths and remove incorrect global-only claims
Extras source dir is under extras/ subdirectory (~/.config/skillshare/extras/<name>/),
not directly under the config root. Also, sync extras and the extras config field
both support project mode — removed incorrect "global only" admonitions.

- extras.md: fix source path references and example output
- sync.md: replace global-only admonition, fix directory structure diagram
- configuration.md: fix source path, add extras/ to overview tree
- index.md: add Extras Management category with extras command
2026-03-12 16:45:02 +08:00
Willie be4c693df5 feat(ui): add step-by-step onboarding tour with spotlight overlay
Self-built tour engine: TourProvider (context + state machine),
TourOverlay (spotlight cutout via box-shadow), TourTooltip (positioned
bubble with arrow, progress dots, mobile bottom sheet).

14 steps covering all sidebar sections. Auto-adjusts for project mode
(skips Git Sync) and empty state (no skills). Keyboard accessible
(Escape/Arrow/Enter). Triggered via sidebar Quick Tour button.
2026-03-12 16:45:02 +08:00
Willie 3981bda6d1 feat(ui): add table view to SearchPage, fix Audit loading and alignment
- SearchPage: add card/table view toggle with pagination, sticky toolbar,
  and localStorage persistence for view preference
- AuditPage: replace generic PageSkeleton with StreamProgressBar for
  seamless loading-to-progress transition
- AuditPage: fix triage panel help text alignment with selector input
  by matching py-1.5 padding
- SkillsPage: add sticky thead and scrollable table body
- Change tag badges from accent to info variant
2026-03-12 16:45:02 +08:00
Willie bac2bc292f fix(ui): align GitSync, Search, Backup, Trash, AuditRules to design system
- GitSyncPage: space-y-5, animate-fade-in, PageHeader in loading/error states,
  Button loading prop replacing manual Spinner, remove Spinner import
- SearchPage: Card overflow prop, remove redundant disabled on loading buttons,
  hide icons during loading state
- BackupPage: space-y-5, actions into PageHeader, summary as inline text,
  remove unused isNewest/index props, add Refresh button, fix hook ordering
- TrashPage: space-y-5, actions into PageHeader, summary as inline text,
  remove unused index prop, add Refresh button
- AuditRulesPage: border-2 → border on accordion, fix sticky header shadow
  thickness, restructure sticky group to include controls bar
2026-03-12 16:45:02 +08:00
Willie d3b9890028 fix(ui): align pages to design system — loading props, spacing, borders, click-to-toggle
- SyncPage/CollectPage/UpdatePage: root container space-y-5, remove manual margins
- Replace manual Spinner with Button loading prop across Sync, Collect, Update pages
- Fix double-toggle bug: wrap Checkbox in stopPropagation span for row click-to-toggle
- CollectPage: native checkbox → Checkbox component, border-2 → border on skill rows
- SyncPage: separator border-muted-dark → border-pencil-light/30, DiffItemRow index key → composite key
- UpdatePage: Card rotation → tilt prop, border-pencil/10 → border-muted, EmptyState for up-to-date
- UpdatePage: remove dead UpdatePageHeader component, Spinner import, outlined Card summary
- InstallForm: restructure layout with grouped sections and dashed separators
- HubManagerModal/SkillPickerModal/SearchPage/InstallPage/AuditRulesPage: minor design token alignment
2026-03-12 16:45:02 +08:00
Willie 095d076bc1 fix(ui): remove all left-border stripes, fix modifier HUD bug, refine components
Replace left-border colored stripes with severity dots across all pages
(AuditPage, AuditRulesPage, InstallForm, GitSyncPage, SkillsPage) and
components (Card accent variant, ConfirmDialog, Select). Card accent now
uses a thicker border instead of a left stripe.

Fix Cmd+S modifier HUD staying visible by resetting state immediately
after shortcut fires and adding a 2-second auto-dismiss safety timer.

Additional refinements: extract Checkbox/Select/Spinner/Tooltip into
standalone components, update Button link variant to pencil colors,
replace SkillsPage FilterChips with SegmentedControl connected, and
update style guide to mark left-border stripes as an anti-pattern.
2026-03-12 16:45:02 +08:00
Willie bb6b3f56d2 fix(ui): replace useEffect with render-time state adjustment in SkillsTable
Removes the anti-pattern of calling setState synchronously inside
useEffect to reset pagination when skills list changes. Uses React's
recommended "adjusting state during rendering" pattern instead, which
avoids cascading re-renders.
2026-03-12 16:45:02 +08:00
Willie 7ade470557 refactor(ui): rename oMLX references to skillshare-inspired
Remove external brand references from code comments, design tokens,
and style guide. The design philosophy is our own.
2026-03-12 16:45:02 +08:00
Willie acfbabd1b2 feat(skills): add ui-website-style skill with design system reference
Consolidate the UI dashboard and website design system guidance into a
dedicated skill. Moves STYLE_GUIDE.md from ui/ into the skill's
references/ directory so it lives alongside the actionable SKILL.md
that Claude uses for component selection, token usage, and page
structure decisions.
2026-03-12 16:45:02 +08:00
Willie cb8b5b530a feat(ui): add modifier keyboard shortcuts, HUD overlay, and sync progress animation
- Add Cmd/Ctrl+S shortcut to navigate to Sync page (cross-platform)
- Show floating HUD bar when holding Cmd/Ctrl to reveal modifier shortcuts
- Add indeterminate shimmer progress bar during sync operations
- Animate SVG pipeline dashed lines with flow effect while syncing
- Update KeyboardShortcutsModal to render modifier key combos (⌘/Ctrl)
- Add ScrollToTop button for long-scrolling pages
- Migrate page styles to use shared design tokens (radius, shadows)
2026-03-12 16:45:02 +08:00
Willie b4288ac7b1 fix(ui): redesign sidebar bottom bar with nav-consistent style
Replace horizontal icon+text buttons with vertical layout matching
the nav item style (icon + label, same padding/gap). Add keyboard
shortcuts toggle button and global shortcut hook integration.
2026-03-12 16:45:02 +08:00
Willie 99335ccf56 feat(ui): add sticky group headers in SkillsPage grouped view
Replace Virtuoso with GroupedVirtuoso for the grouped view so that
directory sub-headers stick below the toolbar while scrolling.
GroupedVirtuoso's TopItemList component is customized with the
measured toolbar height offset to position headers correctly.
2026-03-12 16:45:02 +08:00
Willie 314d6a3dff fix(sync): show duplicate skill names in collision message, fix vertical spacing
Display the actual duplicate skill name(s) in the "isolated by target
filters" info message so users can identify which skills collide.

Remove the extra fmt.Println() before backup section — ui.Header()
already includes a leading newline, so the previous blank line created
a double gap.

Also replace VirtualizedGroupedView with native DOM GroupedView using
sticky sub-headers that respect the toolbar height offset.
2026-03-12 16:45:02 +08:00
Willie 5369595bc1 fix(install): skip target dotdirs during skill discovery
Repos like pbakaus/impeccable commit .claude/skills/ alongside their
source skills, causing discoverSkills to find every skill twice (36
instead of 18). Fix by deriving known target dotdir names (.claude,
.cursor, .skillshare, etc.) from targets.yaml project_path values and
skipping them during filepath.Walk.

Non-target hidden dirs (.curated, .system — used by openai/skills) are
still discovered as before. Injection pattern avoids circular import
between config and install packages.
2026-03-12 16:45:02 +08:00
Willie d6616a7cf1 fix(ui): improve SegmentedControl dark mode visibility, adjust sticky padding
- Add border to active button in connected SegmentedControl so it's
  visible in dark mode (bg-surface was nearly invisible against container)
- Increase sticky toolbar bottom padding (pb-2 → pb-4) for breathing
  room between filter chips and content
2026-03-12 16:45:02 +08:00
Willie 4c41443b7d fix(ui): refine sticky toolbar spacing, soften SegmentedControl and Input styles
- Tighten sticky toolbar gaps (search mb-4→mb-2, chips mb-6→mb-0)
- SegmentedControl connected mode: add p-1 inner padding + gap-0.5,
  active state from solid black to white surface with shadow
- Input: border-radius 4px→8px, focus ring matches pencil palette
2026-03-12 16:45:02 +08:00
Willie d6cbfc82d9 feat(ui): add sticky search/filters toolbar on SkillsPage, clean up LogPage
Wrap search bar, sort dropdown, view toggle, and filter chips in a
sticky container so they stay pinned while scrolling through skills
in all three view modes (grid/grouped/table).

Also clean up LogPage: remove unused imports, simplify status rendering
from Badge to inline dot+text, add pagination page size control, and
streamline section comments.
2026-03-12 16:45:02 +08:00
Willie 3227400958 refactor(ui): extract PageHeader component, tone down Badge and StatusBadge
- Extract shared PageHeader with icon/title/subtitle/actions props,
  replacing duplicated header markup across all 16 pages
- Shrink Badge to text-xs with tighter padding for subtler appearance
- Change StatusBadge normal states (merged/copied/linked) to default
  grey variant — only anomalies (warning/danger) use color
- TargetsPage: move delete button to top-right, restore dashed separator
  between path and mode row
2026-03-12 16:45:02 +08:00
Willie dfd62ee19c fix(ui): compact TargetsPage card layout, remove version stat from dashboard
- Move filter link and skill count inline with sync mode dropdown,
  eliminating separate rows and the dashed separator
- Use ghost variant for Filters button to match neutral B/W theme
- Show filter tags with Edit link when filters exist, inline link when empty
- Remove redundant Version card from DashboardPage stats grid
2026-03-12 16:45:02 +08:00
Willie 6b2d94776a fix(ui): allow Select dropdown to expand for full descriptions, improve TargetsPage filters
- Change dropdown panel from w-full to min-w-full so it can grow
  wider than the trigger when descriptions need more space
- Remove truncate from option description text
- Restructure TargetsPage filter section: only show filter UI for
  merge/copy modes, add inline filter badge display with +/− labels
2026-03-12 16:45:02 +08:00
Willie 19a27202e8 feat(ui): redesign Select dropdown, add shared DialogShell/IconButton/Pagination/SegmentedControl
- Redesign Select with size variants (sm/md), B/W color scheme,
  dropdown animation, and consistent height with Button/Input
- Extract DialogShell for unified modal styling across all dialogs
- Add IconButton for icon-only actions with ghost/outline variants
- Add Pagination component for table views
- Add SegmentedControl for tab-like toggle groups
- Update Button: add link variant, border-2 for stronger presence
- Migrate all pages to use shared components, remove inline styles
2026-03-12 16:45:02 +08:00
Willie fff0711e36 feat(ui): add table view with pagination, virtualize grouped view, improve audit dialogs
Skills page gains a third "table" view with paginated list (10/25/50),
hover tooltips via createPortal, and localStorage persistence for the
selected view. Grouped view now uses Virtuoso for smooth scrolling with
large skill sets.

Install/audit dialogs refactored to card-based findings with severity
filter badges, structured grouping, and increased max-height. Confirm
dialog buttons bumped to medium size.
2026-03-12 16:45:02 +08:00
Willie 64a4c91c99 fix(ui): refine minimal redesign — dark mode B/W, link style, button polish
- Dark mode: replace blue accent with neutral gray for true B/W inversion
- Brighten dark mode semantic colors (success, warning, danger) for readability
- Links: replace wavy underlines with oMLX-style border-bottom (link-subtle class)
- Buttons: pill radius, outlined danger, subtle secondary/ghost hover
- Replace inline fontFamily monospace with global font-mono class (15+ files)
- Card: add overflow prop instead of global overflow-hidden removal
- ConfirmDialog/ExtrasModal: widen for better readability
- SkillsPage: neutral filter chips and badges (no blue/red in dark mode)
- BlockStamp/RiskMeter: consistent sizing with items-stretch
- Sidebar version: dynamic from API instead of hardcoded
2026-03-12 16:45:02 +08:00
Willie dfaf34215c docs: update website and built-in skill for extras first-class support
- diff.md: add --extras and --all flags
- status.md: add Extras section for sync status display
- doctor.md: add Extras health check section
- quick-reference.md: add Extras Management table and extras path
- project-skills.md: add extras to Mode Restrictions (supported) and directory structure
- sync-modes.md: add Extras Sync Modes section
- declarative-manifest.md: add Extras Configuration section
- SKILL.md: add extras commands to Quick Lookup table
2026-03-12 16:45:02 +08:00
Willie 46265ae2e7 feat(ui): match oMLX style — dark sidebar active, clean borders, 8px btn radius 2026-03-12 16:45:02 +08:00
Willie bcf72d52fc feat(ui): apply oMLX button palette — dark primary, outline secondary 2026-03-12 16:45:02 +08:00
Willie 773ce9ba08 chore(ui): final cleanup — remove CSS stubs and compat shims
- Remove all --color-postit-* and --color-tracked-* stub CSS variables
  from both @theme and .dark blocks in index.css
- Remove `postit` variant and `decoration` prop from Card.tsx
- Replace bg-postit Tailwind classes with bg-paper/bg-surface equivalents
- Replace animate-spin-slow/animate-pulse-gentle with standard animate-spin/animate-pulse
2026-03-12 16:45:02 +08:00
Willie fb34809b2f refactor(ui): rename HandButton→Button, HandInput→Input + remove deprecated aliases
- Rename HandButton.tsx → Button.tsx, export default function Button
- Rename HandInput.tsx → Input.tsx, rename exports: HandInput→Input,
  HandTextarea→Textarea, HandSelect→Select, HandCheckbox→Checkbox
- Rename internal interface names (ButtonProps, InputProps, etc.)
- Update all 21 import sites across components/ and pages/
- Remove deprecated `wobbly` and `colors` exports from design.ts
2026-03-12 16:45:02 +08:00
Willie e8a850d757 feat(ui): clean all pages — remove hand-drawn decorations
Replace wobbly->radius, colors->palette, animate-sketch-in->animate-fade-in.
Remove all fontFamily var(--font-hand/heading) inline styles, decoration="tape",
variant="postit", and decorative rotate transforms. Rewrite SkillsPage card
components to use uniform surface-background cards with accent border-l for
tracked skills, dropping the postit/trackedColors arrays and getRotation helper.
2026-03-12 16:45:02 +08:00
Willie ef4e51abcf feat(ui): simplify remaining components — remove hand-drawn styling
Replace wobbly→radius, colors→palette, animate-sketch-in→animate-fade-in,
animate-pulse-gentle→animate-pulse across Skeleton, Toast, ConfirmDialog,
EmptyState, ErrorBoundary, StreamProgressBar, FilterTagInput, BlockStamp,
RiskMeter, FileViewerModal, SkillPickerModal, HubManagerModal, InstallForm.
Remove fontFamily overrides (now inherited from body), decoration="tape"
props from Card, dashed borders, rotation transforms, and hard-coded shadows.
BlockStamp simplified to clean inline-flex badge, no rotation.
2026-03-12 16:45:02 +08:00
Willie cf92a221b2 feat(ui): simplify core components — Card, Button, Input, Badge
Replace hand-drawn skeuomorphic styles (wobbly borders, shadow-translate
hover effects, handwriting font) with clean, minimal equivalents using
the updated radius/shadows tokens. Preserve all props and keyboard
navigation for backward compatibility.
2026-03-12 16:45:02 +08:00
Willie 06ca4696e2 feat(ui): rewrite design tokens — radius, palette, clean CodeMirror theme
- design.ts: replace wobbly border-radius with clean radius constants (4-12px),
  add semantic palette export; keep deprecated colors/wobbly aliases for migration
- codemirror-theme.ts: switch font to SFMono stack, replace dashed gutter border
  with 1px solid, swap postit highlights for info-light/warning-light
- audit/helpers.ts: migrate from colors.blue to palette.info
2026-03-12 16:45:02 +08:00
Willie 8f8991382c feat(ui): rewrite CSS tokens — minimal palette, remove hand-drawn effects 2026-03-12 16:45:02 +08:00
Willie 7b6f0e8f09 feat(ui): swap Google Fonts from Inter to DM Sans 2026-03-12 16:45:02 +08:00