Switch DialogShell backdrop detection from onClick to onMouseDown.
The click event's target resolves to the nearest common ancestor of
mousedown/mouseup positions, so dragging a text selection from an
input onto the backdrop would fire onClose. mousedown's target is
always the element directly pressed, so only an intentional press on
the backdrop itself triggers close.
- Add onMutate to batchMutation for instant UI updates (mirrors
server matchesFolder logic, skips disabled/tracked-repo skills)
- Show inline Spinner next to the folder badge during batch ops,
derived from batchMutation.variables (no manual state sync)
- Block context menu and target selection while batch is pending
to prevent conflicting mutations
- Extract normalizeTargets result into variables to avoid redundant
calls in skill row rendering
- Add normalizeTargets helper: treats ['*'], null, and [] as All
- Folder target summary now reflects direct skills only, not the
entire subtree — child folders have their own visible badges
- Skill badges in grouped view also use normalizeTargets so '*'
displays as 'All' instead of a literal asterisk
- Mixed display: shows 'Mixed' when some skills are All and others
have specific targets (with tooltip showing the breakdown)
When all skills in a folder are tracked-repo members (read-only), the
batch target mutation now shows an error toast instead of a misleading
'0 skills now available in X' success message.
- Enable frontmatter parsing in DiscoverSourceSkillsAll so /api/skills
returns saved targets (fixes target display reverting to All)
- Skip tracked-repo skills in batch/single target handlers to prevent
dirty git state; reject with 400 for single-skill endpoint
- Add RefreshMetaHashes to recompute audit hashes after SKILL.md edits;
batch handler refreshes outside the write lock
- Show 'Uninstall Repo' with confirm dialog for tracked-repo members
instead of the always-failing individual uninstall action
- Return 409 Conflict when enabling a skill disabled by glob pattern
in .skillignore/.skillignore.local instead of false success
- Preserve IsInRepo flag for root-skillignore-disabled skills so they
remain visible in the Tracked tab after disable
- Update changelog and website changelog for v0.18.7
- doctor: replace inline frontmatter parser with version.ReadLocalSkillVersion
which correctly reads nested metadata.version (fixes#119)
- frontmatter_write: use TrimRight instead of TrimSpace for --- delimiter
so indented --- inside YAML block scalars is not mistaken for end marker
- Update changelog and website changelog for v0.18.7
- Fix folder trailing slash bug: filepath.Clean now normalizes input
before matchesFolder comparison (e.g. 'frontend/' → 'frontend')
- Narrow mutex scope in handleBatchSetTargets: RLock for config read,
no lock during DiscoverSourceSkillsAll, Lock only for write loop
(matches existing handleSetSkillTargets pattern)
- Defensive filepath.Clean on cleanEmptyParents inputs
- Add TestMatchesFolder unit test and trailing slash handler test
- Add explicit undefined initializer to useRef<T>() for React 19 compat
- Remove unused isProjectMode from DashboardPage (dead after refactor)
- Remove unused queryClient/toast from SkillsTable (moved to useSkillActions)
Grouped view:
- FolderNode target aggregation (bottom-up O(n) computation)
- Target badges on folder rows (uniform/mixed) and skill rows
- Right-click context menu for batch (folder) and single (skill) editing
Grid view:
- Target badges on skill cards
- Right-click context menu for single skill editing
Table view:
- 'Available in' column with inline Select dropdown
- Simplified to 5 columns (merged Path/Source into Name)
- Actions column (⋯) with flat menu items
- Page size persisted in localStorage
All views:
- Shared useSkillActions hook with optimistic cache updates
- Context menu actions: Available in, View Detail, Enable/Disable, Uninstall
- ConfirmDialog for destructive actions
- Hover-matching highlight on active context menu item
- Clickable source globe icon linking to repo
- Dismissible right-click tip banner with playful theme
Config page:
- Panel wrapper overflow-visible when expanded (fixes dashed border clipping)
Closes#115.
New utility: SetFrontmatterList() writes/removes YAML list fields
in SKILL.md frontmatter with dot-notation support (metadata.targets).
Normalizes legacy top-level targets field. Preserves body content.
New endpoints:
- POST /api/skills/batch/targets — set targets for all skills in folder
- PATCH /api/skills/{name}/targets — set target for single skill
Both use s.mu.Lock() for safe concurrent access.
Includes 15 unit tests covering set/remove/traverse/root-only/not-found.
Part of issue #115.
P2-1: handleUninstallRepo and handleBatchUninstall used s.cfg.Source for
gitignore removal, but project-mode installs write to .skillshare/.gitignore
with a "skills/" prefix. Add gitignoreDir() helper that returns the correct
base directory per mode, and prefix entries in project mode.
P2-2: Registry prune used filepath.Base(repoName) to derive the legacy group,
causing sibling nested repos (e.g., org/_team-skills vs dept/_team-skills) to
collide on the same basename. Now uses exact Group match for nested repos and
restricts legacy basename matching to top-level repos only.
Tests added (15 new):
- resolveTrackedRepo: auto _ prefix, nested, already-prefixed, not-found,
basename fallback
- Registry prune: full-path Group, nested members by prefix, sibling isolation
- Project-mode gitignore: single + batch uninstall
- updateSingle: basename fallback, not-found, regular skill priority
- cleanEmptyParents: multi-level, stops at non-empty, stops at boundary
- Add 'xs' button size tier (px-2 py-1 text-xs) to Button component
- Use xs buttons for tracked repo Update/Uninstall actions to reduce
visual weight in row-level controls
- Move clean/modified status from action area to info group (left side)
as Badge — status is metadata, not an action
- clean: subtle default Badge; modified: warning Badge with dot
- Remove unused Check icon import
ReconcileGlobalSkills uses PruneStaleSkills(skillsOnly=false) which
removes agent entries unrelated to the uninstalled repo. The explicit
filter + Save is sufficient; full reconcile deferred to next sync.
- updateSingle: check exact skill path before resolveTrackedRepo
fallback, preventing basename collision with nested repos
- handleUninstallRepo: match repo's own registry entry by FullName
in addition to group-based matching for member skills
P1: updateSingle now uses resolveTrackedRepo (shared with uninstall)
to find nested tracked repos like org/_team-skills instead of only
probing root-level _name/name.
P2: handleUninstallRepo now prunes registry entries belonging to the
uninstalled repo and runs ReconcileGlobalSkills/ReconcileProjectSkills,
matching the cleanup that handleUninstallBatch already does.
Extracted resolveTrackedRepo as a Server method to deduplicate the
nested path resolution logic between uninstall and update handlers.
MoveToTrash, List, Restore, and Cleanup all assumed flat names.
When a nested tracked repo like org/_team-skills was uninstalled,
the trash entry landed in a subdirectory that List could not see
and Restore could not reach.
- MoveToTrash: create intermediate dirs via filepath.Dir(trashPath)
- List: recursive WalkDir to discover nested entries, store full
relative path in TrashEntry.Name
- Restore: MkdirAll on destination parent before rename
- Cleanup: remove empty intermediate dirs after expiry via
cleanEmptyParents helper
Closesrunkids/skillshare#116 follow-up (nested trash path)
Add handler tests for nested tracked repo uninstall, ambiguous basename rejection, and traversal rejection.
Also isolate trash-backed server tests by setting XDG_DATA_HOME in test helpers.
Validate tracked repo names against path traversal and surface repository listing errors in the uninstall handler.
Track in-flight dashboard repo actions with sets so loading state stays correct during overlapping clicks.
Add update and uninstall controls to the dashboard tracked repo list.
Handle nested tracked repo paths in the uninstall API so dashboard actions work for both top-level and nested repos.
- Fix UI batch uninstall not removing nested skill registry entries:
handler used flat names (__) but registry stores path names (/),
now tracks exact RelPath from discovered skills for matching
- Add stale entry pruning to ReconcileGlobalSkills and
ReconcileProjectSkills using a live set built during disk walk,
so skills deleted from source are removed from registry
- Trigger registry reconcile after sync in both UI handler (via defer
for early-return safety) and CLI (global + project mode), writing
warnings to stderr to avoid corrupting --json output
- UI: fix BatchUninstallPage search treating plain text as exact-match
glob (now substring search when no * or ? present), display nested
skill paths with / instead of __ in confirm and result dialogs
- UI: hide redundant 'X repo(s) and Y skill(s) already up to date'
line on UpdatePage when everything is already current
- Fix test isolation: set XDG_CONFIG_HOME in server test helpers to
prevent host agents dir leaking into test results, skip chmod-based
oplog test when running as root
- Add README badge for Awesome Codex CLI
Add --help/-h flag handling to 7 commands that were missing it:
sync, status, collect, pull, push, doctor, ui.
Previously, running e.g. 'skillshare push --help' would execute
the push instead of showing help. Now all commands safely show
usage info when --help is passed.
Also adds wantsHelp() helper to reduce duplication across commands.
Closes#113
Table view:
- Add max-w-[300px] + truncate + tooltip on Name column
- Fix tooltip overflow clamping to slide instead of flip
- Add block prop to Tooltip for correct getBoundingClientRect in table cells
- Set tooltip delay to 1500ms for table columns
Tooltip component:
- Add block prop to render wrapper as block element
- Fix horizontal overflow: use vw - MARGIN - w instead of flipping left
- Add useEffect cleanup to prevent timer/RAF leak on unmount
Skill detail page:
- Switch metadata from stacked to horizontal label:value layout
- Move CopyButton from label to value side to prevent layout shift
- Reduce spacing (space-y-3 → space-y-2) and label size (text-sm → text-xs)
- Shorten Repository label to Repo
Tracked repos have no .skillshare-meta.json, so reconcile could not
read branch from metadata. Now falls back to git rev-parse --abbrev-ref
HEAD for tracked repos, ensuring branch is written to registry.yaml
for cross-device rebuild.
Added gitCurrentBranch() helper in config package (cannot import
internal/git due to circular dependency).
Added registry assertion to TestInstallBranch_TrackedRepo.
P1: check.go '@' separator broke SSH URLs (git@github.com:org/repo)
— splitURLBranch would split at the '@' in the URL itself
— Fix: use tab character as separator (cannot appear in URLs)
— Added unit test for SSH URL round-trip
P1: install_config.go grouped same-repo different-branch skills together
— groupConfigSkillsByRepo keyed by CloneURL only, ignoring Branch
— Fix: include branch in grouping key so each branch clones separately
P2: reconcile never cleared stale branch from registry
— Only updated when meta.Branch was non-empty, never cleared it
— Fix: sync branch unconditionally when meta is available
sparseCloneSubdir in discoverFromGitSubdir was hardcoding empty branch,
ignoring --branch when sparse checkout was used for subdirectory discovery.
Reported by: gemini-code-assist on PR #112
TestSync_TargetNamingStandard_InvalidSkillWarnsAndSkips now checks
for summarized output 'skill(s) skipped (naming validation)' instead
of per-skill warning line.
- check.md: JSON output now includes branch field for tracked repos
- quick-reference.md: added --branch example in team sharing section
- SKILL.md: added -b flag to install recipes
- check.go: extract urlBranchKey()/splitURLBranch() helpers, used in 5 places
- handler_skills.go: extract enrichSkillBranch() helper, used in 2 handlers
- handler_targets.go: merge duplicate merge/copy resolution into single case
- list.go: cache git.GetCurrentBranch() per-repo instead of per-skill
With 25000+ skipped skills (standard naming + name collisions),
the CLI sync output was flooded with per-skill warning lines.
Now prints a concise summary:
12345 skill(s) skipped (naming validation)
456 name collision(s) excluded
Applied to both merge and copy sync modes.
Problem: Sync page showed 'in sync' but Targets page showed
39032/64075 — ~25000 skills silently dropped by name collisions
and SKILL.md validation in standard naming mode.
Root cause: expectedSkillCount used raw filtered count (pre-resolution)
while diff used post-resolution count. The gap was invisible.
Fix:
1. handler_targets.go: expectedSkillCount now uses resolution.Skills
count (post-collision/validation), matching what sync actually does
2. handler_diff_stream.go: surfaces skippedCount and collisionCount
in diff response so UI can explain why skills were dropped
3. handler_sync.go: diffTarget struct gains SkippedCount/CollisionCount
4. TargetsPage: shows warning when skills are skipped with collision count
5. SyncPage: shows naming conflict notice in 'in sync' cards
6. API client: Target and DiffTarget types gain optional fields
Apply setting change to React Query cache immediately on select,
then confirm via API. Rollback cache on error. Eliminates 2s lag
between dropdown change and UI update.
- API client: branch field on Skill type, discover/install/installBatch
- InstallForm: branch input inline with Source (7:3 ratio), git detection
- SkillsPage: branch badge with GitBranch icon in all 3 view modes
- SkillDetailPage: branch metadata row in detail sidebar
- skillItem struct gains Branch field (json: branch,omitempty)
- handleListSkills and handleGetSkill populate Branch from SkillMeta;
fall back to git.GetCurrentBranch for tracked repos with empty metadata branch
- handleDiscover, handleInstallBatch, handleInstall all accept Branch in
request body and propagate it to Source.Branch and InstallOptions.Branch