Commit Graph
1056 Commits
Author SHA1 Message Date
Willie 87bc3d35c4 feat(ui): add NewSkillPage wizard for creating skills from templates
Multi-step wizard with: name validation (regex + duplicate check),
pattern selection from API, optional category, scaffold dir checkboxes,
and confirmation summary. Uses browser history for back-navigation.
2026-03-18 22:35:02 +08:00
Willie d6be8057ed feat(ui): add API client types and methods for skill creation
Add SkillPattern, SkillCategory, TemplatesResponse, CreateSkillRequest,
and CreateSkillResponse types. Wire up getTemplates() and createSkill()
API methods. Add 'templates' query key for caching.
2026-03-18 22:35:02 +08:00
Willie 7b6cb70a0b test(server): add tests for create skill and templates endpoints 2026-03-18 22:35:02 +08:00
Willie 60b416651f feat(server): add POST /api/skills endpoint for skill creation
Handles skill creation from the web UI with full validation:
- Name validation (ValidNameRe)
- Pattern validation (must exist in Patterns list)
- ScaffoldDirs validation (must be allowed by the chosen pattern)
- Conflict detection (409 if skill already exists)

Creates SKILL.md from the template engine and optional scaffold
directories with .gitkeep files. Returns 201 with skill metadata
and list of created files. Logs to ops log as "create-skill".
2026-03-18 22:35:02 +08:00
Willie 6e23f11be7 feat(server): add GET /api/skills/templates endpoint
Expose skill design patterns and categories via API for the upcoming
web UI skill creation wizard. Returns the full Patterns and Categories
lists from internal/skill/.

Route registered before GET /api/skills/{name} to avoid path conflict.
2026-03-18 22:35:02 +08:00
Willie 22efeea924 refactor: extract skill templates to internal/skill package
Move pattern/category definitions and template generation logic from
cmd/skillshare/new_templates.go to internal/skill/ so both the CLI and
the web UI server can import them. The CLI file becomes thin wrappers
with type aliases to keep new_tui.go and new.go unchanged.
2026-03-18 22:35:02 +08:00
Willie c1e6f1d7b8 docs: add metadata.targets to v0.17.5 changelog 2026-03-18 22:35:02 +08:00
Willie 0ae936a3c1 docs: document metadata.targets in skill format page
Add the new metadata: block placement for targets, explain the
priority rule (metadata wins over top-level), and describe the
metadata block as an ecosystem convention.
2026-03-18 22:35:02 +08:00
Willie 3bedd8a7ea docs: note that ParseFrontmatterFields does not resolve metadata fields 2026-03-18 22:35:02 +08:00
Willie ae1906297f test: add integration tests for metadata.targets sync
Verify that the new metadata.targets format works end-to-end
through the full sync pipeline: filtering, mixed format
coexistence, and metadata-over-toplevel priority.
2026-03-18 22:35:02 +08:00
Willie 3c3974cab3 feat: support metadata.targets in SKILL.md frontmatter
Align with the emerging agent skill ecosystem convention where
deployment/behavioral fields live under a metadata: YAML block.

ParseFrontmatterList() now checks metadata.<field> first, then
falls back to the top-level field. Backward compatible — existing
SKILL.md files without metadata: continue to work unchanged.
2026-03-18 22:35:02 +08:00
Willie 6b3858620f feat(skillignore): add .skillignore.local for local pattern overrides
Allow users to override shared .skillignore patterns without modifying
the committed file. ReadMatcher transparently merges .skillignore +
.skillignore.local (local appended last so !negation rules win).

- Matcher.HasLocal flag tracks .local presence for CLI reporting
- IgnoreStats gains RootLocalFile, RepoLocalFiles, HasLocal() method
- sync/status/doctor show ".local active" indicator
- 6 unit tests + 2 integration tests
- Docs: file-structure, sync, status, doctor, best-practices, creating-skills, org-sharing
2026-03-18 22:35:02 +08:00
Willie 93a3067c76 refactor(tui): move wizard breadcrumbs to help bar footer
Compact single-line format: "✓ reviewer → quality" appended to
the help bar instead of a multi-line header above the list.
2026-03-18 22:35:02 +08:00
Willie c9624df637 feat(tui): add header field to checklist for wizard breadcrumbs
Breadcrumbs now render as a dedicated header area above the list,
separate from the title. This prevents title truncation and keeps
the layout clean.
2026-03-18 22:35:02 +08:00
Willie efdd6366de fix(new): show wizard breadcrumbs inside TUI title instead of terminal 2026-03-18 22:35:02 +08:00
Willie 650065393e feat(new): show breadcrumbs of previous selections in wizard steps 2026-03-18 22:35:02 +08:00
Willie 4f6ae5ad33 feat(new): add wizard back-navigation (Esc returns to previous step) 2026-03-18 22:35:02 +08:00
Willie 26760157b6 docs: add pattern and category fields to skill format reference 2026-03-18 22:35:02 +08:00
Willie 6fa73ae91b fix(new): handle .gitkeep write error instead of ignoring it 2026-03-18 22:35:02 +08:00
Willie c4bfcb0a44 docs: add skill design patterns guide and update new command reference
Add comprehensive skill design patterns page covering five structural
templates (Tool Wrapper, Generator, Reviewer, Inversion, Pipeline) with
a decision flowchart, use-case categories, and detailed examples.

Update `new` command reference with -P/--pattern flag documentation and
a scaffold directories table. Cross-link from skill-design.md.
2026-03-18 22:35:02 +08:00
Willie 8c675182cb test(new): add integration tests for -P flag and scaffold directories 2026-03-18 22:35:02 +08:00
Willie ffa5dba66b feat(new): add TUI prompts and integrate -P flag into new command 2026-03-18 22:35:02 +08:00
Willie 935752bfc9 feat(new): add pattern/category definitions and template generators 2026-03-18 22:35:02 +08:00
Willie 6d0ac1bf81 docs: add SKILLSHARE_UI_BASE_PATH to environment variables reference
Ref: #85
2026-03-18 22:35:02 +08:00
Willie 329869f258 docs: add use case context to reverse proxy section
Ref: #85
2026-03-18 22:35:02 +08:00
Willie da7dfd37cc test: add E2E runbook for UI base path reverse proxy
Covers: API routing with prefix, 404 without prefix, bare path redirect,
__BASE_PATH__ injection, SPA fallback, -b flag, env var fallback.

Also fix unused import in SyncPage.tsx (broke tsc).

Ref: #85
2026-03-18 22:35:02 +08:00
Willie f0e164ce9c refactor: simplify base path code after review
- Export NormalizeBasePath and reuse in ui.go (eliminate duplication)
- Use json.Marshal for safe __BASE_PATH__ injection (prevent XSS)
- Always cache index.html at startup (avoid per-request disk reads)
- Extract shared BASE_PATH module in frontend (single source of truth)

Ref: #85
2026-03-18 22:35:02 +08:00
Willie 550f398464 fix(test): update integration tests for target path validation
Tests were failing because config validation now requires target paths
to exist before sync. Updated tests to create target directories
properly and adjusted expected error messages.

- TestExclude_GlobalSymlinkMode_Ignored: use CreateTarget instead of RemoveAll
- TestSync_SymlinkMode_CreatesSingleSymlink: same
- TestSync_SourceNotExist_ReturnsError: use CreateTarget, update error message
- TestLog_SyncPartialStatus: use read-only dir to trigger partial failure
2026-03-18 22:35:02 +08:00
Willie 657adcc8a6 test+docs: add base path integration tests and reverse proxy guide
- Integration tests: --base-path missing value, -b short flag, env var
- Docs: --base-path flag in table, Nginx/Caddy examples, env var usage

Ref: #85
2026-03-18 22:35:02 +08:00
Willie 214c8b993c feat(ui): support base path for reverse proxy deployments
- Vite base: './' for relative asset paths (works from any sub-path)
- API client reads window.__BASE_PATH__ for request prefix
- React Router uses basename for client-side routing

Ref: #85
2026-03-18 22:35:02 +08:00
Willie 04f65e5320 feat(cli): add --base-path flag and SKILLSHARE_UI_BASE_PATH env var to ui command
Allows serving the UI under a URL prefix (e.g., skillshare ui --base-path /app).
The flag value is passed through to the server constructors and used for
browser URL construction. Falls back to SKILLSHARE_UI_BASE_PATH env var
when the flag is not provided.
2026-03-18 22:35:02 +08:00
Willie 768c9f4a67 feat(server): inject __BASE_PATH__ into SPA index.html when base path is set
When spaHandlerFromDisk receives a non-empty basePath, it pre-computes
a modified index.html with a <script> tag injecting window.__BASE_PATH__.
This allows the frontend to discover its base path at runtime without
build-time configuration. The injection applies to both direct index.html
requests and SPA fallback routes.
2026-03-18 22:35:02 +08:00
Willie 10444eef3f feat(server): add basePath support for reverse-proxy sub-path hosting (#85)
Add normalizeBasePath + wrapBasePath to Server so the UI and API can be
served under a URL prefix (e.g. /app). StripPrefix wraps outside
withConfigAutoReload; bare-path requests redirect to path + "/".
Dev mode (no uiDistDir) prints a warning and skips wrapping.

Includes HTTP routing tests for prefix routing, 404 without prefix,
bare-path redirect, multi-level paths, and empty basePath passthrough.
2026-03-18 22:35:02 +08:00
Willie 92603f5be6 feat: add config save validation and sync safety checks
Validate config semantics (source path, sync modes, target paths) at
save time (API + CLI) instead of failing at sync time with cryptic
errors. Sync no longer auto-creates missing target directories — fails
fast to catch typos like ~/.cusor/skills. Dry-run also validates paths.

- ValidateConfig / ValidateProjectConfig with warnings + errors
- handlePutConfig returns 400 for invalid configs, 200 + warnings
- handleSync pre-checks via ValidateConfig
- ensureRealTargetDir shared helper (replaces duplicated blocks)
- UI: warning toast on config save, warning banners on sync/preview
- Dashboard shows full absolute source path
2026-03-18 22:35:02 +08:00
Willie 6424bc635e docs: update v0.17.5 changelog to reflect banner-based sync preview
Replace toast action description with inline banner approach.
Remove Toast Action Buttons section (feature was reverted).
2026-03-18 22:35:02 +08:00
Willie a7ecc4010d fix(ui): move sync preview banner above editor to avoid toast overlap 2026-03-18 22:35:02 +08:00
Willie 0ff59638d5 refactor(ui): replace toast action with inline banner for sync preview
- Revert Toast.tsx to original (remove action/persistent/replaceKey)
- Remove detailed prop from SyncResultList (YAGNI, caused overflow)
- ConfigPage: show inline banner card after save instead of toast action
- Banner dismisses on edit or manual dismiss, opens sync preview modal
2026-03-18 22:35:02 +08:00
Willie f6ec0e9565 refactor(ui): extract shared sync helpers to eliminate duplication
- Create ui/src/lib/sync.ts with formatSyncToast(), invalidateAfterSync(),
  and summarizeSyncResults() utilities
- SyncPreviewModal and SyncPage now share the same toast message and
  query invalidation logic instead of duplicating it
- Clear stale results/error when SyncPreviewModal closes
2026-03-18 22:35:02 +08:00
Willie 0446711535 fix(ui): include pruned in hasChanges for SyncResultList
Prune-only targets need to show the detailed skill list and
the change icon in the sync preview modal so users can see
which symlinks will be removed before confirming.
2026-03-18 22:35:02 +08:00
Willie 75f35d2471 feat(ui): wire SyncPreviewModal into ConfigPage save handlers
Both handleConfigSave and handleIgnoreSave now show a persistent toast
with a "Preview Sync" action button that opens SyncPreviewModal. The
replaceKey 'config-save' deduplicates toasts when saving in quick
succession.
2026-03-18 22:35:02 +08:00
Willie 7b99d0f130 feat(ui): add SyncPreviewModal with dry-run preview and confirm 2026-03-18 22:35:02 +08:00
Willie 2dcd756f00 refactor(ui): extract SyncResultList component from SyncPage 2026-03-18 22:35:02 +08:00
Willie 6bd13140eb feat(ui): render Toast action button, hide progress bar when persistent 2026-03-18 22:35:02 +08:00
Willie 033521029c feat(ui): add action, persistent, replaceKey to Toast system 2026-03-18 22:35:02 +08:00
Willie 4d2d540127 refactor: simplify ignore payload and deduplicate formatting
- Remove dead nil check in ignorePayload() (repoFiles already initialized)
- Replace manual map merge loops with maps.Copy in 3 handler sites
- Deduplicate fmt.Sprintf + ui.Success in doctor checkSkillignore
- Extract extractIgnoreSources() helper in SyncPage to DRY two identical
  state-setting blocks
v0.17.4
2026-03-18 00:19:30 +08:00
Willie 48a7e40e75 docs: add sync ignored skills and doctor fixes to v0.17.4 changelog
New entries: sync .skillignore visibility (CLI + JSON + UI), doctor
CLI text output for skillignore, doctor output readability, duplicate
names truncation, doctor global mode bug fix.
2026-03-18 00:19:30 +08:00
Willie 7c533f2012 docs: update sync and doctor pages for .skillignore visibility
- sync: add ignored_count/ignored_skills to JSON example, note about
  .skillignore filtering
- doctor: add Skillignore to environment checks table, update example
  output with skillignore line and visual spacing
2026-03-18 00:19:30 +08:00
Willie 33cc974210 style(doctor): add blank line after config directory info
Visually separate config paths from source/skillignore/git checks
for better readability in the Checking environment section.
2026-03-18 00:19:30 +08:00
Willie e54d469d63 style(doctor): add visual break before skill validation checks
Separate the environment checks (config, source, skillignore, git)
from the skill validation checks (integrity, targets) with a blank
line for better readability.
2026-03-18 00:19:30 +08:00
Willie af143a3330 fix(doctor): add CLI text output for skillignore check
checkSkillignore only wrote to the JSON result but never printed
to the terminal, so skillignore status was invisible in CLI output.
2026-03-18 00:19:30 +08:00