Commit Graph
2816 Commits
Author SHA1 Message Date
Willie 746bb9a77b Merge pull request #494 from runkids/runkids/extras-mode-rules
refactor(extras): keep target mode rules in config and share them in the UI
2026-10-08 16:18:15 +08:00
Willie e1aaf343fe Merge branch 'main' into runkids/extras-mode-rules 2026-10-08 16:17:56 +08:00
Willie b90bf2086f Merge pull request #493 from runkids/runkids/extras-sync-api
refactor(extras): pass targets to sync and filter them in one discovery function
2026-10-08 16:17:22 +08:00
Willie 9edac4d110 Merge pull request #495 from runkids/runkids/extras-validate-names
refactor(extras): validate every mode change and share special extra names
2026-10-08 16:16:52 +08:00
Willie 8ccdc91b29 refactor(ui): share target field rules between Add and Edit target
Add target and the Edit target dialog each implemented the field rules
(an extension forces copy, symlink turns flatten off), and they had
drifted: the dialog kept flatten on through a switch to symlink and
back. applyDraftChange now holds the rules and both use it, so the
dialog clears flatten on symlink exactly like Add target.

Refs #490
2026-10-08 16:08:03 +08:00
Willie d61b25bcf2 refactor(extras): apply target filters in one discovery function
The extras diff, list, status and remove-target commands and the
server's list and diff handlers each discovered an extra's source and
then filtered it with ExtraTargetFiles. A new view that forgot the
filter step would silently show the wrong file count or status.

DiscoverExtraTargetFiles now discovers and filters in one call and
returns the unmatched-include warnings that sync reports. Every caller,
including sync itself, uses it, and ExtraTargetFiles is gone. No
behavior change.

Refs #487
2026-10-08 16:08:03 +08:00
Willie 7a4103b9a8 refactor(extras): validate every mode change and share special extra names
cmdExtrasMode only ran ValidateExtraConfig behind a growing list of
conditions, so each new restriction needed another clause. For a plain
folder extra the full check adds only the mode-name and flatten+symlink
rules, which sync already rejects, so validating unconditionally cannot
refuse a config that syncs today.

The agents and memory extra names were string literals in sync, the
server handlers, the memory store, and the CLI. They now live in
internal/config, and the rename guard moves to ValidateExtraRename so a
future CLI rename reuses it instead of copying the check.

Refs #489
2026-10-08 16:08:03 +08:00
Willie dde1dc6ef7 refactor(extras): keep target mode rules in config
The rules "an extension forces copy mode" and "symlink mode drops
include/exclude" were re-implemented in the create, edit-target, and
quick mode handlers. ExtraTargetConfig.EffectiveMode and Normalize now
hold them in one place, and the handlers call those instead. API
behavior is unchanged: edit-target still clears filters on symlink,
quick mode still rejects symlink when the target has filters, and an
extension still forces copy.

Refs #488
2026-10-08 16:08:03 +08:00
Willie 5c50cc4b2b refactor(sync): pass extra targets instead of long argument lists
syncExtraDir took ten positional arguments, three of them bools, and
CollectExtraFiles took nine. Every new target field meant changing each
signature and every call site, and swapped bools compiled silently.

Both now take the target as config.ExtraTargetConfig plus an
ExtraSyncOptions for dry run, force and project root; SyncExtraTarget
takes the same options. The SyncExtra wrapper only served tests, so it
is gone and the tests call syncExtraDir directly. No behavior change.

Refs #486
2026-10-08 16:08:03 +08:00
Willie b699e1cfce Merge pull request #492 from runkids/runkids/extras-filter-435
feat(extras): choose which files each target syncs, and edit targets in place
2026-10-08 16:07:21 +08:00
Willie c182c42d1a fix(extras): keep filter changes from being dropped or saved invalid
- On a multi-target extra, `extras <name> --flatten --add-exclude ...`
  without --target took the flatten-for-all-targets path, which returned
  before the filter flags were applied, and still reported success. Filter
  flags now require --target there, like --mode.
- The `extras list` TUI mode picker saved a mode without validation, so a
  filtered target could be switched to symlink and break every later sync.
  The change is now validated before saving.

Refs #435
2026-10-08 16:01:01 +08:00
Willie 7740ee8798 fix(extras): relink symlinks to a missing source and accept negated includes
- Pointing a symlink-mode extra at a new source after its old folder was
  moved or deleted left the target broken: the old link no longer resolved,
  so it was not recognised as ours, and the next sync skipped it as pointing
  elsewhere. The link text is now compared with the old source as well.
- A negated include such as "!draft.md" only narrows earlier rules, so on
  its own it never matches and was always reported as matching no file.
  Negations are no longer checked for matches.

Refs #435
2026-10-08 15:52:47 +08:00
Willie 72ce921eeb fix(extras): validate hand-written filters and keep links when a save fails
- Sync validation skipped directory extras, so a malformed include such as
  "[" written in the config matched nothing and merge sync pruned every
  link. Extras with include/exclude now go through ValidateExtraConfig.
- The dashboard's quick Mode menu could switch a filtered target to symlink
  and save filters that every later sync rejects. That change is now
  validated with the target's filters and refused.
- Changing an extra's source removed the links into the old folder before
  saving the config, so a failed save left working targets broken. The
  config is saved first.

Refs #435
2026-10-08 15:44:39 +08:00
Willie c979bf0701 fix(ui): keep a context submenu open after switching back to it quickly
Every submenu trigger closed whichever submenu was open when its 180ms
leave timer fired. Moving from Mode to Flatten and back let Flatten's late
timer close Mode's submenu a moment after it opened. A trigger's timer now
closes only its own submenu.
2026-10-08 15:44:39 +08:00
Willie a9ae5349a2 feat(extras): choose which files each target syncs, and edit targets in place
A directory extra used to sync every file to every target, so a tool that
only wanted a few docs got the whole folder. Each target can now set
gitignore-style include/exclude patterns, matched on the path inside the
source. Merge targets prune links to files that stop matching; copy targets
keep earlier copies, since nothing records which copied files are ours.
Filters are rejected for symlink mode and single-file extras, and sync warns
when an include matches nothing.

The dashboard previously forced users to delete and re-add a target or an
extra to change it. Edit target now changes the folder, file name, mode,
flatten and filters with a live preview; Edit extra renames an extra or
points it at another source folder. A moved target or source drops the
links left at the old place and syncs right away.

CLI: --include/--exclude on extras init, and --add-include, --add-exclude,
--remove-include, --remove-exclude on extras <name>.

Refs #435
2026-10-08 15:31:51 +08:00
Willie 8d40e06975 Merge pull request #485 from runkids/runkids/unmatched-include-copy
feat(sync): explain include filters that select no skill
2026-10-08 15:16:48 +08:00
Willie bd7e67fffd fix(git): report unmatched include filters from the sync after a pull
The pull response copied only the sync's warnings, so with unmatched
include filters moved to their own field, the Git Sync page stopped saying
that a filter selected nothing after its automatic sync. The pull response
now carries them and the page shows the same notice as the Sync page.
2026-10-08 15:06:59 +08:00
Willie 81e0824396 fix(sync): skip unmatched include notices when the source is incomplete
When a followed source link cannot be read, the skill list is partial and
pruning is already skipped. Reporting a filter as unmatched in that state
told users the target gets no skills and sent them to edit a filter that
may be fine.
2026-10-08 14:59:59 +08:00
Willie 819ea634f5 fix(ui): show unmatched filter notices in every sync dialog
The project sync dialog and the sync preview modal show only the response's
warnings. With unmatched include filters moved to their own field, a sync
from those dialogs no longer said that a filter selected nothing. Both now
render the same notice as the Sync page.
2026-10-08 14:53:52 +08:00
Willie 47be5105f5 fix(sync): link each target's unmatched filter and ignore blank includes
Two global targets with the same unmatched filter were merged into one
notice whose Edit filter link opened only the first target, leaving the
other unfixed. Only a project's targets share a filter, so other targets
now keep their own notice and link.

A target whose includes were an unmatched pattern plus a blank entry was
not marked as getting no skills, because the check counted the raw list
while filtering drops blanks. It now counts the effective patterns.
2026-10-08 14:48:29 +08:00
Willie 5d5b0f3efb feat(sync): explain include filters that select no skill
The dashboard showed the CLI's raw line, "api-server@claude: include pattern
"*review*" matches no skill in the source", once per target. It named a
config field, did not say the target ends up with no skills, and gave no way
to fix it. Sync now returns these as structured entries; the Sync page
groups a project's targets into one localized notice that says what happens
and links to where the filter is edited. The CLI line also says the filter
adds nothing to the target.
2026-10-08 14:26:41 +08:00
Willie 1b1c8da5b4 feat(ui): keep Sync in reach on the Sync page
The Sync button sat in the sticky bar and the last-sync card started below
it, leaving the right column misaligned with the page header. The buttons
now sit on the card, which sticks with them, so Sync stays visible while the
change list scrolls. The Include bar keeps tight gaps at rest, gets more room
and a bottom line once it sticks.
2026-10-08 14:26:41 +08:00
Willie 0edbadca04 Merge pull request #483 from runkids/runkids/install-from-config
feat: install config entries from the dashboard, prune deleted skills, calmer Sync and Skills pages
2026-10-08 13:27:07 +08:00
Willie 7d6b26c759 docs: show the owner-repo name in the tracked --into example
Tracked repos are cloned as _owner-repo now, so the guide's devops/_skills
path and its flattened target name no longer match what install creates.
2026-10-08 13:05:41 +08:00
Willie e550874899 docs(install): name the tracked repo example by owner-repo in help
Tracked repos are cloned as _owner-repo now, so the help example pointed
users at a _shared-skills directory that no longer exists after install.
2026-10-08 13:00:23 +08:00
Willie 66750ac4e5 fix(ui): leave collapsed groups out of the Skills list paging
A collapsed group's items still used up the 100-item page, so later groups
stayed hidden behind Show more and the footer counted rows nobody could see.
2026-10-08 12:54:45 +08:00
Willie 906669df75 fix(install): reuse a tracked checkout cloned under the old basename name
Tracked repos are now named owner-repo, so repeating `install --track` for a
repo cloned earlier as _<basename> went to a new _owner-repo path and cloned a
second copy whose skills collide during sync. When that older checkout has
the same remote, keep using its name so the install skips as the same repo.
2026-10-08 12:54:45 +08:00
Willie 2188be740e fix(ui): require a fresh check before offering prune
Check statuses persist in one non-expiring localStorage entry shared by every
dashboard on the origin. A restored stale status could offer Prune for a
skill reinstalled since, or one in another project, and prune force-moves it
to trash. Stale is no longer restored from the cache, so Prune only appears
after a check in the current session.
2026-10-08 12:47:13 +08:00
Willie e84075dcec fix(ui): refresh the sync matrix after installing config entries
Newly installed skills had no target entries in the cached matrix while the
Skills page kept it mounted, so the Sync page could hide Discard all for them
until the cache went stale.
2026-10-08 12:40:30 +08:00
Willie e36c38abfc fix(ui): show a skill and an agent with the same name as two sync rows
The sync item grid indexed rows by display path, so a skill "reviewer" and
an agent "reviewer.md" collapsed into one entry while the header still
counted two changes. Keep every row under a shared path.
2026-10-08 12:34:59 +08:00
Willie 735c0fe876 fix(ui): key update check statuses by relative path
Statuses were stored under the skill's basename, so a/foo and b/foo shared
one entry. With Prune all acting on stale statuses, a stale b/foo also marked
a/foo stale and both would be sent to trash. Key statuses by relative path
and bump the cached format so old name-keyed entries are dropped.
2026-10-08 12:26:26 +08:00
Willie a686ee910f fix(server): install config entries into the project source in project mode
The dashboard's install-from-config context read the global skills source
from s.cfg, which stays global in project mode. Missing entries were checked
against the global folder and installed there instead of the project's
.skillshare/skills. Use the project-aware skillsSource and reload the
metadata store from that same folder before reconciling.
2026-10-08 12:26:26 +08:00
Willie f56049d3d3 fix(ui): offer a tracked repo to Discard all only when all of it is new
Uninstalling any skill of a tracked repo removes the whole repo, so when a
repo update brought one new skill while its siblings were already synced,
Discard all would have trashed the synced siblings too. A repo now qualifies
only when every skill in it has never been synced.
2026-10-08 12:19:17 +08:00
Willie a25215dfdc chore: release 0.25.3
The maintainer wants these changes shipped as a patch on the 0.25 line
rather than the 0.26.0 that the feat commits would otherwise propose.

Release-As: 0.25.3
2026-10-08 12:13:00 +08:00
Willie b09a068410 fix(ui): keep Discard all away from skills live in a symlink-mode target
The sync matrix marks symlink-mode targets `na` because filters don't apply,
so Discard all ignored them when deciding whether a skill had ever been
synced. A skill pending only for a merge target while already live through a
symlinked one was offered for discard, and trashing it would also pull it
from the symlinked target. Count those targets as receiving every skill.
2026-10-08 12:08:44 +08:00
Willie 535de2fced feat(ui): install missing entries, prune deleted skills, and calmer sync and skills pages
Installing what config records still needed the CLI, and skills deleted
upstream showed as updates with nothing to update. The Update page and
install dialog now offer Install all for missing entries, and stale skills
get Prune / Prune all, which move them to trash in one request.

A sync of hundreds of changes was a wall of identical rows per target. Sync
now groups targets that receive the same changes into one card listing names
by folder, keeps its action bar and summary sticky, and adds Discard all,
which moves skills that were never synced anywhere to trash after a
confirmation. The Skills page keeps its toolbar and group heads in view while
scrolling, folds New skill and Link folder into the Install menu, remembers
filters in the browser, and moves Update repo into the repo menu.
2026-10-08 12:01:42 +08:00
Willie e3af6274fc feat(install): install config entries from the dashboard and name repos by owner
Bare `skillshare install` already restores everything .metadata.json records
but the disk lacks, yet the dashboard could only re-clone missing tracked
repos through a separate rehydrate path. Expose the CLI's install-from-config
flow instead (GET /api/install/missing, POST /api/install/from-config) so both
surfaces share one detection and one installer, and drop the old
missingTrackedRepos plumbing from update responses.

The install summary now counts tracked repos and their skills apart from
standalone skills, since "Installed 1 skill" hid a whole repo. New tracked
repos are named `_<owner>-<repo>` so two `skills` repos no longer collide;
existing installs keep their names. `check` passes the stale status through
so the dashboard can offer to prune skills deleted upstream.
2026-10-08 12:01:42 +08:00
Willie 3bc8d6669b Merge pull request #471 from runkids/release-please--branches--main
chore(main): release 0.25.2
v0.25.2
2026-10-08 01:41:44 +08:00
Willie 290ef33841 Merge branch 'main' into release-please--branches--main 2026-10-08 01:41:17 +08:00
Willie 56925a5c3d chore(release): rewrite the 0.25.2 changelog for users
The generated entry listed each fix twice (a merge commit and its source
commit share a subject) and only named commits. Group the fixes by area,
say what changed for the user with examples, and note that overrides
for prompt-injection-4 do not carry over to prompt-injection-5.
2026-10-08 01:37:25 +08:00
Willie bbb3f04f27 docs: sync command docs for 0.25.2
The 0.25.2 fixes changed behavior the command pages still described
the old way: update said any .git/ directory makes a tracked repo, the
uninstall Project Mode section missed --into repos and the refusal
inside a tracked repo, and the audit rule table lacked
prompt-injection-5. Also translate the uninstall example comments that
were left in English in ja, ko, zh-Hans and zh-Hant.
2026-10-08 01:34:36 +08:00
github-actions[bot] 603eea669b chore(release): synchronize release metadata 2026-10-07 17:26:58 +00:00
github-actions[bot] 80887bf484 chore(main): release 0.25.2 2026-10-07 17:26:53 +00:00
Willie 9234861fad fix(ui): label Pi packages as packages in the Pi Extensions tab
Every entry Skillshare manages was titled "Plugins · <name>" with a box
icon, so Pi packages installed through the Plugins page looked like
plugins. The tab now splits them the way the Plugins page does
(piPackageTest): a Pi package reads "Package · <name>" with Pi's black
and white mark, and a plugin reads "Plugin · <name>" with the box icon.
2026-10-08 01:22:20 +08:00
Willie b8ce9e088c Merge remote-tracking branch 'origin/main' 2026-10-08 01:08:13 +08:00
Willie 61e0d3f295 docs(audit): list metadata analyzer in skill reference
Keep the built-in skill analyzer list aligned with the audit parser and website documentation.

Validated the five-locale website build, context-router check, and diff checks.
2026-10-08 01:07:55 +08:00
Willie ee41cf05d1 Merge pull request #482 from runkids/runkids/uninstall-into-shorthand
fix(uninstall): resolve tracked repo shorthand under --into
2026-10-08 00:30:58 +08:00
Willie 335dabd54d fix(uninstall): resolve tracked repo shorthand under --into
Reuse the shared tracked checkout resolver after checking the typed path so uninstall org/team finds org/_team without taking precedence over an existing skill or folder. Classify tracked targets by the underscore checkout rule across CLI uninstall entry points, retaining ambiguity errors and the shared inside-repo refusal.
2026-10-08 00:21:32 +08:00
Willie 6eb75547bf Merge pull request #481 from runkids/runkids/479-update-into-shorthand
fix(update): accept the org/team shorthand for --into repos in every entry point
2026-10-08 00:15:25 +08:00
Willie acd8e7e9bc Merge pull request #480 from runkids/runkids/478-reconcile-nested-entry
fix(config): reconcile tracked checkouts by exact metadata key
2026-10-08 00:07:36 +08:00