Two correctness improvements from Codex review:
1. EvalSymlinks before relative-link decisions: shouldUseRelative and
createLink now resolve symlinked ancestors via EvalSymlinks so that
a project opened through a symlinked workspace, or a target dir that
traverses a symlink, produces correct relative paths (or falls back
to absolute when paths diverge from the project root).
2. Atomic reformat via reformatLink: instead of remove→create (which
loses the link on createLink failure), reformat now creates a temp
link and renames it over the original. On Unix this is atomic; on
Windows it falls back to remove→create when rename fails.
Tests added for symlinked project root, divergent target symlink,
and reformatLink atomic swap.
On Windows without Developer Mode, createLink falls back to an NTFS
junction (always absolute). linkNeedsReformat would then return true
on every sync, causing a remove→recreate loop.
Add build-tagged canCreateRelativeLink(): returns true on Unix, and
on Windows probes once with sync.Once by creating a test relative
symlink in a temp dir. linkNeedsReformat skips reformat when the
platform cannot create relative links.
Also use filepath.Clean instead of filepath.Abs in resolveReadlink
(input is already absolute, avoids unnecessary os.Getwd).
Addresses PR #122 review feedback.
- shouldUseRelative: avoid double separator when projectRoot is /
- symlink_windows.go: use pre-resolved absTarget/absSource for Rel
- extras.go: check os.Remove error on wrong symlink replacement
filepath.Abs(dest) on a relative readlink result resolves against CWD,
not the symlink's parent directory. This broke the 'already correct'
check when comparing relative symlinks to absolute source paths.
Add resolveReadlink() helper that joins relative targets with
filepath.Dir(linkPath) before calling filepath.Abs.
Also check os.Remove errors in all reformat paths instead of ignoring
them silently.
Addresses PR #122 review feedback.
sync previously skipped symlinks that pointed to the correct source,
even if their format (absolute vs relative) didn't match the expected
mode. This meant existing absolute symlinks in project mode were never
converted to relative on subsequent syncs.
Add linkNeedsReformat(dest, wantRelative) helper that checks whether
the raw readlink result has the wrong format. All four 'already
correct' skip points now check format and recreate when mismatched:
- SyncTargetMergeWithSkills (skills merge mode)
- SyncTarget (skills symlink mode)
- syncExtraSymlinkMode (extras directory symlink)
- syncOneExtraFile (extras per-file merge)
Global mode is unaffected: shouldUseRelative returns false, so
linkNeedsReformat never triggers on absolute links.
Also fix macOS /var → /private/var path mismatch in
TestSyncProject_RelativeSymlinks by EvalSymlinks on expected path.
status command used a legacy local parser that only looked for a
top-level version: key in SKILL.md frontmatter, always returning empty
since version now lives under metadata.version.
Replace local readSkillVersion() and fetchRemoteSkillVersion() with
the shared versioncheck.ReadLocalSkillVersion() and
FetchRemoteSkillVersion() from internal/version, matching what doctor
and upgrade already use.
Remove now-unused skillshareSkillURL constant from init.go.
Closes#121
Replace direct os.Symlink calls in extras.go with createLink, gaining:
- Relative symlink support in project mode
- Windows junction fallback for extras (previously missing)
Thread projectRoot through SyncExtra, CollectExtraFiles, and all callers.
Ref: #120
Project-mode sync now passes the project root directory through to
createLink, enabling relative symlinks for all paths under the project.
Server handlers use s.projectRoot for project-mode dashboards.
Ref: #120
SyncTargetMerge, SyncTargetMergeWithSkills, CreateSymlink, and SyncTarget
now accept projectRoot. When non-empty, createLink uses relative symlinks
for paths under the project root.
All existing callers pass empty string (global mode, no behavior change).
Ref: #120
Unix: computes filepath.Rel from link dir to source, falls back to
absolute on error.
Windows: tries os.Symlink with relative path first (Developer Mode),
falls back to mklink /J with absolute paths.
All existing call sites pass false (no behavior change yet).
Ref: #120
Determines whether both source and target paths are under the project
root, in which case relative symlinks are portable and can be committed
to git.
Ref: #120
Sync's registry prune logic removed entries for installed skills whose
files were missing from disk. This was wrong: the registry is the
authoritative record of installations managed by install/uninstall.
Remove PruneStaleSkills calls from sync (CLI global, CLI project, and
web UI handler). Reconcile (called during install) still uses prune
with full metadata context, which is correct.
Fixes: running 'sync' after 'install' would clear registry.yaml when
the installed skill's source files were not yet on disk.
Covers setting up multiple Claude Code accounts via CLAUDE_CONFIG_DIR
aliases, syncing skills across accounts with skillshare targets, and
syncing rules/hooks/agents with the extras feature. Includes web UI
section and full config example.
Extract RELEASE_NOTES generation, version bump, and announcement
drafting from /changelog into a new /release skill that orchestrates
the full end-to-end release workflow.
/changelog now focuses solely on CHANGELOG.md + website sync (7 steps).
/release handles: validate → changelog → release notes → version bump
→ commit & tag → draft announcements → present & confirm (7 phases).
Switch DialogShell backdrop detection from onClick to onMouseDown.
The click event's target resolves to the nearest common ancestor of
mousedown/mouseup positions, so dragging a text selection from an
input onto the backdrop would fire onClose. mousedown's target is
always the element directly pressed, so only an intentional press on
the backdrop itself triggers close.
- Add onMutate to batchMutation for instant UI updates (mirrors
server matchesFolder logic, skips disabled/tracked-repo skills)
- Show inline Spinner next to the folder badge during batch ops,
derived from batchMutation.variables (no manual state sync)
- Block context menu and target selection while batch is pending
to prevent conflicting mutations
- Extract normalizeTargets result into variables to avoid redundant
calls in skill row rendering
- Add normalizeTargets helper: treats ['*'], null, and [] as All
- Folder target summary now reflects direct skills only, not the
entire subtree — child folders have their own visible badges
- Skill badges in grouped view also use normalizeTargets so '*'
displays as 'All' instead of a literal asterisk
- Mixed display: shows 'Mixed' when some skills are All and others
have specific targets (with tooltip showing the breakdown)
When all skills in a folder are tracked-repo members (read-only), the
batch target mutation now shows an error toast instead of a misleading
'0 skills now available in X' success message.
- Enable frontmatter parsing in DiscoverSourceSkillsAll so /api/skills
returns saved targets (fixes target display reverting to All)
- Skip tracked-repo skills in batch/single target handlers to prevent
dirty git state; reject with 400 for single-skill endpoint
- Add RefreshMetaHashes to recompute audit hashes after SKILL.md edits;
batch handler refreshes outside the write lock
- Show 'Uninstall Repo' with confirm dialog for tracked-repo members
instead of the always-failing individual uninstall action
- Return 409 Conflict when enabling a skill disabled by glob pattern
in .skillignore/.skillignore.local instead of false success
- Preserve IsInRepo flag for root-skillignore-disabled skills so they
remain visible in the Tracked tab after disable
- Update changelog and website changelog for v0.18.7
- doctor: replace inline frontmatter parser with version.ReadLocalSkillVersion
which correctly reads nested metadata.version (fixes#119)
- frontmatter_write: use TrimRight instead of TrimSpace for --- delimiter
so indented --- inside YAML block scalars is not mistaken for end marker
- Update changelog and website changelog for v0.18.7
- Fix folder trailing slash bug: filepath.Clean now normalizes input
before matchesFolder comparison (e.g. 'frontend/' → 'frontend')
- Narrow mutex scope in handleBatchSetTargets: RLock for config read,
no lock during DiscoverSourceSkillsAll, Lock only for write loop
(matches existing handleSetSkillTargets pattern)
- Defensive filepath.Clean on cleanEmptyParents inputs
- Add TestMatchesFolder unit test and trailing slash handler test
- Add explicit undefined initializer to useRef<T>() for React 19 compat
- Remove unused isProjectMode from DashboardPage (dead after refactor)
- Remove unused queryClient/toast from SkillsTable (moved to useSkillActions)
Grouped view:
- FolderNode target aggregation (bottom-up O(n) computation)
- Target badges on folder rows (uniform/mixed) and skill rows
- Right-click context menu for batch (folder) and single (skill) editing
Grid view:
- Target badges on skill cards
- Right-click context menu for single skill editing
Table view:
- 'Available in' column with inline Select dropdown
- Simplified to 5 columns (merged Path/Source into Name)
- Actions column (⋯) with flat menu items
- Page size persisted in localStorage
All views:
- Shared useSkillActions hook with optimistic cache updates
- Context menu actions: Available in, View Detail, Enable/Disable, Uninstall
- ConfirmDialog for destructive actions
- Hover-matching highlight on active context menu item
- Clickable source globe icon linking to repo
- Dismissible right-click tip banner with playful theme
Config page:
- Panel wrapper overflow-visible when expanded (fixes dashed border clipping)
Closes#115.
New utility: SetFrontmatterList() writes/removes YAML list fields
in SKILL.md frontmatter with dot-notation support (metadata.targets).
Normalizes legacy top-level targets field. Preserves body content.
New endpoints:
- POST /api/skills/batch/targets — set targets for all skills in folder
- PATCH /api/skills/{name}/targets — set target for single skill
Both use s.mu.Lock() for safe concurrent access.
Includes 15 unit tests covering set/remove/traverse/root-only/not-found.
Part of issue #115.
P2-1: handleUninstallRepo and handleBatchUninstall used s.cfg.Source for
gitignore removal, but project-mode installs write to .skillshare/.gitignore
with a "skills/" prefix. Add gitignoreDir() helper that returns the correct
base directory per mode, and prefix entries in project mode.
P2-2: Registry prune used filepath.Base(repoName) to derive the legacy group,
causing sibling nested repos (e.g., org/_team-skills vs dept/_team-skills) to
collide on the same basename. Now uses exact Group match for nested repos and
restricts legacy basename matching to top-level repos only.
Tests added (15 new):
- resolveTrackedRepo: auto _ prefix, nested, already-prefixed, not-found,
basename fallback
- Registry prune: full-path Group, nested members by prefix, sibling isolation
- Project-mode gitignore: single + batch uninstall
- updateSingle: basename fallback, not-found, regular skill priority
- cleanEmptyParents: multi-level, stops at non-empty, stops at boundary
- Add 'xs' button size tier (px-2 py-1 text-xs) to Button component
- Use xs buttons for tracked repo Update/Uninstall actions to reduce
visual weight in row-level controls
- Move clean/modified status from action area to info group (left side)
as Badge — status is metadata, not an action
- clean: subtle default Badge; modified: warning Badge with dot
- Remove unused Check icon import
ReconcileGlobalSkills uses PruneStaleSkills(skillsOnly=false) which
removes agent entries unrelated to the uninstalled repo. The explicit
filter + Save is sufficient; full reconcile deferred to next sync.
- updateSingle: check exact skill path before resolveTrackedRepo
fallback, preventing basename collision with nested repos
- handleUninstallRepo: match repo's own registry entry by FullName
in addition to group-based matching for member skills
P1: updateSingle now uses resolveTrackedRepo (shared with uninstall)
to find nested tracked repos like org/_team-skills instead of only
probing root-level _name/name.
P2: handleUninstallRepo now prunes registry entries belonging to the
uninstalled repo and runs ReconcileGlobalSkills/ReconcileProjectSkills,
matching the cleanup that handleUninstallBatch already does.
Extracted resolveTrackedRepo as a Server method to deduplicate the
nested path resolution logic between uninstall and update handlers.
MoveToTrash, List, Restore, and Cleanup all assumed flat names.
When a nested tracked repo like org/_team-skills was uninstalled,
the trash entry landed in a subdirectory that List could not see
and Restore could not reach.
- MoveToTrash: create intermediate dirs via filepath.Dir(trashPath)
- List: recursive WalkDir to discover nested entries, store full
relative path in TrashEntry.Name
- Restore: MkdirAll on destination parent before rename
- Cleanup: remove empty intermediate dirs after expiry via
cleanEmptyParents helper
Closesrunkids/skillshare#116 follow-up (nested trash path)
Add handler tests for nested tracked repo uninstall, ambiguous basename rejection, and traversal rejection.
Also isolate trash-backed server tests by setting XDG_DATA_HOME in test helpers.
Validate tracked repo names against path traversal and surface repository listing errors in the uninstall handler.
Track in-flight dashboard repo actions with sets so loading state stays correct during overlapping clicks.
Add update and uninstall controls to the dashboard tracked repo list.
Handle nested tracked repo paths in the uninstall API so dashboard actions work for both top-level and nested repos.
- Fix UI batch uninstall not removing nested skill registry entries:
handler used flat names (__) but registry stores path names (/),
now tracks exact RelPath from discovered skills for matching
- Add stale entry pruning to ReconcileGlobalSkills and
ReconcileProjectSkills using a live set built during disk walk,
so skills deleted from source are removed from registry
- Trigger registry reconcile after sync in both UI handler (via defer
for early-return safety) and CLI (global + project mode), writing
warnings to stderr to avoid corrupting --json output
- UI: fix BatchUninstallPage search treating plain text as exact-match
glob (now substring search when no * or ? present), display nested
skill paths with / instead of __ in confirm and result dialogs
- UI: hide redundant 'X repo(s) and Y skill(s) already up to date'
line on UpdatePage when everything is already current
- Fix test isolation: set XDG_CONFIG_HOME in server test helpers to
prevent host agents dir leaking into test results, skip chmod-based
oplog test when running as root
- Add README badge for Awesome Codex CLI