The mcp serve read-only hints and opt-in skill editing (#577) ship as
0.25.13 instead of the computed 0.26.0, per maintainer decision.
Release-As: 0.25.13
* feat(mcp): let mcp serve clients edit listed skills
A remote assistant that reaches skills only through `mcp serve` could
read them but had to hand every change back to a person (#540). Skills
listed in `mcp.serve.edit.skills` can now be changed one existing file
at a time: `preview_skill_edit` writes nothing and returns the full
diff, the audit result and a preview id, and `apply_skill_edit` saves
exactly that preview, once.
Every save is tied to the revision the client read, so a file changed
in the meantime fails with a conflict instead of being overwritten.
Skills that `update` would overwrite stay read-only: tracked repos,
upstream installs, and skills nested inside an install. The skill is
validated and audited in a temporary copy before anything is written;
as with install, a finding at or above `audit.block_threshold` refuses
the edit unless it was accepted with `--force`, and findings are marked
new or existing so the client can see what its change adds.
The write is atomic, keeps the file mode, goes through sourcefs link
checks, and is recorded in the operation log. Native Skills extension
clients still see the edit tools, since the extension cannot write.
* fix(mcp): close gaps in mcp serve skill editing
Codex review of #577 found five ways the edit tools could do more, or
record less, than they promise:
- A blank pattern in mcp.serve.edit.skills was dropped by the filter,
and no patterns match every skill, so `skills: [' ']` made every skill
editable. Blank patterns are now a config error.
- preview_ttl was only checked when skills were listed, so the dashboard
could save an invalid value that later stopped mcp serve. It is now
checked whenever edit is present.
- Apply compared only the edited file's digest, so two previews of
different files, or an edit made elsewhere in between, could save a
skill state that was never validated or audited. Apply now checks and
audits the skill again as it will be saved.
- Edit audits were not written to audit.log, so blocked attempts left no
trace in `skillshare log --audit`. Each preview and apply audit is now
logged like install's audit gate.
- The writability check migrated legacy metadata, so a "writes nothing"
preview (and --check) could rewrite .metadata.json and delete
registry.yaml. It now reads the store without migrating; a legacy
registry.yaml keeps every skill read-only, and a legacy sidecar marks
its skill as installed.
Clients and gateways that gate tools by annotation treat a tool without
readOnlyHint as one that changes data. Executor v2 does, so every
list_skills or read_skill call could stop for approval even though both
only read the skills source. Marking them read-only lets those clients
call them without asking. Refs: #540.
The windows-test job lists only the packages verified to pass on Windows, so
that the job is green on arrival. internal/memory never reached that list: it
is absent from #344's set of failing packages, and no commit ever added it,
which leaves its 36 tests unrun on the platform whose binaries are published.
Cross-compiled the package's test binary for windows/amd64 and ran it on a
real Windows host: 36 top-level tests passed, 0 failed, exit code 0. The
symlink call sites in store_test.go skip or drop their subcases when the
privilege is missing, so a runner without Developer Mode cannot fail on them.
* chore(main): release 0.25.12
* chore(release): synchronize release metadata
* docs(changelog): write user-facing 0.25.12 notes
The generated entry listed commit subjects only. Describe each fix by what a
user sees: the token in ps, unchanged skills reinstalled by update --all, the
silent fetch failure, missed updates behind symlinks, and the dashboard
breaking after upgrade, with examples and issue references.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
0.25.12 changes two things users can notice that the docs never covered.
Token auth now goes through a host-scoped credential helper (#566), so the
token stays out of ps and git skips the user's own helper or keychain for
that host. Grouped updates now warn when a repository cannot be fetched
(#570), with credentials removed from the URL and error. Note both on the
install and update pages in every locale.
* fix(update): stop trusting tree hashes for skills with symlinks
Install copies a file symlink's target, but git stores the link as a blob
holding the target path, so a skill's subtree hash stays the same when a
target outside the folder changes. Batch update skipped such skills as
current and check reported them up to date, leaving stale content installed.
A subdir that holds a symlink now has no usable tree hash: install records
none, update falls back to a reinstall, and check reports the skill as
update_available. Check lists entries with -z so links with non-ASCII names
are not missed behind git's path quoting.
Closes#572
* fix(check): split ls-tree -z output on NUL only
parseLsTreeOutput also split on newlines so the old newline fixtures kept
passing, but with -z a newline belongs to the path. A directory or symlink
whose name holds a newline was cut in two, and a symlink under it was missed.
The fixtures now use NUL-terminated entries like real -z output.
Also writes both shortcut comments in the repo's one-line form and uses
testutil.RunGit in the new update test instead of a raw exec call.
* docs(update): note that skills with symlinks always reinstall
The update page says grouped updates leave skills whose folder did not
change alone. A skill with a symlink no longer has a usable tree hash, so it
is reinstalled whenever the upstream commit moves. State that exception on
the English page and its four translations.
* fix(update): read store in batch fast path
The grouped update fast path read per-skill .skillshare-meta.json
sidecars. The migration to .metadata.json deletes those files, so the
check never matched and update --all reinstalled every skill on every
run.
Read the central store instead, and refresh version and commit there
instead of writing a sidecar. Require SKILL.md on disk so the update
restores a deleted install. --force now skips the check and reinstalls
everything.
* test(update): cover legacy grouped metadata keys
Grouped skills can still be stored under a basename key with a Group
field. Check that the current-skill lookup finds that entry and that the
version refresh updates it in place instead of adding a new key.
* feat(update): report up-to-date skills
The summary lumped skills the fast path skipped in with failures. Count
them as "up to date" in the summary and as up_to_date in --json
output.
* feat(update): log up-to-date count in oplog
The operations log recorded updated, skipped, pruned, and blocked counts
for update but not the new up-to-date count. Record it as up_to_date
so the log matches the summary and --json output.
* test(update): cover up-to-date batch skills
update --all reinstalled every grouped skill on every run. Check that
unchanged skills report as up to date in global and project mode, that
an upstream change updates only the changed skill, and that --force
reinstalls everything.
* docs(update): describe up-to-date batch skills
Describe how update --all and --group leave unchanged skills alone and
report them as up to date, the up_to_date JSON field, and the new
meaning of --force.
* fix(update): keep lock pins on tree-only matches
A tree-hash match after upstream HEAD moved refreshed the full commit in
the store. A project lock pin follows that field, so an unrelated
upstream commit rewrote skills.lock.json even though the skill's files
did not change. Refresh only the version, as the old sidecar refresh
did. check compares the version, so it still reports the skill as up to
date.
The help text, docs and skill reference said --all and --group skip
current skills. The skip lives in the batch path, which runs for any
update of several skills, and a single skill always takes the reinstall
path. Say that instead.
* fix(update): load the store once per batch
Each skill skipped as current reloaded .metadata.json before comparing
its version, so an unchanged batch reparsed the whole store once per
skill. Compare the version already read from the snapshot first, and
refresh the skills that do lag HEAD with one load and save after the
loop. An unchanged batch of 400 skills drops from about 520ms to 64ms.
The help text and docs said any update of several skills takes this
path. In global mode, named and glob targets carry no metadata and
reinstall on the standalone path. Name what does take it: --all,
--group, and several skills named in project mode.
---------
Co-authored-by: Willie <egg358358@gmail.com>
* test(update): cover batch fetch failure warning
A batch update that cannot fetch a repo counts its skills as skipped and
prints nothing about it. Remove the remote after installing two grouped
skills and check that update --all names the repo in a warning.
* fix(update): warn when a repo fetch fails
When a clone failed during update --all, the summary counted its skills
as skipped and printed nothing. That hid a repo that timed out on every
run. Print the repo and the error.
* fix(update): redact credentials in fetch warning
The fetch warning printed the stored repo URL as is. An HTTPS URL can
carry a token as userinfo, and git error text can echo that URL, so the
token reached stdout and CI logs. Name the repo with DisplayURL, which
already strips userinfo for submodule URLs, and redact the userinfo
from the error text.
* fix(update): redact query tokens in fetch warning
The fetch warning redacted only the userinfo of the repo URL. A token in
the query survived in the error text, since git echoes the full URL.
And DisplayURL treats the last "@" anywhere as the end of userinfo, so
an "@" in the path named a different repo.
Parse http(s) repo URLs the way git does: userinfo ends at the last "@"
before the first "/", and the query and fragment go too. Remove the
same parts from the error text. Other URLs print unchanged. DisplayURL
goes back to being private to submodule.go.
---------
Co-authored-by: Willie <egg358358@gmail.com>
An already-running UI server still reads lazy-loaded chunks from its versioned cache after the CLI binary is upgraded. Preserve the pre-upgrade version alongside the downloaded version so upgrade cleanup does not break page navigation.
Add a multi-version cleanup regression test and document the retention policy and accepted consecutive-upgrade limitation across all website locales.
Token auth rewrote the clone URL with url.<user>:<token>@host.insteadOf.
git hands the rewritten URL to git-remote-https as an argument, so any
user on the machine could read the token with ps for as long as a clone
or fetch ran. Every platform token (GitHub, GitLab, Bitbucket, Azure
DevOps, Gitea, CNB) went through the same rewrite.
git now gets the token from a credential helper scoped to the host,
which reads it from SKILLSHARE_GIT_AUTH_PASSWORD; printf is a shell
builtin, so the token never reaches an argv. An empty helper entry
first clears the user's own helpers for that host, so git neither asks
their keychain nor erases from it on a 401, and no longer stores the
skillshare token there as the URL rewrite did.
An http.extraHeader was tried first and dropped: the header goes out
before any 401, so a stale token broke installs from public repos, and
after a rejection git fell back to the user's helper and erased their
stored credentials.
Refs #565
The callout in every README now names the 0.25.11 changes: the MCP pin
and tool-change checks and the list detail panel's Targets row.
aleps001 reported the backup staging leak fixed in #558 (#556).
* chore(main): release 0.25.11
* chore(release): synchronize release metadata
* chore(release): write user-facing notes for 0.25.11
Replace the generated commit list with notes that explain what users
see: the MCP pin and tool-change checks with examples, the backup
cleanup fix, and the list detail panel's Targets row. The internal
skills code-review change is left out because it does not reach users.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
* fix(list): show every target sync placed a skill or agent in
The Targets row of the list detail panel only looked for a symlink named
after the skill's flat name in the target's skills folder. It therefore
left out targets that sync fills in copy mode, targets linked whole in
symlink mode, targets using standard or prefixed naming, and every agent
target (agents were looked up in the skills folder). Targets with skills
turned off were still listed.
The row now asks sync's own name resolution and manifest which entry a
target holds for the skill, and checks agents in their resolved agents
folder by mode or extension output. Each target is resolved once per load
so moving through a large source under standard naming stays fast.
* fix(list): drop a skill's targets as soon as it is disabled in the TUI
Pressing t updated the row's disabled flag but not the discovered skills
that sync's name resolution reads, so the open list kept showing the
skill's targets while a reopened list, which rediscovers it as disabled,
showed none. The toggle now updates that flag too, so both agree: a
disabled skill lists no target, since the next sync removes its entries.
The Playwright example now pins @0.0.83, so readers asked whether a
version is required. It is not: without an exact version (or with
latest, a tag or a range) mcp check only warns, and the server still
syncs and starts.
* feat(mcp): pin tool definitions in mcp check --live and warn when they change
An Agent reads a server's tool names and descriptions as instructions,
and a server can change them after the user reviewed it (a "rug pull").
The MCP spec 2026-07-28 local-server security guide notes the protocol
does nothing about this and advises clients that re-prompt on a changed
definition; most clients do not.
`mcp check --live` now records one SHA-256 per tool over name,
description and inputSchema the first time a server answers, in
mcp/tool-pins.json of the state directory, keyed by scope and server.
Later probes report a changed or new tool as a `tool-change` warning and
a removed one as info, until `--accept-tools` (only with --live) records
the current definitions. Without --live the pins are never read or
written. An unreadable pin file is never rewritten, since it may hold
other servers' pins. The dashboard words both warnings in every locale.
* fix(mcp): keep schema numbers exact, name the scope to accept in, and log acceptance
Codex review on #560:
- Tool definitions were decoded through float64 before hashing, so a
schema bound changed from 9007199254740992 to 9007199254740993 hashed
the same and raised no warning. Numbers now keep their literal text.
- The suggested accept command left out -g/-p; run from inside a project
after a global check, it would accept the project's server instead.
It now names the scope of the check that warned.
- Accepting changed tool definitions approves a possible rug pull, but
left no record. --accept-tools now writes an operations log entry with
the servers it accepted.
* fix(mcp): log a tool acceptance only when its baseline was saved
Codex review on #560: when comparing succeeded but writing tool-pins.json
failed (lock held, state directory unwritable), the report kept its
"accepted" finding, so the operations log listed the server as accepted
with status ok although its old pins remained. Such a server is now
logged under `failed` and the entry's status is error.
* fix(mcp): log first pins as accepted and report errors in the accept entry
Codex review on #560:
- A check that accepted one server but found an error on another still
logged status ok, while the command itself exited 1. A server with an
error is now listed under `failed` and the entry's status is error.
- --accept-tools on a server's first probe records its baseline, but the
finding says "pinned", so the entry listed nothing as accepted. A first
pin counts as accepted now.
* chore(release): request version 0.25.11
The MCP pin checks (#559, #560) and the backup staging fix (#558) ship
as 0.25.11 instead of the computed 0.26.0, per maintainer decision.
Release-As: 0.25.11
* feat(mcp): warn when a local server runs an unpinned package or image
An entry such as `npx -y some-mcp` fetches whatever the registry serves
at every Agent start, so a compromised release reaches the machine on the
next launch without anyone noticing. The MCP local-server security guide
(spec 2026-07-28) names version pinning as a baseline and points out
that a container tag can move while a digest cannot.
`mcp check` now adds a `pin` finding from command and args alone, with no
network: npx, uvx and `pipx run` with no version or `latest`, and
`docker`/`podman run` with no tag or `latest`, are warnings; an image
pinned by tag but not by `@sha256:` digest is info. Value-taking run
flags are skipped so hardened lines such as `--cap-drop ALL` are not read
as the image. Warnings keep the exit code at 0, as before.
* fix(mcp): check every npx package, word pin warnings in the dashboard, document them in doctor
Codex review on #559:
- npx accepts --package more than once and fetches each one, but the pin
check stopped at the first, so `npx --package=lodash@4.17.21
--package=cowsay cowsay` passed although cowsay is unpinned. Every
--package/-p value is now checked.
- The dashboard words env, command and dns findings in the viewer's
language but showed the new pin warning in English. It now has its own
sentence for an unversioned package and for an untagged image in every
locale. The dashboard hides info findings, so the digest note needs none.
- doctor promotes check warnings, so an unpinned launcher now shows there;
its docs list the pin check.
The mcp check runbook gains a step for the pin check.
* fix(mcp): check uvx --with packages and ignore environment markers in pins
Codex review on #559:
- uvx --with (-w) installs each named package beside the tool, so an
unpinned one moves just like an unpinned tool, but the pin check
skipped it as a flag value. Every --with requirement is now checked
next to the --from or command package.
- In `--from 'mcp-server; python_version == "3.12"'` the == belongs to
the environment marker, not to the package, yet it read as a pinned
version. Only the requirement before ';' is inspected now.
* fix(mcp): treat only exact versions as pins, and pin the docs' own examples
Codex review on #559:
- npm resolves a dist-tag (`@next`) or a range (`@^1.2.3`) to whatever
release matches at launch, yet any selector but `latest` passed as
pinned. An npx package is pinned now only by an exact semver version,
the rule Pi bindings already use.
- `==1.*` is a prefix match in Python version specifiers, so
`uvx --from 'mcp-server==1.*'` can pick up a new 1.x release; it is no
longer read as a pin.
- The Context7, Playwright and filesystem examples in the docs and the
built-in skill launched unpinned packages, so copying them produced the
new warning at once. They now name the current registry version.
* fix(backup): reclaim abandoned staging directories safely
Interrupted backup copies leave hidden .snapshot-* directories that retention cleanup never discovers. Hold a shared process lock during copies and use an exclusive cleanup lock to reclaim orphaned staging without deleting active work.
Share retention planning with non-mutating dry runs, report busy manual cleanup in the CLI and API, and align dashboard messages and translated docs. Cover process interruption and automatic cleanup with regression tests and an executable E2E runbook.
Closes#556
* fix(backup): address staging cleanup review findings
Keep cleanup reachable for staging-only dashboard backups and disclose abandoned incomplete directory deletion in every confirmation locale. Cover the empty-state confirmation with a regression test.
Read staging entries before a read-only lock probe so first-use dry runs cannot count a newly active writer. Refresh entries only under the acquired lock and classify both backup-root reads in the filesystem guard.
* fix(backup): align cleanup guides and doctor status
Disclose abandoned incomplete directory removal in backup help, completion descriptions, and the daily backup guide with all four translations. Add help and completion regressions so these consumers stay aligned with cleanup.
Keep the doctor Backups row visible when only the persistent lock remains after cleanup, preserving the existing JSON check and covering the lock-only state.
* fix(backup): complete cleanup documentation disclosure
Cleanup reclaims abandoned incomplete directories regardless of retention, so retention-only summaries understated the action. Align the backup synopsis, option table and previews, related workflow guides, built-in reference and all four website translations. Scope the retention defaults to completed snapshots.
None of these paths exists in the checkout or is written by a script, build or workflow in the repo: old planning and tool folders (docs/plans, docs/superpowers, openspec, .spectra, .superpowers, .feature-radar, showcase), MEMORY.md and internal/server/dist. !/proposals/ re-included a folder no rule ignores. git status --ignored lists the same paths before and after.
Entries had piled up under "Test" and after "Air hot-reload" regardless of what they ignore, and /specs/ was listed twice. Group them by purpose and drop the duplicate and openspec/.vector-search.db*, which openspec/ already covers. git status --ignored lists the same paths before and after.
skillshare sync -p rewrites both manifests on every run, if only to bump updated_at, so each sync left a diff to discard. The links they describe stay tracked; the manifests stay on disk for sync.
The skill syncs to .agents/skills, so Pi and Codex read it too. Naming Sonnet made Pi fail to start every review subagent, since its model registry has no such model. Use the tool's default subagent model, and run the passes in sequence where a tool has no subagents.
Contributors had to run `skillshare sync -p` before the project skills
showed up in Claude Code or in agents that read .agents/skills. Tracking
the links makes them available right after cloning. The manifests drop
skillshare-codebase-audit, which was removed in b9304e01.
The code review skill also treats translated docs as consumers, so an
English page change without its website/i18n copies is reported.
The skill restated the audit topic in an older form: its flag grep matches
no file because the CLI parses its own arguments, and its fixed list of
mutating commands contradicts the topic's rule to judge from current
behavior. The audit topic stays the source for consistency audits.
The contributor page listed it, so it now lists skillshare-code-review in
its place, and uses the skills' real names, which gained the skillshare-
prefix in an earlier rename.
Reviews so far ran /simplify and a generic /code-review separately. Neither
knows AGENTS.md, the wiki topics, or the consumer sweep the pull-requests
topic asks for, so Codex kept finding missed consumers one round at a time.
skillshare-code-review runs correctness, rules, spec, consumer and cleanup
passes in parallel, verifies each finding against the code, and reports by
pass. AGENTS.md now asks agents to run it with `fix` on their own change
after finishing a request and before opening a pull request; a review the
user requests stays read-only.
* chore(main): release 0.25.10
* chore(release): synchronize release metadata
* docs(changelog): describe 0.25.10 for users
Replace the generated commit list with what changed on the dashboard: Open folder on the MCP page and a project's Agent files on its MCP tab.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
The README callouts still described 0.25.6. They now describe the MCP
page's Open folder and the project MCP tab's Agent files, in every
translated README.
The built-in skill said the MCP page has a Projects tab; that tab
redirects to the Projects page, where each project's MCP tab now also
lists the project's Agent files.
* feat(mcp): open an Agent's MCP config folder, and project files, from the dashboard
A user who wants their own editor (Notepad++ on Windows) found setting
both PATH and $EDITOR too much just to open a config file, and could not
find any entry point for the MCP files of an mcp.projects root (#538).
Each Agent row on the MCP page now also has Open folder, which opens the
folder holding the file in the file manager, so any program can open it
from there. Before the Agent has written its file, it opens the closest
folder that exists. The project MCP tab gets the same Agents list for
that project's files. The open endpoint resolves project paths from the
config, as it does global ones, so a request still cannot name another
file, and folder and file opens keep the same-machine and headless
guards. The file manager launch is shared with the extensions folder.
* fix(mcp): keep a project's existing Agent files listed for remote viewers
Codex review: the project MCP tab built its Agents list from the
project's targets plus the files this viewer could open. A viewer on a
LAN address or behind a proxy can open none, so an existing file of an
Agent outside the project's targets dropped off the list, although the
docs say it shows with its path and only the open buttons go.
The list now returns which files exist apart from whether this viewer
may open them, and the page shows the open buttons only when local.
* fix(mcp): list the Agents a project's own servers write to in its file rail
Codex review: a server that exists only in one project can pick Agents
outside the project's targets, and sync writes their project files, but
the project tab listed only the project's targets and files that already
existed. Before the first sync such an Agent had no row, so its path
could not be copied and its folder could not be opened.
The list now also takes the targets of the project's own servers. Global
servers reach a project only through its targets, so they add nothing.
The rule lives in mcpView as projectFileTargets, with a unit test.
* chore(main): release 0.25.9
* chore(release): synchronize release metadata
* docs(release): write user-facing notes for 0.25.9
Replace the generated commit list with notes that describe each change
from the user's side, with examples, matching the recent entries.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
The MCP page's Open in editor button (#552) was documented only in the
English command reference, so ja, ko, zh-Hans and zh-Hant readers did not
learn about it or that it shows only when the browser runs on the
dashboard's machine.
* fix(config): keep YAML anchors and aliases when a command writes the config
Every writer re-encodes the in-memory struct, which has no anchors, so a
command such as `target a --add-exclude` expanded `&shared` / `*shared`
under targets and projects and the lists stopped following each other.
The comment pass added for #525 already pairs each old node with the one
that replaced it; relinkAliases uses the same pairs to put anchors back and
turn unedited alias values into aliases again.
An anchored node keeps its anchor and the aliases that still hold its old
value follow its new value, as the file declares. An alias that was edited
keeps its own list and leaves the anchored one alone. Output is sorted by
name, so the anchor moves to the first place the group appears: an alias
may not precede its anchor.
Fixes#546
* fix(config): keep YAML merge keys when a command writes the config
A command rewrites config.yaml from the Go struct, which holds the merged
keys of `<<: *base` and not the merge itself, so every merge key was written
out expanded and later edits of the anchored mapping no longer reached the
mappings that merged it. relinkAliases already restored anchors and aliases
from the old/new node pairing; relinkMerge now does the same for merge keys,
including `<<: [*a, *b]`, merges in nested mappings and in project-config
target items.
A key stays written out when the old mapping set it itself, or when its value
is no longer the one its merge source gives it. yaml.v3 merges are shallow, so
such a key replaces the merged value as a whole and what is written always
decodes to the config the command meant to save. A source that was removed, or
that holds a key the mapping no longer has, is not merged back.
Output order is not the old file's order, so an anchor that would follow its
first merge key moves onto it (`<<: &base`). The next write pairs that mapping
with the alias that still shows its value, so the file stays stable.
The runbook steps for anchors now write their own config: mdproof re-runs the
setup before each step, so step 7 and 8 never saw the config of step 6
(Codex review on #551). Steps for merge keys are added the same way.
* fix(config): let edits of an anchored mapping that add or remove a key reach its mergers
A command that added a key to an anchored mapping (the first `agents:`
block via `target base --agent-mode copy`) made relinkMerge refuse the
merge source: the merging mapping's pre-edit data lacked the key, which
was read as "the command removed it". The merge key was dropped and the
merger written out expanded, so later edits of the anchor no longer
reached it.
A source is now refused only when the merging mapping had a key before
the write and the command removed it. A key the source gained does not
count.
The symmetric case is fixed with it: a key removed from the anchored
mapping stayed written out under a merger that still held the old merged
value. An unedited key that the merger did not set itself now follows
the source that gave it, whatever that source now says (a changed value,
a removed key, or the next source of `<<: [*a, *b]`). A key the merger
set itself, or that the command edited, stays written out.
Tests cover add, remove and change of a key on the anchored mapping and
on the merging mapping, a key from either source of a merge list, nested
merges, projects, project-config target items and chained merges. Runbook
step 11 covers the real binary.
* fix(config): keep every comment when a write relinks merge keys and aliases
Rewriting a merge key replaced the original merge items and covered keys with
new nodes and carried over only the comments of the key and the list itself, so
a comment on an item of `<<:` followed by `- *a # note` was lost on any write,
and so was the trailing comment of a removed key when the mapping was left with
keys the merge supplies.
Comments now follow the entry they were on: a merge item's to the alias that
replaces it, those of an item that is no longer merged to the next item, and
those of a key the merge supplies to the next key still written, or in front of
the merge key when none is. The merge list keeps its flow or block style so item
comments stay on their lines.
Sweeping the rest of the relink paths for the same loss found more places where
yaml.v3 drops or moves a comment: the comment after an anchor on a block mapping
collided with its first key's comment, a line comment on a block collection or
on a key with an empty value is not written, and an anchored collection's head
comment moved on the next write. These are settled once on the written tree, and
the body of an inline merge source gets its comments paired too.
Open in editor split $VISUAL and $EDITOR on whitespace, so a Windows
path such as "C:\Program Files\Notepad++\notepad++.exe" broke at the
space and no editor was found. A user asked to open files in Notepad++,
which is not on PATH by default (#538).
Double or single quotes now keep a field together. Backslashes stay
literal, since Windows paths use them.
* feat(mcp): open an Agent's MCP config file from the dashboard
Users asked to jump from the MCP page straight into a client's config
file, such as opencode.json or .cursor/mcp.json, instead of copying the
path and opening it by hand (#538).
The open uses the same editor chain as a skill's Open in editor, so the
dashboard opens files one way. The endpoint takes a target, not a path,
and only opens a file the MCP page already lists. It answers only
requests from the machine running the dashboard, because the editor
starts on that machine. The list now reports which files exist, so the
button is hidden for a client detected before it has a file.
* fix(mcp): hide Open in editor where the server would refuse it
Codex review: the dashboard can be opened through a LAN IP, but the
open endpoint answers only loopback requests, so the button showed and
every click returned 403, while the docs promised it would open.
The list now reports `openable` instead of `existing`: the files that
exist, and only when the request comes from the dashboard's machine. A
viewer elsewhere does not see the button, and the docs say where it
appears.
* fix(mcp): don't treat a reverse proxy's viewers as local for Open in editor
Codex review: the documented Nginx and Caddy setups connect from
127.0.0.1, so the loopback socket check let any browser behind the proxy
see the button and launch editors on the server.
The browser now counts as local only when the socket and the Host it
used are both loopback and no proxy forwarding header is present. Both
documented proxies keep the browser's Host and add X-Real-IP or
X-Forwarded-For, so their viewers no longer qualify.
* fix(sync): limit project adoption writes to moved skills
A stale install record could trigger a full project reconcile during sync, adding unrelated remote installs to the manifest, ignore rules and lockfile. Skip project writes when nothing was re-keyed, and update only moved declarations, ignore rules and existing pins while preserving full explicit reconcile behavior.
Cover the visible project directory sharing its global source with byte-identical no-move checks and a real move that preserves unrelated entries and audit acceptances.
* fix(sync): preserve existing move destination declarations
The adoption-only config rewrite could duplicate a destination already declared in the project manifest. Keep that destination declaration and remove the moved old entry, matching full reconcile behavior while preserving the destination fields.
Add a regression that fails with duplicate entries and passes with the existing destination branch retained. Re-run make check after the fix.
Pi 1.2.0 (earendil-works/pi#10765) runs normalizePath on resource-filter
patterns before matching, so `~`, `~/`, `file://` and, on Windows, `~\`
and Git Bash/MSYS/Cygwin/WSL drive paths now match files that older Pi
never matched. Skillshare supports Pi 0.99.2 and later without knowing
which one evaluates the rules, so it reported a definite selection that
could be wrong and let the write guard reason from it. Such rules now
evaluate as unknown, and the dashboard names the rule instead of a
generic message.
Exact rules also missed Pi's normalizeExactPattern in every version: a
leading ".\" is dropped on all platforms and backslashes become slashes
on Windows. Skillshare only dropped "./", so `-.\extensions\a.ts`
looked unmatched and produced a duplicate missing row.
* chore(main): release 0.25.8
* chore(release): synchronize release metadata
* docs(changelog): rewrite 0.25.8 notes for users
The generated entry listed the raw commit subject. Describe the macOS OMP install fix with the message users saw and the command that now works.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
Adding a plugin from a Git URL to Oh My Pi on macOS was always blocked
with "linked or non-directory OMP path component", which the dashboard
shows as "The reviewed OMP runtime destination must be verified empty".
The source is cloned into os.MkdirTemp, which lives under /var/folders,
and /var links to /private/var. The OMP install check reads the source's
package.json through ompSafePath, which rejects any linked component, so
Skillshare's own temp clone failed it. A local source under a linked
parent failed the same way.
acquireRef now hands callers the resolved root of the temp clone and of
a local directory, while the recorded source stays as given. Links inside
the source are still handled as before; cleanup still removes the
original temp directory.
* chore(main): release 0.25.7
* chore(release): synchronize release metadata
* docs(changelog): rewrite 0.25.7 notes for users
The generated entry listed raw commit subjects. Describe the OMP version fix and the plugin update dialog fix in the changelog's usual style, with the error users saw and what changed.
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Willie <egg358358@gmail.com>
* fix(plugin): accept OMP 18.6.1 and later instead of exactly 18.6.1
The OMP adapter pinned the native version to exactly 18.6.1, so every
newer release was refused: the dashboard reported "Installation requires
OMP 18.6.1" for a user on 18.8.7, and removal and standalone extension
selection were blocked the same way.
The sources the adapter depends on (marketplace cache/manager/types,
plugin-cli output, the project anchor in discovery/helpers.ts, extension
loading and the pi-natives file lock) are unchanged from v18.6.1 through
v18.10.2, so the pin is now a minimum. The install, removal and selection
gates share one check built on the existing plainVersion helper;
unparsable, prerelease and older versions stay blocked.
Messages, all dashboard locales, the plugin reference docs and the
built-in skill now state 18.6.1+. A test keeps the English guidance text
in en.json equal to the Go strings the dashboard matches on.
* fix(docs): record the OMP 18.6.1+ boundary in the cache safety report
The safety report still said installation is allowed only for OMP 18.6.1
and that an unknown version blocks it, which no longer matches the gate.
It now states the minimum, which versions stay blocked, and the source
comparison and native 18.8.7 run that justify replacing the pin. The two
OMP runbooks no longer require exactly 18.6.1.
Keep plugin names on their own line and let agent labels and version changes wrap. Reserve space for update status so batches with many agents remain readable.
Shared memory lives under ~/.config/skillshare/extras/memory on the host.
Inside the devcontainer the CLI resolves a different path, so the blanket
"never run skillshare on the host" rule blocked memory reviews from
saving approved notes. Carve out an exception limited to
`skillshare extras memory ... -g` on explicit user request.
The 0.25.6 callout covers the batch plugin update, the dashboard memory
section and memory tools, and OpenCode 2 MCP and plugin support. The
dashboard memory paragraph from #537 was only in English; the four
translated guides now carry it. johnkattenhorn reported #535.
* fix(mcp): turn off a global server in OpenCode 2 projects
OpenCode 2 replaces a global server with the project entry of the same
name, and silently drops an entry without its type and command or url.
The project switch Skillshare wrote, {"enabled": false}, therefore left
the server on in OpenCode 2, while OpenCode 1 merged it by field.
Checked against OpenCode 2.0.27 and 1.19.0: OpenCode 2 still reads the
flat mcp.<name> shape and turns enabled: false into disabled: true, and
both read an entry with type and command or url. So no version detection
is needed. When the global config under mcp.projects defines the server,
the OpenCode switch now carries its type and executable, or its url
without the query, next to enabled: false. Args, env, headers and the
query stay out of a project file that may be committed, as the Pi switch
once did. A switch that already carries the endpoint keeps it when the
global server later leaves the config, unless it was edited since sync.
In project mode, or when the global config lacks the server, only the
bare switch can be written; the plan now says OpenCode 2 ignores it, in
the CLI and the dashboard.
Import also reads OpenCode 2's mcp.servers section, which its own
`mcp add` writes, instead of reporting it as one broken server.
Refs #538
* fix(mcp): keep secrets in a URL path out of the OpenCode switch
The OpenCode switch dropped only the query of the global server's URL.
Some MCP services put the key in the path instead, and an absolute
executable path names the user's home directory; both then reached a
project file that may be committed. A disabled server never starts, and
OpenCode 2 accepts any type with a command or url, so the switch now
carries only the executable's name or the URL's scheme and host.
Refs #538
* fix(mcp): skip OpenCode 2's timeout defaults when importing
OpenCode 2 keeps server defaults in mcp.timeout next to mcp.servers, so
import listed timeout as a broken server. It is dropped only together
with a recognized servers section, where it cannot be a v1 server.
Refs #538
* fix(mcp): read an empty OpenCode 2 servers section
An empty mcp.servers object was not recognized as OpenCode 2's section,
so import listed servers and timeout as broken servers instead of
finding no entries. The dashboard help for disabled also still said only
the switch is written, which is no longer true for opencode.
Refs #538
* fix(mcp): keep an OpenCode endpoint switch next to its own fields
The kept switch was matched by the whole native entry, so a field only
OpenCode reads, such as a per-server timeout, made the next sync drop the
type and command or url once the global server left the config, and
OpenCode 2 then ignored the switch. Match the fields Skillshare manages.
Refs #538
* fix(mcp): show the OpenCode endpoint switch in the dashboard preview
The dashboard renders a project's server alone, so the preview never saw
the same-named global server and showed the bare switch that OpenCode 2
ignores, while sync wrote the switch with the endpoint. Resolve the
global server the way sync does.
Refs #538
* fix(plugin): read OpenCode 2's version output
OpenCode 2 prints "opencode v2.0.27" for --version, while OpenCode 1
prints only "1.19.0". The adapter trimmed a leading "v" only, so plugin
sync to OpenCode 2 failed as an unrecognized version and imported
updates were skipped as if OpenCode 1 had no update command. Read the
last field, and decide the update check with the same parser.
Refs #538
* feat(memory): add host-owned review and verification workflows
Share scoped memory tools between Dashboard and Memory, and route retrospective and Dreaming requests through the built-in skill. Keep agent execution in the host, require approval for reviewed edits, and preserve versioned CLI write safeguards.
Confirm scope before exposing prompts and include the resolved root in recent memory responses. Update provenance guidance and localized documentation, with regressions for unavailable scope and protected review prompts.
* fix(memory): distinguish trial copy controls for screen readers
Include the localized step title in each trial copy control accessible name while keeping the short visible label. Update the existing clipboard test selector for the distinct names; no new test or local test rerun was requested for this label-only fix.
* fix(memory): point connection hints to the trial tools
Replace stale verification-prompt directions in all eleven locales with the current Memory tools and Try across sessions labels. Interpolate the existing localized labels so future naming changes remain aligned.
No new tests or local test reruns for this copy-only correction, as requested by the maintainer.
* feat(ui): surface existing shared memory on the dashboard
Make shared notes visible through recent updates and direct links, with file timestamps and an introductory state for untouched starters. Keep the dashboard quiet until memory is configured, and preserve access to existing notes when starter files are missing.
* fix(memory): bound dashboard reads and remember preview expansion
Count vault entries from metadata and read at most the two starters and four recent candidates instead of hashing the full vault on dashboard load. Keep incomplete starter states accessible and refresh the overview after source and instruction changes. Remember preview expansion in browser storage and raise the collapsed height to 360px.