Commit Graph
191 Commits
Author SHA1 Message Date
Willie 2c982848c5 feat: classify HIGH audit findings as warnings and refresh docs/playground 2026-02-11 10:10:09 +08:00
Willie bf6f60467f docs: update website for audit rules UI, built-in skill opt-in, and missing pages
- init.md: add step 5 (built-in skill prompt) to What Happens diagram
- first-sync.md: add tip about built-in skill prompt during init
- audit.md: add Custom Rules Editor section for /audit/rules page
- ui.md: add Audit, Audit Rules, Trash, Log to Dashboard Pages table
  and audit/log REST API endpoints
- file-structure.md: add audit-rules.yaml to overview tree
2026-02-11 04:43:58 +08:00
Willie 927bad707e feat: add audit rules Web UI page with create/edit support
Add REST API (GET/PUT/POST /api/audit/rules) for managing custom
audit-rules.yaml through the web dashboard. Extract template and
validation logic from CLI into reusable audit package functions
(ValidateRulesYAML, InitRulesFile, DefaultRulesTemplate). Frontend
provides CodeMirror YAML editor with dirty tracking, file creation
flow, and mode-aware path display. Sidebar nav gains overflow scroll.
2026-02-11 04:36:58 +08:00
Willie fbcec80788 feat: externalize audit rules to YAML with user customization
Move 17 hardcoded audit rules from Go structs to embedded rules.yaml,
enabling community PRs on rule definitions without recompilation.

Add user-customizable audit rules at two levels:
- Global: ~/.config/skillshare/audit-rules.yaml
- Project: .skillshare/audit-rules.yaml

Merge semantics: built-in → global → project. Users can append new
rules, override existing ones by id, or disable them (enabled: false).

Replace hardcoded localhostURL check with generic exclude regex field
on rules. Add --init-rules flag to scaffold a starter rules file.

Public API (ScanSkill, ScanContent, Finding, Result) unchanged —
callers require zero modifications.
2026-02-11 03:40:54 +08:00
Willie 98db20a9a0 test: add !online build tag to offline integration tests
Prevent test-docker and test-docker-online from running the same 36
offline integration tests. Each offline test file now has
`//go:build !online` so the two sets are mutually exclusive:
- default (no tag): 36 offline tests only
- -tags online: online tests only
2026-02-11 03:40:54 +08:00
Willie 18a4177973 test: add online integration tests for install, update, and search
Cover real GitHub operations that were previously untested:
- install clone (subdir skill)
- install --track (full repo)
- update tracked repo (freshly cloned → up to date)
- search with conditional GITHUB_TOKEN skip

Also pass GITHUB_TOKEN into sandbox-online container and remove
the -run filter so all online-tagged tests run automatically.
2026-02-11 03:40:54 +08:00
Willie 348102d5a9 feat: make built-in skill opt-in for init and upgrade
Built-in skillshare skill was auto-installed during `init` and
unconditionally refreshed by `upgrade --skill`. This caused
unintended pushes and surprised new users who didn't need it.

Changes:
- init: add --skill/--no-skill flags, prompt [y/N] (default N)
- upgrade: decouple --skill from --force, prompt when not installed
- Add 4 new integration tests for the opt-in behavior
- Update existing tests to use --no-skill or --force as needed
- Document all non-interactive init flags in website docs
2026-02-11 03:40:54 +08:00
Willie 84ba16802d feat: add log filtering, improve log UX, and custom dropdown
- Add --cmd, --status, --since, --json flags to CLI log command
- Auto-skip irrelevant log section when --cmd narrows to one file
- Add blank line separator between log entries for readability
- API returns totalAll and commands for smarter frontend filtering
- Custom HandSelect dropdown matching hand-drawn design system
- Empty state distinguishes "no matching entries" from "no entries"
- Update website docs and built-in skill reference with new flags
2026-02-11 03:40:54 +08:00
Willie e8a3c57cb4 Merge pull request #19 from runkids/fix/filepath-issue-on-windows
fix: normalize backslash path separators for Windows
v0.11.3
2026-02-11 03:38:27 +08:00
Willie 0b280d0864 fix: normalize backslash path separators for Windows (fixes #18)
On Windows, filepath.Join produces backslash separators that were
written directly into .gitignore and JSON metadata files. Git does
not match backslash patterns, and metadata subdirs with backslashes
corrupt source URLs during updates.

Use strings.ReplaceAll(s, "\\", "/") at write boundaries — matching
the existing pattern in sync.go — to ensure config/metadata files
always contain forward slashes regardless of OS.
2026-02-11 03:30:14 +08:00
Willie 7287b68921 feat: make -v output mise-parseable for registry support
`skillshare version` keeps the ASCII logo, while `-v`/`--version`
now outputs `skillshare v<version>` — the plain-text format that
mise's registry test expects (`skillshare v{{version}}`).

Add registry/skillshare.toml for the upcoming jdx/mise PR.
v0.11.2
2026-02-11 03:03:46 +08:00
Willie acca11fa5f refactor: slim built-in skill to reduce context window cost
Reduce SKILL.md description (959→506 chars) and body (117→66 lines)
by removing content already covered in references/ (Quick Start,
verbose examples, Finding Skills section). Zero information loss.
v0.11.1
2026-02-10 11:57:28 +08:00
Willie f49b3999bc feat: enrich install and audit logs with mode/path and installed skills 2026-02-10 11:51:09 +08:00
Willie 4c48556094 fix: remove audit false positives from built-in skill and trim description
The built-in skillshare skill's references/audit.md contained real threat
strings (curl to evil URL, base64 decode pipe, prompt injection text) in
example output snippets, causing `skillshare audit` to flag itself. Remove
the offending `> ...` snippet lines while keeping the finding messages.

Also trim SKILL.md description from 1039 to 959 chars (under Codex 1024
limit) by removing redundant trigger phrases already covered by other entries.

Add integration test that copies the real built-in skill into a sandbox and
verifies `skillshare audit skillshare` produces zero findings.
2026-02-10 11:46:39 +08:00
Willie 591e874c3a docs: refine neutral comparison language and project mode guidance 2026-02-10 05:14:54 +08:00
Willie 4d620f25fd feat: improve log view and project log ignore defaults v0.11.0 2026-02-10 04:52:52 +08:00
Willie 46c1f8ebcb feat: add tracked field to ProjectSkill config, fix reconcile for tracked repos
ProjectSkill gains `tracked: true` (omitempty) so `install -p` can
correctly dispatch tracked repos via InstallTrackedRepo instead of
regular Install. ReconcileProjectSkills now detects .git/ dirs and
reads git remote origin URL for tracked repos that lack meta files,
fixing the bug where tracked repos were silently skipped during
reconcile. SkillName validation is moved after the tracked branch
so _ prefixed repo names no longer fail.

Docs updated to position config.yaml as a portable skill manifest
usable by teams, open source contributors, and community templates.
2026-02-10 04:43:39 +08:00
Willie e5813cc7e0 feat: add oplog instrumentation to all API handlers, improve audit/log/sync CLI
- Add oplog write helpers to server (oplog_helper.go) and instrument
  all handler_*.go endpoints with ops/audit logging
- Improve audit CLI with structured auditRunSummary and severity counts
- Enhance log CLI with richer filtering and detail display
- Improve sync CLI with drift detection summaries in oplog
- Reorder web UI sidebar nav by user workflow (core → acquire → distribute → maintain → monitor)
- Enhance LogPage with better formatting and filtering
- Add server oplog unit tests (logging_test.go, log_test.go)
- Update docs for log command and quick-reference
2026-02-10 03:50:03 +08:00
Willie f152245f27 docs(skill): update built-in skill to v0.11.0 with audit, trash, log, and drift detection
Add new reference docs for security audit, trash (soft-delete), and
operation log commands. Update existing references with sync drift
detection, install audit blocking, SSH subpath syntax, and new Web UI
pages/API endpoints.
2026-02-10 03:32:36 +08:00
Willie 14bb54d6bd fix(log): show target count in sync log details
CLI formatLogDetail and Web UI formatDetail now display the "targets"
arg as "N target(s)" so sync entries are no longer blank in Details.
2026-02-10 03:16:04 +08:00
Willie f2017a35aa feat: fix tracked repo discovery, improve naming, and unify project list
Sync discovery (DiscoverSourceSkills) was skipping all hidden directories
via utils.IsHidden(), causing skills inside .curated/ and .system/ (like
openai/skills) to be invisible after install. Now only .git is skipped,
matching the install-time discovery that was already fixed in 8ec5306.

Tracked repo naming now uses owner-repo format (e.g., _openai-skills
instead of _skills) via new Source.TrackName() method, preventing
collisions between repos that share the same basename.

Project-mode `list` command now uses recursive DiscoverSourceSkills()
instead of shallow os.ReadDir(), aligning with global list and web UI
behavior so tracked repo skills are visible everywhere.

Also includes CHANGELOG for v0.11.0, README updates, docs improvements,
and minor UI nav reorder.
2026-02-10 03:13:21 +08:00
Willie 2feff60e65 docs: add log command reference and update README/sidebar/file-structure
- New: website/docs/commands/log.md with usage, format, options, web UI
- commands/index.md: add log to Utilities table and quick reference
- sidebars.ts: add commands/log to Security & Utilities category
- file-structure.md: add logs/ directory to tree and platform tables
- README.md: add skillshare log to Daily Commands, update v0.11.0 summary
2026-02-10 03:00:28 +08:00
Willie 5a65993304 feat: add operation log — JSONL-based persistent audit trail for CLI, API, and web UI
Add oplog package (internal/oplog) that records every mutating command
(install, uninstall, sync, push, pull, collect, backup, restore, update,
audit) as a JSONL entry with timestamp, status, duration, and args.

- CLI: `skillshare log` with --audit, --tail, --clear, --project flags
- API: GET/DELETE /api/log endpoints with type and limit params
- Web UI: LogPage with ops/audit tabs, table view, clear and refresh
- Instrumentation across 12 command handlers (CLI + server)
2026-02-10 02:56:59 +08:00
Willie 8ec53065b5 feat(install): fix hidden-dir discovery, add fuzzy search, and improve install UX
discoverSkills() skipped all dot-prefixed dirs, causing repos like
openai/skills (which use .curated/ and .system/) to find 0 skills.
Fix: only skip .git, traverse all other hidden dirs.

CLI --skill flag now falls back to fuzzy matching (via lithammer/fuzzysearch)
when exact match fails. Single fuzzy match auto-selects; ambiguous matches
show "did you mean" suggestions.

UI SkillPickerModal gains a filter input (autofocus, substring on name+path)
that appears for >5 skills. Select All toggles only filtered skills.

Batch install toast fix: always show summary toast even when some skills
are blocked by security audit (previously early-returned with no feedback).
Audit dialog now targets only blocked skills for force-retry.

CLI output for mixed results: use warning banner instead of success,
show failures first, condense >10 successes into a single line.
2026-02-10 02:23:16 +08:00
Willie 4d17ff5d57 feat: add security audit — scan engine, CLI, install hooks, web UI, and docs
Scan skills for prompt injection, data exfiltration, credential access,
destructive commands, obfuscation, and suspicious URLs. CRITICAL findings
block installation by default; HIGH/MEDIUM shown as warnings.

- Scan engine: internal/audit with regex-based pattern matching
- CLI: `skillshare audit [name]` with per-skill progress and summary
- Install hooks: auto-scan after copy, block on CRITICAL unless --force
- Web UI: AuditPage with run/rescan, InstallForm shows ConfirmDialog
  for audit blocks (force-retry) and warning details
- ConfirmDialog: add `wide` prop, hide cancel when cancelText is empty
- Reduced false positives: rm -rf only flags root/glob, skip localhost
  URLs, exclude `fetch` as English word, hidden-unicode downgraded to HIGH
- README: add audit section, update screenshots, unify image sizes,
  add audit to Why/Comparison/Daily Commands
- Docs: audit command page, install security scanning section, FAQ,
  common errors, daily workflow, sidebar, landing page, intro
- Blog specs: add audit sections to Dev.to and Medium drafts
2026-02-10 01:53:55 +08:00
Willie d4290307ca feat: add sync drift detection to status, doctor, and web UI
Detect when targets have fewer linked skills than source and surface
warnings across CLI (status, doctor) and web UI (Dashboard, Targets).
Helps users notice unsynced skills after installing new ones.
2026-02-10 00:10:10 +08:00
Willie caf119d5be feat(install): support subpath in SSH URLs with // separator
Corporate environments using SSH-only Git access couldn't specify a
skill within a monorepo. Extend gitSSHPattern regex and parseGitSSH()
to capture an optional //subdir suffix, matching the convention used
by Terraform and Go modules.

Example: git@host:owner/repo.git//path/to/skill
2026-02-09 23:46:23 +08:00
Willie 668823135c docs: add comparison page and README comparison section
Add declarative vs imperative skill management comparison to help
users coming from other tools understand architectural differences.
Highlight config-driven sync, safe removal, and reproducible setup.
2026-02-09 23:22:27 +08:00
Willie 8604ab278e feat(ui): add Trash page, trash API handlers, and CLI delete/empty commands
- Add Web UI Trash page with list, restore, delete, and empty actions
- Add 4 server handlers (handler_trash.go) with dual-mode support
- Fix handleUninstallSkill/handleUninstallRepo to use trash.MoveToTrash
  instead of os.RemoveAll (bug fix: uninstall via UI now soft-deletes)
- Add trash delete/empty CLI subcommands with integration tests
- Show Uninstall button for all skills in SkillDetailPage (not just
  tracked/installed ones)
- Update confirm dialog wording to reflect soft-delete behavior
- Update docs with new trash subcommands
2026-02-09 23:19:28 +08:00
Willie 3a920610f2 feat: add trash (soft-delete) for uninstall with 7-day retention
Replace permanent deletion with soft-delete: uninstall now moves skills
to a trash directory instead of using os.RemoveAll. Skills are retained
for 7 days and automatically cleaned up during sync/uninstall operations.

- Add internal/trash package (MoveToTrash, List, Cleanup, Restore, FindByName)
- Add `skillshare trash list` and `skillshare trash restore <name>` commands
- Show reinstall hint from metadata when uninstalling remote skills
- Add trash status to `skillshare doctor` output
- Opportunistic cleanup of expired items during sync and uninstall
- Support both global (~/.config/skillshare/trash/) and project (.skillshare/trash/) modes
- 10 unit tests + 10 integration tests
- Update docs: uninstall, trash, doctor, FAQ, file-structure, sync, daily-workflow
2026-02-09 22:46:36 +08:00
Willie d2e0065553 feat(search): add relevance scoring, parallel enrichment, and repo-scoped search
Search results were ranked only by GitHub stars, causing unrelated
high-star repos to outrank dedicated skill repos. Additionally,
owner/repo queries (e.g., "vercel-labs/skills") were treated as
plain text search instead of repo-scoped search, returning
completely wrong results.

Changes:
- Add multi-signal relevance scoring (name 0.45, description 0.25,
  stars 0.30) with log10-normalized star counts
- Detect owner/repo[/subdir] queries and use GitHub `repo:` qualifier
- Parallelize star and description enrichment (WaitGroup + semaphore,
  cap 10) — reduces wall time from 3-6s to ~200-600ms
- Extract both name and description from SKILL.md frontmatter
- Add Score field with json:"-" tag (hidden from CLI --json and API)
- Remove overly generous ContainsAny partial matching in name scoring
2026-02-09 22:18:05 +08:00
Willie 570195d1a2 feat: enhance skill template, improve search UX, and harden playground
- new: redesign SKILL.md template based on Anthropic's skill-building
  guide — description now includes WHAT+WHEN trigger format, step-based
  instructions (Gather/Execute/Validate), examples, and troubleshooting
- search: prompt for keyword when run without arguments instead of
  auto-browsing popular skills
- playground: default shell to $HOME (/sandbox-home) and mount source
  as read-only to prevent accidental host file modifications
2026-02-09 21:43:10 +08:00
Willie 0c49860d63 feat: add project mode labels, privacy-first messaging, and UI polish
- Add (project) labels to status, sync, collect, target, and uninstall
  headers for clear mode distinction (matching list/target list pattern)
- Add ui.WithModeLabel() helper for shared functions that run in both modes
- Update uninstall confirmation prompt: "from the project?" in project mode
- Add "Privacy-first" to README Why section and website homepage
- Replace "Unified Source" card with "Privacy-First" card on website
- Unify Quick Actions card heights with h-full in DashboardPage
- Add frontend rebuild note to Docker sandbox docs
2026-02-09 21:08:03 +08:00
Willie 380907b320 feat(website): redesign with hand-drawn aesthetic and update README logo
Overhaul the documentation site with a hand-drawn design system:
- Custom CSS with paper textures, wobbly borders, and sketchy shadows
- Hero section with dashed ring, sparkle decorations, and floating animation
- Card components with post-it accent colors and tape decorations
- Replace README logo with hero-style version (ring + sparkles + paper bg)
2026-02-09 11:43:27 +08:00
Willie ecabe20d0e feat(docs): add search feature 2026-02-09 10:34:00 +08:00
Willie f7dafddfd9 chore(docs): modify docs link 2026-02-09 00:29:42 +08:00
Willie 3e8aec74aa fix: show helpful message when Windows upgrade fails due to locked binary
When another process (e.g. `skillshare ui`) holds the exe file open,
Windows denies the rename. Detect this and suggest closing other
skillshare processes instead of showing a raw "Access is denied" error.
2026-02-08 17:45:18 +08:00
Willie 86b5650fe5 fix: correct ui:build path in mise.toml
The multi-line run block is a single shell script, so `cd ui` persisted
into subsequent lines, making rm and cp target wrong paths. Wrap in a
subshell so the directory change does not leak.
2026-02-08 17:36:51 +08:00
Willie e38a396ee0 docs: add web dashboard to built-in skillshare skill
Add "web dashboard", "skillshare ui" triggers to description for skill
activation. Add Web UI row to commands table. Create references/ui.md
with usage, flags, dashboard pages, project mode differences, REST API
endpoints, and Docker instructions.
v0.10.2
2026-02-08 17:25:21 +08:00
Willie 14bd568b9a feat: add project mode support to web dashboard (skillshare ui -p)
The web dashboard now fully supports project-level skills. When launched
with `-p` or when `.skillshare/config.yaml` is auto-detected, the UI
adapts: Git Sync and Backup pages are hidden, Config edits the project
config, Install reconciles ProjectConfig.Skills[], and targets resolve
from project-level definitions.

Server: add NewProject constructor, IsProjectMode/configPath/saveConfig/
reloadConfig helpers, branch all handlers for project mode.

Frontend: AppContext propagates isProjectMode, Layout filters nav items,
Git/Backup pages show unavailable message, Config/Dashboard adapt.

Extract ReconcileProjectSkills to internal/config for reuse by both CLI
and server. Add unit tests and integration tests for project UI.

Update docs, README, and Docker playground with project mode demo project
and skillshare-ui-p alias.
2026-02-08 17:15:59 +08:00
Willie 2b2d8014d6 docs: reorganize README and refresh messaging 2026-02-08 16:46:33 +08:00
Willie 503ee8af24 refactor: DRY up Docker sandbox scripts with shared entrypoint and boilerplate
- Add docker/sandbox/entrypoint.sh to auto-copy /ui-dist → internal/server/dist/
  when missing, fixing the gitignore regression for all Docker workflows
- Add scripts/_sandbox_common.sh with shared SCRIPT_DIR, PROJECT_ROOT,
  COMPOSE_FILE, and require_docker() function
- Refactor all 5 sandbox scripts to source _sandbox_common.sh
- Use YAML extension fields (x-sandbox-common) in docker-compose.sandbox.yml
  to eliminate duplicated service config
- Break sandbox_playground_up.sh one-liner into readable steps, add
  skillshare-ui alias and init hint
- Change test.sh to use `make build` for placeholder consistency
2026-02-08 16:32:28 +08:00
Willie afc932c2bf feat: make upgrade --skill always refresh and overwrite 2026-02-08 16:23:02 +08:00
Willie 5df04bdc36 chore: gitignore internal/server/dist/ and auto-create placeholder on build
Build artifacts (favicon, logos, index.html) were tracked in git to
satisfy go:embed, causing noisy diffs after `make ui-build`. Now the
entire dist/ is gitignored and `make build` auto-creates a minimal
placeholder index.html when dist is missing, so fresh clones still
compile without a frontend build step.

CI workflows updated to use `make build` instead of bare `go build`
to pick up the placeholder logic.
2026-02-08 16:12:43 +08:00
Willie 6185849328 fix: handle Windows junctions in sync and diff v0.10.1 2026-02-08 15:14:16 +08:00
Willie 61b741dca2 chore: modify icon 2026-02-08 05:19:33 +08:00
Willie 092fb14f8a feat: add web dashboard with embedded React SPA (skillshare ui)
Single-binary web UI for visual skill management — React 19 + Vite
frontend embedded via go:embed, Go net/http REST API backend (30+
endpoints). Includes dashboard, skills browser, targets, sync, collect,
search, install, config editor, backup/restore, and git sync pages.

Also adds Bitbucket/GitLab URL parsing for install, git operations
library, skill version checking, CI frontend build steps, Docker
sandbox support, and website docs for the ui command.
v0.10.0
2026-02-08 05:08:30 +08:00
Willie 3ec3c3060a ci: add docker sandbox CI jobs and release test gate
- Add workflow_call trigger to test.yaml for reusable workflow support
- Add docker-sandbox-offline and docker-sandbox-online CI jobs
- Gate release.yaml behind test.yaml so all tests must pass before
  GoReleaser runs
2026-02-07 23:13:08 +08:00
Willie 080e29e0ff feat: add docker sandbox test/playground workflows and docs v0.9.3 2026-02-07 21:55:20 +08:00
Willie bf41422659 fix(install): naming behavior and docs 2026-02-07 21:08:36 +08:00