mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-18 18:04:17 +00:00
fix(herdr): keep the header pill clear of the Update panel button (#840)
With a newer release published, the panel's header drew "Update panel" on top of the folder and machine pill: at the panel's 400px the row has no room for both, and the pill did not shrink, so the two overlapped. Seen in a running Herdr with version.js set below the latest release. The pill is now a plain element that shrinks and ends in an ellipsis, so the button, the version and the close button keep their place. panels.png gains the button in the first view, drawn as the running panel shows it, with the pill shortened.
This commit is contained in:
@@ -13,7 +13,7 @@ Left to right, everything as in Herdr's `main` layout, plus two blocks:
|
||||
- **Sidebar**, 268px: Herdr's own brand bar, Spaces, Agents and footer.
|
||||
- **Work column**: the tab bar row, now `tabs` (weight 1) beside a 118px `skillshare-toggle` block. The toggle draws the 16px skillshare mark and "skillshare", on `selected` while the panel shows. Under it the shown tab and Herdr's Files/Changes side panel, then the status bar.
|
||||
- **skillshare panel**, a 400px column (380–720px, the narrowest the tab row fits) right of the work area, top to bottom:
|
||||
- a 44px header: the mark, "skillshare", a pill with the folder (or "global" outside a project) and the machine, an "Update panel" button when a newer skillshare release is published and nothing is running, the CLI version in `muted`, and a close button;
|
||||
- a 44px header: the mark, "skillshare", a pill with the folder (or "global" outside a project) and the machine, which shortens with an ellipsis when the row runs out of room, an "Update panel" button when a newer skillshare release is published and nothing is running, the CLI version in `muted`, and a close button;
|
||||
- Overview, Library and Machines tabs, the shown one underlined in `foreground`. At the row's right, a skillshare project gets an All · Project · Global switch that Overview and Library share; outside a project it says "Global". On Machines the same place says when the machines were last checked.
|
||||
- Overview:
|
||||
- a headline with its mark: "Reading skillshare", "Everything is in sync", "n targets need a sync" (or "n resources to sync" when only MCP servers, plugins or hooks wait), or "Syncing n targets"; a primary Sync button while something waits;
|
||||
|
||||
@@ -444,7 +444,8 @@ export default class Skillshare extends View {
|
||||
.child(h_flex().h(44).flex_none().pl(14).pr(8).gap(8).items_center()
|
||||
.child(image("mods/skillshare/mark.svg").w(18).h(18).flex_none())
|
||||
.child(div().flex_none().text_size(S().title).font_semibold().child("skillshare"))
|
||||
.children([where ? h_flex().min_w(0).child(pill(where, t)) : null].filter(Boolean))
|
||||
// The pill gives way first: it shortens with an ellipsis when the update button needs the room.
|
||||
.children([where ? div().min_w(0).truncate().px(8).py(2).rounded(10).bg(t.selected).text_size(S().label).text_color(t.muted).child(where) : null].filter(Boolean))
|
||||
.child(div().flex_1())
|
||||
.when(Boolean(newPanel), (el) => el.child(secondary("panel-update", "Update panel", t, () => openDialog({ width: 440, height: 250, props: { role: "panelupdate", from: VERSION, to: newPanel } }), { h: 24, px: 8, size: S().label })))
|
||||
.when(Boolean(this.version), (el) => el.child(div().flex_none().text_size(S().secondary).text_color(t.muted).child(`v${String(this.version).replace(/^v/, "")}`)))
|
||||
|
||||
Binary file not shown.
|
Before Width: | Height: | Size: 394 KiB After Width: | Height: | Size: 419 KiB |
Reference in New Issue
Block a user