fix(extras): never sync skillshare's .metadata.json store

Installed-skill source dirs carry a .metadata.json tracking store. Extras
discovery walked it like user content, so a transform extension renamed it
to .metadata.toml in the target. Skip the reserved file in
DiscoverExtraFiles so it is never synced or transformed in any mode.
This commit is contained in:
Willie
2026-05-30 19:23:12 +08:00
parent f88044e2cc
commit 157eddc3d9
2 changed files with 30 additions and 2 deletions
+12 -2
View File
@@ -19,9 +19,16 @@ type ExtraResult struct {
Warnings []string // Non-fatal warnings (e.g. flatten collisions)
}
// reservedMetadataFile is skillshare's per-directory install-tracking store
// (mirrors install.MetadataFileName, duplicated here to avoid an import cycle).
// It is internal bookkeeping, not user content, so it must never be synced or
// transformed into a target directory.
const reservedMetadataFile = ".metadata.json"
// DiscoverExtraFiles recursively walks sourcePath and returns relative paths
// of all regular files. Directories named ".git" are skipped. Results are
// sorted for deterministic output.
// of all regular files. Directories named ".git" and skillshare's reserved
// .metadata.json bookkeeping file are skipped. Results are sorted for
// deterministic output.
func DiscoverExtraFiles(sourcePath string) ([]string, error) {
info, err := os.Stat(sourcePath)
if err != nil {
@@ -45,6 +52,9 @@ func DiscoverExtraFiles(sourcePath string) ([]string, error) {
}
return nil
}
if fi.Name() == reservedMetadataFile {
return nil // skillshare's internal tracking store, never sync it
}
rel, relErr := filepath.Rel(sourcePath, path)
if relErr != nil {
return nil
+18
View File
@@ -56,6 +56,24 @@ func TestDiscoverExtraFiles(t *testing.T) {
}
}
// TestDiscoverExtraFiles_SkipsMetadata verifies skillshare's reserved
// .metadata.json tracking store is never discovered, so it cannot be synced or
// transformed into a target (e.g. installed-agent dirs carry one).
func TestDiscoverExtraFiles_SkipsMetadata(t *testing.T) {
src, _ := setupExtrasTest(t, map[string]string{
"agent.md": "# Agent",
".metadata.json": `{"version":1,"entries":{}}`,
})
files, err := DiscoverExtraFiles(src)
if err != nil {
t.Fatal(err)
}
if len(files) != 1 || files[0] != "agent.md" {
t.Errorf("expected only [agent.md], got %v", files)
}
}
// --- SyncExtra merge mode tests ---
func TestSyncExtra_MergeMode(t *testing.T) {