fix: address CodeRabbit review suggestions

- Move Gemini API key to server-side route (security)
- Add default type='button' to Button component
- Use dynamic agent count instead of hardcoded 32
- Add 'use client' directive to Documentation
- Fix stale closure in SkillSubmitForm with useCallback
- Add URL validation for external references
- Add noopener to external links for security
- Fix Clawdbot path in agents.mdx
- Update cicd.mdx with correct CLI commands
- Capitalize proper nouns (Markdown, provider names)
- Add text language to README code block
- Update date example in quickstart.mdx
This commit is contained in:
Rohit Ghumare
2026-01-28 17:44:29 +00:00
parent 58bd0bbdd4
commit 12253f4b51
14 changed files with 183 additions and 147 deletions
+1 -1
View File
@@ -20,7 +20,7 @@ pnpm build
## Structure
```
```text
docs/fumadocs/
├── content/docs/ # MDX documentation files
├── src/
+1 -1
View File
@@ -20,7 +20,7 @@ SkillKit uses an adapter pattern to support 32 AI coding platforms. Each adapter
| Windsurf | `.windsurf/skills/` | Markdown |
| Antigravity | `.antigravity/skills/` | SKILL.md |
| Amp | `.amp/skills/` | SKILL.md |
| Clawdbot | `skills/` | SKILL.md |
| Clawdbot | `.clawdbot/skills/` (alt: `skills/`) | SKILL.md |
| Droid (Factory) | `.factory/skills/` | SKILL.md |
| Goose | `.goose/skills/` | SKILL.md |
| Kilo Code | `.kilocode/skills/` | SKILL.md |
+3 -3
View File
@@ -10,9 +10,9 @@ Generate templates for automated skill management.
## Generate Templates
```bash
skillkit cicd github-action
skillkit cicd gitlab-ci
skillkit cicd pre-commit
skillkit cicd init --provider github
skillkit cicd init --provider gitlab
skillkit cicd init --provider circleci
```
## GitHub Actions
+1 -1
View File
@@ -41,7 +41,7 @@ skillkit install <source> [options]
| `--yes` | `-y` | boolean | Skip confirmation prompts |
| `--global` | `-g` | boolean | Install to global directory |
| `--force` | `-f` | boolean | Overwrite existing skills |
| `--provider` | `-p` | string | Force provider: github, gitlab, bitbucket |
| `--provider` | `-p` | string | Force provider: GitHub, GitLab, Bitbucket |
| `--list` | `-l` | boolean | List available skills without installing |
| `--agent` | — | array | Target specific agents (repeatable) |
+1 -1
View File
@@ -160,7 +160,7 @@ Your choices are saved to `~/.skillkit/preferences.json`:
"lastSelectedAgents": ["claude", "cursor"],
"autoSync": true,
"marketplace": {
"lastRefresh": "2024-01-01T00:00:00Z"
"lastRefresh": "2025-01-01T00:00:00Z"
}
}
```
+1 -1
View File
@@ -5,7 +5,7 @@ description: Understanding AI agent skills - format, lifecycle, and quality
# Skills
A skill is an instruction file that teaches AI coding agents how to handle specific tasks. Each skill uses a universal markdown format (SKILL.md) with YAML frontmatter.
A skill is an instruction file that teaches AI coding agents how to handle specific tasks. Each skill uses a universal Markdown format (SKILL.md) with YAML frontmatter.
## Skills vs Context vs Commands
+2 -2
View File
@@ -1,11 +1,11 @@
---
title: Testing
description: Test skills with 14+ assertion types
description: Test skills with multiple assertion types
---
# Testing
SkillKit includes a testing framework with 14+ assertion types.
SkillKit includes a testing framework with multiple assertion types.
## Run Tests
@@ -0,0 +1,127 @@
import { GoogleGenAI, Type, Schema } from "@google/genai";
import { NextRequest, NextResponse } from "next/server";
const agentSkillSchema: Schema = {
type: Type.OBJECT,
properties: {
name: { type: Type.STRING, description: "Skill name in slug format (e.g., 'react-best-practices')" },
title: { type: Type.STRING, description: "Human readable title" },
description: { type: Type.STRING, description: "Brief description of what this skill teaches AI agents" },
version: { type: Type.STRING, description: "Semantic version (e.g., '1.0.0')" },
tags: {
type: Type.ARRAY,
items: { type: Type.STRING },
description: "Tags for categorization"
},
applicability: { type: Type.STRING, description: "When the AI agent should apply this skill (e.g., 'Apply when working with React components')" },
principles: {
type: Type.ARRAY,
items: {
type: Type.OBJECT,
properties: {
title: { type: Type.STRING },
description: { type: Type.STRING, description: "Detailed instruction for the AI agent" },
priority: { type: Type.STRING, description: "must, should, or may" }
},
required: ["title", "description", "priority"]
},
description: "Core principles and guidelines (5-8 items)"
},
patterns: {
type: Type.ARRAY,
items: {
type: Type.OBJECT,
properties: {
name: { type: Type.STRING },
description: { type: Type.STRING },
example: { type: Type.STRING, description: "Code example demonstrating the pattern" },
language: { type: Type.STRING, description: "Programming language for syntax highlighting" }
},
required: ["name", "description", "example"]
},
description: "Code patterns with examples (3-5 items)"
},
antiPatterns: {
type: Type.ARRAY,
items: {
type: Type.OBJECT,
properties: {
name: { type: Type.STRING },
description: { type: Type.STRING },
badExample: { type: Type.STRING, description: "Code showing what NOT to do" },
goodExample: { type: Type.STRING, description: "Code showing the correct approach" }
},
required: ["name", "description"]
},
description: "Anti-patterns to avoid (2-4 items)"
},
filePatterns: {
type: Type.ARRAY,
items: { type: Type.STRING },
description: "Glob patterns for files this skill applies to (e.g., '*.tsx', 'src/components/**')"
},
references: {
type: Type.ARRAY,
items: { type: Type.STRING },
description: "Links to official documentation or resources"
}
},
required: ["name", "title", "description", "version", "tags", "applicability", "principles", "patterns", "antiPatterns"]
};
export async function POST(request: NextRequest) {
const apiKey = process.env.GEMINI_API_KEY;
if (!apiKey) {
return NextResponse.json({ error: "Gemini API key not configured" }, { status: 500 });
}
try {
const { topic } = await request.json();
const sanitizedTopic = topic?.trim().slice(0, 500) || '';
if (!sanitizedTopic) {
return NextResponse.json({ error: "Topic is required" }, { status: 400 });
}
const ai = new GoogleGenAI({ apiKey });
const response = await ai.models.generateContent({
model: "gemini-2.0-flash",
contents: `Create a comprehensive AI coding agent skill for: "${sanitizedTopic}"
This skill will be used by AI coding assistants (like Claude Code, Cursor, GitHub Copilot) to provide better code suggestions and follow best practices.
The skill should include:
1. Clear principles that tell the AI WHAT to do and WHEN
2. Code patterns with REAL, WORKING examples (not pseudocode)
3. Anti-patterns showing common mistakes and how to fix them
4. Specific file patterns where this skill applies
Make the instructions actionable and specific. The AI agent should be able to directly apply these guidelines when writing code.
Focus on practical, production-ready patterns used in modern development.`,
config: {
responseMimeType: "application/json",
responseSchema: agentSkillSchema,
systemInstruction: `You are an expert software architect creating AI agent skills.
Your skills are used by AI coding assistants to write better code.
Guidelines:
- Write instructions as commands to the AI (e.g., "Always use...", "Never...", "Prefer...")
- Include REAL code examples, not pseudocode
- Be specific and actionable
- Focus on modern best practices (2024+)
- Include edge cases and error handling patterns
- Make principles enforceable and testable`
}
});
if (!response.text) {
return NextResponse.json({ error: "No response from Gemini" }, { status: 500 });
}
const data = JSON.parse(response.text);
return NextResponse.json(data);
} catch (error) {
console.error("Gemini API Error:", error);
return NextResponse.json({ error: "Failed to generate skill" }, { status: 500 });
}
}
+2 -1
View File
@@ -307,12 +307,13 @@ const SCROLL_ANIMATION_STYLES = `
export function Agents(): React.ReactElement {
const duplicatedAgents = [...AGENTS, ...AGENTS];
const agentCount = AGENTS.length;
return (
<section className="py-6 border-b border-zinc-800 overflow-hidden">
<div className="mx-auto max-w-5xl px-4 sm:px-6 lg:px-8">
<p className="text-zinc-500 font-mono text-[11px] uppercase tracking-widest mb-6 text-center">
Works with 32 AI Agents
Works with {agentCount} AI Agents
</p>
</div>
+2
View File
@@ -22,6 +22,7 @@ export function Button({
fullWidth = false,
isLoading = false,
disabled,
type = 'button',
...props
}: ButtonProps): React.ReactElement {
const widthClass = fullWidth ? 'w-full' : '';
@@ -36,6 +37,7 @@ export function Button({
return (
<button
className={classes}
type={type}
disabled={disabled || isLoading}
{...props}
>
@@ -1,3 +1,5 @@
'use client'
import React, { useState } from 'react';
interface DocSection {
@@ -94,6 +94,15 @@ function downloadContent(content: string, filename: string): void {
URL.revokeObjectURL(url);
}
function isValidUrl(str: string): boolean {
try {
new URL(str);
return true;
} catch {
return false;
}
}
// localStorage cache for AI-generated skills
const CACHE_KEY = 'skillkit_ai_cache';
const CACHE_VERSION = 1;
@@ -630,14 +639,18 @@ ${skillContent.slice(0, 4000)}${skillContent.length > 4000 ? '\n...(truncated)'
<ul className="space-y-1">
{generatedSkill.references.map((ref, idx) => (
<li key={idx}>
<a
href={ref}
target="_blank"
rel="noreferrer"
className="text-zinc-400 hover:text-white font-mono text-sm transition-colors"
>
{ref}
</a>
{isValidUrl(ref) ? (
<a
href={ref}
target="_blank"
rel="noopener noreferrer"
className="text-zinc-400 hover:text-white font-mono text-sm transition-colors"
>
{ref}
</a>
) : (
<span className="text-zinc-400 font-mono text-sm">{ref}</span>
)}
</li>
))}
</ul>
@@ -66,7 +66,7 @@ export function SkillSubmitForm(): React.ReactElement {
}
}
function parseSkillContent(content: string): void {
const parseSkillContent = useCallback(function(content: string): void {
const frontmatterMatch = content.match(/^---\n([\s\S]*?)\n---/);
if (frontmatterMatch) {
const fm = frontmatterMatch[1];
@@ -84,7 +84,7 @@ export function SkillSubmitForm(): React.ReactElement {
}
}
updateField('skillContent', content);
}
}, []);
async function handleDetect(): Promise<void> {
if (!githubUrl) return;
@@ -157,10 +157,13 @@ export function SkillSubmitForm(): React.ReactElement {
setFileName(file.name);
const reader = new FileReader();
reader.onload = (event) => {
parseSkillContent(event.target?.result as string);
const content = event.target?.result;
if (typeof content === 'string') {
parseSkillContent(content);
}
};
reader.readAsText(file);
}, []);
}, [parseSkillContent]);
const handleDrop = useCallback(function(e: React.DragEvent): void {
e.preventDefault();
+12 -124
View File
@@ -1,135 +1,23 @@
import { GoogleGenAI, Type, Schema } from "@google/genai";
import { AgentSkill } from "../types";
let ai: GoogleGenAI | null = null;
function getAI(): GoogleGenAI {
if (!ai) {
const apiKey = process.env.NEXT_PUBLIC_GEMINI_API_KEY || process.env.GEMINI_API_KEY;
if (!apiKey) {
throw new Error("Gemini API key not configured");
}
ai = new GoogleGenAI({ apiKey });
}
return ai;
}
const agentSkillSchema: Schema = {
type: Type.OBJECT,
properties: {
name: { type: Type.STRING, description: "Skill name in slug format (e.g., 'react-best-practices')" },
title: { type: Type.STRING, description: "Human readable title" },
description: { type: Type.STRING, description: "Brief description of what this skill teaches AI agents" },
version: { type: Type.STRING, description: "Semantic version (e.g., '1.0.0')" },
tags: {
type: Type.ARRAY,
items: { type: Type.STRING },
description: "Tags for categorization"
},
applicability: { type: Type.STRING, description: "When the AI agent should apply this skill (e.g., 'Apply when working with React components')" },
principles: {
type: Type.ARRAY,
items: {
type: Type.OBJECT,
properties: {
title: { type: Type.STRING },
description: { type: Type.STRING, description: "Detailed instruction for the AI agent" },
priority: { type: Type.STRING, description: "must, should, or may" }
},
required: ["title", "description", "priority"]
},
description: "Core principles and guidelines (5-8 items)"
},
patterns: {
type: Type.ARRAY,
items: {
type: Type.OBJECT,
properties: {
name: { type: Type.STRING },
description: { type: Type.STRING },
example: { type: Type.STRING, description: "Code example demonstrating the pattern" },
language: { type: Type.STRING, description: "Programming language for syntax highlighting" }
},
required: ["name", "description", "example"]
},
description: "Code patterns with examples (3-5 items)"
},
antiPatterns: {
type: Type.ARRAY,
items: {
type: Type.OBJECT,
properties: {
name: { type: Type.STRING },
description: { type: Type.STRING },
badExample: { type: Type.STRING, description: "Code showing what NOT to do" },
goodExample: { type: Type.STRING, description: "Code showing the correct approach" }
},
required: ["name", "description"]
},
description: "Anti-patterns to avoid (2-4 items)"
},
filePatterns: {
type: Type.ARRAY,
items: { type: Type.STRING },
description: "Glob patterns for files this skill applies to (e.g., '*.tsx', 'src/components/**')"
},
references: {
type: Type.ARRAY,
items: { type: Type.STRING },
description: "Links to official documentation or resources"
}
},
required: ["name", "title", "description", "version", "tags", "applicability", "principles", "patterns", "antiPatterns"]
};
export const generateAgentSkill = async (topic: string): Promise<AgentSkill> => {
export async function generateAgentSkill(topic: string): Promise<AgentSkill> {
const sanitizedTopic = topic?.trim().slice(0, 500) || '';
if (!sanitizedTopic) {
throw new Error("Topic is required");
}
try {
const response = await getAI().models.generateContent({
model: "gemini-2.0-flash",
contents: `Create a comprehensive AI coding agent skill for: "${sanitizedTopic}"
const response = await fetch('/api/generate-skill', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ topic: sanitizedTopic }),
});
This skill will be used by AI coding assistants (like Claude Code, Cursor, GitHub Copilot) to provide better code suggestions and follow best practices.
The skill should include:
1. Clear principles that tell the AI WHAT to do and WHEN
2. Code patterns with REAL, WORKING examples (not pseudocode)
3. Anti-patterns showing common mistakes and how to fix them
4. Specific file patterns where this skill applies
Make the instructions actionable and specific. The AI agent should be able to directly apply these guidelines when writing code.
Focus on practical, production-ready patterns used in modern development.`,
config: {
responseMimeType: "application/json",
responseSchema: agentSkillSchema,
systemInstruction: `You are an expert software architect creating AI agent skills.
Your skills are used by AI coding assistants to write better code.
Guidelines:
- Write instructions as commands to the AI (e.g., "Always use...", "Never...", "Prefer...")
- Include REAL code examples, not pseudocode
- Be specific and actionable
- Focus on modern best practices (2024+)
- Include edge cases and error handling patterns
- Make principles enforceable and testable`
}
});
if (!response.text) {
throw new Error("No response from Gemini.");
}
const data = JSON.parse(response.text) as AgentSkill;
return data;
} catch (error) {
console.error("Gemini API Error:", error);
throw error;
if (!response.ok) {
const error = await response.json().catch(() => ({ error: 'Unknown error' }));
throw new Error(error.error || 'Failed to generate skill');
}
};
return response.json();
}
export const generateLearningPath: (topic: string) => Promise<AgentSkill> = generateAgentSkill;