docs: record maintenance review findings

This commit is contained in:
RCD
2026-03-12 12:02:21 +07:00
parent 13a1fbe946
commit 85f6a29477
2 changed files with 26 additions and 5 deletions
+21
View File
@@ -40,3 +40,24 @@ Merged upstream CLIProxyAPI releases `v6.8.50` and `v6.8.51` directly into Proxy
## Release Notes
- Next dev tag: `v0.3.0-dev-0.42`
- Latest upstream target at merge time: `CLIProxyAPI v6.8.51`
## Maintenance Review
- Completed parallel findings-first review of `internal/auth/*`, `internal/translator/*`, and `internal/api/handlers/*` on 2026-03-12 12:01:40 +07.
- Auth review findings:
- `internal/auth/kiro/token_repository.go` only queues `auth_method` values `idc` and `builder-id` for background refresh even though `internal/auth/kiro/oauth.go` persists social logins as `auth_method: "social"` and the refresher has a default OAuth refresh path for non-SSO methods. Result: Google/GitHub Kiro tokens are skipped by auto-refresh.
- `internal/auth/kiro/token_repository.go` walks nested token files but rewrites refreshed tokens back to `filepath.Join(baseDir, token.ID)` after truncating IDs to `filepath.Base(path)`. Result: nested Kiro token files would be rewritten into the auth root instead of their original directory.
- Translator review findings:
- `internal/translator/kiro/openai` can emit streamed tool-call argument deltas with the wrong OpenAI tool index.
- `internal/translator/kiro/openai` does not actually enforce `tool_choice`; it still forwards tools when callers request `none` or pin a specific function.
- `internal/translator/openai/openai/responses` downgrades `developer` messages to `user`.
- `internal/translator/gemini/openai/chat-completions` reads/mapping finish reasons incorrectly for some response shapes.
- `internal/translator/gemini/openai/responses` can send `functionResponse.name = "unknown"` on follow-up tool-output requests.
- API handler review findings:
- `internal/api/handlers/management/memory.go` uses raw `session` query values to build filesystem paths for delete/export/import instead of the memory store's sanitized session path helper, allowing traversal outside the memory store root.
- `internal/api/handlers/management/generic_import.go` derives auth filenames from the first characters of imported API keys, exposing secret prefixes in filenames and management responses.
- `internal/api/handlers/management/auth_files.go` writes uploaded auth files to disk before validation and leaves invalid files behind on registration failure.
- `internal/api/handlers/management/config_basic.go` returns a zero-value config from `GetConfig` because it serializes `new(*h.cfg)` instead of the current config.
- `internal/api/handlers/management/auth_priority.go` and `internal/api/handlers/management/auth_files.go` update priority in places the runtime selector does not read, so management-set auth priority does not affect routing and does not persist reliably for file-backed auths.
- Config mutation helpers in `internal/api/handlers/management/handler.go` mutate `h.cfg` before persistence succeeds, so failed writes can leave runtime config diverged from disk until restart.
- Review validation:
- `go test ./internal/auth/... ./internal/translator/... ./internal/api/handlers/...` - PASS
+5 -5
View File
@@ -103,24 +103,24 @@
"id": 17,
"name": "Auth packages code review",
"description": "Codex review of internal/auth/* packages",
"passes": false
"passes": true
},
{
"id": 18,
"name": "Translator packages code review",
"description": "Codex review of internal/translator/* packages",
"passes": false
"passes": true
},
{
"id": 19,
"name": "API handlers code review",
"description": "Codex review of internal/api/handlers/* packages",
"passes": false
"passes": true
}
],
"summary": {
"total": 19,
"passing": 16,
"failing": 3
"passing": 19,
"failing": 0
}
}