mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-18 18:04:17 +00:00
* feat(ui): show the install's own upgrade command in the update dialog The update dialog always offered `skillshare upgrade` for the terminal. On Nix that command only prints advice, and Homebrew users are better served by `brew upgrade skillshare`, so the right command appeared only after a click on Update returned an error. /api/version now detects the install method, reports its command as upgradeCommand, and looks up the latest version the way the CLI update notice does for that method. The dialog shows that command, or the existing "update your Nix configuration and rebuild" text when a Nix configuration provides skillshare, so no new translations are needed. * fix(ui): keep `skillshare upgrade` in the update dialog, add only a Nix note Review of the previous commit found three regressions: - `skillshare upgrade` already runs `brew upgrade` on Homebrew and also updates the built-in skill. Showing `brew upgrade skillshare` (or the nix profile command) instead broke the case where only the skill is outdated: the shown command updates nothing. - /api/version looked up the latest version through `brew info` on Homebrew, inside the request with no timeout. Homebrew's auto-update could stall the dialog, and a server without brew on PATH never showed an update. - The rendered dialog tests only checked shown text, which wiki/frontend.md says to leave to screenshots. The dialog keeps `skillshare upgrade` and the GitHub lookup. /api/version reports nixUpgradeCommand only for Nix installs, and when a newer CLI is pending the dialog adds the existing Nix advice under the command. The decision lives in nixUpdateNote, unit-tested in upgradeError.test.ts.
React + TypeScript + Vite
This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules.
Currently, two official plugins are available:
- @vitejs/plugin-react uses Babel (or oxc when used in rolldown-vite) for Fast Refresh
- @vitejs/plugin-react-swc uses SWC for Fast Refresh
React Compiler
The React Compiler is not enabled on this template because of its impact on dev & build performances. To add it, see this documentation.
Expanding the ESLint configuration
If you are developing a production application, we recommend updating the configuration to enable type-aware lint rules:
export default defineConfig([
globalIgnores(['dist']),
{
files: ['**/*.{ts,tsx}'],
extends: [
// Other configs...
// Remove tseslint.configs.recommended and replace with this
tseslint.configs.recommendedTypeChecked,
// Alternatively, use this for stricter rules
tseslint.configs.strictTypeChecked,
// Optionally, add this for stylistic rules
tseslint.configs.stylisticTypeChecked,
// Other configs...
],
languageOptions: {
parserOptions: {
project: ['./tsconfig.node.json', './tsconfig.app.json'],
tsconfigRootDir: import.meta.dirname,
},
// other options...
},
},
])
You can also install eslint-plugin-react-x and eslint-plugin-react-dom for React-specific lint rules:
// eslint.config.js
import reactX from 'eslint-plugin-react-x'
import reactDom from 'eslint-plugin-react-dom'
export default defineConfig([
globalIgnores(['dist']),
{
files: ['**/*.{ts,tsx}'],
extends: [
// Other configs...
// Enable lint rules for React
reactX.configs['recommended-typescript'],
// Enable lint rules for React DOM
reactDom.configs.recommended,
],
languageOptions: {
parserOptions: {
project: ['./tsconfig.node.json', './tsconfig.app.json'],
tsconfigRootDir: import.meta.dirname,
},
// other options...
},
},
])