Files
skillshare/proposals
Willie fc1785673b docs: review-round limits and move-skill proposal (#510) (#516)
* docs(wiki): cap Codex review rounds and require a state matrix before review

PR #513 reached 7+ Codex rounds because each round surfaced one more
state dimension (project mode, tracked installs, followed links, legacy
keys, lock pins) that the change had never listed. Every round costs the
maintainer a review cycle.

Require a state matrix and a consumer sweep before the first review,
separate findings worth code from unrealistic combinations, and stop at
three rounds unless a finding shows data loss or a broken supported
workflow.

* docs(proposals): add move installed skill proposal for #510

Moving an installed skill with mv strands its install record, and the
documented workaround (uninstall + install --into) re-downloads and
drops audit acceptances and lock pins. Propose one explicit move
operation shared by the CLI, the Web API and the dashboard.

Records the maintainer decisions: no auto-sync, followed links refused,
target filters warn only, whole-folder move in v1, --force limited to
name collisions.

* fix(proposals): cover nested skills, bare tracked checkouts and duplicate destinations

Codex review of the move proposal found three gaps in the folder-move
design:

- A skill directory that contains nested skills was planned as one
  skill, so descendants would move on disk but keep their old records,
  pins and audit acceptances. Plan now expands descendants too.
- Refusals were derived from discovered skills only, so a tracked
  checkout with no discoverable skill would move along with its folder.
  Preflight now walks the whole tree for checkouts and links.
- Two inputs converging on one destination path were treated as a
  forceable flat-name collision and left the batch half-moved. They are
  now a separate, non-forceable duplicate_dest refusal.

* fix(proposals): keep nested records through reconcile, warn both filter directions, refuse overlapping roots

Second Codex round on the move proposal found three more gaps:

- The reconcile walk stops at an installed parent and then prunes every
  record it did not see, so a moved nested skill would lose its record
  and audit acceptances. Reconcile must keep records below a live
  installed record.
- Target filter warnings only covered rules that stop matching. A move
  into a folder that an exclude pattern covers (or an include newly
  adds) changes sync output too, so compare the effective filter result
  before and after.
- Batches such as `move foo foo/sub archive` planned the same subtree
  twice. Overlapping source roots are now refused before any rename.
2026-10-10 23:36:33 +08:00
..