mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
Addresses P1 and P2 from code review on the RWMutex commit: P1 — Stream handlers now snapshot config under RLock before streaming: - handleDiffStream: clone Targets map to prevent concurrent map panic - handleCheckStream, handleAuditStream: snapshot source/projectRoot - handleUpdateStream: snapshot source (per-item Lock already correct) P2 — All read handlers now use narrow snapshot instead of defer RUnlock: - RLock → copy needed fields to locals → RUnlock → do work with locals - Prevents slow I/O (git fetch, version check, audit scan) from blocking the auto-reload middleware's exclusive Lock on concurrent requests Other changes: - computeTargetDiff takes source parameter (no more s.cfg.Source access) - Add cloneTargets() helper for safe map copying - Add writeOpsLogTo/writeAuditLogTo for lock-free oplog writes
256 lines
6.1 KiB
Go
256 lines
6.1 KiB
Go
package server
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"skillshare/internal/backup"
|
|
)
|
|
|
|
type backupInfoJSON struct {
|
|
Timestamp string `json:"timestamp"`
|
|
Path string `json:"path"`
|
|
Targets []string `json:"targets"`
|
|
Date string `json:"date"`
|
|
SizeBytes int64 `json:"sizeBytes"`
|
|
}
|
|
|
|
func toBackupJSON(b backup.BackupInfo) backupInfoJSON {
|
|
return backupInfoJSON{
|
|
Timestamp: b.Timestamp,
|
|
Path: b.Path,
|
|
Targets: b.Targets,
|
|
Date: b.Date.Format("2006-01-02T15:04:05Z07:00"),
|
|
SizeBytes: backup.Size(b.Path),
|
|
}
|
|
}
|
|
|
|
// handleListBackups returns all backups
|
|
func (s *Server) handleListBackups(w http.ResponseWriter, r *http.Request) {
|
|
backups, err := backup.List()
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, err.Error())
|
|
return
|
|
}
|
|
|
|
items := make([]backupInfoJSON, 0, len(backups))
|
|
for _, b := range backups {
|
|
items = append(items, toBackupJSON(b))
|
|
}
|
|
|
|
total, _ := backup.TotalSize()
|
|
writeJSON(w, map[string]any{
|
|
"backups": items,
|
|
"totalSizeBytes": total,
|
|
})
|
|
}
|
|
|
|
// handleCreateBackup creates a backup of target(s)
|
|
func (s *Server) handleCreateBackup(w http.ResponseWriter, r *http.Request) {
|
|
start := time.Now()
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
var body struct {
|
|
Target string `json:"target"` // empty = all targets
|
|
}
|
|
json.NewDecoder(r.Body).Decode(&body)
|
|
|
|
targets := make(map[string]string)
|
|
if body.Target != "" {
|
|
t, ok := s.cfg.Targets[body.Target]
|
|
if !ok {
|
|
writeError(w, http.StatusBadRequest, "target not found: "+body.Target)
|
|
return
|
|
}
|
|
targets[body.Target] = t.Path
|
|
} else {
|
|
for name, t := range s.cfg.Targets {
|
|
targets[name] = t.Path
|
|
}
|
|
}
|
|
|
|
var created []string
|
|
for name, path := range targets {
|
|
bp, err := backup.Create(name, path)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "backup failed for "+name+": "+err.Error())
|
|
return
|
|
}
|
|
if bp != "" {
|
|
created = append(created, name)
|
|
}
|
|
}
|
|
|
|
s.writeOpsLog("backup", "ok", start, map[string]any{
|
|
"target": body.Target,
|
|
"targets_total": len(targets),
|
|
"targets_backed": len(created),
|
|
"scope": "ui",
|
|
}, "")
|
|
|
|
writeJSON(w, map[string]any{
|
|
"success": true,
|
|
"backedUpTargets": created,
|
|
})
|
|
}
|
|
|
|
// handleCleanupBackups removes old backups
|
|
func (s *Server) handleCleanupBackups(w http.ResponseWriter, r *http.Request) {
|
|
start := time.Now()
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
cfg := backup.DefaultCleanupConfig()
|
|
removed, err := backup.Cleanup(cfg)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, err.Error())
|
|
return
|
|
}
|
|
|
|
s.writeOpsLog("backup", "ok", start, map[string]any{
|
|
"action": "cleanup",
|
|
"removed": removed,
|
|
"scope": "ui",
|
|
}, "")
|
|
|
|
writeJSON(w, map[string]any{
|
|
"success": true,
|
|
"removed": removed,
|
|
})
|
|
}
|
|
|
|
// handleRestore restores a backup to a target
|
|
func (s *Server) handleRestore(w http.ResponseWriter, r *http.Request) {
|
|
start := time.Now()
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
|
|
var body struct {
|
|
Timestamp string `json:"timestamp"`
|
|
Target string `json:"target"`
|
|
Force bool `json:"force"`
|
|
}
|
|
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid JSON body")
|
|
return
|
|
}
|
|
|
|
if body.Timestamp == "" || body.Target == "" {
|
|
writeError(w, http.StatusBadRequest, "timestamp and target are required")
|
|
return
|
|
}
|
|
|
|
// Verify target exists in config
|
|
t, ok := s.cfg.Targets[body.Target]
|
|
if !ok {
|
|
writeError(w, http.StatusBadRequest, "target not found: "+body.Target)
|
|
return
|
|
}
|
|
|
|
// Find backup
|
|
bk, err := backup.GetBackupByTimestamp(body.Timestamp)
|
|
if err != nil {
|
|
writeError(w, http.StatusNotFound, "backup not found: "+err.Error())
|
|
return
|
|
}
|
|
|
|
opts := backup.RestoreOptions{Force: body.Force}
|
|
|
|
// Validate first
|
|
if err := backup.ValidateRestore(bk.Path, body.Target, t.Path, opts); err != nil {
|
|
writeError(w, http.StatusConflict, err.Error())
|
|
return
|
|
}
|
|
|
|
// Restore
|
|
if err := backup.RestoreToPath(bk.Path, body.Target, t.Path, opts); err != nil {
|
|
writeError(w, http.StatusInternalServerError, "restore failed: "+err.Error())
|
|
return
|
|
}
|
|
|
|
s.writeOpsLog("restore", "ok", start, map[string]any{
|
|
"target": body.Target,
|
|
"from": body.Timestamp,
|
|
"force": body.Force,
|
|
"scope": "ui",
|
|
}, "")
|
|
|
|
writeJSON(w, map[string]any{
|
|
"success": true,
|
|
"target": body.Target,
|
|
"timestamp": body.Timestamp,
|
|
})
|
|
}
|
|
|
|
// handleValidateRestore checks if a restore would succeed and returns conflict info.
|
|
func (s *Server) handleValidateRestore(w http.ResponseWriter, r *http.Request) {
|
|
// Snapshot config under RLock, then release before I/O.
|
|
s.mu.RLock()
|
|
targets := s.cloneTargets()
|
|
s.mu.RUnlock()
|
|
|
|
var body struct {
|
|
Timestamp string `json:"timestamp"`
|
|
Target string `json:"target"`
|
|
}
|
|
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid JSON body")
|
|
return
|
|
}
|
|
|
|
if body.Timestamp == "" || body.Target == "" {
|
|
writeError(w, http.StatusBadRequest, "timestamp and target are required")
|
|
return
|
|
}
|
|
|
|
t, ok := targets[body.Target]
|
|
if !ok {
|
|
writeError(w, http.StatusBadRequest, "target not found: "+body.Target)
|
|
return
|
|
}
|
|
|
|
bk, err := backup.GetBackupByTimestamp(body.Timestamp)
|
|
if err != nil {
|
|
writeError(w, http.StatusNotFound, "backup not found: "+err.Error())
|
|
return
|
|
}
|
|
|
|
backupSize := backup.Size(filepath.Join(bk.Path, body.Target))
|
|
|
|
// Check destination state with Lstat to detect symlinks
|
|
isSymlink := false
|
|
var conflicts []string
|
|
info, err := os.Lstat(t.Path)
|
|
if err == nil {
|
|
if info.Mode()&os.ModeSymlink != 0 {
|
|
isSymlink = true
|
|
} else if info.IsDir() {
|
|
entries, _ := os.ReadDir(t.Path)
|
|
for _, e := range entries {
|
|
conflicts = append(conflicts, e.Name())
|
|
}
|
|
}
|
|
}
|
|
|
|
// Validate backup source exists for target
|
|
opts := backup.RestoreOptions{Force: true}
|
|
validErr := backup.ValidateRestore(bk.Path, body.Target, t.Path, opts)
|
|
|
|
errMsg := ""
|
|
if validErr != nil {
|
|
errMsg = validErr.Error()
|
|
}
|
|
|
|
writeJSON(w, map[string]any{
|
|
"valid": validErr == nil,
|
|
"error": errMsg,
|
|
"conflicts": conflicts,
|
|
"backupSizeBytes": backupSize,
|
|
"currentIsSymlink": isSymlink,
|
|
})
|
|
}
|