mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-20 12:23:22 +00:00
Implement Issue #46 across install/update paths to reduce perceived hangs and improve subdir installation performance on large repositories. Main changes: - Add git progress streaming primitives in internal/install/git_progress.go. - runGitCommandWithProgress supports stderr streaming callbacks in TTY mode. - scanGitProgress handles both CR and LF progress delimiters. - Thread InstallOptions.OnProgress through clone/pull/discovery/install/update paths. - Keep non-TTY behavior quiet to avoid noisy logs. - Add TreeSpinner.Update for live message updates. - Add progress-aware git update APIs in internal/git/info.go: - PullWithProgress and ForcePullWithProgress (keep PullWithEnv/ForcePullWithEnv for compatibility). - Introduce shared GitHub client utilities in internal/github/client.go. - Centralize token lookup, request construction, and rate-limit handling. - Refactor internal/search/search.go to use shared client while preserving compatibility aliases. - Add GitHub/GHE API subdir fast path in internal/install/github_download.go. - github.com => api.github.com - github-like enterprise hosts => https://<host>/api/v3 - On API failure, emit warning and fallback to git-based flows. - Add sparse checkout fallback for non-GitHub subdir sources in internal/install/sparse_checkout.go. - Use filter+no-checkout+depth=1 then sparse-checkout set + checkout. - Extend discovery/install metadata plumbing. - DiscoveryResult now includes CommitHash and Warnings. - install/discover subdir paths preserve warnings and commit hashes from API/sparse/full-clone flows. - Preserve compatibility and UX expectations. - Keep existing action strings (for tests/UI stability). - Keep legacy discover/pull APIs as wrappers around new progress-aware variants. - Improve --track download efficiency. - Track clone now attempts --filter=blob:none --depth 1 --single-branch first. - Falls back to full clone only on remote capability mismatch, not on auth/not-found errors. CLI wiring: - cmd/skillshare/install.go - TTY handlers now pass progress callbacks and use with-progress discover APIs. - Subdir handler shows API-vs-clone stage messages and renders discovery fallback warnings. - cmd/skillshare/update.go and cmd/skillshare/update_project.go - Use PullWithProgress/ForcePullWithProgress for tracked repos. - Ensure reinstall/update install flows forward progress callbacks. Tests added/updated: - internal/install/git_progress_test.go - internal/install/github_download_test.go - internal/install/sparse_checkout_test.go - internal/install/tracked_clone_test.go - internal/install/source_test.go (GitHubOwner/GitHubRepo coverage) - internal/git/info_test.go (PullWithProgress/ForcePullWithProgress) - tests/integration/install_subdir_optimization_test.go - tests/integration/install_online_test.go (GitHub API subdir case) Validation performed: - go test ./internal/install -count=1 - go test ./internal/git -run 'Test.*Pull.*' -count=1 - go build -o bin/skillshare ./cmd/skillshare && SKILLSHARE_TEST_BINARY="/Users/williehung/Developer/Apps/github/skillshare/bin/skillshare" go test ./tests/integration -run 'TestInstall_Subdir|TestUpdate_' -count=1 - go build -o bin/skillshare ./cmd/skillshare && SKILLSHARE_TEST_BINARY="/Users/williehung/Developer/Apps/github/skillshare/bin/skillshare" go test ./tests/integration -run 'TestInstall_Track_|TestUpdate_TrackedRepo' -count=1 - go test -tags online ./tests/integration -run TestInstall_GitHubSubdirViaAPI -count=1 - make lint - make test
70 lines
1.6 KiB
Go
70 lines
1.6 KiB
Go
package install
|
|
|
|
import (
|
|
"fmt"
|
|
"os/exec"
|
|
"strconv"
|
|
"strings"
|
|
)
|
|
|
|
func gitSupportsSparseCheckout() bool {
|
|
out, err := exec.Command("git", "--version").Output()
|
|
if err != nil {
|
|
return false
|
|
}
|
|
return supportsSparseCheckoutVersion(strings.TrimSpace(string(out)))
|
|
}
|
|
|
|
func supportsSparseCheckoutVersion(versionOutput string) bool {
|
|
// Examples:
|
|
// git version 2.44.0
|
|
// git version 2.39.3 (Apple Git-146)
|
|
fields := strings.Fields(versionOutput)
|
|
if len(fields) < 3 {
|
|
return false
|
|
}
|
|
ver := fields[2]
|
|
parts := strings.Split(ver, ".")
|
|
if len(parts) < 2 {
|
|
return false
|
|
}
|
|
major, err := strconv.Atoi(parts[0])
|
|
if err != nil {
|
|
return false
|
|
}
|
|
minor, err := strconv.Atoi(parts[1])
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
if major > 2 {
|
|
return true
|
|
}
|
|
return major == 2 && minor >= 25
|
|
}
|
|
|
|
func sparseCloneSubdir(url, subdir, destPath string, extraEnv []string, onProgress ProgressCallback) error {
|
|
subdir = strings.TrimSpace(subdir)
|
|
if subdir == "" {
|
|
return fmt.Errorf("sparse checkout requires non-empty subdir")
|
|
}
|
|
|
|
cloneArgs := []string{"clone", "--filter=blob:none", "--no-checkout", "--depth", "1", "--quiet", url, destPath}
|
|
if onProgress != nil {
|
|
cloneArgs = []string{"clone", "--filter=blob:none", "--no-checkout", "--depth", "1", "--progress", url, destPath}
|
|
}
|
|
if err := runGitCommandWithProgress(cloneArgs, "", extraEnv, onProgress); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := runGitCommandWithProgress([]string{"sparse-checkout", "set", subdir}, destPath, extraEnv, nil); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := runGitCommandWithProgress([]string{"checkout"}, destPath, extraEnv, nil); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|