mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
The skill list endpoint discovers skills with DiscoverSourceSkillsAll (which includes disabled skills), but the uninstall handler used DiscoverSourceSkills, which excludes anything listed in .skillignore. A disabled skill therefore stayed visible in the dashboard yet failed to uninstall with "skill not found". Switch handleBatchUninstallSkills to DiscoverSourceSkillsAll so the two endpoints agree on which skills exist. The CLI was unaffected. Fixes #190
131 lines
4.3 KiB
Go
131 lines
4.3 KiB
Go
package server
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"skillshare/internal/config"
|
|
"skillshare/internal/install"
|
|
)
|
|
|
|
// Issue #190: a disabled skill (listed in .skillignore) must still be
|
|
// uninstallable via the UI. The list handler uses DiscoverSourceSkillsAll
|
|
// (includes disabled skills), so the uninstall handler must match it —
|
|
// otherwise the skill shows in the UI but uninstall reports "skill not found".
|
|
func TestHandleBatchUninstall_DisabledSkill(t *testing.T) {
|
|
s, src := newTestServer(t)
|
|
|
|
addSkill(t, src, "disabled-skill")
|
|
// Disable it the way the toggle handler does: add to .skillignore.
|
|
os.WriteFile(filepath.Join(src, ".skillignore"), []byte("disabled-skill\n"), 0644)
|
|
|
|
s.skillsStore = install.NewMetadataStore()
|
|
|
|
body := batchUninstallRequest{Names: []string{"disabled-skill"}, Force: true}
|
|
b, _ := json.Marshal(body)
|
|
req := httptest.NewRequest(http.MethodPost, "/api/uninstall", bytes.NewReader(b))
|
|
rr := httptest.NewRecorder()
|
|
s.handleBatchUninstall(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Results []batchUninstallItemResult `json:"results"`
|
|
Summary batchUninstallSummary `json:"summary"`
|
|
}
|
|
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("failed to decode response: %v", err)
|
|
}
|
|
if resp.Summary.Succeeded != 1 || resp.Summary.Failed != 0 {
|
|
t.Fatalf("expected 1 succeeded / 0 failed, got %+v (results: %+v)", resp.Summary, resp.Results)
|
|
}
|
|
if _, err := os.Stat(filepath.Join(src, "disabled-skill")); !os.IsNotExist(err) {
|
|
t.Fatal("expected disabled-skill directory to be removed from source")
|
|
}
|
|
}
|
|
|
|
func TestHandleBatchUninstall_ProjectMode_GitignorePath(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
|
|
// Simulate project mode
|
|
projectRoot := t.TempDir()
|
|
projectSkillsDir := filepath.Join(projectRoot, ".skillshare", "skills")
|
|
os.MkdirAll(projectSkillsDir, 0755)
|
|
s.projectRoot = projectRoot
|
|
s.projectCfg = &config.ProjectConfig{}
|
|
s.cfg.Source = projectSkillsDir
|
|
|
|
// Create tracked repo
|
|
addTrackedRepo(t, projectSkillsDir, "_team-skills")
|
|
|
|
// Write gitignore the way project install does
|
|
gitignoreDir := filepath.Join(projectRoot, ".skillshare")
|
|
gitignorePath := filepath.Join(gitignoreDir, ".gitignore")
|
|
os.WriteFile(gitignorePath, []byte(
|
|
"# BEGIN SKILLSHARE MANAGED - DO NOT EDIT\nskills/_team-skills/\n# END SKILLSHARE MANAGED\n",
|
|
), 0644)
|
|
|
|
s.skillsStore = install.NewMetadataStore()
|
|
s.skillsStore.Set("_team-skills", &install.MetadataEntry{Tracked: true})
|
|
|
|
body := batchUninstallRequest{Names: []string{"_team-skills"}, Force: true}
|
|
b, _ := json.Marshal(body)
|
|
req := httptest.NewRequest(http.MethodPost, "/api/uninstall", bytes.NewReader(b))
|
|
rr := httptest.NewRecorder()
|
|
s.handleBatchUninstall(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
data, err := os.ReadFile(gitignorePath)
|
|
if err != nil {
|
|
t.Fatalf("failed to read gitignore: %v", err)
|
|
}
|
|
if strings.Contains(string(data), "skills/_team-skills/") {
|
|
t.Fatal("expected skills/_team-skills/ to be removed from .skillshare/.gitignore")
|
|
}
|
|
}
|
|
|
|
func TestHandleBatchUninstall_GlobalMode_GitignorePath(t *testing.T) {
|
|
s, src := newTestServer(t)
|
|
|
|
// Create tracked repo in global source
|
|
addTrackedRepo(t, src, "_team-skills")
|
|
|
|
// Write gitignore in source dir
|
|
gitignorePath := filepath.Join(src, ".gitignore")
|
|
os.WriteFile(gitignorePath, []byte(
|
|
"# BEGIN SKILLSHARE MANAGED - DO NOT EDIT\n_team-skills/\n# END SKILLSHARE MANAGED\n",
|
|
), 0644)
|
|
|
|
s.skillsStore = install.NewMetadataStore()
|
|
s.skillsStore.Set("_team-skills", &install.MetadataEntry{Tracked: true})
|
|
|
|
body := batchUninstallRequest{Names: []string{"_team-skills"}, Force: true}
|
|
b, _ := json.Marshal(body)
|
|
req := httptest.NewRequest(http.MethodPost, "/api/uninstall", bytes.NewReader(b))
|
|
rr := httptest.NewRecorder()
|
|
s.handleBatchUninstall(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
data, err := os.ReadFile(gitignorePath)
|
|
if err != nil {
|
|
t.Fatalf("failed to read gitignore: %v", err)
|
|
}
|
|
if strings.Contains(string(data), "_team-skills/") {
|
|
t.Fatal("expected _team-skills/ to be removed from global source .gitignore")
|
|
}
|
|
}
|