mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-18 18:04:17 +00:00
The legacy color constants in internal/ui (Red, Gray, Dim, Bold, Reset, …) were compile-time strings that ignored the theme, so status, doctor, extras list and about twenty other commands printed ANSI codes even with NO_COLOR set. Make them variables and blank them at startup when the theme reports NoColor, so the theme stays the single source of that decision. The two places that hardcoded escape codes (usage and log --stats) now use the same variables.
114 lines
3.2 KiB
Go
114 lines
3.2 KiB
Go
//go:build !online
|
|
|
|
package integration
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"skillshare/internal/testutil"
|
|
)
|
|
|
|
// TestList_SKILLSHARE_THEME_Light verifies that when SKILLSHARE_THEME=light
|
|
// is set, the list output uses the light Primary color (232) and does not
|
|
// contain pure bright white (15), resolving issue #125.
|
|
func TestList_SKILLSHARE_THEME_Light(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.CreateSkill("hello-world", map[string]string{
|
|
"SKILL.md": "---\nname: hello-world\ndescription: A test skill\n---\n# Hello",
|
|
})
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
result := sb.RunCLIEnv(
|
|
map[string]string{"SKILLSHARE_THEME": "light"},
|
|
"list", "--no-tui",
|
|
)
|
|
|
|
if result.ExitCode != 0 {
|
|
t.Fatalf("list exited %d: %s", result.ExitCode, result.Output())
|
|
}
|
|
|
|
// Light Primary is 232 — the rendered 256-color escape is
|
|
// ESC[38;5;232m. Plain text from tables etc. may not include this,
|
|
// so we only assert that pure white 15 is NOT present.
|
|
if strings.Contains(result.Stdout, "\x1b[38;5;15m") {
|
|
t.Error("light theme output must not contain pure white (Color 15)")
|
|
}
|
|
}
|
|
|
|
// TestList_NO_COLOR verifies that NO_COLOR strips all ANSI escape sequences.
|
|
func TestList_NO_COLOR(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.CreateSkill("hello", map[string]string{
|
|
"SKILL.md": "---\nname: hello\ndescription: A test skill\n---\n# H",
|
|
})
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets: {}
|
|
`)
|
|
|
|
result := sb.RunCLIEnv(
|
|
map[string]string{"NO_COLOR": "1"},
|
|
"list", "--no-tui",
|
|
)
|
|
|
|
if result.ExitCode != 0 {
|
|
t.Fatalf("list exited %d: %s", result.ExitCode, result.Output())
|
|
}
|
|
|
|
if strings.Contains(result.Stdout, "\x1b[") {
|
|
t.Errorf("NO_COLOR must strip all ANSI escapes, got: %q", result.Stdout)
|
|
}
|
|
}
|
|
|
|
// TestTargetOutput_NO_COLOR verifies that per-target lines in status, doctor,
|
|
// and extras list honor NO_COLOR. These paths build output from the raw ui
|
|
// color variables rather than theme.ANSI().
|
|
func TestTargetOutput_NO_COLOR(t *testing.T) {
|
|
sb := testutil.NewSandbox(t)
|
|
defer sb.Cleanup()
|
|
|
|
sb.CreateSkill("hello", map[string]string{
|
|
"SKILL.md": "---\nname: hello\ndescription: A test skill\n---\n# H",
|
|
})
|
|
rulesSource := filepath.Join(filepath.Dir(sb.SourcePath), "extras", "rules")
|
|
if err := os.MkdirAll(rulesSource, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
sb.WriteConfig(`source: ` + sb.SourcePath + `
|
|
targets:
|
|
claude:
|
|
path: ` + sb.CreateTarget("claude") + `
|
|
extras:
|
|
- name: rules
|
|
targets:
|
|
- path: ` + filepath.Join(sb.Home, "rules-target") + `
|
|
`)
|
|
|
|
for _, tc := range []struct {
|
|
args []string
|
|
want string // a target line that must be rendered
|
|
}{
|
|
{[]string{"status"}, "claude"},
|
|
{[]string{"doctor"}, "claude"},
|
|
{[]string{"extras", "list", "--no-tui"}, "rules-target"},
|
|
} {
|
|
t.Run(strings.Join(tc.args, " "), func(t *testing.T) {
|
|
result := sb.RunCLIEnv(map[string]string{"NO_COLOR": "1"}, tc.args...)
|
|
if !strings.Contains(result.Output(), tc.want) {
|
|
t.Fatalf("expected output to mention %q, got: %s", tc.want, result.Output())
|
|
}
|
|
if strings.Contains(result.Output(), "\x1b[") {
|
|
t.Errorf("NO_COLOR must strip all ANSI escapes, got: %q", result.Output())
|
|
}
|
|
})
|
|
}
|
|
}
|