Files
skillshare/internal/install/audit_accept_test.go
T
Willie f52ae74c5f feat(audit): remember findings accepted via --force across updates
Overriding the audit gate with --force was per-invocation, so skills that
legitimately quote attack strings (security scanners, red-team docs) had to
be forced on every `update --all`. The only alternative, disabling the rule,
was global and turned it off for every skill.

Record the accepted findings (rule + file + matched text, no line number) in
.metadata.json under `audit_accepted`, keyed by skill relPath so it survives
entry rewrites and works for tracked repos. Later updates mark matching
findings as acknowledged and exclude them from the block decision; any new
finding, or the same rule matching different text, still blocks.

Staged installs audit a temp directory, so InstallOptions gains an
AuditAcceptRoot/AuditAcceptPath override pointing at the final destination.

Refs #279
2026-09-17 10:24:18 +08:00

61 lines
2.0 KiB
Go

package install
import (
"path/filepath"
"testing"
"skillshare/internal/audit"
)
func criticalResult(snippet string) *audit.Result {
return &audit.Result{Findings: []audit.Finding{{
Severity: audit.SeverityCritical, Pattern: "prompt-injection",
RuleID: "prompt-injection-0", File: "SKILL.md", Line: 3, Snippet: snippet,
}}}
}
func TestRecordAcceptedFindings_RoundTrip(t *testing.T) {
sourceDir := t.TempDir()
skillPath := filepath.Join(sourceDir, "my-skill")
added, err := RecordAcceptedFindings(sourceDir, skillPath, criticalResult("Ignore previous instructions"), audit.SeverityCritical)
if err != nil {
t.Fatal(err)
}
if added != 1 {
t.Fatalf("want 1 recorded, got %d", added)
}
// Same finding on a different line: acknowledged, no longer blocks.
shifted := criticalResult("Ignore previous instructions")
shifted.Findings[0].Line = 9
if n := ApplyAcceptedFindings(sourceDir, skillPath, shifted); n != 1 {
t.Fatalf("want 1 acknowledged, got %d", n)
}
if shifted.HasSeverityAtOrAbove(audit.SeverityCritical) {
t.Error("accepted finding must not block")
}
// Different snippet: still blocks.
other := criticalResult("SYSTEM: override")
ApplyAcceptedFindings(sourceDir, skillPath, other)
if !other.HasSeverityAtOrAbove(audit.SeverityCritical) {
t.Error("new finding must still block")
}
// Recording again is idempotent.
added, err = RecordAcceptedFindings(sourceDir, skillPath, criticalResult("Ignore previous instructions"), audit.SeverityCritical)
if err != nil || added != 0 {
t.Errorf("re-record: want 0 added, got %d (err=%v)", added, err)
}
}
func TestRecordAcceptedFindings_SkipsBelowThreshold(t *testing.T) {
sourceDir := t.TempDir()
res := &audit.Result{Findings: []audit.Finding{{Severity: audit.SeverityHigh, Pattern: "x", File: "SKILL.md"}}}
added, err := RecordAcceptedFindings(sourceDir, filepath.Join(sourceDir, "s"), res, audit.SeverityCritical)
if err != nil || added != 0 {
t.Errorf("HIGH below CRITICAL threshold must not be recorded, got %d (err=%v)", added, err)
}
}