Files
skillshare/internal/check/agent_check_test.go
T
Willie d16c4f3812 fix: correct metadata store routing, corruption handling, and lookup depth
Three bugs introduced during centralized metadata migration:

1. Batch agent installs via UI wrote metadata to skills/.metadata.json
   instead of agents/.metadata.json because handleInstallBatch hard-coded
   SourceDir to s.cfg.Source. Override SourceDir with agentsSource() when
   body.Kind is agent.

2. CheckAgents used LoadMetadataOrNew which silently converts parse
   failures into an empty store, making all tracked agents appear local
   and suppressing drift/update diagnostics. Switch to LoadMetadata and
   surface corruption as status=error with the parse error message.

3. findMetaEntry only climbed 3 parent directories when searching for
   .metadata.json, but --into supports arbitrary nesting depth. Raise
   the ceiling to 10 (root sentinel still terminates early).
2026-04-08 18:06:20 +08:00

153 lines
4.3 KiB
Go

package check
import (
"encoding/json"
"os"
"path/filepath"
"testing"
"skillshare/internal/install"
"skillshare/internal/utils"
)
func TestCheckAgents_NoAgents(t *testing.T) {
dir := t.TempDir()
results := CheckAgents(dir)
if len(results) != 0 {
t.Errorf("expected 0 results, got %d", len(results))
}
}
func TestCheckAgents_LocalAgent(t *testing.T) {
dir := t.TempDir()
os.WriteFile(filepath.Join(dir, "tutor.md"), []byte("# Tutor"), 0644)
results := CheckAgents(dir)
if len(results) != 1 {
t.Fatalf("expected 1 result, got %d", len(results))
}
if results[0].Name != "tutor" {
t.Errorf("Name = %q, want %q", results[0].Name, "tutor")
}
if results[0].Status != "local" {
t.Errorf("Status = %q, want %q", results[0].Status, "local")
}
}
func TestCheckAgents_UpToDate(t *testing.T) {
dir := t.TempDir()
agentFile := filepath.Join(dir, "tutor.md")
os.WriteFile(agentFile, []byte("# Tutor agent"), 0644)
hash, _ := utils.FileHashFormatted(agentFile)
meta := &install.SkillMeta{
Source: "test",
Kind: "agent",
FileHashes: map[string]string{"tutor.md": hash},
}
metaData, _ := json.MarshalIndent(meta, "", " ")
os.WriteFile(filepath.Join(dir, "tutor.skillshare-meta.json"), metaData, 0644)
results := CheckAgents(dir)
if len(results) != 1 {
t.Fatalf("expected 1 result, got %d", len(results))
}
if results[0].Status != "up_to_date" {
t.Errorf("Status = %q, want %q", results[0].Status, "up_to_date")
}
}
func TestCheckAgents_Drifted(t *testing.T) {
dir := t.TempDir()
agentFile := filepath.Join(dir, "tutor.md")
os.WriteFile(agentFile, []byte("# Modified content"), 0644)
meta := &install.SkillMeta{
Source: "test",
Kind: "agent",
FileHashes: map[string]string{"tutor.md": "sha256:0000000000000000000000000000000000000000000000000000000000000000"},
}
metaData, _ := json.MarshalIndent(meta, "", " ")
os.WriteFile(filepath.Join(dir, "tutor.skillshare-meta.json"), metaData, 0644)
results := CheckAgents(dir)
if len(results) != 1 {
t.Fatalf("expected 1 result, got %d", len(results))
}
if results[0].Status != "drifted" {
t.Errorf("Status = %q, want %q", results[0].Status, "drifted")
}
}
func TestCheckAgents_InvalidCentralizedMetadata(t *testing.T) {
dir := t.TempDir()
os.WriteFile(filepath.Join(dir, "tutor.md"), []byte("# Tutor"), 0644)
os.WriteFile(filepath.Join(dir, install.MetadataFileName), []byte("{invalid"), 0644)
results := CheckAgents(dir)
if len(results) != 1 {
t.Fatalf("expected 1 result, got %d", len(results))
}
if results[0].Name != "tutor" {
t.Errorf("Name = %q, want %q", results[0].Name, "tutor")
}
if results[0].Status != "error" {
t.Errorf("Status = %q, want %q", results[0].Status, "error")
}
if results[0].Message == "" {
t.Fatal("expected error message for invalid centralized metadata")
}
}
func TestCheckAgents_NonExistentDir(t *testing.T) {
results := CheckAgents("/nonexistent/path")
if results != nil {
t.Errorf("expected nil for nonexistent dir, got %v", results)
}
}
func TestCheckAgents_Nested(t *testing.T) {
dir := t.TempDir()
subdir := filepath.Join(dir, "demo")
os.MkdirAll(subdir, 0755)
agentFile := filepath.Join(subdir, "tutor.md")
os.WriteFile(agentFile, []byte("# Tutor"), 0644)
hash, _ := utils.FileHashFormatted(agentFile)
meta := &install.SkillMeta{
Source: "https://github.com/example/repo",
Kind: "agent",
FileHashes: map[string]string{"tutor.md": hash},
}
metaData, _ := json.MarshalIndent(meta, "", " ")
os.WriteFile(filepath.Join(subdir, "tutor.skillshare-meta.json"), metaData, 0644)
results := CheckAgents(dir)
if len(results) != 1 {
t.Fatalf("expected 1 result, got %d", len(results))
}
if results[0].Name != "demo/tutor" {
t.Errorf("Name = %q, want %q", results[0].Name, "demo/tutor")
}
if results[0].Status != "up_to_date" {
t.Errorf("Status = %q, want %q", results[0].Status, "up_to_date")
}
if results[0].Source != "https://github.com/example/repo" {
t.Errorf("Source = %q, want non-empty", results[0].Source)
}
}
func TestCheckAgents_SkipsNonMd(t *testing.T) {
dir := t.TempDir()
os.WriteFile(filepath.Join(dir, "tutor.md"), []byte("# Tutor"), 0644)
os.WriteFile(filepath.Join(dir, "config.yaml"), []byte("key: val"), 0644)
os.MkdirAll(filepath.Join(dir, "subdir"), 0755)
results := CheckAgents(dir)
if len(results) != 1 {
t.Fatalf("expected 1 result (only .md files), got %d", len(results))
}
}