Files
skillshare/internal/install/install_update.go
T
Willie f28e5e23f4 fix(install): keep local installs updatable from any directory and in shape (#336)
* fix(install): keep local installs updatable from any directory and in shape

Follow-ups to local-source change detection (#334):

- Global installs recorded a relative local path as typed, so `update`
  and `check` resolved it against whatever directory they ran in and
  failed with "source path does not exist". Global CLI and dashboard
  installs now record the absolute path. Project mode keeps the path as
  written, because .skillshare/config.yaml is shared across machines.
- The dashboard installs the root of a directory that also holds child
  skills as its SKILL.md alone, but `update` re-copied the whole
  directory, pulling in child skills and unrelated files. Updates now
  keep that shape. The detection is shared with `check` so both agree on
  which files belong to the install.

* fix(install): never narrow a whole-directory update to SKILL.md alone

The SKILL.md-only shape was inferred from a child skill in the source that
the recorded hashes lack. A whole-directory install whose source gained a
child skill later matched that too, so `update` replaced it with SKILL.md
alone and deleted its other files. Decide from the recorded files instead:
only an install that recorded SKILL.md alone keeps that shape.
2026-10-02 20:30:27 +08:00

288 lines
8.9 KiB
Go

package install
import (
"fmt"
"os"
"path/filepath"
"skillshare/internal/audit"
)
func handleUpdate(source *Source, destPath string, result *InstallResult, opts InstallOptions) (*InstallResult, error) {
result.SkillPath = destPath
// For git repos without subdir, use git pull for true single-skill repo
// installs. Legacy installs of repo-root orchestrators (root SKILL.md plus
// child skills) used to be full repository clones; migrate those through the
// discovery installer so the root skill becomes SKILL.md-only.
if source.IsGit() && !source.HasSubdir() && IsGitRepo(destPath) {
if hasDescendantSkillFile(destPath) {
migrated, err := updateRepoRootOrchestrator(source, destPath, result, opts)
if migrated || err != nil {
return result, err
}
}
if opts.DryRun {
result.Action = "would update (git pull)"
return result, nil
}
threshold, err := audit.NormalizeThreshold(opts.AuditThreshold)
if err != nil {
threshold = audit.DefaultThreshold()
}
result.AuditThreshold = threshold
// Record hash before pull for rollback
beforeHash, err := getGitFullHash(destPath)
if err != nil {
return nil, fmt.Errorf("failed to determine rollback commit before update (aborting for safety): %w", err)
}
if beforeHash == "" {
return nil, fmt.Errorf("failed to determine rollback commit before update (aborting for safety): empty commit hash")
}
if err := gitPull(destPath, opts.OnProgress); err != nil {
return nil, fmt.Errorf("failed to update: %w", err)
}
// Post-pull audit gate: rollback on findings at/above threshold unless skipped.
if !opts.SkipAudit {
afterHash, _ := getGitFullHash(destPath)
if afterHash != beforeHash {
scanResult, err := auditGateFailClosed(opts.SourceDir, destPath, beforeHash, threshold, opts.AuditProjectRoot, opts.AuditOverride)
if err != nil {
return nil, err
}
result.AuditRiskScore = scanResult.RiskScore
result.AuditRiskLabel = scanResult.RiskLabel
if opts.AuditOverride {
result.Warnings = append(result.Warnings, recordAcceptedWarning(opts.SourceDir, destPath, scanResult, threshold)...)
}
}
} else {
result.AuditSkipped = true
}
// Update centralized metadata timestamp and file hashes.
meta, _ := ReadMeta(destPath)
if meta == nil {
meta = NewMetaFromSource(source)
}
if hash, err := getGitCommit(destPath); err == nil {
meta.Version = hash
}
meta.Commit, _ = getGitFullHash(destPath)
if meta.Subdir != "" {
meta.TreeHash = getSubdirTreeHash(destPath, meta.Subdir)
}
if hashes, hashErr := ComputeFileHashes(destPath); hashErr == nil {
meta.FileHashes = hashes
}
if err := WriteMetaToStore(opts.SourceDir, destPath, meta); err != nil {
result.Warnings = append(result.Warnings, fmt.Sprintf("failed to write metadata: %v", err))
}
result.Action = "updated"
return result, nil
}
// For other cases (e.g., git with subdir), reinstall automatically
// --update implies willingness to reinstall when git pull is not possible
if opts.DryRun {
result.Action = "would reinstall from source"
return result, nil
}
// Safe update: install to temp first, then swap
tempDir, err := os.MkdirTemp("", "skillshare-update-*")
if err != nil {
return nil, fmt.Errorf("failed to create temp directory: %w", err)
}
defer os.RemoveAll(tempDir)
tempDest := filepath.Join(tempDir, "skill")
// Install to temp location first.
// Force is NOT set: tempDest is fresh, so no overwrite needed.
// AuditOverride is forwarded so --force can still override the audit gate
// without granting overwrite semantics.
innerResult, err := Install(source, tempDest, InstallOptions{
Name: opts.Name,
Force: false,
AuditOverride: opts.AuditOverride,
DryRun: false,
Update: false,
OnProgress: opts.OnProgress,
SkipAudit: opts.SkipAudit,
AuditThreshold: opts.AuditThreshold,
AuditProjectRoot: opts.AuditProjectRoot,
AuditAcceptRoot: opts.SourceDir,
AuditAcceptPath: destPath,
skillFileOnly: isSkillFileOnlyLocalInstall(source, destPath, opts.SourceDir),
})
if err != nil {
// Installation failed - original skill is preserved
return nil, err
}
// Propagate audit results and warnings from inner install
if innerResult != nil {
result.AuditRiskScore = innerResult.AuditRiskScore
result.AuditRiskLabel = innerResult.AuditRiskLabel
result.AuditSkipped = innerResult.AuditSkipped
result.AuditThreshold = innerResult.AuditThreshold
result.Warnings = append(result.Warnings, innerResult.Warnings...)
}
// Preserve metadata generated during the temp install, then write it against
// the real destination after the swap. Writing the temp install directly to
// opts.SourceDir would create ../../ temp-path keys for nested skills.
updatedMeta := readTempUpdateMeta(tempDir)
// Installation succeeded - now safe to remove original and move new
if err := os.RemoveAll(destPath); err != nil {
return nil, fmt.Errorf("failed to remove existing skill: %w", err)
}
if err := os.Rename(tempDest, destPath); err != nil {
// Rename failed (possibly cross-device), try copy instead
if err := copyDir(tempDest, destPath); err != nil {
return nil, fmt.Errorf("failed to move updated skill: %w", err)
}
}
if updatedMeta != nil {
if err := WriteMetaToStore(opts.SourceDir, destPath, updatedMeta); err != nil {
result.Warnings = append(result.Warnings, fmt.Sprintf("failed to write metadata: %v", err))
}
}
result.Action = "reinstalled"
return result, nil
}
func readTempUpdateMeta(tempDir string) *SkillMeta {
store, err := LoadMetadata(tempDir)
if err != nil {
return nil
}
entry := store.Get("skill")
if entry == nil {
return nil
}
return &SkillMeta{
Source: entry.Source,
Kind: entry.Kind,
Type: entry.Type,
InstalledAt: entry.InstalledAt,
RepoURL: entry.RepoURL,
Subdir: entry.Subdir,
Version: entry.Version,
TreeHash: entry.TreeHash,
FileHashes: entry.FileHashes,
Branch: entry.Branch,
Commit: entry.Commit,
}
}
func hasDescendantSkillFile(root string) bool {
found := false
_ = filepath.Walk(root, func(path string, info os.FileInfo, err error) error {
if err != nil || found {
return nil
}
if info.IsDir() {
if path != root && info.Name() == ".git" {
return filepath.SkipDir
}
return nil
}
if info.Name() == "SKILL.md" && filepath.Dir(path) != root {
found = true
}
return nil
})
return found
}
func updateRepoRootOrchestrator(source *Source, destPath string, result *InstallResult, opts InstallOptions) (bool, error) {
discovery, err := DiscoverFromGitWithProgress(source, opts.OnProgress)
if err != nil {
return false, fmt.Errorf("failed to discover repository for orchestrator update: %w", err)
}
defer CleanupDiscovery(discovery)
rootSkill, ok := repoRootOrchestratorRoot(discovery)
if !ok {
return false, nil
}
if opts.DryRun {
result.Action = "would reinstall root skill"
return true, nil
}
tempDir, err := os.MkdirTemp("", "skillshare-update-*")
if err != nil {
return true, fmt.Errorf("failed to create temp directory: %w", err)
}
defer os.RemoveAll(tempDir)
tempDest := filepath.Join(tempDir, "skill")
innerResult, err := installFromDiscoveryInternal(discovery, rootSkill, tempDest, InstallOptions{
Name: opts.Name,
Force: false,
AuditOverride: opts.AuditOverride,
DryRun: false,
Update: false,
OnProgress: opts.OnProgress,
SkipAudit: opts.SkipAudit,
AuditThreshold: opts.AuditThreshold,
AuditProjectRoot: opts.AuditProjectRoot,
AuditAcceptRoot: opts.SourceDir,
AuditAcceptPath: destPath,
}, false)
if err != nil {
return true, err
}
if innerResult != nil {
result.AuditRiskScore = innerResult.AuditRiskScore
result.AuditRiskLabel = innerResult.AuditRiskLabel
result.AuditSkipped = innerResult.AuditSkipped
result.AuditThreshold = innerResult.AuditThreshold
result.Warnings = append(result.Warnings, innerResult.Warnings...)
}
if err := os.RemoveAll(destPath); err != nil {
return true, fmt.Errorf("failed to remove existing skill: %w", err)
}
if err := os.Rename(tempDest, destPath); err != nil {
if err := copyDir(tempDest, destPath); err != nil {
return true, fmt.Errorf("failed to move updated skill: %w", err)
}
}
fullSource, fullSubdir := discoveredSkillSourceParts(discovery, rootSkill)
if err := writeDiscoveredSkillMetadata(discovery, rootSkill, destPath, opts.SourceDir, fullSource, fullSubdir); err != nil {
result.Warnings = append(result.Warnings, fmt.Sprintf("failed to write metadata: %v", err))
}
result.Action = "reinstalled"
return true, nil
}
func repoRootOrchestratorRoot(discovery *DiscoveryResult) (SkillInfo, bool) {
if discovery == nil || discovery.Source == nil || discovery.Source.HasSubdir() {
return SkillInfo{}, false
}
for _, skill := range discovery.Skills {
if skill.Path == "." && descendantSkillPaths(discovery, skill) != nil {
return skill, true
}
}
return SkillInfo{}, false
}