mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
Backend: - PATCH /api/targets/:name accepts agent_include/agent_exclude fields - POST /api/sync-matrix/preview returns agent entries with kind=agent - GET /api/overview returns agentsSource and extrasSource paths - Fix ResolveProjectTargets to resolve Agents sub-key (path + filters) - Add agent filter CLI flags: --add-agent-include, --add-agent-exclude, --remove-agent-include, --remove-agent-exclude, --agent-mode - Unify target list JSON/TUI to show agent info and filters Frontend: - FilterStudioPage: kind-driven single-context view (?kind=skill|agent) - KindBadge: use design system tokens (ss-badge + wobble in playful) - TargetsPage: link to Filter Studio with ?kind= param - ResourceDetailPage: capitalize type labels (Local, GitHub) - ResourcesPage: sync activeTab from URL searchParams on navigation - DashboardPage: show agents/extras source dirs, link skills card with ?tab=skills for reliable tab switching - API client: extend updateTarget and previewSyncMatrix for agent filters Tests: - Agent include/exclude round-trip persistence - Invalid agent pattern returns 400 - Preview with agent entries and kind field - No agent entries for targets without agent path - CLI target agent filter integration tests
295 lines
9.6 KiB
Go
295 lines
9.6 KiB
Go
package server
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"skillshare/internal/config"
|
|
)
|
|
|
|
func TestHandleSyncMatrix_Empty(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/sync-matrix", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
var resp struct {
|
|
Entries []any `json:"entries"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Entries) != 0 {
|
|
t.Errorf("expected 0 entries, got %d", len(resp.Entries))
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrix_WithSkillsAndTargets(t *testing.T) {
|
|
tgtPath := filepath.Join(t.TempDir(), "claude-skills")
|
|
s, sourceDir := newTestServerWithTargets(t, map[string]string{"claude": tgtPath})
|
|
addSkill(t, sourceDir, "frontend-design")
|
|
addSkill(t, sourceDir, "backend-api")
|
|
req := httptest.NewRequest(http.MethodGet, "/api/sync-matrix", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
var resp struct {
|
|
Entries []struct {
|
|
Skill string `json:"skill"`
|
|
Target string `json:"target"`
|
|
Status string `json:"status"`
|
|
} `json:"entries"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Entries) != 2 {
|
|
t.Fatalf("expected 2 entries, got %d", len(resp.Entries))
|
|
}
|
|
for _, e := range resp.Entries {
|
|
if e.Target != "claude" {
|
|
t.Errorf("expected target 'claude', got %q", e.Target)
|
|
}
|
|
if e.Status != "synced" {
|
|
t.Errorf("skill %q: expected 'synced', got %q", e.Skill, e.Status)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrix_WithFilters(t *testing.T) {
|
|
tgtPath := filepath.Join(t.TempDir(), "claude-skills")
|
|
s, sourceDir := newTestServerWithTargets(t, map[string]string{"claude": tgtPath})
|
|
addSkill(t, sourceDir, "frontend-design")
|
|
addSkill(t, sourceDir, "backend-api")
|
|
s.cfg.Targets["claude"] = config.TargetConfig{Path: tgtPath, Mode: "merge", Exclude: []string{"backend*"}}
|
|
if err := s.cfg.Save(); err != nil {
|
|
t.Fatalf("failed to save config: %v", err)
|
|
}
|
|
req := httptest.NewRequest(http.MethodGet, "/api/sync-matrix", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
var resp struct {
|
|
Entries []struct {
|
|
Skill string `json:"skill"`
|
|
Status string `json:"status"`
|
|
Reason string `json:"reason"`
|
|
} `json:"entries"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Entries) != 2 {
|
|
t.Fatalf("expected 2 entries, got %d", len(resp.Entries))
|
|
}
|
|
statusMap := map[string]string{}
|
|
reasonMap := map[string]string{}
|
|
for _, e := range resp.Entries {
|
|
statusMap[e.Skill] = e.Status
|
|
reasonMap[e.Skill] = e.Reason
|
|
}
|
|
if statusMap["frontend-design"] != "synced" {
|
|
t.Errorf("frontend-design: expected synced, got %q", statusMap["frontend-design"])
|
|
}
|
|
if statusMap["backend-api"] != "excluded" {
|
|
t.Errorf("backend-api: expected excluded, got %q", statusMap["backend-api"])
|
|
}
|
|
if reasonMap["backend-api"] != "backend*" {
|
|
t.Errorf("backend-api reason: expected 'backend*', got %q", reasonMap["backend-api"])
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrix_TargetQueryParam(t *testing.T) {
|
|
tgt1 := filepath.Join(t.TempDir(), "claude-skills")
|
|
tgt2 := filepath.Join(t.TempDir(), "cursor-skills")
|
|
s, sourceDir := newTestServerWithTargets(t, map[string]string{"claude": tgt1, "cursor": tgt2})
|
|
addSkill(t, sourceDir, "my-skill")
|
|
req := httptest.NewRequest(http.MethodGet, "/api/sync-matrix?target=claude", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
var resp struct {
|
|
Entries []struct {
|
|
Target string `json:"target"`
|
|
} `json:"entries"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
for _, e := range resp.Entries {
|
|
if e.Target != "claude" {
|
|
t.Errorf("expected only claude entries, got %q", e.Target)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrixPreview_Basic(t *testing.T) {
|
|
tgtPath := filepath.Join(t.TempDir(), "claude-skills")
|
|
s, sourceDir := newTestServerWithTargets(t, map[string]string{"claude": tgtPath})
|
|
addSkill(t, sourceDir, "frontend-design")
|
|
addSkill(t, sourceDir, "backend-api")
|
|
addSkill(t, sourceDir, "legacy-tool")
|
|
body := `{"target":"claude","include":["frontend*","backend*"],"exclude":["legacy*"]}`
|
|
req := httptest.NewRequest(http.MethodPost, "/api/sync-matrix/preview", strings.NewReader(body))
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
var resp struct {
|
|
Entries []struct {
|
|
Skill string `json:"skill"`
|
|
Status string `json:"status"`
|
|
} `json:"entries"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Entries) != 3 {
|
|
t.Fatalf("expected 3 entries, got %d", len(resp.Entries))
|
|
}
|
|
statusMap := map[string]string{}
|
|
for _, e := range resp.Entries {
|
|
statusMap[e.Skill] = e.Status
|
|
}
|
|
if statusMap["frontend-design"] != "synced" {
|
|
t.Errorf("frontend-design: expected synced, got %q", statusMap["frontend-design"])
|
|
}
|
|
if statusMap["backend-api"] != "synced" {
|
|
t.Errorf("backend-api: expected synced, got %q", statusMap["backend-api"])
|
|
}
|
|
if statusMap["legacy-tool"] != "not_included" {
|
|
t.Errorf("legacy-tool: expected not_included, got %q", statusMap["legacy-tool"])
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrixPreview_InvalidPattern(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
body := `{"target":"claude","include":["[unclosed"]}`
|
|
req := httptest.NewRequest(http.MethodPost, "/api/sync-matrix/preview", strings.NewReader(body))
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusBadRequest {
|
|
t.Errorf("expected 400, got %d", rr.Code)
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrixPreview_MissingTarget(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
body := `{"include":["*"]}`
|
|
req := httptest.NewRequest(http.MethodPost, "/api/sync-matrix/preview", strings.NewReader(body))
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusBadRequest {
|
|
t.Errorf("expected 400, got %d", rr.Code)
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrixPreview_IncludesAgents(t *testing.T) {
|
|
home := filepath.Join(t.TempDir(), "home")
|
|
os.MkdirAll(home, 0755)
|
|
t.Setenv("HOME", home)
|
|
|
|
tgtPath := filepath.Join(t.TempDir(), "claude-skills")
|
|
s, sourceDir := newTestServerWithTargets(t, map[string]string{"claude": tgtPath})
|
|
addSkill(t, sourceDir, "my-skill")
|
|
|
|
// Add agents to the agents source directory
|
|
agentsSource := s.cfg.EffectiveAgentsSource()
|
|
addAgentFile(t, agentsSource, "code-reviewer.md")
|
|
addAgentFile(t, agentsSource, "draft-helper.md")
|
|
|
|
body := `{"target":"claude","include":[],"exclude":[],"agent_include":[],"agent_exclude":["draft-*"]}`
|
|
req := httptest.NewRequest(http.MethodPost, "/api/sync-matrix/preview", strings.NewReader(body))
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Entries []struct {
|
|
Skill string `json:"skill"`
|
|
Status string `json:"status"`
|
|
Kind string `json:"kind"`
|
|
} `json:"entries"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
|
|
// Should have 1 skill + 2 agents = 3 entries
|
|
if len(resp.Entries) != 3 {
|
|
t.Fatalf("expected 3 entries, got %d", len(resp.Entries))
|
|
}
|
|
|
|
statusMap := map[string]string{}
|
|
kindMap := map[string]string{}
|
|
for _, e := range resp.Entries {
|
|
statusMap[e.Skill] = e.Status
|
|
kindMap[e.Skill] = e.Kind
|
|
}
|
|
|
|
// Skill should be synced
|
|
if statusMap["my-skill"] != "synced" {
|
|
t.Errorf("my-skill: expected synced, got %q", statusMap["my-skill"])
|
|
}
|
|
if kindMap["my-skill"] != "" {
|
|
t.Errorf("my-skill kind: expected empty, got %q", kindMap["my-skill"])
|
|
}
|
|
|
|
// code-reviewer agent should be synced
|
|
if statusMap["code-reviewer.md"] != "synced" {
|
|
t.Errorf("code-reviewer.md: expected synced, got %q", statusMap["code-reviewer.md"])
|
|
}
|
|
if kindMap["code-reviewer.md"] != "agent" {
|
|
t.Errorf("code-reviewer.md kind: expected agent, got %q", kindMap["code-reviewer.md"])
|
|
}
|
|
|
|
// draft-helper agent should be excluded
|
|
if statusMap["draft-helper.md"] != "excluded" {
|
|
t.Errorf("draft-helper.md: expected excluded, got %q", statusMap["draft-helper.md"])
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrixPreview_NoAgentsWhenNoAgentPath(t *testing.T) {
|
|
// custom-tool has no agent path in builtin targets
|
|
tgtPath := filepath.Join(t.TempDir(), "custom-skills")
|
|
s, sourceDir := newTestServerWithTargets(t, map[string]string{"custom-tool": tgtPath})
|
|
addSkill(t, sourceDir, "my-skill")
|
|
|
|
// Add agents to the agents source
|
|
agentsSource := s.cfg.EffectiveAgentsSource()
|
|
addAgentFile(t, agentsSource, "reviewer.md")
|
|
|
|
body := `{"target":"custom-tool","include":[],"exclude":[]}`
|
|
req := httptest.NewRequest(http.MethodPost, "/api/sync-matrix/preview", strings.NewReader(body))
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Entries []struct {
|
|
Skill string `json:"skill"`
|
|
Kind string `json:"kind"`
|
|
} `json:"entries"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
|
|
// Should have only 1 skill, no agents
|
|
if len(resp.Entries) != 1 {
|
|
t.Fatalf("expected 1 entry (skill only, no agents), got %d", len(resp.Entries))
|
|
}
|
|
if resp.Entries[0].Kind == "agent" {
|
|
t.Error("expected no agent entries for target without agent path")
|
|
}
|
|
}
|
|
|
|
func TestHandleSyncMatrixPreview_InvalidAgentPattern(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
body := `{"target":"claude","include":[],"exclude":[],"agent_include":["[unclosed"]}`
|
|
req := httptest.NewRequest(http.MethodPost, "/api/sync-matrix/preview", strings.NewReader(body))
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
if rr.Code != http.StatusBadRequest {
|
|
t.Errorf("expected 400 for invalid agent pattern, got %d", rr.Code)
|
|
}
|
|
}
|