mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
* fix(opencode): preserve v2 directory packages
Stage the reviewed issue 913 source for isolated fork validation. Preserve
package directories and manifests without executing managed packages or
installing their dependencies, and include receipt and localized UI fixes.
Reviewed local source: 15ac88e2f266571b8a6dc8d777302db0f4dcae44
Exact source tree: 45ebabfe2b
Static checks and independent inspection completed. Go, integration,
dashboard, rendering, and hosted runtime validation remain pending.
This fork staging commit is not an upstream publication or merge.
* test(opencode): align schema and snapshot assertions
Check the version-aware binding schema and verify native unregister retains the unchanged managed snapshot.
* fix(opencode): resolve Windows npm native launchers
Probe recognized native Opencode executables without invoking a batch shell; exercise the default version probe on hosted Windows.
* test(opencode): normalize Windows fixture line endings
Avoid doubling carriage returns when Git checks out the npm fixture with CRLF.
* fix(opencode): keep an undetected OpenCode version from blocking other agents
Review of the v2 directory package change found that one failed
`opencode --version` probe failed the whole hooks plan, so a machine
without the binary (a second machine sharing the config, CI, a
devcontainer) could no longer sync hooks to any agent, and doctor and
the dashboard preview failed with it.
Hooks:
- A probe that fails or reports an unknown major now skips only the
OpenCode bindings with one warning per target. Outputs already owned
there are parked, so they are neither rewritten nor removed while the
layout is unknown. The probe runs once per plan, list and import.
- A `package` binding on OpenCode v1 is skipped with a warning instead
of failing the plan.
- The v2 dependency warning is reported once, and only when a package
file is written, so a synced hook no longer keeps doctor yellow.
- `hooks import` reports an unreadable file such as a symlink as that
package's problem; other packages and flat files stay importable.
The package validation problem is reported once instead of twice.
- Directories under `plugins/` are listed as unmanaged only on v2.
Plugins:
- The inventory leaves `plugins/skillshare-NAME` registrations to
hooks, so a synced v2 hook is not offered as an importable plugin.
Dashboard: the new warnings are translated in every locale, a
`hook NAME:` prefix no longer defeats translation, the native preview
translates its per-file error, and the YAML editor documents `package`.
Docs: the English pages and the built-in skill describe the behavior
above; the ja, ko, zh-Hans and zh-Hant pages now carry the same
content as the English ones. The runbook drives the CLI with mdproof
assertions instead of prose expectations.
Refs #913.
---------
Co-authored-by: Willie <egg358358@gmail.com>
224 lines
7.3 KiB
YAML
224 lines
7.3 KiB
YAML
name: Test
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
paths-ignore:
|
|
- "website/**"
|
|
- "README.md"
|
|
- "CHANGELOG.md"
|
|
pull_request:
|
|
branches: [main]
|
|
paths-ignore:
|
|
- "website/**"
|
|
- "README.md"
|
|
- "CHANGELOG.md"
|
|
schedule:
|
|
- cron: "0 3 * * *"
|
|
workflow_dispatch:
|
|
workflow_call:
|
|
inputs:
|
|
ref:
|
|
description: Exact commit to verify for a release
|
|
type: string
|
|
default: ""
|
|
|
|
# A newer push to a pull request supersedes its running tests; other events keep their own run.
|
|
concurrency:
|
|
group: ${{ github.event_name == 'pull_request' && format('test-pr-{0}', github.event.pull_request.number) || format('test-{0}', github.run_id) }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
unit-test:
|
|
# Release Please tests a merged Release PR at its exact SHA (inputs.ref) before tagging,
|
|
# so the push run for that same commit is skipped. Release PR runs stay: they are required checks.
|
|
if: ¬-release-duplicate "${{ !(github.event_name == 'push' && !inputs.ref && startsWith(github.event.head_commit.message, 'chore(main): release ')) }}"
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ inputs.ref || github.sha }}
|
|
|
|
- name: Check AI context routes
|
|
run: python3 scripts/ai-context.py check
|
|
|
|
- name: Herdr mod tests
|
|
run: make test-herdr
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: go.mod
|
|
|
|
- name: Build
|
|
run: make build
|
|
|
|
- name: Formatting, lint and release metadata tests
|
|
run: |
|
|
make fmt-check lint
|
|
python3 -B -m unittest discover -s scripts/release -p '*_test.py'
|
|
python3 -B -m unittest discover -s scripts/design -p '*_test.py'
|
|
|
|
- name: Unit Tests
|
|
run: go test -v -race ./cmd/skillshare/... ./internal/...
|
|
env:
|
|
SKILLSHARE_TEST_BINARY: ${{ github.workspace }}/bin/skillshare
|
|
|
|
integration-test:
|
|
if: *not-release-duplicate
|
|
runs-on: ${{ matrix.os }}
|
|
strategy:
|
|
matrix:
|
|
os: [ubuntu-latest, macos-latest]
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ inputs.ref || github.sha }}
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: go.mod
|
|
|
|
- name: Build Binary
|
|
run: make build
|
|
|
|
- name: Integration Tests
|
|
run: go test -v -race ./tests/integration/...
|
|
env:
|
|
SKILLSHARE_TEST_BINARY: ${{ github.workspace }}/bin/skillshare
|
|
|
|
windows-test:
|
|
# Releases publish windows_amd64 and windows_arm64 archives, and `_windows.go` files are compiled
|
|
# only on Windows, yet every job above runs on Linux or macOS: a Windows-only regression reaches
|
|
# users at release time instead of at review.
|
|
# This job starts with the packages that already pass on windows-latest, so it is green on
|
|
# arrival. #344 lists the packages that do not pass there and the failures behind them; each fix
|
|
# adds its package back to this list.
|
|
# No -race: the race detector needs a C toolchain on Windows, and ubuntu and macOS cover it.
|
|
# -count=1 so that a cached result cannot report a pass for a package that never ran.
|
|
if: *not-release-duplicate
|
|
runs-on: windows-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ inputs.ref || github.sha }}
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: go.mod
|
|
|
|
- name: OpenCode version probe regression
|
|
run: go test ./internal/hooks -run '^TestOpenCodeDefaultProbe$' -count=1
|
|
|
|
- name: Unit Tests
|
|
shell: bash
|
|
run: |
|
|
go test -v -count=1 \
|
|
./cmd/skillshare \
|
|
./internal/audit \
|
|
./internal/backup \
|
|
./internal/check \
|
|
./internal/childproc \
|
|
./internal/config \
|
|
./internal/hub \
|
|
./internal/install \
|
|
./internal/instructions \
|
|
./internal/mcp \
|
|
./internal/memory \
|
|
./internal/projectdir \
|
|
./internal/projects \
|
|
./internal/resource \
|
|
./internal/search \
|
|
./internal/skill \
|
|
./internal/skillignore \
|
|
./internal/sourcewalk \
|
|
./internal/sync \
|
|
./internal/theme \
|
|
./internal/trash \
|
|
./internal/ui \
|
|
./internal/uidist \
|
|
./internal/utils \
|
|
./internal/validate \
|
|
./internal/version
|
|
|
|
# Run this Windows-only regression; the rest of oplog still has failures tracked in #344.
|
|
- name: Windows legacy config log regression
|
|
shell: bash
|
|
run: go test -v -count=1 ./internal/oplog -run "^TestLogDir_WindowsLegacySelectedGlobal$"
|
|
- name: Native project registration smoke
|
|
shell: pwsh
|
|
env:
|
|
SKILLSHARE_TEST_BINARY: ${{ github.workspace }}/bin/skillshare.exe
|
|
run: |
|
|
$principal = [Security.Principal.WindowsPrincipal]::new([Security.Principal.WindowsIdentity]::GetCurrent())
|
|
Write-Output "Architecture=$env:PROCESSOR_ARCHITECTURE elevated=$($principal.IsInRole([Security.Principal.WindowsBuiltInRole]::Administrator))"
|
|
go build -o bin/skillshare.exe ./cmd/skillshare
|
|
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
|
|
go test -v -count=1 ./tests/integration -run '^TestProject_NativeLinksSmoke$'
|
|
|
|
docker-sandbox-offline:
|
|
if: *not-release-duplicate
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ inputs.ref || github.sha }}
|
|
|
|
- name: Docker Sandbox Tests (Offline)
|
|
run: ./scripts/test_docker.sh
|
|
|
|
docker-sandbox-online:
|
|
runs-on: ubuntu-latest
|
|
if: "${{ (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && !(github.event_name == 'push' && !inputs.ref && startsWith(github.event.head_commit.message, 'chore(main): release ')) }}"
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ inputs.ref || github.sha }}
|
|
|
|
- name: Docker Sandbox Tests (Online)
|
|
run: ./scripts/test_docker_online.sh
|
|
|
|
redteam:
|
|
if: *not-release-duplicate
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ inputs.ref || github.sha }}
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: go.mod
|
|
|
|
- name: Red Team Test
|
|
run: make test-redteam
|
|
|
|
redteam-signal:
|
|
runs-on: ubuntu-latest
|
|
if: "${{ (github.event_name == 'push' && (inputs.ref || !startsWith(github.event.head_commit.message, 'chore(main): release '))) || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}"
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ inputs.ref || github.sha }}
|
|
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: go.mod
|
|
|
|
- name: Red Team Signal (Code Mutation)
|
|
run: make test-redteam-signal
|
|
|
|
- name: Red Team Signal (Rules Disable)
|
|
run: make test-redteam-rules-signal
|