Files
skillshare/internal/plugin/lifecycle.go
T
Willie e0c1111b79 feat(plugins): add a plugin without choosing Agents yet
Adding a plugin forced at least one target, so keeping a plugin in
Skillshare for later meant installing it somewhere and then deselecting
every Agent by hand.

A package now records its source, so it stays managed with no Agent
bound. Agents are bound later from the same source, installing it as it
is then. Removing the last Agent keeps such a plugin; removing the
plugin itself drops it. In the terminal picker, confirming with nothing
selected records it, while Esc still cancels.

The plugin list also shows the installed version as a tag, and an
update check shows old -> new for plugins whose source has moved on.
2026-09-21 17:18:03 +08:00

146 lines
4.6 KiB
Go

package plugin
import (
"context"
"errors"
"fmt"
"os"
"path/filepath"
)
func (s *Service) Apply(ctx context.Context, r Request, revision string) (*Result, error) {
if revision == "" {
return nil, fmt.Errorf("preview the plugin changes before applying")
}
// Serialize CLI and UI mutations across processes, not just HTTP requests.
if err := os.MkdirAll(filepath.Dir(s.ConfigPath), 0755); err != nil {
return nil, err
}
lock, err := os.OpenFile(s.ConfigPath+".plugins.lock", os.O_WRONLY|os.O_CREATE|os.O_EXCL, 0600)
if err != nil {
return nil, fmt.Errorf("another plugin operation is running (lock: %s.plugins.lock)", s.ConfigPath)
}
_ = lock.Close()
defer os.Remove(s.ConfigPath + ".plugins.lock")
p, err := s.Preview(ctx, r)
if err != nil {
return nil, err
}
if p.Revision != revision {
return nil, fmt.Errorf("plugin state changed since preview; preview again")
}
if p.Blocked {
return nil, fmt.Errorf("resolve blocked plugin targets before applying")
}
if r.Action == "check" {
return nil, fmt.Errorf("check is read-only")
}
d, err := s.load()
if err != nil {
return nil, err
}
result := &Result{Results: []Outcome{}}
changed := false
for _, c := range p.Changes {
if c.Action == "noop" {
result.Results = append(result.Results, Outcome{Name: c.Name, Target: c.Target, Status: "unchanged"})
if r.Action == "sync" && d.packages[c.Name].Bindings[c.Target].Pending != "" {
changed = true
pack := d.packages[c.Name]
b := pack.Bindings[c.Target]
b.Pending = ""
pack.Bindings[c.Target] = b
d.packages[c.Name] = pack
}
continue
}
changed = true
pack := d.packages[c.Name]
if pack.Bindings == nil {
pack.Bindings = map[string]Binding{}
}
if c.Target == "" {
if c.Action == "forget" {
delete(d.packages, c.Name)
} else {
pack.Source, pack.SourceRef, pack.Plugin, pack.Entry = c.Binding.Source, c.Binding.SourceRef, c.Binding.Plugin, c.Binding.Entry
d.packages[c.Name] = pack
}
continue
}
if r.Action == "add" && pack.Source == "" && c.Binding.Source != "" {
pack.Source, pack.SourceRef, pack.Plugin, pack.Entry = c.Binding.Source, c.Binding.SourceRef, c.Binding.Plugin, r.Entry
}
b := c.Binding
b.Pending = c.Action
if c.Action == "import" || c.Action == "selection" {
b.Pending = ""
}
pack.Bindings[c.Target] = b
d.packages[c.Name] = pack
}
if !changed {
return result, nil
}
if err := s.save(d); err != nil {
return result, err
}
var failures []error
for _, c := range p.Changes {
if c.Action == "noop" {
continue
}
if c.Target == "" {
outcome := Outcome{Name: c.Name, Status: "saved", Message: "Added to Skillshare. Choose Agents when you want to install it."}
if c.Action == "forget" {
outcome.Status, outcome.Message = "removed", "Removed from Skillshare."
}
result.Results = append(result.Results, outcome)
continue
}
b := d.packages[c.Name].Bindings[c.Target]
applyErr := s.applyChange(ctx, c, b)
outcome := Outcome{Name: c.Name, Target: c.Target, Status: "installed", Message: "Native installation recorded. Reload the Agent and complete any required login or hook trust."}
if applyErr != nil {
outcome.Status = "failed"
outcome.Message = applyErr.Error()
failures = append(failures, applyErr)
} else {
pack := d.packages[c.Name]
if c.Action == "remove" || c.Action == "forget" {
delete(pack.Bindings, c.Target)
outcome.Status = "removed"
outcome.Message = "Native plugin removed; shared marketplaces are retained."
} else {
b.Pending = ""
pack.Bindings[c.Target] = b
if c.Action == "selection" {
outcome.Status = "saved"
outcome.Message = "Sync selection saved. Run sync to apply installation changes."
}
if c.Action == "uninstall" {
outcome.Status = "excluded"
outcome.Message = "Removed from this target; plugin definition retained."
}
if c.Action == "import" {
outcome.Status = "imported"
outcome.Message = "Existing installation adopted without changing its enabled state."
}
}
// A package with a recorded source stays managed without Agents until it is removed whole.
if len(pack.Bindings) == 0 && (pack.Source == "" || (r.Action == "remove" && len(r.Targets) == 0)) {
delete(d.packages, c.Name)
} else {
d.packages[c.Name] = pack
}
if err := s.save(d); err != nil {
outcome.Status = "failed"
outcome.Message = "Native operation completed, but recording its result failed; inspect status before retrying."
failures = append(failures, err)
}
}
result.Results = append(result.Results, outcome)
}
return result, errors.Join(failures...)
}