Files
skillshare/internal/config/extras_validate_test.go
T
Willie 482778e50c feat(config): add extras name validation with reserved words and regex
ValidateExtraName rejects empty names, reserved words ("skills", "extras"),
and names that don't start with alphanumeric or contain invalid characters
(slashes, dots, spaces, leading dash/underscore). ValidateExtraNameUnique
prevents duplicate extra names in config.
2026-03-12 16:45:02 +08:00

55 lines
1.4 KiB
Go

package config
import (
"testing"
)
func TestValidateExtraName(t *testing.T) {
tests := []struct {
name string
wantErr bool
}{
// valid names
{name: "rules", wantErr: false},
{name: "my-commands", wantErr: false},
{name: "team_prompts", wantErr: false},
{name: "a1", wantErr: false},
// reserved names
{name: "skills", wantErr: true},
{name: "extras", wantErr: true},
// empty
{name: "", wantErr: true},
// path traversal / invalid characters
{name: "../escape", wantErr: true},
{name: "has space", wantErr: true},
{name: "has/slash", wantErr: true},
{name: "-starts-dash", wantErr: true},
{name: "_starts-under", wantErr: true},
{name: ".hidden", wantErr: true},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
err := ValidateExtraName(tc.name)
if tc.wantErr && err == nil {
t.Errorf("ValidateExtraName(%q) = nil, want error", tc.name)
}
if !tc.wantErr && err != nil {
t.Errorf("ValidateExtraName(%q) = %v, want nil", tc.name, err)
}
})
}
}
func TestValidateExtraName_NoDuplicate(t *testing.T) {
existing := []ExtraConfig{{Name: "rules"}}
if err := ValidateExtraNameUnique("rules", existing); err == nil {
t.Error("ValidateExtraNameUnique(\"rules\", existing) = nil, want error for duplicate")
}
if err := ValidateExtraNameUnique("commands", existing); err != nil {
t.Errorf("ValidateExtraNameUnique(\"commands\", existing) = %v, want nil", err)
}
}