mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-18 18:04:17 +00:00
Add a global automatic-update preference with an environment override, CLI controls and dashboard settings. Suppress automatic release checks and cached notices while retaining explicit checks and upgrades. Recheck policy before publishing in-flight results, preserve structured JSON errors, and reject incomplete manual checks. Include schema, completion, localization, documentation and regression coverage. Closes #846.
123 lines
3.5 KiB
Go
123 lines
3.5 KiB
Go
package server
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"skillshare/internal/config"
|
|
versioncheck "skillshare/internal/version"
|
|
)
|
|
|
|
func (s *Server) handleUpdatePolicy(w http.ResponseWriter, r *http.Request) {
|
|
policy, err := config.ReadUpdatePolicy()
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, err.Error())
|
|
return
|
|
}
|
|
writeJSON(w, policy)
|
|
}
|
|
|
|
func (s *Server) handleVersionCheck(w http.ResponseWriter, r *http.Request) {
|
|
// Snapshot config under RLock, then release before I/O.
|
|
s.mu.RLock()
|
|
source := s.cfg.EffectiveSkillsSource()
|
|
projectRoot := s.projectRoot
|
|
s.mu.RUnlock()
|
|
|
|
isProjectMode := projectRoot != ""
|
|
policy, err := config.ReadUpdatePolicy()
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, err.Error())
|
|
return
|
|
}
|
|
manual := r.URL.Query().Get("manual") == "true"
|
|
check := policy.Enabled || manual
|
|
|
|
cliVersion := versioncheck.Version
|
|
method := detectUIInstallMethod()
|
|
cliUpdateAvailable := false
|
|
var cliLatest *string
|
|
cliDevMode := cliVersion == "" || cliVersion == "dev"
|
|
|
|
// Dev builds expose a simulated update so the browser update/restart flow can be tested.
|
|
if check && cliDevMode {
|
|
latest := "dev-ui-flow"
|
|
cliUpdateAvailable = true
|
|
cliLatest = &latest
|
|
} else if check {
|
|
var result *versioncheck.CheckResult
|
|
if manual {
|
|
var err error
|
|
result, err = versioncheck.CheckNow(cliVersion, method)
|
|
if err != nil {
|
|
writeError(w, http.StatusBadGateway, err.Error())
|
|
return
|
|
}
|
|
} else {
|
|
result = versioncheck.Check(cliVersion, method)
|
|
}
|
|
if result != nil {
|
|
// CLI version check (uses 24h cache)
|
|
cliUpdateAvailable = result.UpdateAvailable
|
|
cliLatest = &result.LatestVersion
|
|
}
|
|
}
|
|
|
|
// `skillshare upgrade` updates both everywhere but leaves a Nix-store CLI
|
|
// to Nix, so the dialog also says how Nix updates it.
|
|
var nixUpgradeCommand *string
|
|
if method.IsNix() {
|
|
command := method.UpgradeCommand()
|
|
nixUpgradeCommand = &command
|
|
}
|
|
|
|
// Skill version (local) — always check global source for built-in skill
|
|
skillSourceDir := source
|
|
if isProjectMode {
|
|
if globalCfg, err := config.LoadReadOnly(); err == nil {
|
|
skillSourceDir = globalCfg.EffectiveSkillsSource()
|
|
}
|
|
}
|
|
skillVersion := versioncheck.ReadLocalSkillVersion(skillSourceDir)
|
|
|
|
// Skill version (remote) — uses 24h cache, network call with 3s timeout
|
|
var skillLatest *string
|
|
skillUpdateAvailable := false
|
|
if check && skillVersion != "" && (manual || config.AutoUpdateCheckEnabled()) {
|
|
var remote string
|
|
if manual {
|
|
remote = versioncheck.FetchRemoteSkillVersion()
|
|
if remote == "" {
|
|
writeError(w, http.StatusBadGateway, "failed to check built-in skill version")
|
|
return
|
|
}
|
|
} else {
|
|
remote = versioncheck.CachedRemoteSkillVersion()
|
|
}
|
|
if remote != "" {
|
|
skillLatest = &remote
|
|
skillUpdateAvailable = versioncheck.SkillOutdated(skillVersion, remote)
|
|
}
|
|
}
|
|
|
|
if !manual {
|
|
policy, err = config.ReadUpdatePolicy()
|
|
if err != nil || !policy.Enabled {
|
|
cliLatest, skillLatest = nil, nil
|
|
cliUpdateAvailable, skillUpdateAvailable = false, false
|
|
}
|
|
}
|
|
writeJSON(w, map[string]any{
|
|
"autoCheckEnabled": policy.Enabled,
|
|
"autoCheckConfigured": policy.Configured,
|
|
"autoCheckEnvOverride": policy.EnvOverride,
|
|
"cliVersion": cliVersion,
|
|
"cliLatest": cliLatest,
|
|
"cliUpdateAvailable": cliUpdateAvailable,
|
|
"cliDevMode": cliDevMode,
|
|
"nixUpgradeCommand": nixUpgradeCommand,
|
|
"skillVersion": skillVersion,
|
|
"skillLatest": skillLatest,
|
|
"skillUpdateAvailable": skillUpdateAvailable,
|
|
})
|
|
}
|