Files
skillshare/internal/server/handler_agent_diff_test.go
T
Willie 568d2b7f64 fix: address code review findings
- Fix data race: read agentsSource inside RLock in handleDiffStream
- Validate kind param in handleSync (reject invalid values)
- Add test for symlink-points-elsewhere agent diff case
- Always show KindBadge on DiffItemRow (default to 'skill')
2026-04-09 23:50:42 +08:00

106 lines
2.8 KiB
Go

package server
import (
"os"
"path/filepath"
"testing"
"skillshare/internal/resource"
)
func TestComputeAgentTargetDiff_MissingInTarget(t *testing.T) {
targetDir := t.TempDir()
agents := []resource.DiscoveredResource{
{FlatName: "helper.md", AbsPath: "/src/helper.md", RelPath: "helper.md"},
}
items := computeAgentTargetDiff(targetDir, agents)
if len(items) != 1 {
t.Fatalf("expected 1 item, got %d", len(items))
}
if items[0].Action != "link" {
t.Errorf("expected action 'link', got %q", items[0].Action)
}
if items[0].Kind != "agent" {
t.Errorf("expected kind 'agent', got %q", items[0].Kind)
}
}
func TestComputeAgentTargetDiff_OrphanSymlink(t *testing.T) {
targetDir := t.TempDir()
os.Symlink("/nonexistent/old.md", filepath.Join(targetDir, "orphan.md"))
items := computeAgentTargetDiff(targetDir, nil)
if len(items) != 1 {
t.Fatalf("expected 1 item, got %d", len(items))
}
if items[0].Action != "prune" {
t.Errorf("expected action 'prune', got %q", items[0].Action)
}
}
func TestComputeAgentTargetDiff_LocalFile(t *testing.T) {
targetDir := t.TempDir()
os.WriteFile(filepath.Join(targetDir, "local.md"), []byte("# Local"), 0644)
items := computeAgentTargetDiff(targetDir, nil)
if len(items) != 1 {
t.Fatalf("expected 1 item, got %d", len(items))
}
if items[0].Action != "local" {
t.Errorf("expected action 'local', got %q", items[0].Action)
}
}
func TestComputeAgentTargetDiff_SymlinkPointsElsewhere(t *testing.T) {
sourceDir := t.TempDir()
otherDir := t.TempDir()
targetDir := t.TempDir()
srcFile := filepath.Join(sourceDir, "agent.md")
os.WriteFile(srcFile, []byte("# Agent"), 0644)
otherFile := filepath.Join(otherDir, "agent.md")
os.WriteFile(otherFile, []byte("# Other"), 0644)
// Symlink points to otherFile, not srcFile
os.Symlink(otherFile, filepath.Join(targetDir, "agent.md"))
agents := []resource.DiscoveredResource{
{FlatName: "agent.md", AbsPath: srcFile, RelPath: "agent.md"},
}
items := computeAgentTargetDiff(targetDir, agents)
if len(items) != 1 {
t.Fatalf("expected 1 item, got %d", len(items))
}
if items[0].Action != "update" {
t.Errorf("expected action 'update', got %q", items[0].Action)
}
if items[0].Reason != "symlink points elsewhere" {
t.Errorf("expected reason 'symlink points elsewhere', got %q", items[0].Reason)
}
}
func TestComputeAgentTargetDiff_InSync(t *testing.T) {
sourceDir := t.TempDir()
targetDir := t.TempDir()
srcFile := filepath.Join(sourceDir, "agent.md")
os.WriteFile(srcFile, []byte("# Agent"), 0644)
os.Symlink(srcFile, filepath.Join(targetDir, "agent.md"))
agents := []resource.DiscoveredResource{
{FlatName: "agent.md", AbsPath: srcFile, RelPath: "agent.md"},
}
items := computeAgentTargetDiff(targetDir, agents)
if len(items) != 0 {
t.Fatalf("expected 0 items (in sync), got %d", len(items))
}
}