mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
Add multi-select mode to the Resources page so users can enable or disable many skills or agents at once (issue #203), instead of toggling each one individually. - New POST /api/resources/batch/toggle endpoint (skills + agents) backed by the shared .skillignore/.agentignore, returning per-item results and an updated/unchanged/failed summary - Selection mode across grid, tree, and table views with a unified checkbox, folder-level tri-state select-all in the tree, a bottom action bar (Enable applies immediately, Disable confirms first), and optimistic updates - i18n keys for all 11 locales
179 lines
5.0 KiB
Go
179 lines
5.0 KiB
Go
package server
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"skillshare/internal/resource"
|
|
"skillshare/internal/skillignore"
|
|
ssync "skillshare/internal/sync"
|
|
)
|
|
|
|
type batchToggleRequest struct {
|
|
Names []string `json:"names"`
|
|
Kind string `json:"kind"`
|
|
Enable bool `json:"enable"`
|
|
}
|
|
|
|
type batchToggleItemResult struct {
|
|
Name string `json:"name"`
|
|
Success bool `json:"success"`
|
|
Disabled bool `json:"disabled"`
|
|
Error string `json:"error,omitempty"`
|
|
}
|
|
|
|
type batchToggleResponse struct {
|
|
Results []batchToggleItemResult `json:"results"`
|
|
Summary struct {
|
|
Updated int `json:"updated"`
|
|
Unchanged int `json:"unchanged"`
|
|
Failed int `json:"failed"`
|
|
} `json:"summary"`
|
|
}
|
|
|
|
// handleBatchToggleSkills handles POST /api/resources/batch/toggle.
|
|
// Enables or disables many skills or agents at once by adding/removing their
|
|
// paths in the shared .skillignore / .agentignore file. One kind per request.
|
|
func (s *Server) handleBatchToggleSkills(w http.ResponseWriter, r *http.Request) {
|
|
start := time.Now()
|
|
|
|
var req batchToggleRequest
|
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
|
writeError(w, http.StatusBadRequest, "invalid request body: "+err.Error())
|
|
return
|
|
}
|
|
if req.Kind != "" && req.Kind != "agent" && req.Kind != "skill" {
|
|
writeError(w, http.StatusBadRequest, "invalid kind: "+req.Kind)
|
|
return
|
|
}
|
|
|
|
// Snapshot config under read lock, then discover without holding the lock.
|
|
s.mu.RLock()
|
|
source := s.cfg.EffectiveSkillsSource()
|
|
agentsSource := s.agentsSource()
|
|
s.mu.RUnlock()
|
|
|
|
// Discover once and build a name → status lookup. First match wins, matching
|
|
// the resolve* helpers used by the single-resource toggle handler.
|
|
type entry struct {
|
|
relPath string
|
|
disabled bool
|
|
}
|
|
lookup := map[string]entry{}
|
|
put := func(key string, e entry) {
|
|
if key == "" {
|
|
return
|
|
}
|
|
if _, exists := lookup[key]; !exists {
|
|
lookup[key] = e
|
|
}
|
|
}
|
|
|
|
var ignorePath string
|
|
if req.Kind == "agent" {
|
|
if agentsSource == "" {
|
|
writeError(w, http.StatusNotFound, "no agents source configured")
|
|
return
|
|
}
|
|
discovered, err := resource.AgentKind{}.Discover(agentsSource)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to discover agents: "+err.Error())
|
|
return
|
|
}
|
|
for _, d := range discovered {
|
|
e := entry{relPath: d.RelPath, disabled: d.Disabled}
|
|
put(d.FlatName, e)
|
|
put(d.Name, e)
|
|
put(d.RelPath, e)
|
|
put(agentDisplayName(d.RelPath), e)
|
|
}
|
|
ignorePath = filepath.Join(agentsSource, ".agentignore")
|
|
} else {
|
|
discovered, err := ssync.DiscoverSourceSkillsAll(source)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "failed to discover skills: "+err.Error())
|
|
return
|
|
}
|
|
for _, d := range discovered {
|
|
e := entry{relPath: d.RelPath, disabled: d.Disabled}
|
|
put(d.FlatName, e)
|
|
put(filepath.Base(d.SourcePath), e)
|
|
put(d.RelPath, e)
|
|
}
|
|
ignorePath = filepath.Join(source, ".skillignore")
|
|
}
|
|
|
|
var resp batchToggleResponse
|
|
resp.Results = make([]batchToggleItemResult, 0, len(req.Names))
|
|
|
|
// Acquire the write lock only for the file-write loop.
|
|
s.mu.Lock()
|
|
for _, name := range req.Names {
|
|
e, ok := lookup[name]
|
|
if !ok {
|
|
resp.Results = append(resp.Results, batchToggleItemResult{Name: name, Error: "resource not found: " + name})
|
|
resp.Summary.Failed++
|
|
continue
|
|
}
|
|
|
|
if req.Enable {
|
|
if !e.disabled {
|
|
resp.Results = append(resp.Results, batchToggleItemResult{Name: name, Success: true, Disabled: false})
|
|
resp.Summary.Unchanged++
|
|
continue
|
|
}
|
|
removed, err := skillignore.RemovePattern(ignorePath, e.relPath)
|
|
if err != nil {
|
|
resp.Results = append(resp.Results, batchToggleItemResult{Name: name, Disabled: true, Error: err.Error()})
|
|
resp.Summary.Failed++
|
|
continue
|
|
}
|
|
if !removed {
|
|
resp.Results = append(resp.Results, batchToggleItemResult{
|
|
Name: name,
|
|
Disabled: true,
|
|
Error: "disabled by a glob or directory pattern — edit the ignore file manually to remove the matching rule",
|
|
})
|
|
resp.Summary.Failed++
|
|
continue
|
|
}
|
|
resp.Results = append(resp.Results, batchToggleItemResult{Name: name, Success: true, Disabled: false})
|
|
resp.Summary.Updated++
|
|
continue
|
|
}
|
|
|
|
added, err := skillignore.AddPattern(ignorePath, e.relPath)
|
|
if err != nil {
|
|
resp.Results = append(resp.Results, batchToggleItemResult{Name: name, Error: err.Error()})
|
|
resp.Summary.Failed++
|
|
continue
|
|
}
|
|
if !added {
|
|
resp.Results = append(resp.Results, batchToggleItemResult{Name: name, Success: true, Disabled: true})
|
|
resp.Summary.Unchanged++
|
|
continue
|
|
}
|
|
resp.Results = append(resp.Results, batchToggleItemResult{Name: name, Success: true, Disabled: true})
|
|
resp.Summary.Updated++
|
|
}
|
|
s.mu.Unlock()
|
|
|
|
action := "batch-disable"
|
|
if req.Enable {
|
|
action = "batch-enable"
|
|
}
|
|
s.writeOpsLog(action, "ok", start, map[string]any{
|
|
"kind": req.Kind,
|
|
"enable": req.Enable,
|
|
"count": len(req.Names),
|
|
"updated": resp.Summary.Updated,
|
|
"unchanged": resp.Summary.Unchanged,
|
|
"failed": resp.Summary.Failed,
|
|
"scope": "ui",
|
|
}, "")
|
|
|
|
writeJSON(w, resp)
|
|
}
|