mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-20 20:34:19 +00:00
UpdateGitIgnore/RemoveFromGitIgnore were called per-skill inside loops, re-reading the entire .gitignore each time. With large files (100K+ lines in project mode), this caused O(N×M) complexity and process hangs. - Add UpdateGitIgnoreBatch and RemoveFromGitIgnoreBatch (single read/write) - ReconcileProjectSkills: collect entries during walk, batch-update once - uninstall (global + project): batch-remove after loop, not per-iteration - Fix spinner WithRemoveWhenDone in StartSpinnerWithSteps - Add E2E runbook for gitignore batch performance validation
3.1 KiB
3.1 KiB
CLI E2E Runbook: Gitignore Batch Update Performance
Validates that project-mode install completes within a reasonable time
even when .skillshare/.gitignore is very large (100K+ lines).
Root cause: ReconcileProjectSkills previously called UpdateGitIgnore
per-skill inside WalkDir, re-reading the entire .gitignore each time.
Fix: batch-collect entries, then call UpdateGitIgnoreBatch once.
Scope
- Project-mode repeated install (all skills already exist → skip path) completes within 10 seconds, not hanging
- .gitignore managed block is correctly maintained after batch update
- New entries are added when installing to a fresh project
- Existing entries are not duplicated on re-install
Environment
Run inside devcontainer with ssenv HOME isolation.
Steps
Step 1: Create isolated project environment
ssenv create "$ENV_NAME" --init
ssenv enter "$ENV_NAME" -- bash -c '
mkdir -p ~/test-project
cd ~/test-project
ss init -p --no-copy --all-targets --no-git --no-skill
'
Expected: Project initialized with .skillshare/ directory created.
Step 2: First install (populates .gitignore)
ssenv enter "$ENV_NAME" -- bash -c '
cd ~/test-project
ss install runkids/feature-radar -y -p
'
Expected:
- Exit code 0
- 5 skills installed
.skillshare/.gitignorecontains entries for all 5 skills inside managed block
Step 3: Verify .gitignore content
ssenv enter "$ENV_NAME" -- bash -c '
cd ~/test-project
grep -c "^skills/" .skillshare/.gitignore
grep "BEGIN SKILLSHARE" .skillshare/.gitignore
grep "END SKILLSHARE" .skillshare/.gitignore
'
Expected:
- At least 5 entries starting with
skills/ - BEGIN and END markers present
Step 4: Re-install with large .gitignore (performance test)
Inflate .gitignore to simulate a large project, then re-install.
ssenv enter "$ENV_NAME" -- bash -c '
cd ~/test-project
# Inject 100K dummy lines into managed block to simulate large .gitignore
python3 -c "
for i in range(100000):
print(f\"skills/dummy-skill-{i}/\")
" > /tmp/dummy_lines.txt
# Insert dummy lines before END marker
sed -i "/^# END SKILLSHARE/e cat /tmp/dummy_lines.txt" .skillshare/.gitignore
wc -l .skillshare/.gitignore
'
Expected: .gitignore now has 100K+ lines.
Step 5: Timed re-install (must not hang)
ssenv enter "$ENV_NAME" -- bash -c '
cd ~/test-project
timeout 10 ss install runkids/feature-radar -y -p
echo "EXIT_CODE: $?"
'
Expected:
- Output shows "5 skipped"
EXIT_CODE: 0(not 124 = timeout)- Completes within 10 seconds
Step 6: No duplicate entries after re-install
ssenv enter "$ENV_NAME" -- bash -c '
cd ~/test-project
# Count occurrences of each real skill entry (should be exactly 1 each)
for s in feature-radar feature-radar-archive feature-radar-learn feature-radar-ref feature-radar-scan; do
count=$(grep -c "^skills/$s/$" .skillshare/.gitignore)
echo "$s: $count"
done
'
Expected: Each skill entry appears exactly 1 time (no duplicates).
Pass Criteria
- All 6 steps pass
- Step 5 is the critical performance test: must exit 0 within 10s