mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
Addresses P1 and P2 from code review on the RWMutex commit: P1 — Stream handlers now snapshot config under RLock before streaming: - handleDiffStream: clone Targets map to prevent concurrent map panic - handleCheckStream, handleAuditStream: snapshot source/projectRoot - handleUpdateStream: snapshot source (per-item Lock already correct) P2 — All read handlers now use narrow snapshot instead of defer RUnlock: - RLock → copy needed fields to locals → RUnlock → do work with locals - Prevents slow I/O (git fetch, version check, audit scan) from blocking the auto-reload middleware's exclusive Lock on concurrent requests Other changes: - computeTargetDiff takes source parameter (no more s.cfg.Source access) - Add cloneTargets() helper for safe map copying - Add writeOpsLogTo/writeAuditLogTo for lock-free oplog writes
57 lines
1.5 KiB
Go
57 lines
1.5 KiB
Go
package server
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"skillshare/internal/config"
|
|
versioncheck "skillshare/internal/version"
|
|
)
|
|
|
|
func (s *Server) handleVersionCheck(w http.ResponseWriter, r *http.Request) {
|
|
// Snapshot config under RLock, then release before I/O.
|
|
s.mu.RLock()
|
|
source := s.cfg.Source
|
|
projectRoot := s.projectRoot
|
|
s.mu.RUnlock()
|
|
|
|
isProjectMode := projectRoot != ""
|
|
|
|
cliVersion := versioncheck.Version
|
|
cliUpdateAvailable := false
|
|
var cliLatest *string
|
|
|
|
// CLI version check (uses 24h cache)
|
|
if result := versioncheck.Check(cliVersion, versioncheck.InstallDirect); result != nil {
|
|
cliUpdateAvailable = result.UpdateAvailable
|
|
cliLatest = &result.LatestVersion
|
|
}
|
|
|
|
// Skill version (local) — always check global source for built-in skill
|
|
skillSourceDir := source
|
|
if isProjectMode {
|
|
if globalCfg, err := config.Load(); err == nil {
|
|
skillSourceDir = globalCfg.Source
|
|
}
|
|
}
|
|
skillVersion := versioncheck.ReadLocalSkillVersion(skillSourceDir)
|
|
|
|
// Skill version (remote) — network call with 3s timeout
|
|
var skillLatest *string
|
|
skillUpdateAvailable := false
|
|
if skillVersion != "" {
|
|
if remote := versioncheck.FetchRemoteSkillVersion(); remote != "" {
|
|
skillLatest = &remote
|
|
skillUpdateAvailable = remote != skillVersion
|
|
}
|
|
}
|
|
|
|
writeJSON(w, map[string]any{
|
|
"cliVersion": cliVersion,
|
|
"cliLatest": cliLatest,
|
|
"cliUpdateAvailable": cliUpdateAvailable,
|
|
"skillVersion": skillVersion,
|
|
"skillLatest": skillLatest,
|
|
"skillUpdateAvailable": skillUpdateAvailable,
|
|
})
|
|
}
|