Files
skillshare/herdr/tests/loader.test.mjs
T
Willie c677291e3d feat(herdr): hide disabled rows, group In sync by source, and split the panel into testable modules (#782)
* feat(herdr): hide disabled rows and group In sync by source

A source with many disabled skills buries the few rows that need
attention, and a long In sync list gives no sense of where skills
came from.

- Disabled rows are hidden by default; "Show disabled · n" lists them
  again and the choice is kept. A disabled hook with pending changes
  stays visible because it still needs a sync.
- In sync skills and agents can be grouped by their source repository
  (By source) or shown flat (List); a source with one row stays a
  plain row, and a filter opens every group.
- Opened plugin and MCP rows show their source, version and targets
  instead of an empty detail area.

* refactor(herdr): move the panel's logic out of main.js into testable modules

The bugs fixed in #773, #774 and #775 sat in main.js code that imports
Herdr, so node could not test it: the detached-job polling, the busy
state, and perform's op chain. Only model.js's parsing had tests.

Each concern now lives in a module that takes Herdr's functions as
arguments, so herdr/tests runs it:

- jobs.js runs skillshare: short reads as one exec, longer work
  detached and polled, with the sweep of old job folders and one
  JOB_MINUTES limit shared with SWEEP.
- channel.js carries requests, notices and one lock per machine
  through shared values. The install dialog used to check only a
  global busy string and then run without the lock; it now takes
  that machine's lock. Holders refresh the lock before each command
  and an untouched lock expires after a minute, because a dialog's
  task ends without cleanup when it closes.
- operations.js holds what each request runs and the conflict
  handling of a pull; perform only takes the lock and shows progress
  and the result.
- loader.js reads the Resources data and the Machines cards, and runs
  status alongside the snapshots.
2026-11-05 10:40:11 +08:00

56 lines
3.1 KiB
JavaScript

import { test } from "node:test";
import assert from "node:assert/strict";
import { spawnSync } from "node:child_process";
import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { findProject, loadResources, loadMachine } from "../skillshare/mods/skillshare/loader.js";
import { SNAPSHOT, GIT_STATUS } from "../skillshare/mods/skillshare/model.js";
// A fake machine answering by command: `jobs` and `runs` keyed by skillshare args joined by
// spaces (a snapshot by its scope flag), `scripts` by script. `seen` records each call's options.
function machine({ jobs = {}, runs = {}, scripts = {} } = {}) {
const seen = [];
const ok = { code: 0, stdout: "", stderr: "" };
return {
seen,
io: {
job: async (args, opt) => { seen.push({ args, ...opt }); return { ...ok, ...(opt.script === SNAPSHOT ? jobs[`snapshot ${args[0]}`] : jobs[args.join(" ")]) }; },
run: async (args) => ({ ...ok, ...runs[args.join(" ")] }),
sh: async (script) => ({ ...ok, ...scripts[script] }),
},
};
}
const snapshot = (list) => ({ stdout: `@@list 0\n${JSON.stringify(list)}\n@@diff 0\n{}\n@@mcp 0\n[]\n@@plugins 0\n[]\n@@hooks 0\n[]\n` });
test("the first folder skillshare treats as a project wins", (t) => {
const root = mkdtempSync(join(tmpdir(), "ss-proj-"));
t.after(() => rmSync(root, { recursive: true, force: true }));
const plain = join(root, "plain"), proj = join(root, "proj");
mkdirSync(plain); mkdirSync(join(proj, ".skillshare"), { recursive: true });
writeFileSync(join(proj, ".skillshare", "config.yaml"), "");
const sh = async (script, args) => ({ stdout: spawnSync("sh", ["-c", script, "test", ...args], { encoding: "utf8" }).stdout });
return findProject({ sh }, null, [plain, proj]).then((p) => assert.equal(p, proj));
});
test("a project's snapshot runs in the project folder", async () => {
const { io, seen } = machine({ jobs: { "snapshot -p": snapshot([]), "snapshot -g": snapshot([]) } });
await loadResources(io, "mini", "/work/app", false);
assert.deepEqual(seen.map((s) => [s.args[0], s.cwd]).sort(), [["-g", null], ["-p", "/work/app"]]);
});
test("a scope whose list did not parse carries the CLI's error", async () => {
const { io } = machine({ jobs: { "snapshot -g": { code: 1, stdout: "", stderr: "config not found" } } });
assert.equal((await loadResources(io, null, null, false)).error, "config not found");
});
test("a machine card counts targets that take skills and the source's git state", async () => {
const { io } = machine({
jobs: { "doctor --json -g": { stdout: JSON.stringify({ version: { current: "0.28.4", latest: "0.28.5", update_available: true } }) } },
runs: { "status --json -g": { stdout: JSON.stringify({ source: { path: "/src" }, targets: [{ name: "claude" }, { name: "codex", skills_enabled: false }] }) } },
scripts: { [GIT_STATUS]: { stdout: "top /src\n## main...origin/main [behind 2]\n" } },
});
const m = await loadMachine(io, "mini");
assert.deepEqual([m.label, m.version, m.update, m.targets, m.git.behind], ["mini", "0.28.4", true, 1, 2]);
});