mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
* feat(extras): add shared Markdown memory management Store user-managed notes in extras/memory for global and project scopes. Add CLI operations, a nested dashboard browser, versioned edits, and backup-backed deletion and recovery. Connect selected agents with reviewed, marked reading guidance while preserving existing instruction files and routes. Add explicit INDEX linking, conflict draft comparison, and copy-content previews. Document the workflow in five website locales with English screenshots and translate dashboard copy across all eleven locales. Native automatic memory remains separate from this shared file overlay. Validation: make check; 22 UI tests; TypeScript and ESLint; production UI build; six isolated CLI E2E steps; five-locale website build; explicit Claude-write/fresh-Codex-read smoke test. * feat(memory): support dashboard note moves and redesign browser Add version-checked rename and folder moves without replacing existing notes. Back up the old path and preserve content and permissions while refreshing selection, search, index warnings, and backup links. Integrate the two-pane Memory browser and compact agent controls. Refresh all English screenshots and document move/link/history behavior in five locales. Validation: make check, scoped UI tests, TypeScript, ESLint, UI production build, five-locale website build, locale parity, and visible Chrome workflow checks. * fix(memory): recheck reviewed files before committing changes Preserve external edits detected after note backup or draft preparation, and create new notes exclusively. Revalidate each guidance file before writing, report stale partial failures, and correct the built-in move/rename documentation. * fix(memory): repair initialization and preserve note recovery scope Detect missing starter files before dashboard note creation and refresh the index after initialization. Honor requested backup paths, include external project memory sources in recovery scope, and log initialization failures after partial mutations. * fix(memory): protect guidance creates and match Windows history paths Create new reviewed instruction files exclusively to preserve competing writes. Match Windows history links with native backup paths while keeping POSIX names and backup API paths intact. * fix(memory): require configured extra for external backup access Keep project backup scope inside the repository unless a valid memory folder extra enables its external source. Cover listing, version preview and restore denial without changing configured-source recovery. * fix(memory): lock backup scope validation through restore Validate project memory backup access under the restore write lock so concurrent extra deletion cannot revoke access between validation and writing. Hold read locks across scoped backup reads as well.
5.1 KiB
5.1 KiB
CLI E2E Runbook: Shared Memory Notes
Scope
Verify source-only initialization, Markdown search, versioned updates, stale
edit protection, project source overrides, and exclusion of linked/hidden notes.
Native automatic memory is separate. Initialization creates missing INDEX.md
and LEARNED.md templates without overwriting user notes.
Environment
Run inside the devcontainer with mdproof's per-runbook HOME isolation.
MEMORY_CLI may point to a worktree's built binary; otherwise use skillshare.
Every step initializes the scope it uses and does not depend on previous steps.
Steps
1. Initialize global memory and search real Markdown
memory_cli=${MEMORY_CLI:-skillshare}
"$memory_cli" extras memory init -g >/dev/null
"$memory_cli" extras memory show INDEX.md -g | grep -Fq '[Lessons learned](LEARNED.md)'
"$memory_cli" extras memory show LEARNED.md -g | grep -q 'Evidence:'
printf '# Architecture\nShared seam and agent instructions.\n' > "$HOME/memory-input.md"
"$memory_cli" extras memory write architecture.md --from "$HOME/memory-input.md" -g >/dev/null
"$memory_cli" extras memory list --search 'SHARED SEAM' --json -g
Expected:
- exit_code: 0
- jq: .notes | length == 1
- jq: .notes[0].path == "architecture.md"
- jq: .notes[0].title == "Architecture"
2. Update with the last read version; reject stale writes
memory_cli=${MEMORY_CLI:-skillshare}
"$memory_cli" extras memory init -g >/dev/null
printf '# Before\n' > "$HOME/version-input.md"
"$memory_cli" extras memory write versioned.md --from "$HOME/version-input.md" -g >/dev/null
memory_version=$("$memory_cli" extras memory show versioned.md --json -g | jq -r '.version')
printf '# After\n' > "$HOME/version-input.md"
"$memory_cli" extras memory write versioned.md --from "$HOME/version-input.md" --version "$memory_version" -g >/dev/null
if "$memory_cli" extras memory write versioned.md --from "$HOME/version-input.md" --version "$memory_version" -g > "$HOME/conflict.txt" 2>&1; then
exit 1
fi
grep -q 'reload it before saving' "$HOME/conflict.txt"
"$memory_cli" extras memory show versioned.md --json -g
Expected:
- exit_code: 0
- jq: .content == "# After\n"
3. Preserve a project index and use the per-extra source
memory_cli=${MEMORY_CLI:-skillshare}
mkdir -p "$HOME/memory-project/.skillshare" "$HOME/memory-project/notes"
printf 'targets: []\nextras:\n - name: memory\n source: notes\n targets: []\n' > "$HOME/memory-project/.skillshare/config.yaml"
printf '# My index\n' > "$HOME/memory-project/notes/INDEX.md"
printf '# My lessons\n' > "$HOME/memory-project/notes/LEARNED.md"
cd "$HOME/memory-project"
"$memory_cli" extras memory init -p >/dev/null
grep -q 'My index' notes/INDEX.md
grep -q 'My lessons' notes/LEARNED.md
"$memory_cli" extras memory instructions --json -p
Expected:
- exit_code: 0
- jq: .root | endswith("/memory-project/notes")
- jq: .instructions | contains("INDEX.md")
- jq: .instructions | contains("Update these notes only when the user requests it.")
4. Exclude hidden state and links; reject traversal
memory_cli=${MEMORY_CLI:-skillshare}
memory_root=$("$memory_cli" extras memory init --json -g | jq -r '.root')
mkdir -p "$memory_root/.obsidian"
printf '# Private hidden evidence\n' > "$memory_root/.obsidian/private.md"
printf '# Private linked evidence\n' > "$HOME/private.md"
ln -s "$HOME/private.md" "$memory_root/private-link.md"
if "$memory_cli" extras memory write ../escape.md --from "$HOME/private.md" -g >/dev/null 2>&1; then
exit 1
fi
"$memory_cli" extras memory list --search private --json -g
Expected:
- exit_code: 0
- jq: .notes == []
5. Back up and delete a note with its current version
memory_cli=${MEMORY_CLI:-skillshare}
memory_root=$("$memory_cli" extras memory init --json -g | jq -r '.root')
printf '# Delete demo\n' | "$memory_cli" extras memory write wiki/delete-demo.md --from - -g >/dev/null
version=$("$memory_cli" extras memory show wiki/delete-demo.md --json -g | jq -r '.version')
if "$memory_cli" extras memory delete wiki/delete-demo.md --version stale -g >/dev/null 2>&1; then
exit 1
fi
"$memory_cli" extras memory delete wiki/delete-demo.md --version "$version" --json -g >/dev/null
test ! -f "$memory_root/wiki/delete-demo.md"
"$memory_cli" backup files show "$memory_root/wiki/delete-demo.md" | grep -q delete
"$memory_cli" extras memory list --search delete-demo --json -g
Expected:
- exit_code: 0
- jq: .notes == []
6. Keep valid notes available beside unsupported external files
memory_cli=${MEMORY_CLI:-skillshare}
memory_root=$("$memory_cli" extras memory init --json -g | jq -r '.root')
printf '# Valid external note\n' > "$memory_root/valid.md"
printf '\377' > "$memory_root/invalid.md"
head -c 1048577 /dev/zero > "$memory_root/large.md"
"$memory_cli" extras memory list --json -g
Expected:
- exit_code: 0
- jq: [.notes[] | select(.invalid != null)] | length == 2
- jq: [.notes[] | select(.path == "valid.md")] | length == 1
Pass Criteria
All six steps pass. Existing files survive rejected writes and stale deletions, the project index and lessons are preserved, and no native agent memory directory is modified.