Files
skillshare/tests/integration/install_project_test.go
T
Willie e91890d2b0 test: fix all integration tests for centralized .metadata.json format
- Dual-write in WriteMeta: also writes to .metadata.json for backward compat
- Migration looks in parent dir for registry.yaml
- Group uninstall matches entries by Group field + full path
- Sync test uses MetadataStore instead of registry.yaml
- All integration tests pass (0 FAIL)
2026-04-08 14:28:57 +08:00

161 lines
5.1 KiB
Go

//go:build !online
package integration
import (
"os"
"path/filepath"
"testing"
"skillshare/internal/install"
"skillshare/internal/testutil"
)
func TestInstallProject_LocalPath(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
// Create a source skill to install from
sourceSkill := filepath.Join(sb.Root, "external-skill")
os.MkdirAll(sourceSkill, 0755)
os.WriteFile(filepath.Join(sourceSkill, "SKILL.md"), []byte("---\nname: external-skill\n---\n# External"), 0644)
result := sb.RunCLIInDir(projectRoot, "install", sourceSkill, "-p")
result.AssertSuccess(t)
// Skill name comes from directory name, not frontmatter
if !sb.FileExists(filepath.Join(projectRoot, ".skillshare", "skills", "external-skill", "SKILL.md")) {
t.Error("skill should be installed to .skillshare/skills/")
}
}
func TestInstallProject_CustomName(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
sourceSkill := filepath.Join(sb.Root, "my-source")
os.MkdirAll(sourceSkill, 0755)
os.WriteFile(filepath.Join(sourceSkill, "SKILL.md"), []byte("---\nname: original\n---\n# S"), 0644)
result := sb.RunCLIInDir(projectRoot, "install", sourceSkill, "--name", "custom", "-p")
result.AssertSuccess(t)
if !sb.FileExists(filepath.Join(projectRoot, ".skillshare", "skills", "custom", "SKILL.md")) {
t.Error("skill should be installed with custom name")
}
}
func TestInstallProject_DryRun(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
sourceSkill := filepath.Join(sb.Root, "dry-skill")
os.MkdirAll(sourceSkill, 0755)
os.WriteFile(filepath.Join(sourceSkill, "SKILL.md"), []byte("---\nname: dry\n---\n# D"), 0644)
result := sb.RunCLIInDir(projectRoot, "install", sourceSkill, "--dry-run", "-p")
result.AssertSuccess(t)
if sb.FileExists(filepath.Join(projectRoot, ".skillshare", "skills", "dry")) {
t.Error("dry-run should not install skill")
}
}
func TestInstallProject_TrackRequiresGitSource(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
// --track with a non-git source should fail with git-related error
result := sb.RunCLIInDir(projectRoot, "install", "/some/path", "--track", "-p")
result.AssertFailure(t)
result.AssertAnyOutputContains(t, "git repository source")
}
func TestInstallProject_FromConfig_SkipsExisting(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
// Create an already-installed skill
sb.CreateProjectSkill(projectRoot, "already-here", map[string]string{
"SKILL.md": "# Already",
})
// Write metadata entry so config-based install sees it
skillsDir := filepath.Join(projectRoot, ".skillshare", "skills")
store, err := install.LoadMetadata(skillsDir)
if err != nil {
t.Fatalf("failed to load metadata: %v", err)
}
store.Set("already-here", &install.MetadataEntry{
Source: "someone/skills/already-here",
Type: "github",
})
if err := store.Save(skillsDir); err != nil {
t.Fatalf("failed to save metadata: %v", err)
}
sb.WriteProjectConfig(projectRoot, `targets:
- claude
`)
// install (no args) → should skip existing
result := sb.RunCLIInDir(projectRoot, "install", "-p")
result.AssertSuccess(t)
result.AssertAnyOutputContains(t, "skipped")
}
func TestInstallProject_FromConfig_EmptySkills(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
result := sb.RunCLIInDir(projectRoot, "install", "-p")
result.AssertSuccess(t)
result.AssertAnyOutputContains(t, "No remote skills")
}
func TestInstallProject_NoSource_WithName_Errors(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
result := sb.RunCLIInDir(projectRoot, "install", "-p", "--name", "custom")
result.AssertFailure(t)
result.AssertAnyOutputContains(t, "require a source argument")
}
func TestInstallProject_NoSource_WithExclude_Errors(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
result := sb.RunCLIInDir(projectRoot, "install", "-p", "--exclude", "skip-me")
result.AssertFailure(t)
result.AssertAnyOutputContains(t, "require a source argument")
}
func TestInstallProject_AuditThresholdShortFlag_BlocksHighFinding(t *testing.T) {
sb := testutil.NewSandbox(t)
defer sb.Cleanup()
projectRoot := sb.SetupProjectDir("claude")
highPath := filepath.Join(sb.Root, "project-flag-high")
os.MkdirAll(highPath, 0755)
os.WriteFile(filepath.Join(highPath, "SKILL.md"),
[]byte("---\nname: project-flag-high\n---\n# CI helper\nsudo apt-get install -y jq"), 0644)
result := sb.RunCLIInDir(projectRoot, "install", highPath, "-p", "-T", "high")
result.AssertFailure(t)
result.AssertAnyOutputContains(t, "at/above HIGH")
projectSkillPath := filepath.Join(projectRoot, ".skillshare", "skills", "project-flag-high", "SKILL.md")
if sb.FileExists(projectSkillPath) {
t.Error("project install should be blocked when -T high is set")
}
}