Files
skillshare/internal/server/handler_toggle.go
T
Willie 5836a8802f feat: add agent filter support to Filter Studio, targets CLI, and overview API
Backend:
- PATCH /api/targets/:name accepts agent_include/agent_exclude fields
- POST /api/sync-matrix/preview returns agent entries with kind=agent
- GET /api/overview returns agentsSource and extrasSource paths
- Fix ResolveProjectTargets to resolve Agents sub-key (path + filters)
- Add agent filter CLI flags: --add-agent-include, --add-agent-exclude,
  --remove-agent-include, --remove-agent-exclude, --agent-mode
- Unify target list JSON/TUI to show agent info and filters

Frontend:
- FilterStudioPage: kind-driven single-context view (?kind=skill|agent)
- KindBadge: use design system tokens (ss-badge + wobble in playful)
- TargetsPage: link to Filter Studio with ?kind= param
- ResourceDetailPage: capitalize type labels (Local, GitHub)
- ResourcesPage: sync activeTab from URL searchParams on navigation
- DashboardPage: show agents/extras source dirs, link skills card
  with ?tab=skills for reliable tab switching
- API client: extend updateTarget and previewSyncMatrix for agent filters

Tests:
- Agent include/exclude round-trip persistence
- Invalid agent pattern returns 400
- Preview with agent entries and kind field
- No agent entries for targets without agent path
- CLI target agent filter integration tests
2026-04-09 03:50:28 +08:00

127 lines
3.6 KiB
Go

package server
import (
"fmt"
"net/http"
"path/filepath"
"time"
"skillshare/internal/skillignore"
ssync "skillshare/internal/sync"
)
func (s *Server) handleDisableSkill(w http.ResponseWriter, r *http.Request) {
s.handleToggleSkill(w, r, false)
}
func (s *Server) handleEnableSkill(w http.ResponseWriter, r *http.Request) {
s.handleToggleSkill(w, r, true)
}
func (s *Server) handleToggleSkill(w http.ResponseWriter, r *http.Request, enable bool) {
start := time.Now()
name := r.PathValue("name")
kind := r.URL.Query().Get("kind")
if kind != "" && kind != "agent" && kind != "skill" {
writeError(w, http.StatusBadRequest, "invalid kind: "+kind)
return
}
// Resolve under RLock — discovery is I/O-heavy, don't hold write lock
s.mu.RLock()
source := s.cfg.Source
agentsSource := s.agentsSource()
s.mu.RUnlock()
relPath := ""
isDisabled := false
ignorePath := ""
if kind == "agent" {
if agentsSource == "" {
writeError(w, http.StatusNotFound, "agent not found: "+name)
return
}
var err error
relPath, isDisabled, err = s.resolveAgentRelPathWithStatus(agentsSource, name)
if err != nil {
writeError(w, http.StatusNotFound, err.Error())
return
}
ignorePath = filepath.Join(agentsSource, ".agentignore")
} else {
var err error
relPath, isDisabled, err = s.resolveSkillRelPathWithStatus(source, name)
if err != nil {
writeError(w, http.StatusNotFound, err.Error())
return
}
ignorePath = filepath.Join(source, ".skillignore")
}
// Write lock only for the file mutation
s.mu.Lock()
defer s.mu.Unlock()
action := "disable"
disabled := true
if enable {
action = "enable"
disabled = false
if !isDisabled {
writeJSON(w, map[string]any{"success": true, "name": name, "disabled": false, "message": "not disabled"})
return
}
removed, err := skillignore.RemovePattern(ignorePath, relPath)
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to update .skillignore: "+err.Error())
return
}
if !removed {
writeError(w, http.StatusConflict, "skill is disabled by a glob or directory pattern in .skillignore or .skillignore.local — edit the file manually to remove the matching rule")
return
}
} else {
added, err := skillignore.AddPattern(ignorePath, relPath)
if err != nil {
writeError(w, http.StatusInternalServerError, "failed to update .skillignore: "+err.Error())
return
}
if !added {
writeJSON(w, map[string]any{"success": true, "name": name, "disabled": true, "message": "already disabled"})
return
}
}
s.writeOpsLog(action, "ok", start, map[string]any{
"name": name,
"kind": kind,
"scope": "ui",
}, "")
writeJSON(w, map[string]any{"success": true, "name": name, "disabled": disabled})
}
// resolveSkillRelPath finds a skill's relPath by flatName or baseName.
// Searches all skills including disabled ones. Caller must provide source path.
func (s *Server) resolveSkillRelPath(source, name string) (string, error) {
relPath, _, err := s.resolveSkillRelPathWithStatus(source, name)
return relPath, err
}
// resolveSkillRelPathWithStatus is like resolveSkillRelPath but also returns
// whether the skill is currently disabled (matched by .skillignore).
func (s *Server) resolveSkillRelPathWithStatus(source, name string) (string, bool, error) {
discovered, err := ssync.DiscoverSourceSkillsAll(source)
if err != nil {
return "", false, fmt.Errorf("failed to discover skills: %w", err)
}
for _, d := range discovered {
baseName := filepath.Base(d.SourcePath)
if d.FlatName == name || baseName == name || d.RelPath == name {
return d.RelPath, d.Disabled, nil
}
}
return "", false, fmt.Errorf("skill not found: %s", name)
}