mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
Three bugs introduced during centralized metadata migration: 1. Batch agent installs via UI wrote metadata to skills/.metadata.json instead of agents/.metadata.json because handleInstallBatch hard-coded SourceDir to s.cfg.Source. Override SourceDir with agentsSource() when body.Kind is agent. 2. CheckAgents used LoadMetadataOrNew which silently converts parse failures into an empty store, making all tracked agents appear local and suppressing drift/update diagnostics. Switch to LoadMetadata and surface corruption as status=error with the parse error message. 3. findMetaEntry only climbed 3 parent directories when searching for .metadata.json, but --into supports arbitrary nesting depth. Raise the ceiling to 10 (root sentinel still terminates early).
73 lines
2.0 KiB
Go
73 lines
2.0 KiB
Go
package server
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"skillshare/internal/install"
|
|
)
|
|
|
|
func TestHandleInstallBatch_AgentInstallWritesMetadataToAgentsSource(t *testing.T) {
|
|
s, skillsDir := newTestServer(t)
|
|
|
|
agentsDir := filepath.Join(t.TempDir(), "agents")
|
|
if err := os.MkdirAll(agentsDir, 0755); err != nil {
|
|
t.Fatalf("failed to create agents dir: %v", err)
|
|
}
|
|
s.cfg.AgentsSource = agentsDir
|
|
s.agentsStore = install.NewMetadataStore()
|
|
|
|
repoDir := t.TempDir()
|
|
initGitRepo(t, repoDir)
|
|
|
|
agentPath := filepath.Join(repoDir, "reviewer.md")
|
|
if err := os.WriteFile(agentPath, []byte("# Reviewer agent"), 0644); err != nil {
|
|
t.Fatalf("failed to write agent file: %v", err)
|
|
}
|
|
for _, args := range [][]string{
|
|
{"add", "reviewer.md"},
|
|
{"commit", "-m", "add reviewer agent"},
|
|
} {
|
|
cmd := exec.Command("git", args...)
|
|
cmd.Dir = repoDir
|
|
if out, err := cmd.CombinedOutput(); err != nil {
|
|
t.Fatalf("git %v failed: %s %v", args, out, err)
|
|
}
|
|
}
|
|
|
|
payload, err := json.Marshal(map[string]any{
|
|
"source": "file://" + repoDir,
|
|
"skills": []map[string]string{
|
|
{"name": "reviewer", "path": "reviewer.md"},
|
|
},
|
|
"kind": "agent",
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("failed to marshal payload: %v", err)
|
|
}
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/api/install/batch", bytes.NewReader(payload))
|
|
rr := httptest.NewRecorder()
|
|
s.mux.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("unexpected status: got %d, body=%s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
if _, err := os.Stat(filepath.Join(agentsDir, "reviewer.md")); err != nil {
|
|
t.Fatalf("expected installed agent in agents source: %v", err)
|
|
}
|
|
if _, err := os.Stat(filepath.Join(agentsDir, install.MetadataFileName)); err != nil {
|
|
t.Fatalf("expected metadata written to agents source: %v", err)
|
|
}
|
|
if _, err := os.Stat(filepath.Join(skillsDir, install.MetadataFileName)); !os.IsNotExist(err) {
|
|
t.Fatalf("expected no agent metadata written to skills source, got err=%v", err)
|
|
}
|
|
}
|