mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-20 20:34:19 +00:00
* perf(upgrade): download release assets over parallel ranges release-assets.githubusercontent.com throttles each connection on some networks. The 9.6 MB darwin_arm64 archive took 122-171 s over one connection but 25 s as 8 ranges, each on its own connection, with an identical checksum. `skillshare upgrade` and the first `skillshare ui` of a new version both waited minutes on that download. DownloadToFile probes with `Range: bytes=0-0`; a 206 answer splits the file into ranges fetched in parallel from the redirected URL, and a 200 answer streams the single response as before, so servers without range support cost no extra request. Size limits and checksum verification are unchanged. The UI asset download is about 2 MB now, so the docs no longer say 1 MB. * fix(upgrade): keep the caller's transport for parallel ranges Each range built its client from http.DefaultTransport, so a caller's custom transport (private CA, authenticated proxy, custom dialer) only applied to the probe. The ranges then failed or bypassed the caller's network setup even though the probe succeeded. Each range now copies the caller's client with a clone of its *http.Transport, which keeps those settings and still gives the range its own connection. A transport that cannot be cloned is shared as is.
117 lines
3.4 KiB
Go
117 lines
3.4 KiB
Go
package utils
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"strings"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// payload is larger than minParallelSize and not a multiple of downloadParts.
|
|
var payload = bytes.Repeat([]byte("0123456789abcdef"), (minParallelSize+12345)/16)
|
|
|
|
func download(t *testing.T, srv *httptest.Server, maxSize int64) ([]byte, error) {
|
|
t.Helper()
|
|
f, err := os.CreateTemp(t.TempDir(), "dl-*")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
client := &http.Client{Timeout: 10 * time.Second}
|
|
if err := DownloadToFile(client, srv.URL+"/asset", f, maxSize, nil); err != nil {
|
|
return nil, err
|
|
}
|
|
return os.ReadFile(f.Name())
|
|
}
|
|
|
|
func TestDownloadToFile_ParallelRangesReassembleExactBytes(t *testing.T) {
|
|
var requests atomic.Int32
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
requests.Add(1)
|
|
http.ServeContent(w, r, "asset", time.Time{}, bytes.NewReader(payload))
|
|
}))
|
|
defer srv.Close()
|
|
|
|
got, err := download(t, srv, int64(len(payload)))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !bytes.Equal(got, payload) {
|
|
t.Fatalf("got %d bytes, want the exact %d-byte payload", len(got), len(payload))
|
|
}
|
|
if n := requests.Load(); n != 1+downloadParts {
|
|
t.Errorf("requests = %d, want a probe plus %d ranges", n, downloadParts)
|
|
}
|
|
}
|
|
|
|
func TestDownloadToFile_ServerWithoutRangesStreamsWholeFile(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
w.Write(payload)
|
|
}))
|
|
defer srv.Close()
|
|
|
|
got, err := download(t, srv, int64(len(payload)))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !bytes.Equal(got, payload) {
|
|
t.Fatalf("got %d bytes, want the exact %d-byte payload", len(got), len(payload))
|
|
}
|
|
}
|
|
|
|
func TestDownloadToFile_FailedRangeReturnsError(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
// The probe and the first range succeed; every other range fails.
|
|
if !strings.HasPrefix(r.Header.Get("Range"), "bytes=0-") {
|
|
http.Error(w, "boom", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
http.ServeContent(w, r, "asset", time.Time{}, bytes.NewReader(payload))
|
|
}))
|
|
defer srv.Close()
|
|
|
|
if _, err := download(t, srv, int64(len(payload))); err == nil {
|
|
t.Fatal("expected an error when a range fails")
|
|
}
|
|
}
|
|
|
|
func TestDownloadToFile_RejectsOversizeBeforeDownloading(t *testing.T) {
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
http.ServeContent(w, r, "asset", time.Time{}, bytes.NewReader(payload))
|
|
}))
|
|
defer srv.Close()
|
|
|
|
_, err := download(t, srv, int64(len(payload))-1)
|
|
if err == nil || !strings.Contains(err.Error(), "exceeds the maximum size") {
|
|
t.Fatalf("err = %v, want the maximum size error", err)
|
|
}
|
|
}
|
|
|
|
func TestDownloadToFile_RangesKeepTheClientTransport(t *testing.T) {
|
|
srv := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
http.ServeContent(w, r, "asset", time.Time{}, bytes.NewReader(payload))
|
|
}))
|
|
defer srv.Close()
|
|
f, err := os.CreateTemp(t.TempDir(), "dl-*")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
|
|
// srv.Client() trusts the test server's certificate; http.DefaultTransport does not.
|
|
if err := DownloadToFile(srv.Client(), srv.URL+"/asset", f, int64(len(payload)), nil); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, err := os.ReadFile(f.Name())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !bytes.Equal(got, payload) {
|
|
t.Fatalf("got %d bytes, want the exact %d-byte payload", len(got), len(payload))
|
|
}
|
|
}
|