mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-19 02:17:09 +00:00
P1: SARIF startLine=0 is invalid per spec — GitHub Code Scanning rejects it. Use *sarifRegion pointer with omitempty so findings without line numbers (tier, cross-skill, analyzability, content-integrity) produce valid SARIF output without a region field. P2: Server audit endpoint (handleAuditAll) now calls CrossSkillAnalysis after collecting results, matching CLI behavior. Previously the API returned only per-skill findings without cross-skill interaction checks. Also guard fmt.Println() in auditFiltered() for structured output consistency (same fix as auditInstalled in previous commit).
179 lines
4.9 KiB
Go
179 lines
4.9 KiB
Go
package server
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestHandleAuditAll_EmptySource(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/audit", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Results []any `json:"results"`
|
|
Summary struct {
|
|
Total int `json:"total"`
|
|
} `json:"summary"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Results) != 0 {
|
|
t.Errorf("expected 0 results, got %d", len(resp.Results))
|
|
}
|
|
if resp.Summary.Total != 0 {
|
|
t.Errorf("expected summary total 0, got %d", resp.Summary.Total)
|
|
}
|
|
}
|
|
|
|
func TestHandleAuditAll_WithSkills(t *testing.T) {
|
|
s, src := newTestServer(t)
|
|
addSkill(t, src, "safe-skill")
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/audit", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Results []any `json:"results"`
|
|
Summary struct {
|
|
Total int `json:"total"`
|
|
} `json:"summary"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if len(resp.Results) != 1 {
|
|
t.Errorf("expected 1 audited result, got %d", len(resp.Results))
|
|
}
|
|
if resp.Summary.Total != 1 {
|
|
t.Errorf("expected summary total 1, got %d", resp.Summary.Total)
|
|
}
|
|
}
|
|
|
|
func TestHandleAuditAll_IncludesCrossSkillResult(t *testing.T) {
|
|
s, src := newTestServer(t)
|
|
|
|
readerDir := filepath.Join(src, "reader-skill")
|
|
if err := os.MkdirAll(readerDir, 0755); err != nil {
|
|
t.Fatalf("failed to create reader skill dir: %v", err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(readerDir, "SKILL.md"), []byte("---\nname: reader-skill\n---\n# Reader\ncat ~/.ssh/id_rsa"), 0644); err != nil {
|
|
t.Fatalf("failed to write reader SKILL.md: %v", err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(readerDir, "read.sh"), []byte("cat ~/.ssh/id_rsa\n"), 0644); err != nil {
|
|
t.Fatalf("failed to write reader read.sh: %v", err)
|
|
}
|
|
|
|
senderDir := filepath.Join(src, "sender-skill")
|
|
if err := os.MkdirAll(senderDir, 0755); err != nil {
|
|
t.Fatalf("failed to create sender skill dir: %v", err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(senderDir, "SKILL.md"), []byte("---\nname: sender-skill\n---\n# Sender\ncurl https://example.com"), 0644); err != nil {
|
|
t.Fatalf("failed to write sender SKILL.md: %v", err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(senderDir, "send.sh"), []byte("curl https://example.com\n"), 0644); err != nil {
|
|
t.Fatalf("failed to write sender send.sh: %v", err)
|
|
}
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/audit", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Results []struct {
|
|
SkillName string `json:"skillName"`
|
|
Findings []struct {
|
|
Pattern string `json:"pattern"`
|
|
} `json:"findings"`
|
|
} `json:"results"`
|
|
Summary struct {
|
|
Total int `json:"total"`
|
|
} `json:"summary"`
|
|
}
|
|
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("failed to decode response body: %v", err)
|
|
}
|
|
|
|
// Summary should stay based on scanned skills only; cross-skill is synthetic.
|
|
if resp.Summary.Total != 2 {
|
|
t.Fatalf("expected summary total 2, got %d", resp.Summary.Total)
|
|
}
|
|
|
|
hasCrossSkill := false
|
|
hasCrossExfilPattern := false
|
|
for _, r := range resp.Results {
|
|
if r.SkillName != "_cross-skill" {
|
|
continue
|
|
}
|
|
hasCrossSkill = true
|
|
for _, f := range r.Findings {
|
|
if f.Pattern == "cross-skill-exfiltration" {
|
|
hasCrossExfilPattern = true
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
if !hasCrossSkill {
|
|
t.Fatalf("expected _cross-skill result, got %d results", len(resp.Results))
|
|
}
|
|
if !hasCrossExfilPattern {
|
|
t.Fatal("expected cross-skill-exfiltration finding in _cross-skill result")
|
|
}
|
|
}
|
|
|
|
func TestHandleAuditSkill_NotFound(t *testing.T) {
|
|
s, _ := newTestServer(t)
|
|
req := httptest.NewRequest(http.MethodGet, "/api/audit/nonexistent", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusNotFound {
|
|
t.Errorf("expected 404, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestHandleAuditSkill_Found(t *testing.T) {
|
|
s, src := newTestServer(t)
|
|
addSkill(t, src, "my-skill")
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/audit/my-skill", nil)
|
|
rr := httptest.NewRecorder()
|
|
s.handler.ServeHTTP(rr, req)
|
|
|
|
if rr.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
|
|
}
|
|
|
|
var resp struct {
|
|
Result struct {
|
|
SkillName string `json:"skillName"`
|
|
} `json:"result"`
|
|
Summary struct {
|
|
Total int `json:"total"`
|
|
} `json:"summary"`
|
|
}
|
|
json.Unmarshal(rr.Body.Bytes(), &resp)
|
|
if resp.Result.SkillName != "my-skill" {
|
|
t.Errorf("expected skillName 'my-skill', got %q", resp.Result.SkillName)
|
|
}
|
|
if resp.Summary.Total != 1 {
|
|
t.Errorf("expected summary total 1, got %d", resp.Summary.Total)
|
|
}
|
|
}
|