mirror of
https://github.com/runkids/skillshare.git
synced 2026-11-20 20:34:19 +00:00
- Add flag validation step and quality checklist to runbook generation - Add retrospective step after test execution for continuous improvement - Document --init interaction, registry.yaml assertion rules, common flag mistakes - Distinguish runbook bugs from real bugs in FAIL analysis - Fix stale config.yaml skill assertions in uninstall_all_glob runbook - Add registry_yaml_split runbook (7-step E2E for the registry.yaml refactor)
4.9 KiB
4.9 KiB
CLI E2E Runbook: registry.yaml Split
Verifies that skills are stored in registry.yaml (not config.yaml) after the refactor, including migration from old format.
Scope
- Fresh init creates empty registry.yaml
- Install writes skills to registry.yaml, not config.yaml
- Migration: old config.yaml with skills[] → auto-split on any command
- Uninstall removes skills from registry.yaml
- Project mode: same behavior in .skillshare/
Environment
Run inside devcontainer with ssenv isolation.
Steps
Step 1: Fresh init — verify registry.yaml exists
ss init --no-copy --all-targets --no-git --no-skill
Expected:
~/.config/skillshare/config.yamlexists and does NOT containskills:~/.config/skillshare/registry.yamlexists (may be empty or minimal)
cat ~/.config/skillshare/config.yaml
cat ~/.config/skillshare/registry.yaml 2>/dev/null || echo "MISSING"
Step 2: Install a local skill — verify registry.yaml updated
mkdir -p /tmp/test-skill
echo "---
name: test-skill
---
# Test Skill" > /tmp/test-skill/SKILL.md
ss install /tmp/test-skill
Expected:
~/.config/skillshare/skills/test-skill/SKILL.mdexists~/.config/skillshare/registry.yamlcontainsname: test-skill~/.config/skillshare/config.yamldoes NOT containskills:ortest-skill
cat ~/.config/skillshare/registry.yaml
grep -c "skills:" ~/.config/skillshare/config.yaml && echo "FAIL: config has skills" || echo "PASS: config clean"
Step 3: Migration — old config with skills[] auto-migrates
# Manually inject skills[] into config.yaml (simulating old format)
cat > ~/.config/skillshare/config.yaml << 'YAML'
source: ~/.config/skillshare/skills
targets: {}
skills:
- name: legacy-skill
source: github.com/example/repo
YAML
# Remove registry to test migration
rm -f ~/.config/skillshare/registry.yaml
# Run any command — triggers migration via config.Load()
ss status
Expected:
~/.config/skillshare/registry.yamlcreated withname: legacy-skill~/.config/skillshare/config.yamlno longer containsskills:
cat ~/.config/skillshare/registry.yaml
grep -c "skills:" ~/.config/skillshare/config.yaml && echo "FAIL: skills still in config" || echo "PASS: migration ok"
Step 4: Migration preserves existing registry
# Write registry with real skill
cat > ~/.config/skillshare/registry.yaml << 'YAML'
skills:
- name: real-skill
source: github.com/real/repo
YAML
# Inject stale skills into config (simulating edge case)
cat > ~/.config/skillshare/config.yaml << 'YAML'
source: ~/.config/skillshare/skills
targets: {}
skills:
- name: stale-skill
source: github.com/stale/repo
YAML
ss status
Expected:
registry.yamlstill hasreal-skill, NOTstale-skillconfig.yamlmay still haveskills:(registry existed so migration skipped the write)
grep "real-skill" ~/.config/skillshare/registry.yaml && echo "PASS" || echo "FAIL"
grep "stale-skill" ~/.config/skillshare/registry.yaml && echo "FAIL: stale leaked" || echo "PASS: no leak"
Step 5: Uninstall removes from registry.yaml
# Reset clean state
ss init --no-copy --all-targets --no-git --no-skill --force
mkdir -p /tmp/remove-me
echo "---
name: remove-me
---
# Remove Me" > /tmp/remove-me/SKILL.md
ss install /tmp/remove-me
ss uninstall remove-me --yes
Expected:
registry.yamldoes NOT containremove-me
grep "remove-me" ~/.config/skillshare/registry.yaml && echo "FAIL: still present" || echo "PASS: removed"
Step 6: Install with --into records group in registry
ss init --no-copy --all-targets --no-git --no-skill --force
mkdir -p /tmp/grouped-skill
echo "---
name: grouped-skill
---
# Grouped" > /tmp/grouped-skill/SKILL.md
ss install /tmp/grouped-skill --into frontend
Expected:
registry.yamlcontainsgroup: frontendandname: grouped-skillconfig.yamldoes NOT containgroup:orgrouped-skill
cat ~/.config/skillshare/registry.yaml
grep "group: frontend" ~/.config/skillshare/registry.yaml && echo "PASS" || echo "FAIL"
Step 7: Project mode — registry in .skillshare/
mkdir -p /tmp/project-test
cd /tmp/project-test
ss init -p --target claude --no-git --no-skill
mkdir -p /tmp/proj-skill
echo "---
name: proj-skill
---
# Project Skill" > /tmp/proj-skill/SKILL.md
SKILLSHARE_DEV_ALLOW_WORKSPACE_PROJECT=1 ss install /tmp/proj-skill -p
Expected:
.skillshare/registry.yamlcontainsname: proj-skill.skillshare/config.yamldoes NOT containskills:
cat /tmp/project-test/.skillshare/registry.yaml
grep -c "skills:" /tmp/project-test/.skillshare/config.yaml && echo "FAIL" || echo "PASS"
Pass Criteria
- All 7 steps pass
- Skills never appear in config.yaml after any operation
- Migration works in both directions (old → new, and preserves existing registry)
- Both global and project modes use registry.yaml